[PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-27 Thread Johan Hovold
Add device-id entry for GW Instek AFG-2225, which has a byte swapped bInterfaceSubClass (0x20). Reported-by: Karl Palsson Cc: stable Signed-off-by: Johan Hovold --- Care to give this patch a try as well, Karl? You can respond with a Tested-by tag if you want. Thanks, Johan drivers/usb/clas

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-27 Thread Karl Palsson
On Mon, Oct 27, 2014 at 06:34:33PM +0100, Johan Hovold wrote: > Add device-id entry for GW Instek AFG-2225, which has a byte swapped > bInterfaceSubClass (0x20). > > Reported-by: Karl Palsson > Cc: stable > Signed-off-by: Johan Hovold > --- > > Care to give this patch a try as well, Karl? You

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-27 Thread Johan Hovold
On Mon, Oct 27, 2014 at 05:56:27PM +, Karl Palsson wrote: > On Mon, Oct 27, 2014 at 06:34:33PM +0100, Johan Hovold wrote: > > Add device-id entry for GW Instek AFG-2225, which has a byte swapped > > bInterfaceSubClass (0x20). > > > > Reported-by: Karl Palsson > > Cc: stable > > Signed-off-by

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-27 Thread Oliver Neukum
On Mon, 2014-10-27 at 19:07 +0100, Johan Hovold wrote: > I guess we could use that quirk, but I'm actually leaning towards just > removing that quirk and reducing the log level of the message to info. > > Oliver, what do you say? Now that I think about this, I'd say that we should actually expor

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-27 Thread Dan Williams
On Mon, 2014-10-27 at 20:40 +0100, Oliver Neukum wrote: > On Mon, 2014-10-27 at 19:07 +0100, Johan Hovold wrote: > > > I guess we could use that quirk, but I'm actually leaning towards just > > removing that quirk and reducing the log level of the message to info. > > > > Oliver, what do you say?

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Johan Hovold
On Mon, Oct 27, 2014 at 08:40:51PM +0100, Oliver Neukum wrote: > On Mon, 2014-10-27 at 19:07 +0100, Johan Hovold wrote: > > > I guess we could use that quirk, but I'm actually leaning towards just > > removing that quirk and reducing the log level of the message to info. > > > > Oliver, what do y

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Bjørn Mork
Johan Hovold writes: > Today, only one device has the "NOT_A_MODEM" flag (*only* to prevent one > message during probe), and most devices are simply matched on the > interface class fields anyway. I'm not sure we want to start registering > devices with broken bmCapabilities in the driver (rather

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Oliver Neukum
On Tue, 2014-10-28 at 08:03 +0100, Johan Hovold wrote: > Today, only one device has the "NOT_A_MODEM" flag (*only* to prevent > one > message during probe), and most devices are simply matched on the > interface class fields anyway. I'm not sure we want to start > registering > devices with broken

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Oliver Neukum
On Tue, 2014-10-28 at 10:05 +0100, Bjørn Mork wrote: > Johan Hovold writes: > > > Today, only one device has the "NOT_A_MODEM" flag (*only* to prevent one > > message during probe), and most devices are simply matched on the > > interface class fields anyway. I'm not sure we want to start registe

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Oliver Neukum
On Mon, 2014-10-27 at 15:35 -0500, Dan Williams wrote: > so whenever that flag gets exported, we also need to make sure that > things that the kernel says *aren't* modems, actually aren't modems. > Which we apparently get wrong right now for various Nokia devices. I > don't really trust the manufa

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Dan Williams
On Tue, 2014-10-28 at 10:26 +0100, Oliver Neukum wrote: > On Tue, 2014-10-28 at 10:05 +0100, Bjørn Mork wrote: > > Johan Hovold writes: > > > > > Today, only one device has the "NOT_A_MODEM" flag (*only* to prevent one > > > message during probe), and most devices are simply matched on the > > >

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Oliver Neukum
On Tue, 2014-10-28 at 11:49 -0500, Dan Williams wrote: > > Well, then I guess it is up to Dan. Would you use the exported > > capabilities? > > From a practical standpoint, I'm not it would be as useful as we all > would like, mainly because the capabilities can be wrong and kernel > changes filte

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-29 Thread Peter Stuge
Oliver Neukum wrote: > Then I guess I'll take no further action in kernel space. I for one would like the kernel messages to be less prominent, if they stay at all. Since descriptors are not always correct, it's not so useful for the kernel to output such "loud" messages. //Peter -- To unsubscr

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-30 Thread Oliver Neukum
On Thu, 2014-10-30 at 02:19 +0100, Peter Stuge wrote: > Oliver Neukum wrote: > > Then I guess I'll take no further action in kernel space. > > I for one would like the kernel messages to be less prominent, if > they stay at all. I am removing them. Regards Oliver -- To

patch "USB: cdc-acm: add device id for GW Instek AFG-2225" added to usb tree

2014-11-03 Thread gregkh
This is a note to let you know that I've just added the patch titled USB: cdc-acm: add device id for GW Instek AFG-2225 to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. The patch will show up in the next relea

Patch "USB: cdc-acm: add device id for GW Instek AFG-2225" has been added to the 3.10-stable tree

2014-11-09 Thread gregkh
This is a note to let you know that I've just added the patch titled USB: cdc-acm: add device id for GW Instek AFG-2225 to the 3.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: usb-

Patch "USB: cdc-acm: add device id for GW Instek AFG-2225" has been added to the 3.14-stable tree

2014-11-09 Thread gregkh
This is a note to let you know that I've just added the patch titled USB: cdc-acm: add device id for GW Instek AFG-2225 to the 3.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: usb-

Patch "USB: cdc-acm: add device id for GW Instek AFG-2225" has been added to the 3.17-stable tree

2014-11-09 Thread gregkh
This is a note to let you know that I've just added the patch titled USB: cdc-acm: add device id for GW Instek AFG-2225 to the 3.17-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: usb-