[PATCH] drm/i915: hold forcewake around ring hw init

2012-06-04 Thread Daniel Vetter
Empirical evidence suggests that we need to: On at least one ivb machine when running the hangman i-g-t test, the rings don't properly initialize properly - the RING_START registers seems to be stuck at all zeros. Holding forcewake around this register init sequences makes chip reset reliable agai

[PATCH] drm/i915: hold forcewake around ring hw init

2012-06-04 Thread Daniel Vetter
Empirical evidence suggests that we need to: On at least one ivb machine when running the hangman i-g-t test, the rings don't properly initialize properly - the RING_START registers seems to be stuck at all zeros. Holding forcewake around this register init sequences makes chip reset reliable agai

Re: [PATCH] drm/i915: hold forcewake around ring hw init

2012-06-04 Thread Daniel Vetter
On Mon, Jun 04, 2012 at 11:18:15AM +0200, Daniel Vetter wrote: > Empirical evidence suggests that we need to: On at least one ivb > machine when running the hangman i-g-t test, the rings don't properly > initialize properly - the RING_START registers seems to be stuck at > all zeros. > > Holding f

Re: [Intel-gfx] [PATCH] drm/i915: hold forcewake around ring hw init

2012-06-04 Thread Jani Nikula
Hi Daniel, please find a couple of comments inline. BR, Jani. On Mon, 04 Jun 2012, Daniel Vetter wrote: > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 238a521..a0c76aa 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.

Re: [Intel-gfx] [PATCH] drm/i915: hold forcewake around ring hw init

2012-06-04 Thread Daniel Vetter
On Mon, Jun 04, 2012 at 12:04:41PM +0300, Jani Nikula wrote: > > Hi Daniel, please find a couple of comments inline. Oops, a clear case of -ENOTENOUGHCOFFEE. Thanks for catching these, I'll follow up with a v2 shortly. -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 --

Re: [Intel-gfx] [PATCH] drm/i915: hold forcewake around ring hw init

2012-06-04 Thread Chris Wilson
On Mon, 4 Jun 2012 11:16:04 +0200, Daniel Vetter wrote: > On Mon, Jun 04, 2012 at 12:04:41PM +0300, Jani Nikula wrote: > > > > Hi Daniel, please find a couple of comments inline. > > Oops, a clear case of -ENOTENOUGHCOFFEE. Thanks for catching these, I'll > follow up with a v2 shortly. Fwiw, th

Re: [Intel-gfx] [PATCH] drm/i915: hold forcewake around ring hw init

2012-06-04 Thread Eugeni Dodonov
On 06/04/2012 06:18 AM, Daniel Vetter wrote: Empirical evidence suggests that we need to: On at least one ivb machine when running the hangman i-g-t test, the rings don't properly initialize properly - the RING_START registers seems to be stuck at all zeros. Holding forcewake around this registe

Re: [Intel-gfx] [PATCH] drm/i915: hold forcewake around ring hw init

2012-06-04 Thread Daniel Vetter
On Mon, Jun 04, 2012 at 09:47:54AM -0300, Eugeni Dodonov wrote: > On 06/04/2012 06:18 AM, Daniel Vetter wrote: > >Empirical evidence suggests that we need to: On at least one ivb > >machine when running the hangman i-g-t test, the rings don't properly > >initialize properly - the RING_START registe

Patch "drm/i915: hold forcewake around ring hw init" has been added to the 3.4-stable tree

2013-01-15 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/i915: hold forcewake around ring hw init to the 3.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: 0005-drm-i9

FAILED: patch "[PATCH] drm/i915: hold forcewake around ring hw init" failed to apply to 3.4-stable tree

2012-06-09 Thread gregkh
tree -- >From b7884eb45ec98c0d34c7f49005ae9d4b4b4e38f6 Mon Sep 17 00:00:00 2001 From: Daniel Vetter Date: Mon, 4 Jun 2012 11:18:15 +0200 Subject: [PATCH] drm/i915: hold forcewake around ring hw init Empirical evidence suggests that we need to: On at least one ivb machine when running the hangman i-