[PATCH] drm: Destroy the planes prior to destroying the associated CRTC

2012-09-17 Thread Chris Wilson
As during the plane cleanup, we wish to disable the hardware and so may modify state on the associated CRTC, that CRTC must continue to exist until we are finished. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54101 Signed-off-by: Chris Wilson Cc: Jesse Barnes Cc: stable@vger.kernel.or

Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC

2012-09-17 Thread Jesse Barnes
On Mon, 17 Sep 2012 10:38:03 +0100 Chris Wilson wrote: > As during the plane cleanup, we wish to disable the hardware and > so may modify state on the associated CRTC, that CRTC must continue to > exist until we are finished. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54101 > Sig

Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC

2012-09-17 Thread Chris Wilson
On Mon, 17 Sep 2012 07:55:59 -0700, Jesse Barnes wrote: > Yeah, looks good. Did we used to not touch the crtc in the plane > cleanup? Either way this is safer. I think the bug only came to light because QA is now routinely running with slub_debug. -Chris -- Chris Wilson, Intel Open Source Te

Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC

2012-09-19 Thread Daniel Vetter
On Mon, Sep 17, 2012 at 04:04:23PM +0100, Chris Wilson wrote: > On Mon, 17 Sep 2012 07:55:59 -0700, Jesse Barnes > wrote: > > Yeah, looks good. Did we used to not touch the crtc in the plane > > cleanup? Either way this is safer. > > I think the bug only came to light because QA is now routine

Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC

2012-09-19 Thread Paul Menzel
Am Mittwoch, den 19.09.2012, 11:34 +0200 schrieb Daniel Vetter: > On Mon, Sep 17, 2012 at 04:04:23PM +0100, Chris Wilson wrote: > > On Mon, 17 Sep 2012 07:55:59 -0700, Jesse Barnes > > wrote: > > > Yeah, looks good. Did we used to not touch the crtc in the plane > > > cleanup? Either way this i

Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC

2012-09-19 Thread Chris Wilson
On Wed, 19 Sep 2012 11:45:34 +0200, Paul Menzel wrote: > Am Mittwoch, den 19.09.2012, 11:34 +0200 schrieb Daniel Vetter: > > On Mon, Sep 17, 2012 at 04:04:23PM +0100, Chris Wilson wrote: > > > On Mon, 17 Sep 2012 07:55:59 -0700, Jesse Barnes > > > wrote: > > > > Yeah, looks good. Did we used t

Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC

2012-09-19 Thread Joonyoung Shim
On 09/17/2012 06:38 PM, Chris Wilson wrote: As during the plane cleanup, we wish to disable the hardware and so may modify state on the associated CRTC, that CRTC must continue to exist until we are finished. A similar issue can occur in the drm_framebuffer_cleanup(). If crtc and plane use same

Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC

2012-09-19 Thread Rob Clark
On Wed, Sep 19, 2012 at 9:52 PM, Joonyoung Shim wrote: > On 09/17/2012 06:38 PM, Chris Wilson wrote: >> >> As during the plane cleanup, we wish to disable the hardware and >> so may modify state on the associated CRTC, that CRTC must continue to >> exist until we are finished. > > > A similar issu

Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC

2012-09-19 Thread Joonyoung Shim
On 09/20/2012 02:38 PM, Rob Clark wrote: On Wed, Sep 19, 2012 at 9:52 PM, Joonyoung Shim wrote: On 09/17/2012 06:38 PM, Chris Wilson wrote: As during the plane cleanup, we wish to disable the hardware and so may modify state on the associated CRTC, that CRTC must continue to exist until we are

Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC

2012-09-20 Thread Chris Wilson
> >>>+ list_for_each_entry_safe(crtc, ct, &dev->mode_config.crtc_list, > >>> head) { > >>> + crtc->funcs->destroy(crtc); > >>> + } > >>> + > >>> idr_remove_all(&dev->mod

Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC

2012-09-20 Thread Joonyoung Shim
_ dri-devel mailing list dri-de...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel From: Chris Wilson Subject: Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC To: Rob Clark , Joonyoung Shim Cc: airl...@redhat.com, stable@vger.kernel.org, dri-de...

Patch "drm: Destroy the planes prior to destroying the associated CRTC" has been added to the 3.5-stable tree

2012-10-09 Thread gregkh
This is a note to let you know that I've just added the patch titled drm: Destroy the planes prior to destroying the associated CRTC to the 3.5-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch i

Patch "drm: Destroy the planes prior to destroying the associated CRTC" has been added to the 3.6-stable tree

2012-10-09 Thread gregkh
This is a note to let you know that I've just added the patch titled drm: Destroy the planes prior to destroying the associated CRTC to the 3.6-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch i

Patch "drm: Destroy the planes prior to destroying the associated CRTC" has been added to the 3.4-stable tree

2012-10-09 Thread gregkh
This is a note to let you know that I've just added the patch titled drm: Destroy the planes prior to destroying the associated CRTC to the 3.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch i