[PATCH] md/raid5: fix locking in handle_stripe_clean_event()

2015-10-28 Thread Roman Gushchin
After commit 566c09c53455 ("raid5: relieve lock contention in get_active_stripe()") __find_stripe() is called under conf->hash_locks + hash. But handle_stripe_clean_event() calls remove_hash() under conf->device_lock. Under some cirscumstances the hash chain can be circuited, and we get an infini

[PATCH] md/raid5: fix locking in handle_stripe_clean_event()

2015-11-06 Thread Roman Gushchin
commit b8a9d66d043ffac116100775a469f05f5158c16f upstream. After commit 566c09c53455 ("raid5: relieve lock contention in get_active_stripe()") __find_stripe() is called under conf->hash_locks + hash. But handle_stripe_clean_event() calls remove_hash() under conf->device_lock. Under some cirscumst

Re: [PATCH] md/raid5: fix locking in handle_stripe_clean_event()

2015-10-28 Thread Neil Brown
On Wed, Oct 28 2015, Roman Gushchin wrote: > After commit 566c09c53455 ("raid5: relieve lock contention in > get_active_stripe()") > __find_stripe() is called under conf->hash_locks + hash. > But handle_stripe_clean_event() calls remove_hash() under > conf->device_lock. > > Under some cirscumstan

Re: [PATCH] md/raid5: fix locking in handle_stripe_clean_event()

2015-10-29 Thread Roman Gushchin
29.10.2015, 03:35, "Neil Brown" : > On Wed, Oct 28 2015, Roman Gushchin wrote: > >>  After commit 566c09c53455 ("raid5: relieve lock contention in >> get_active_stripe()") >>  __find_stripe() is called under conf->hash_locks + hash. >>  But handle_stripe_clean_event() calls remove_hash() under >>

Re: [PATCH] md/raid5: fix locking in handle_stripe_clean_event()

2015-10-29 Thread Greg KH
On Thu, Oct 29, 2015 at 05:15:48PM +0300, Roman Gushchin wrote: > 29.10.2015, 03:35, "Neil Brown" : > > On Wed, Oct 28 2015, Roman Gushchin wrote: > > > >>  After commit 566c09c53455 ("raid5: relieve lock contention in > >> get_active_stripe()") > >>  __find_stripe() is called under conf->hash_loc

Re: [PATCH] md/raid5: fix locking in handle_stripe_clean_event()

2015-11-11 Thread Luis Henriques
On Fri, Nov 06, 2015 at 12:54:47PM +0300, Roman Gushchin wrote: > commit b8a9d66d043ffac116100775a469f05f5158c16f upstream. > Thanks, I'll use this backport for the 3.16 kernel as well. Cheers, -- Luís > After commit 566c09c53455 ("raid5: relieve lock contention in > get_active_stripe()") > __

Patch "md/raid5: fix locking in handle_stripe_clean_event()" has been added to the 4.1-stable tree

2015-11-05 Thread gregkh
This is a note to let you know that I've just added the patch titled md/raid5: fix locking in handle_stripe_clean_event() to the 4.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: md-

Patch "md/raid5: fix locking in handle_stripe_clean_event()" has been added to the 4.2-stable tree

2015-11-05 Thread gregkh
This is a note to let you know that I've just added the patch titled md/raid5: fix locking in handle_stripe_clean_event() to the 4.2-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: md-

Patch "md/raid5: fix locking in handle_stripe_clean_event()" has been added to the 3.14-stable tree

2015-11-06 Thread gregkh
This is a note to let you know that I've just added the patch titled md/raid5: fix locking in handle_stripe_clean_event() to the 3.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: md

FAILED: patch "[PATCH] md/raid5: fix locking in handle_stripe_clean_event()" failed to apply to 3.14-stable tree

2015-11-05 Thread gregkh
tree -- >From b8a9d66d043ffac116100775a469f05f5158c16f Mon Sep 17 00:00:00 2001 From: Roman Gushchin Date: Sat, 31 Oct 2015 10:53:50 +1100 Subject: [PATCH] md/raid5: fix locking in handle_stripe_clean_event() After commit 566c09c53455 ("raid5: relieve lock contention in get_