Re: [PATCH-3.5.y] staging: comedi: pcmuio: fix possible NULL deref on detach

2013-12-19 Thread Luis Henriques
On Thu, Dec 12, 2013 at 01:21:59PM +, Ian Abbott wrote: > follow 2fd2bdfccae61efe18f6b92b6a45fbf936d75b48 Thanks Ian, I'm queuing it for the 3.5 kernel. Cheers, -- Luis > > pcmuio_detach() is called by the comedi core even if pcmuio_attach() > returned an error, so `dev->private` might be `

[PATCH-3.5.y] staging: comedi: pcmuio: fix possible NULL deref on detach

2013-12-12 Thread Ian Abbott
follow 2fd2bdfccae61efe18f6b92b6a45fbf936d75b48 pcmuio_detach() is called by the comedi core even if pcmuio_attach() returned an error, so `dev->private` might be `NULL`. Check for that before dereferencing it. Also, as pointed out by Dan Carpenter, there is no need to check the pointer passed t