Re: [PATCH -stable] ntp: Correct TAI offset during leap second

2012-06-30 Thread Ben Hutchings
On Mon, 2012-06-18 at 14:55 +0100, Ben Hutchings wrote: On Sun, 2012-06-17 at 19:34 +0200, Richard Cochran wrote: On Sun, Jun 17, 2012 at 11:47:51AM -0500, Jonathan Nieder wrote: Ben Hutchings wrote: On Fri, 2012-06-15 at 11:56 -0700, John Stultz wrote: commit

Re: [PATCH -stable] ntp: Correct TAI offset during leap second

2012-06-30 Thread John Stultz
On 06/30/2012 06:28 PM, Ben Hutchings wrote: On Mon, 2012-06-18 at 14:55 +0100, Ben Hutchings wrote: On Sun, 2012-06-17 at 19:34 +0200, Richard Cochran wrote: On Sun, Jun 17, 2012 at 11:47:51AM -0500, Jonathan Nieder wrote: Ben Hutchings wrote: On Fri, 2012-06-15 at 11:56 -0700, John Stultz

Re: [PATCH -stable] ntp: Correct TAI offset during leap second

2012-06-20 Thread Richard Cochran
On Tue, Jun 19, 2012 at 10:26:49AM -0700, John Stultz wrote: Richard, are you planning on taking another go at those changes? Or were my last suggestions just too daft? ;) I wonder if it is really worth the effort to fix up adjtimex. But I am strongly in favor of adding CLOCK_TAI, since that

Re: [PATCH -stable] ntp: Correct TAI offset during leap second

2012-06-20 Thread John Stultz
On 06/20/2012 09:25 AM, Richard Cochran wrote: On Tue, Jun 19, 2012 at 10:26:49AM -0700, John Stultz wrote: Richard, are you planning on taking another go at those changes? Or were my last suggestions just too daft? ;) I wonder if it is really worth the effort to fix up adjtimex. But I am

Re: [PATCH -stable] ntp: Correct TAI offset during leap second

2012-06-19 Thread Ben Hutchings
On Mon, 2012-06-18 at 18:28 +0200, Richard Cochran wrote: On Mon, Jun 18, 2012 at 02:55:11PM +0100, Ben Hutchings wrote: On Sun, 2012-06-17 at 19:34 +0200, Richard Cochran wrote: The offset should change upon entering state OOP, so something like the following (untested) patch should fix

Re: [PATCH -stable] ntp: Correct TAI offset during leap second

2012-06-18 Thread Ben Hutchings
On Sun, 2012-06-17 at 19:34 +0200, Richard Cochran wrote: On Sun, Jun 17, 2012 at 11:47:51AM -0500, Jonathan Nieder wrote: Ben Hutchings wrote: On Fri, 2012-06-15 at 11:56 -0700, John Stultz wrote: commit dd48d708ff3e917f6d6b6c2b696c3f18c019feed upstream. [...] This doesn't apply

Re: [PATCH -stable] ntp: Correct TAI offset during leap second

2012-06-18 Thread Richard Cochran
On Mon, Jun 18, 2012 at 02:55:11PM +0100, Ben Hutchings wrote: On Sun, 2012-06-17 at 19:34 +0200, Richard Cochran wrote: The offset should change upon entering state OOP, so something like the following (untested) patch should fix it for 3.2.9. [...] It looks like this patch just changes

Re: [PATCH -stable] ntp: Correct TAI offset during leap second

2012-06-18 Thread John Stultz
On 06/18/2012 06:55 AM, Ben Hutchings wrote: On Sun, 2012-06-17 at 19:34 +0200, Richard Cochran wrote: On Sun, Jun 17, 2012 at 11:47:51AM -0500, Jonathan Nieder wrote: Ben Hutchings wrote: 6b43ae8a619d (ntp: Fix leap-second hrtimer livelock) sounds important, but the patch depends on

Re: [PATCH -stable] ntp: Correct TAI offset during leap second

2012-06-17 Thread Ben Hutchings
On Fri, 2012-06-15 at 11:56 -0700, John Stultz wrote: Hey Greg, Forgot to cc stable on this one. Thanks to Dave Jones for noticing! -john -- From: Richard Cochranrichardcoch...@gmail.com commit dd48d708ff3e917f6d6b6c2b696c3f18c019feed upstream. When repeating a

Re: [PATCH -stable] ntp: Correct TAI offset during leap second

2012-06-17 Thread Jonathan Nieder
Ben Hutchings wrote: On Fri, 2012-06-15 at 11:56 -0700, John Stultz wrote: commit dd48d708ff3e917f6d6b6c2b696c3f18c019feed upstream. [...] This doesn't apply to 3.2.y, unsurprisingly. Let me know if there are any urgent leap second fixes that will be needed there. 6b43ae8a619d (ntp: Fix

Re: [PATCH -stable] ntp: Correct TAI offset during leap second

2012-06-17 Thread Richard Cochran
On Sun, Jun 17, 2012 at 11:47:51AM -0500, Jonathan Nieder wrote: Ben Hutchings wrote: On Fri, 2012-06-15 at 11:56 -0700, John Stultz wrote: commit dd48d708ff3e917f6d6b6c2b696c3f18c019feed upstream. [...] This doesn't apply to 3.2.y, unsurprisingly. Let me know if there are any urgent

[PATCH -stable] ntp: Correct TAI offset during leap second

2012-06-15 Thread John Stultz
Hey Greg, Forgot to cc stable on this one. Thanks to Dave Jones for noticing! -john -- From: Richard Cochranrichardcoch...@gmail.com commit dd48d708ff3e917f6d6b6c2b696c3f18c019feed upstream. When repeating a UTC time value during a leap second (when the UTC time should be

Re: [PATCH -stable] ntp: Correct TAI offset during leap second

2012-06-15 Thread John Stultz
On 06/15/2012 11:56 AM, John Stultz wrote: Hey Greg, Forgot to cc stable on this one. Thanks to Dave Jones for noticing! -john Gah. Thunderbird's preformat wrecked that one. Sorry. Here it is again. -john -- From: Richard Cochranrichardcoch...@gmail.com commit