于 2013年11月09日 01:51, Brian Norris 写道:
Thanks for looking into this quickly, BTW.
this patch is not good, it uses the data in the stack to do the DMA
transfer.
I will send a new patch to fix this NULL issue.
thanks
Huang Shijie
--
To unsubscribe from this list: send the line "unsubscribe stab
On Fri, Nov 08, 2013 at 09:51:19AM -0800, Brian Norris wrote:
>
> I agree with Fabio; we don't actually need the +1. (Of course, saving 1
> byte is not that much of a problem. But making the code more
> straightforward is.) If you "ack" I'll just drop the +1 myself.
it is ok to me.
You can drop t
On Fri, Nov 8, 2013 at 3:51 PM, Brian Norris
wrote:
> I agree with Fabio; we don't actually need the +1. (Of course, saving 1
> byte is not that much of a problem. But making the code more
> straightforward is.) If you "ack" I'll just drop the +1 myself.
You can also add my:
Tested-by: Fabio Es
On Thu, Nov 07, 2013 at 05:46:36PM +0800, Huang Shijie wrote:
> The imx23 board will check the fingerprint, so it will call the
> mx23_check_transcription_stamp. This function will use @chip->buffers->databuf
> as its buffer which is allocated in the nand_scan_tail().
>
> Unfortunately, the mx23_c
On Fri, Nov 8, 2013 at 1:10 AM, Huang Shijie wrote:
> 于 2013年11月07日 21:07, Fabio Estevam 写道:
>
>> Why buffer[FINGERPRINT_LEN + 1] instead of buffer[FINGERPRINT_LEN] ?
>
> just for the safe guard. "+1" is to simulate the terminal '\0' of the
> string.
> Of course, it's ok to use the buffer[FINGERPI
于 2013年11月07日 21:07, Fabio Estevam 写道:
Why buffer[FINGERPRINT_LEN + 1] instead of buffer[FINGERPRINT_LEN] ?
just for the safe guard. "+1" is to simulate the terminal '\0' of the
string.
Of course, it's ok to use the buffer[FINGERPINGT_LEN].
thanks
Huang Shijie
--
To unsubscribe from this list
Hi Huang,
On Thu, Nov 7, 2013 at 7:46 AM, Huang Shijie wrote:
> The imx23 board will check the fingerprint, so it will call the
> mx23_check_transcription_stamp. This function will use @chip->buffers->databuf
> as its buffer which is allocated in the nand_scan_tail().
>
> Unfortunately, the mx23_
The imx23 board will check the fingerprint, so it will call the
mx23_check_transcription_stamp. This function will use @chip->buffers->databuf
as its buffer which is allocated in the nand_scan_tail().
Unfortunately, the mx23_check_transcription_stamp is called before the
nand_scan_tail(). So we wi
