Re: [PATCH fix for 3.17 1/2] xhci: Check for eps[ep_index].ring being NULL after an usb_device_reset

2014-10-01 Thread Hans de Goede
Hi, On 09/28/2014 09:33 PM, Alan Stern wrote: > On Sun, 28 Sep 2014, Hans de Goede wrote: > The problem is the following call sequence (simplified): 1) usb_reset_device 2) usb_reset_and_verify_device 2) hub_port_init 3)hub_port_finish_reset 3) xhci_di

Re: [PATCH fix for 3.17 1/2] xhci: Check for eps[ep_index].ring being NULL after an usb_device_reset

2014-09-28 Thread Alan Stern
On Sun, 28 Sep 2014, Hans de Goede wrote: > >> The problem is the following call sequence (simplified): > >> > >> 1) usb_reset_device > >> 2) usb_reset_and_verify_device > >> 2) hub_port_init > >> 3)hub_port_finish_reset > >> 3) xhci_discover_or_reset_device > >> This frees xhci

Re: [PATCH fix for 3.17 1/2] xhci: Check for eps[ep_index].ring being NULL after an usb_device_reset

2014-09-28 Thread Hans de Goede
Hi, On 09/28/2014 04:29 PM, Alan Stern wrote: > On Sat, 27 Sep 2014, Hans de Goede wrote: > >> This commit fixes the following oops: >> >> [10238.622067] scsi host3: uas_eh_bus_reset_handler start >> [10240.766164] usb 3-4: reset SuperSpeed USB device number 3 using xhci_hcd >> [10245.779365] usb

Re: [PATCH fix for 3.17 1/2] xhci: Check for eps[ep_index].ring being NULL after an usb_device_reset

2014-09-28 Thread Alan Stern
On Sat, 27 Sep 2014, Hans de Goede wrote: > This commit fixes the following oops: > > [10238.622067] scsi host3: uas_eh_bus_reset_handler start > [10240.766164] usb 3-4: reset SuperSpeed USB device number 3 using xhci_hcd > [10245.779365] usb 3-4: device descriptor read/8, error -110 > [10245.883

Re: [PATCH fix for 3.17 1/2] xhci: Check for eps[ep_index].ring being NULL after an usb_device_reset

2014-09-28 Thread Ben Hutchings
On Sat, 2014-09-27 at 15:01 +0200, Hans de Goede wrote: [...] > --- a/drivers/usb/host/xhci.c > +++ b/drivers/usb/host/xhci.c > @@ -1146,10 +1146,12 @@ unsigned int xhci_last_valid_endpoint(u32 added_ctxs) > * returns 0 this is a root hub; returns -EINVAL for NULL pointers. > */ > static int x

[PATCH fix for 3.17 1/2] xhci: Check for eps[ep_index].ring being NULL after an usb_device_reset

2014-09-27 Thread Hans de Goede
This commit fixes the following oops: [10238.622067] scsi host3: uas_eh_bus_reset_handler start [10240.766164] usb 3-4: reset SuperSpeed USB device number 3 using xhci_hcd [10245.779365] usb 3-4: device descriptor read/8, error -110 [10245.883331] usb 3-4: reset SuperSpeed USB device number 3 usin