[PATCH v2 1/1] elantech: Add support for trackpoint found on some v3 models

2014-06-12 Thread Ulrik De Bie
Some elantech v3 touchpad equipped laptops also have a trackpoint, before this commit, these give sync errors. With this patch, the trackpoint is provided as another input device: 'Elantech PS/2 TrackPoint' The patch will also output messages that do not follow the expected pattern. In the mean ti

Re: [PATCH v2 1/1] elantech: Add support for trackpoint found on some v3 models

2014-06-12 Thread Greg KH
On Thu, Jun 12, 2014 at 08:15:01PM +0200, Ulrik De Bie wrote: > Some elantech v3 touchpad equipped laptops also have a trackpoint, before > this commit, these give sync errors. With this patch, the trackpoint is > provided as another input device: 'Elantech PS/2 TrackPoint' > > The patch will also

Re: [PATCH v2 1/1] elantech: Add support for trackpoint found on some v3 models

2014-06-12 Thread ulrik . debie-os
Hi Greg, Without this patch the elantech.c driver will still bind to the touchpad, and then get out of sync each time the user touches the trackpoint or the 3 mouse buttons associated with the trackpoint. This out of sync will result in a few dmesg lines and a few lost touchpad input events. The

Re: [PATCH v2 1/1] elantech: Add support for trackpoint found on some v3 models

2014-06-12 Thread Greg KH
On Thu, Jun 12, 2014 at 09:03:45PM +0200, ulrik.debie...@e2big.org wrote: > Hi Greg, > > Without this patch the elantech.c driver will still bind to the > touchpad, and then get out of sync each time the user touches > the trackpoint or the 3 mouse buttons associated with the trackpoint. > > This

Re: [PATCH v2 1/1] elantech: Add support for trackpoint found on some v3 models

2014-06-12 Thread David Herrmann
Hi On Thu, Jun 12, 2014 at 8:15 PM, Ulrik De Bie wrote: > Some elantech v3 touchpad equipped laptops also have a trackpoint, before > this commit, these give sync errors. With this patch, the trackpoint is > provided as another input device: 'Elantech PS/2 TrackPoint' > > The patch will also outp

Re: [PATCH v2 1/1] elantech: Add support for trackpoint found on some v3 models

2014-06-13 Thread David Herrmann
Hi On Fri, Jun 13, 2014 at 9:24 AM, Hans de Goede wrote: >> You rely on external data here, so please check for truncation. If >> anyone changes psmouse->ps2dev.serio->phys, they would not notice that >> you rely on it here. So I'd do sth like: >> >> size_t n = snprintf(etd->tp_phys, sizeof(etd->