This is a note to let you know that I've just added the patch titled

    gpio: mpc8xxx: Prevent NULL pointer deref in demux handler

to the 3.3-stable tree which can be found at:
    
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     gpio-mpc8xxx-prevent-null-pointer-deref-in-demux-handler.patch
and it can be found in the queue-3.3 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From d6de85e85edcc38c9edcde45a0a568818fcddc13 Mon Sep 17 00:00:00 2001
From: Thomas Gleixner <t...@linutronix.de>
Date: Thu, 3 May 2012 12:22:06 +0200
Subject: gpio: mpc8xxx: Prevent NULL pointer deref in demux handler

From: Thomas Gleixner <t...@linutronix.de>

commit d6de85e85edcc38c9edcde45a0a568818fcddc13 upstream.

commit cfadd838(powerpc/8xxx: Fix interrupt handling in MPC8xxx GPIO
driver) added an unconditional call of chip->irq_eoi() to the demux
handler.

This leads to a NULL pointer derefernce on MPC512x platforms which use
this driver as well.

Make it conditional.

Reported-by: Thomas Wucher <thwuc...@linutronix.de>
Signed-off-by: Thomas Gleixner <t...@linutronix.de>
Cc: Felix Radensky <fe...@embedded-sol.com>
Cc: Kumar Gala <ga...@kernel.crashing.org>
Cc: Grant Likely <grant.lik...@secretlab.ca>
Signed-off-by: Grant Likely <grant.lik...@secretlab.ca>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

---
 drivers/gpio/gpio-mpc8xxx.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/gpio/gpio-mpc8xxx.c
+++ b/drivers/gpio/gpio-mpc8xxx.c
@@ -163,7 +163,8 @@ static void mpc8xxx_gpio_irq_cascade(uns
        if (mask)
                generic_handle_irq(irq_linear_revmap(mpc8xxx_gc->irq,
                                                     32 - ffs(mask)));
-       chip->irq_eoi(&desc->irq_data);
+       if (chip->irq_eoi)
+               chip->irq_eoi(&desc->irq_data);
 }
 
 static void mpc8xxx_irq_unmask(struct irq_data *d)


Patches currently in stable-queue which might be from t...@linutronix.de are

queue-3.3/powerpc-fix-broken-cpu_idle_wait-implementation.patch
queue-3.3/gpio-mpc8xxx-prevent-null-pointer-deref-in-demux-handler.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to