Re: [PATCH] mm: Actually clear pmd_numa before invalidating

2014-08-13 Thread Mel Gorman
On Wed, Aug 13, 2014 at 01:23:33PM -0700, Andrew Morton wrote: > On Wed, 13 Aug 2014 20:16:31 + "Wilcox, Matthew R" > wrote: > > > I am quite shockingly ignorant of the MM code. While looking at this > > function to figure out how/whether to use it, I noticed the bug, and > > sent a patch.

Re: [PATCH] mm: Actually clear pmd_numa before invalidating

2014-08-13 Thread Andrew Morton
On Wed, 13 Aug 2014 20:16:31 + "Wilcox, Matthew R" wrote: > I am quite shockingly ignorant of the MM code. While looking at this > function to figure out how/whether to use it, I noticed the bug, and > sent a patch. I assumed the gibberish in the changelog meant something > important to pe

RE: [PATCH] mm: Actually clear pmd_numa before invalidating

2014-08-13 Thread Wilcox, Matthew R
:-) -Original Message- From: Andrew Morton [mailto:a...@linux-foundation.org] Sent: Wednesday, August 13, 2014 1:13 PM To: Wilcox, Matthew R Cc: linux...@kvack.org; Mel Gorman; Rik van Riel; stable@vger.kernel.org Subject: Re: [PATCH] mm: Actually clear pmd_numa before invalidating On Wed, 13 Aug 2014 20

Re: [PATCH] mm: Actually clear pmd_numa before invalidating

2014-08-13 Thread Andrew Morton
On Wed, 13 Aug 2014 20:04:02 + "Wilcox, Matthew R" wrote: > The commit log for 67f87463d3 explains what the runtime effects should have > been. No it doesn't. In fact the sentence "The existing caller of pmdp_invalidate should handle it but it's an inconsistent state for a PMD." makes me

RE: [PATCH] mm: Actually clear pmd_numa before invalidating

2014-08-13 Thread Wilcox, Matthew R
, Matthew R Cc: linux...@kvack.org; Mel Gorman; Rik van Riel; stable@vger.kernel.org Subject: Re: [PATCH] mm: Actually clear pmd_numa before invalidating On Wed, 13 Aug 2014 11:28:27 -0400 Matthew Wilcox wrote: > Commit 67f87463d3 cleared the NUMA bit in a copy of the PMD entry, but > then

Re: [PATCH] mm: Actually clear pmd_numa before invalidating

2014-08-13 Thread Andrew Morton
On Wed, 13 Aug 2014 11:28:27 -0400 Matthew Wilcox wrote: > Commit 67f87463d3 cleared the NUMA bit in a copy of the PMD entry, but > then wrote back the original > > Signed-off-by: Matthew Wilcox > Cc: Mel Gorman > Cc: Rik van Riel > Cc: What are the runtime effects of this patch? -- To u

Re: [PATCH] mm: Actually clear pmd_numa before invalidating

2014-08-13 Thread Mel Gorman
On Wed, Aug 13, 2014 at 11:28:27AM -0400, Matthew Wilcox wrote: > Commit 67f87463d3 cleared the NUMA bit in a copy of the PMD entry, but > then wrote back the original > > Signed-off-by: Matthew Wilcox > Cc: Mel Gorman > Cc: Rik van Riel > Cc: > Cc: Andrew Morton Acked-by: Mel Gorman -- M

Re: [PATCH] mm: Actually clear pmd_numa before invalidating

2014-08-13 Thread Rik van Riel
On 08/13/2014 11:28 AM, Matthew Wilcox wrote: > Commit 67f87463d3 cleared the NUMA bit in a copy of the PMD entry, but > then wrote back the original > > Signed-off-by: Matthew Wilcox > Cc: Mel Gorman > Cc: Rik van Riel > Cc: > Cc: Andrew Morton Reviewed-by: Rik van Riel -- To unsubscribe