RE: [PATCH 1/2] Drivers: hv: balloon: Fix a bug in the hot-add code

2013-07-13 Thread KY Srinivasan
; jasow...@redhat.com; Stable > Subject: Re: [PATCH 1/2] Drivers: hv: balloon: Fix a bug in the hot-add code > > On Fri, Jul 12, 2013 at 09:07:19PM +, KY Srinivasan wrote: > [...] > > > Well now it might look like a bug that you don't test the result > > > of wai

Re: [PATCH 1/2] Drivers: hv: balloon: Fix a bug in the hot-add code

2013-07-12 Thread Ben Hutchings
On Fri, Jul 12, 2013 at 09:07:19PM +, KY Srinivasan wrote: [...] > > Well now it might look like a bug that you don't test the result > > of wait_for_completion_timeout(). Maybe update the comment to > > explain why it's OK to continue anyway? > > I put in the comment in the patch explaining

RE: [PATCH 1/2] Drivers: hv: balloon: Fix a bug in the hot-add code

2013-07-12 Thread KY Srinivasan
; jasow...@redhat.com; Stable > Subject: Re: [PATCH 1/2] Drivers: hv: balloon: Fix a bug in the hot-add code > > On Fri, Jul 12, 2013 at 06:56:14AM -0700, K. Y. Srinivasan wrote: > > As we hot-add 128 MB chunks of memory, we wait to ensure that the memory > > is onlined before at

Re: [PATCH 1/2] Drivers: hv: balloon: Fix a bug in the hot-add code

2013-07-12 Thread Ben Hutchings
On Fri, Jul 12, 2013 at 06:56:14AM -0700, K. Y. Srinivasan wrote: > As we hot-add 128 MB chunks of memory, we wait to ensure that the memory > is onlined before attempting to hot-add the next chunk. If the udev rule for > memory hot-add is not executed within the allowed time, we would rollback the