RE: [PATCH] Update test 22.locale.num.put.mt.cpp to validate results [take 2]

2007-08-13 Thread Travis Vitek
Martin Sebor wrote: > >> >> +#define countof(x) (sizeof (x) / sizeof (*x)) > >Since you seem to like it so much ;-) we might as well move this >macro to some central test suite header (and rename it according >to the naming convention). > I'd love to, provided that we can define the naming con

Re: [PATCH] Update test 22.locale.num.put.mt.cpp to validate results [take 2]

2007-08-13 Thread Martin Sebor
Travis Vitek wrote: [...] +TEST_N (data.bool_, bool, data.value_ != 0); +TEST_N (data.long_, long, data.value_); +TEST_N (data.ulong_, unsigned long, data.value_); I note you've changed the test from invoking one num_put member per iteration to invoking all members each iteration

RE: [PATCH] Update test 22.locale.num.put.mt.cpp to validate results [take 2]

2007-08-13 Thread Travis Vitek
>Martin Sebor wrote: > >Travis Vitek wrote: >> Attached is a patch to enhance the num_put facet mt test. Threads >> verify that the values they put compare equal to those put in the >> primary thread. > >There are few outstanding issues here that we need to resolve before >committing this patch.

[jira] Commented: (STDCXX-521) [gcc/GNU make 3.79.1] linker errors while generating dependencies

2007-08-13 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519570 ] Martin Sebor commented on STDCXX-521: - Sure enough, the $(value ...) function in GNU make 3.79.1 behaves differen

[jira] Commented: (STDCXX-521) [gcc/GNU make 3.79.1] linker errors while generating dependencies

2007-08-13 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519569 ] Martin Sebor commented on STDCXX-521: - I suspect the regression might have been introduced while working around

[jira] Assigned: (STDCXX-521) [gcc/GNU make 3.79.1] linker errors while generating dependencies

2007-08-13 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Sebor reassigned STDCXX-521: --- Assignee: Martin Sebor > [gcc/GNU make 3.79.1] linker errors while generating dependencies >

[jira] Created: (STDCXX-521) [gcc/GNU make 3.79.1] linker errors while generating dependencies

2007-08-13 Thread Martin Sebor (JIRA)
[gcc/GNU make 3.79.1] linker errors while generating dependencies - Key: STDCXX-521 URL: https://issues.apache.org/jira/browse/STDCXX-521 Project: C++ Standard Library Issue Typ

Re: Jira issues against trunk

2007-08-13 Thread Martin Sebor
I agree. Unless someone has a better idea (hint -- it would be nice to get feedback from others as well :) I'll go with trunk. Martin Andrew Black wrote: The only benefit I can see in using -dev over trunk, is it would provide a view into what release the bug was discovered (and fixed) in. Thi

Re: [PATCH] Update test 22.locale.time.put.mt.cpp to validate results [take 2]

2007-08-13 Thread Martin Sebor
Travis Vitek wrote: Travis Vitek wrote: Martin Sebor wrote: What do you think about this: let's change rw_locales() to always return a list of names that starts with "C". That way callers that don't want to exercise the "C" locale can simply skip past it while others will be guaranteed to ex

Re: [PATCH] Update test 22.locale.time.put.mt.cpp to validate results [take 2]

2007-08-13 Thread Martin Sebor
Travis Vitek wrote: Martin Sebor wrote: Now that I've committed the patch... I have a question about the bit below that I noticed too late: [...] @@ -160,19 +214,117 @@ static int run_test (int, char**) [...] +const char* const possible_locale_options[] = { +locale_list, "C\

RE: [PATCH] Update test 22.locale.time.put.mt.cpp to validate results [take 2]

2007-08-13 Thread Travis Vitek
Travis Vitek wrote: > >Martin Sebor wrote: >> >>What do you think about this: let's change rw_locales() to always >>return a list of names that starts with "C". That way callers that >>don't want to exercise the "C" locale can simply skip past it while >>others will be guaranteed to exercise the

RE: [PATCH] Update test 22.locale.time.put.mt.cpp to validate results [take 2]

2007-08-13 Thread Travis Vitek
Martin Sebor wrote: > >Now that I've committed the patch... I have a question about the bit >below that I noticed too late: > >[...] >> @@ -160,19 +214,117 @@ >> static int >> run_test (int, char**) >[...] >> +const char* const possible_locale_options[] = { >> +locale_list, "C\0",

Re: Windows build results in the pink

2007-08-13 Thread Andrew Black
Greetings Martin, all. I had time on Friday to investigate the problem with the windows parser script, and checked in a change which resolved the issue. I have not looked into the issue with result parsing on solaris 10 for AMD64. --Andrew Black Andrew Black wrote: > Greetings Martin > > I am

[jira] Closed: (STDCXX-519) [MSVC 7.1 fails to compile fmtflags_manip.cpp example

2007-08-13 Thread Farid Zaripov (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farid Zaripov closed STDCXX-519. > [MSVC 7.1 fails to compile fmtflags_manip.cpp example > -

[jira] Resolved: (STDCXX-519) [MSVC 7.1 fails to compile fmtflags_manip.cpp example

2007-08-13 Thread Farid Zaripov (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farid Zaripov resolved STDCXX-519. -- Resolution: Fixed Fix Version/s: 4.2 I was wrong, the typedef doesn't helps. Fixed thus

[jira] Assigned: (STDCXX-519) [MSVC 7.1 fails to compile fmtflags_manip.cpp example

2007-08-13 Thread Farid Zaripov (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farid Zaripov reassigned STDCXX-519: Assignee: Farid Zaripov > [MSVC 7.1 fails to compile fmtflags_manip.cpp example > -