[jira] Commented: (STDCXX-226) __rw::__rw_new_capacity() uses floating point math

2007-12-19 Thread Farid Zaripov (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553368 ] Farid Zaripov commented on STDCXX-226: -- In the committed patch the _RWSTD_NEW_CAPACITY_RATIO and _RWSTD_STRING_

[jira] Commented: (STDCXX-226) __rw::__rw_new_capacity() uses floating point math

2007-12-13 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551553 ] Martin Sebor commented on STDCXX-226: - I'm not 100% sure it can do that. The floating point environment (such as

[jira] Commented: (STDCXX-226) __rw::__rw_new_capacity() uses floating point math

2007-12-13 Thread Farid Zaripov (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551505 ] Farid Zaripov commented on STDCXX-226: -- In my patch _RWSTD_NEW_CAPACITY_RATIO still double, and it's converted t

[jira] Commented: (STDCXX-226) __rw::__rw_new_capacity() uses floating point math

2007-12-12 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551189 ] Martin Sebor commented on STDCXX-226: - You're right, I must have been looking at the wrong column. Mea culpa! I

[jira] Commented: (STDCXX-226) __rw::__rw_new_capacity() uses floating point math

2007-12-12 Thread Farid Zaripov (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551006 ] Farid Zaripov commented on STDCXX-226: -- In my testing the algorithm in My patch is more accurate :) ---

[jira] Commented: (STDCXX-226) __rw::__rw_new_capacity() uses floating point math

2007-12-11 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550775 ] Martin Sebor commented on STDCXX-226: - We still need to benchmark this before making any changes... Currently, w

[jira] Commented: (STDCXX-226) __rw::__rw_new_capacity() uses floating point math

2007-11-19 Thread Farid Zaripov (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543588 ] Farid Zaripov commented on STDCXX-226: -- We can replace _RWSTD_RATIO_DIVIDER == 1000 to 1024 and then replace div

[jira] Commented: (STDCXX-226) __rw::__rw_new_capacity() uses floating point math

2007-11-16 Thread Martin Sebor (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543151 ] Martin Sebor commented on STDCXX-226: - I'm concerned about the performance implications of replacing a single flo

[jira] Commented: (STDCXX-226) __rw::__rw_new_capacity() uses floating point math

2007-11-16 Thread Farid Zaripov (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543070 ] Farid Zaripov commented on STDCXX-226: -- I'm just thinking why the grow algorithm in basic_stringbuf<>::_C_grow i

[jira] Commented: (STDCXX-226) __rw::__rw_new_capacity() uses floating point math

2007-11-15 Thread Travis Vitek (JIRA)
[ https://issues.apache.org/jira/browse/STDCXX-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542908 ] Travis Vitek commented on STDCXX-226: - I noticed that basic_stringbuf<>::_C_grow was changed, but it sill uses f