[
https://issues.apache.org/jira/browse/STDCXX-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Sebor updated STDCXX-636:
Summary: 23.deque.special test fails assertions (was: 23.deque.special
test fails)
23
:40 AM
To: stdcxx-dev@incubator.apache.org
Subject: Re: 23.deque.special
Farid Zaripov wrote:
Below is a part of the 23.deque.special test. These rw_assert's
fails because of deque::end() internal representation is
dependent on
object and cannot be swapped.
I'm not sure I understand
-Original Message-
From: Martin Sebor [mailto:[EMAIL PROTECTED] On Behalf Of Martin Sebor
Sent: Monday, July 09, 2007 7:40 AM
To: stdcxx-dev@incubator.apache.org
Subject: Re: 23.deque.special
Farid Zaripov wrote:
Below is a part of the 23.deque.special test. These rw_assert's
Farid Zaripov wrote:
-Original Message-
From: Martin Sebor [mailto:[EMAIL PROTECTED] On Behalf Of Martin Sebor
Sent: Monday, July 09, 2007 7:40 AM
To: stdcxx-dev@incubator.apache.org
Subject: Re: 23.deque.special
Farid Zaripov wrote:
Below is a part of the 23.deque.special test
-Original Message-
From: Martin Sebor [mailto:[EMAIL PROTECTED]
Sent: Monday, July 09, 2007 8:05 PM
To: stdcxx-dev@incubator.apache.org
Subject: Re: 23.deque.special
Right, I think that will be necessary. I was under the
impression that you already did that in the change below
Farid Zaripov wrote:
[...]
Are you suggesting to loosen the test so as not to exercise this
requirement?
I suggest only not to exercise iterators if one deque is empty.
But that would only hide the bug. swapping empty deques needs
to work (and not invalidate iterators) just as well as
-Original Message-
From: Martin Sebor [mailto:[EMAIL PROTECTED]
Sent: Monday, July 09, 2007 10:05 PM
To: stdcxx-dev@incubator.apache.org
Subject: Re: 23.deque.special
But in current implementation iterator not invalidated. Yes, it's
mebmers has changed, but it's still valid
Farid Zaripov wrote:
Below is a part of the 23.deque.special test. These rw_assert's
fails because of deque::end() internal representation is dependent
on object and cannot be swapped.
I'm not sure I understand. Swapping two deques is required not to
invalidate any iterators, isn't
Below is a part of the 23.deque.special test. These rw_assert's
fails because of deque::end() internal representation is dependent
on object and cannot be swapped.
I think that this part should be replaced to just checking
deque.begin() == deque.end() after (and perhaps, before) the swap
