Re: [Stellarium-pubdevel] Dynamic loading/unloading of modules

2012-02-14 Thread Matthew Gates
Thanks for the clarification Bogdan, and the reminder about the help page - we'll need to implement a mechanism to remove plugin help info from the help dialog. On 14 February 2012 09:36, Bogdan Marinov wrote: > On Tue, Feb 14, 2012 at 1:17 PM, Matthew Gates wrote: >> Do we need to un-register k

[Stellarium-pubdevel] CMAKE_BUILD_TYPE default setting -> Debug

2012-02-14 Thread Matthew Gates
Hi all, I've noticed a few times that we get commits into trunk with asserts which trigger and terminate the program - ones which trigger frequently enough that I can only imagine that the committer is not using the cmake option -DCMAKE_BUILD_TYPE=Debug. A question from frna in the IRC reminded m

Re: [Stellarium-pubdevel] Dynamic loading/unloading of modules

2012-02-14 Thread Bogdan Marinov
On Tue, Feb 14, 2012 at 1:17 PM, Matthew Gates wrote: > Do we need to un-register keyboard commands which have been registered > with StelGui::addGuiActions(...)?  What will happen if we don't > un-register them? If there are signals still connected to them, they may get called, with varying resu

Re: [Stellarium-pubdevel] Safe mode - what happened

2012-02-14 Thread Bogdan Marinov
On Tue, Feb 14, 2012 at 12:55 AM, Matthew Gates wrote: > Hi, > > Just saw a commit from treaves about the safe mode being "moved to the > windows #define, where it is used".  What happened with safe mode.  I > had noticed that a release or two after it was originally implemented, > it has effectiv

Re: [Stellarium-pubdevel] Dynamic loading/unloading of modules

2012-02-14 Thread Alexander Wolf
2012/2/14 Matthew Gates : > Do we need to un-register keyboard commands which have been registered > with StelGui::addGuiActions(...)?  What will happen if we don't > un-register them? I think we will get strange work, maybe crash -- With best regards, Alexander

Re: [Stellarium-pubdevel] Dynamic loading/unloading of modules

2012-02-14 Thread Matthew Gates
Do we need to un-register keyboard commands which have been registered with StelGui::addGuiActions(...)? What will happen if we don't un-register them? On 11 February 2012 09:07, Bogdan Marinov wrote: > On Thu, Feb 9, 2012 at 1:31 PM, Alexander Wolf wrote: >> 2012/2/9 Bogdan Marinov : >>> Bernh