Re: [PATCH] xtensa: always retrieve all syscall arguments

2013-05-06 Thread Mike Frysinger
On Monday 06 May 2013 21:49:22 Mike Frysinger wrote: > On Monday 06 May 2013 19:49:01 Chris Zankel wrote: > > Now, readahead, and possibly all other syscalls that take 64-bit > > arguments are handled by specific functions, so the problem doesn't > > really exist in those cases. However, looking at

Re: [PATCH] xtensa: always retrieve all syscall arguments

2013-05-06 Thread Dmitry V. Levin
On Mon, May 06, 2013 at 09:49:22PM -0400, Mike Frysinger wrote: > i think you do point out though that the value is wrong for 64bit arches -- > it > should be 3: > syscall(__NR_readahead, > 1 /* arg1: fd */, > 0 /* arg2: off */, > 0 /* arg3: count*/

Re: [PATCH] xtensa: always retrieve all syscall arguments

2013-05-06 Thread Mike Frysinger
On Monday 06 May 2013 19:49:01 Chris Zankel wrote: > As you said, the n-args field in syscallent serves two purposes. In the > case of readahead (int fd, off64_t offset, size_t count), for example, > these two numbers would differ: > > The syscall arguments are in a6 (fd), a3 (skipped), a4/a5 (of

Re: [PATCH] xtensa: always retrieve all syscall arguments

2013-05-06 Thread Chris Zankel
Hi Dimitry, On 05/06/2013 04:15 PM, Dmitry V. Levin wrote: > On Mon, May 06, 2013 at 03:17:55PM -0700, Chris Zankel wrote: >> The number of arguments specified in syscallent.h does not include >> registers that are skipped to align 64-bit arguments to even/odd >> register pairs. So, always retriev

Re: [PATCH] xtensa: disable socket and ipc subcall support

2013-05-06 Thread Dmitry V. Levin
On Mon, May 06, 2013 at 03:21:38PM -0700, Chris Zankel wrote: > The Xtensa architecture also used dedicated syscalls and doesn't > need to multiplex ipc and socket subcalls. Applied, thanks. -- ldv pgplqmQvZ8pHu.pgp Description: PGP signature --

[PATCH] xtensa: disable socket and ipc subcall support

2013-05-06 Thread Chris Zankel
The Xtensa architecture also used dedicated syscalls and doesn't need to multiplex ipc and socket subcalls. * linux/syscall.h: Do not define SYS_socket_subcall and SYS_ipc_subcall for xtensa. Signed-off-by: Chris Zankel --- linux/syscall.h |3 ++- 1 file changed, 2 insertions(+), 1 deleti

Re: [PATCH] xtensa: always retrieve all syscall arguments

2013-05-06 Thread Dmitry V. Levin
On Mon, May 06, 2013 at 03:17:55PM -0700, Chris Zankel wrote: > The number of arguments specified in syscallent.h does not include > registers that are skipped to align 64-bit arguments to even/odd > register pairs. So, always retrieve all registers used for arguments. The number of arguments spec

[PATCH] xtensa: always retrieve all syscall arguments

2013-05-06 Thread Chris Zankel
The number of arguments specified in syscallent.h does not include registers that are skipped to align 64-bit arguments to even/odd register pairs. So, always retrieve all registers used for arguments. * syscall.c (get_syscall_args): always retrieve all syscall arguments Signed-off-by: Chris Zank

Re: Upcoming release in May

2013-05-06 Thread Chris Zankel
Hi, Tested 6b03c9b5ced3d4f0d641443a73bd34ba481dbd1a for Xtensa. Builds fine and runs some simple tests. However I found a couple of issues and have sent patches to this list. * We didn't retrieve enough registers from the kernel when we skip registers to align 64-bit arguments to even/odd register

Re: [PATCH v2] tests/stat: support fstatat syscall for stat()

2013-05-06 Thread Dmitry V. Levin
On Mon, May 06, 2013 at 11:21:13AM -0400, Chris Metcalf wrote: > Newer Linux architectures don't support the stat/stat64 syscalls. > Instead they use fstatat() with AT_FDCWD and an extra flags argument. > Support seeing this output in the 'strace -efile' test. > > As part of this change, use "grep

Re: [PATCH] tile: disable socket and ipc subcall support

2013-05-06 Thread Dmitry V. Levin
On Mon, May 06, 2013 at 11:41:29AM -0400, Chris Metcalf wrote: > The tile arch just has the dedicated syscalls, so disable > the logic for parsing subcalls. Added a changelog entry and applied. Thanks, -- ldv pgpqt_iKVQKGf.pgp Description: PGP signature --

Re: [PATCH] disable socketcall for Blackfin targets

2013-05-06 Thread Dmitry V. Levin
On Mon, May 06, 2013 at 01:49:41AM -0400, Mike Frysinger wrote: > The Blackfin arch does not have a socketcall (it has dedicated syscalls > broken out), so disable the logic for it. > > * linux/syscall.h: Do not define SYS_socket_subcall for BFIN targets. OK, you should know better. :) The change

Re: [PATCH] printllval: fix 64bit unpacking on mips/o32 and xtensa

2013-05-06 Thread Dmitry V. Levin
On Sun, May 05, 2013 at 10:31:15PM -0400, Mike Frysinger wrote: > On Sunday 05 May 2013 19:38:01 Dmitry V. Levin wrote: > > On Sun, May 05, 2013 at 06:30:21PM -0400, Mike Frysinger wrote: > > > While ARM's EABI does aligning of 64bit values when making syscalls, its > > > OABI does not. Note that

[PATCH v2] tests/stat: support fstatat syscall for stat()

2013-05-06 Thread Chris Metcalf
Newer Linux architectures don't support the stat/stat64 syscalls. Instead they use fstatat() with AT_FDCWD and an extra flags argument. Support seeing this output in the 'strace -efile' test. As part of this change, use "grep -E -x" syntax consistently for all stat tests, since the number of \(foo

Re: [PATCH] tests/stat: support fstatat syscall for stat()

2013-05-06 Thread Chris Metcalf
On 5/6/2013 12:10 PM, Mike Frysinger wrote: > On Monday 06 May 2013 11:21:13 Chris Metcalf wrote: >> -LC_ALL=C grep -x 'stat\(64\)\?("sample", {st_mode=S_IFREG|0644, >> st_size=4611840, \.\.\.}) \+= 0' check.log > /dev/null || >> +LC_ALL=C grep -x 'f\?stat\(at\)\?\(64\)\?(\(AT_FDCWD, \)\?"samp

Re: [PATCH] tests/stat: support fstatat syscall for stat()

2013-05-06 Thread Mike Frysinger
On Monday 06 May 2013 11:21:13 Chris Metcalf wrote: > -LC_ALL=C grep -x 'stat\(64\)\?("sample", {st_mode=S_IFREG|0644, > st_size=4611840, \.\.\.}) \+= 0' check.log > /dev/null || > +LC_ALL=C grep -x 'f\?stat\(at\)\?\(64\)\?(\(AT_FDCWD, \)\?"sample", > {st_mode=S_IFREG|0644, st_size=461184

[PATCH] tile: disable socket and ipc subcall support

2013-05-06 Thread Chris Metcalf
The tile arch just has the dedicated syscalls, so disable the logic for parsing subcalls. Signed-off-by: Chris Metcalf --- linux/syscall.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux/syscall.h b/linux/syscall.h index 6368cef..1a36732 100644 --- a/linux/syscall.

[PATCH] tests/stat: support fstatat syscall for stat()

2013-05-06 Thread Chris Metcalf
Newer Linux architectures don't support the stat/stat64 syscalls. Instead they use fstatat() with AT_FDCWD and an extra flags argument. Support seeing this output in the 'strace -efile' test. Signed-off-by: Chris Metcalf --- Note that the two strace -efiles tests ("find" and "find -L") actually p