Re: Q: statfs related syscalls (was: Re: GSOC: Introduction)

2017-03-17 Thread Abhishek Tiwari
On Thu, Mar 16, 2017 at 11:33 PM, Abhishek Tiwari wrote: > On Thu, Mar 16, 2017 at 5:54 AM, Dmitry V. Levin wrote: >> On Wed, Mar 15, 2017 at 11:14:29PM +0530, Abhishek Tiwari wrote: >> [...] >>> Is it fine to group statfs+ statfs64+ fstatfs + fstatfs64 + ustat as >>> %statfs or it should be (st

Re: GSoC: Introduction

2017-03-17 Thread Dmitry V. Levin
On Fri, Mar 17, 2017 at 08:36:45PM +0100, Israel vianney wrote: [...] > Please I 've gone through the tests and test folder in the source code > trying to understand the used format, I also checked on codecov what is > left to be done as for the testing, then noticed some files with 100% miss > but

Re: [PATCH v3] Implemented -e trace=%clock option

2017-03-17 Thread Dmitry V. Levin
On Thu, Mar 16, 2017 at 04:41:22PM +0530, Rishi Bhatt wrote: [...] > diff --git a/sysent.h b/sysent.h > index f4eaa930..7e95ab3a 100644 > --- a/sysent.h > +++ b/sysent.h > @@ -22,5 +22,5 @@ typedef struct sysent { > #define TRACE_INDIRECT_SUBCALL 02000 /* Syscall is an indirect > socket/i

Re: [PATCH v7] Implement decoding of statx syscall

2017-03-17 Thread Dmitry V. Levin
On Fri, Mar 17, 2017 at 10:58:35PM +0300, Victor Krapivensky wrote: > * linux/i386/syscallent.h [383]: Add statx entry. > * linux/x32/syscallent.h [332]: Likewise. > * linux/x86_64/syscallent.h [332]: Likewise. > * pathtrace.c (pathtrace_match): Handle SEN_statx. > * statx.c: New file. > * statx.h:

Re: [PATCH v2] Implemented -e trace=%clock option for clock_* related syscalls

2017-03-17 Thread Rishi Bhatt
Is there any issue that i have to look in the patch that i have sent? On Thu, Mar 16, 2017 at 4:41 PM, Rishi Bhatt wrote: > > Patched the changes that you have mentioned. > On Thu, Mar 16, 2017 at 7:45 AM, Dmitry V. Levin wrote: > >> On Thu, Mar 16, 2017 at 12:17:08AM +0530, Rishi Bhatt wrote:

Re: GSOC: Introduction

2017-03-17 Thread Eugene Syromyatnikov
On Thu, Mar 16, 2017 at 10:07:27PM +0530, Abhishek Tiwari wrote: > From 38ea98c7ba87bc485d8af34fc401f46b05b2c035 Mon Sep 17 00:00:00 2001 > From: Abhishek Tiwari > Date: Thu, 16 Mar 2017 16:55:44 +0530 > Subject: [PATCH v4] Implement -e trace=%statfs option for tracing statfs like > syscalls. >

[PATCH v7] Implement decoding of statx syscall

2017-03-17 Thread Victor Krapivensky
* linux/i386/syscallent.h [383]: Add statx entry. * linux/x32/syscallent.h [332]: Likewise. * linux/x86_64/syscallent.h [332]: Likewise. * pathtrace.c (pathtrace_match): Handle SEN_statx. * statx.c: New file. * statx.h: Likewise. * Makefile.am (strace_SOURCES): Add them. * tests/.gitignore: Add sta

Re: GSoC: Introduction

2017-03-17 Thread Israel vianney
Hi On Mar 13, 2017 18:44, "Dmitry V. Levin" wrote: Hi, On Sun, Mar 12, 2017 at 06:55:44AM +0100, Israel vianney wrote: > Hi, > > I am Vianney Israel a second year undergraduate computer science student in > ISICOM University from Cameroon. I am new to open-source and i wish to > contribute to S

Re: [PATCH v6] Implement decoding of statx syscall

2017-03-17 Thread Eugene Syromyatnikov
On Fri, Mar 17, 2017 at 08:08:29PM +0300, Victor Krapivensky wrote: > * linux/i386/syscallent.h [383]: Add statx entry. > * linux/x32/syscallent.h [332]: Likewise. > * linux/x86_64/syscallent.h [332]: Likewise. > * pathtrace.c (pathtrace_match): Handle SEN_statx. > * statx.c: New file. > * statx.h:

Re: Gsoc Introduction.

2017-03-17 Thread Eugene Syromyatnikov
On Fri, Mar 17, 2017 at 06:35:09PM +0100, Eugene Syromyatnikov wrote: > Please format function declaration as following: > > int > nsfs_ioctl(struct tcb *tcp, unsigned int code, kernel_ulong_t arg) { Oops. Opening curly brace should be on the next line, like this: int nsfs_ioctl(struct tcb *tcp,

Re: Gsoc Introduction.

2017-03-17 Thread Eugene Syromyatnikov
On Fri, Mar 17, 2017 at 08:12:02AM +0700, Nikolay Marchuk wrote: > Thank you for review. I have rewritten my code, but I still have some > problems with NS_GET_NSTYPE parsing without additional argument. And new > tests are not fully tested, because I haven't build kernel yet. Please send patches

[PATCH v6] Implement decoding of statx syscall

2017-03-17 Thread Victor Krapivensky
* linux/i386/syscallent.h [383]: Add statx entry. * linux/x32/syscallent.h [332]: Likewise. * linux/x86_64/syscallent.h [332]: Likewise. * pathtrace.c (pathtrace_match): Handle SEN_statx. * statx.c: New file. * statx.h: Likewise. * Makefile.am (strace_SOURCES): Add them. * tests/.gitignore: Add sta

Re: [PATCH v5] Implement decoding of statx syscall

2017-03-17 Thread Victor Krapivensky
On Thu, Mar 16, 2017 at 04:27:26AM +0300, Dmitry V. Levin wrote: > This blank line at the end has caused this "git am" response: > > Applying: Implement decoding of statx syscall > .git/rebase-apply/patch:385: new blank line at EOF. > + > fatal: 1 line adds whitespace errors. > Patch failed at 000