Please review patch for bug in previous reply.
On Sun, Mar 19, 2017 at 6:11 AM, Dmitry V. Levin wrote:
> On Sat, Mar 18, 2017 at 08:29:46PM +0530, Abhishek Tiwari wrote:
> [...]
>> +done << EOF
>> +17 statfs
>
> Please add a test for statfs64 here as well.
Sir,
the statfs64.test file calls the
>> git grep -Fl 'statfs' linux/*/syscallent* | xargs sed -i
>> 's/0\(,[[:space:]]*SEN(osf_statfs\)/TSF\1/'
>> git grep -Fl 'statfs' linux/*/syscallent* | xargs sed -i
>> 's/0\(,[[:space:]]*SEN(.*_statfs\)/TSF\1/'
>> git grep -Fl 'statvfs' linux/*/syscallent* | xargs sed -i
>> '
Hello strace-developers:
My name is JingPiao Chen. I'am a Computer Science sophomore from
Guangdong Pharmaceutical University. I am interested in Netlink socket
parsers suggested by Gabriel Laskar and Dmitry V. Levin. I am familiar
with C, git, shell script, and gdb.
My current work base on the co
well so i have changed clock.tests's comment style.Below is the patch.Also
i have changed the version to what you have set in subject.
On Sun, Mar 19, 2017 at 7:37 AM, Rishi Bhatt
wrote:
>
>
> On Sun, Mar 19, 2017 at 6:34 AM, Dmitry V. Levin wrote:
>
>> On Sat, Mar 18, 2017 at 07:35:49PM +0530,
On Sun, Mar 19, 2017 at 6:34 AM, Dmitry V. Levin wrote:
> On Sat, Mar 18, 2017 at 07:35:49PM +0530, Rishi Bhatt wrote:
> > Hey if i am taking rt_sigretrun,nanosleep as negative testcases i am
> > getting sigusr and sigalarm respectively, i should not get them right?
> > Also sched.test is also fa
On Sat, Mar 18, 2017 at 07:35:49PM +0530, Rishi Bhatt wrote:
> Hey if i am taking rt_sigretrun,nanosleep as negative testcases i am
> getting sigusr and sigalarm respectively, i should not get them right?
> Also sched.test is also failing for them. Well i have included fstat and
> open as negatives
On Sat, Mar 18, 2017 at 08:29:46PM +0530, Abhishek Tiwari wrote:
> This commit adds %statsfs option to trace statfs, statfs64, statvfs,
> statvfs64 syscalls. The following commands update linux/*/syscallent* files:
This line is too long. The limit is 72 symbols, please wrap.
> git grep -F
On Sat, Mar 18, 2017 at 06:19:07PM +0300, Victor Krapivensky wrote:
> * linux/i386/syscallent.h [383]: Add statx entry.
> * linux/x32/syscallent.h [332]: Likewise.
> * linux/x86_64/syscallent.h [332]: Likewise.
> * pathtrace.c (pathtrace_match): Handle SEN_statx.
> * statx.c: New file.
> * statx.h:
On Sat, Mar 18, 2017 at 05:36:27PM +0300, Victor Krapivensky wrote:
> On Sat, Mar 18, 2017 at 10:44:09AM +0100, Eugene Syromyatnikov wrote:
[...]
> > Only one branch in regards of of stx.field.nsec value is covered in all
> > instances of this macro.
>
> Yes. This seems to be a property of a files
On Sat, Mar 18, 2017 at 07:47:46PM +0700, Nikolay Marchuk wrote:
git am applies this mail as a single commit, it this behaviour intended?
It also (still) does not contain a summary of changes, as I noted
yesterday.
The compilation warnings and dubious rc check noted in the previous e-mail are
st
Hi,
Well i am currently understanding how to implement a parser,so i am
starting with the simple ones first i.e umask.c,readahead.c,mount.c.
What i know about the implementation of parser:
What we do in these are use the tcb struct(u_arg[]) to get the values that
are passed in as arguments,i am no
* linux/i386/syscallent.h [383]: Add statx entry.
* linux/x32/syscallent.h [332]: Likewise.
* linux/x86_64/syscallent.h [332]: Likewise.
* pathtrace.c (pathtrace_match): Handle SEN_statx.
* statx.c: New file.
* statx.h: Likewise.
* Makefile.am (strace_SOURCES): Add them.
* tests/.gitignore: Add sta
Oops. Just realized that ~STATX_ALL and ~STATX_NLINK produce
platform-dependent values. Please ignore v8 and review v9 instead.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashd
* linux/i386/syscallent.h [383]: Add statx entry.
* linux/x32/syscallent.h [332]: Likewise.
* linux/x86_64/syscallent.h [332]: Likewise.
* pathtrace.c (pathtrace_match): Handle SEN_statx.
* statx.c: New file.
* statx.h: Likewise.
* Makefile.am (strace_SOURCES): Add them.
* tests/.gitignore: Add sta
>> Below is attached a patch corresonding to -e trace=%statfs option.
>> Please review.
>
> git am patch fails to apply this patch with the following diagnostics:
>
> .git/rebase-apply/patch:778: trailing whitespace.
> 17 statfs
> fatal: 1 line adds whitespace errors.
>
fixed. Patch attached.
>
>
On Sat, Mar 18, 2017 at 10:44:09AM +0100, Eugene Syromyatnikov wrote:
> I haven't look at v7 of the patch yet, but coverage [1] shows that at least
> this line is not covered by the test.
The version of the patch you run coverage on is very old (it still has
reserved2 field of struct_statx of size
Hey if i am taking rt_sigretrun,nanosleep as negative testcases i am
getting sigusr and sigalarm respectively, i should not get them right?
Also sched.test is also failing for them. Well i have included fstat and
open as negatives.
The way these test is made which expect the last output to be
'+++
On Sat, Mar 18, 2017 at 05:57:39PM +0530, Abhishek Tiwari wrote:
> On Sat, Mar 18, 2017 at 3:53 PM, Eugene Syromyatnikov
> wrote:
>
> > So, after some thinking, I have the following scheme in mind:
> >
> > {old,}stat{,64} TRACE_STAT TST
> %stat
>
> > {old,}lstat{,64}
Sir,
I have gone through mailing list to understand what has been
implemented in netlink socket parser.
>From what I understand, the netlink packet decoding has been done.
I have done socket programming and am known to the system calls that
server or client makes. However I'm having trouble unders
---
linux/32/ioctls_inc_align16.h | 2 ++
linux/32/ioctls_inc_align32.h | 2 ++
linux/32/ioctls_inc_align64.h | 2 ++
linux/64/ioctls_inc.h | 2 ++
linux/x32/ioctls_inc0.h | 2 ++
5 files changed, 10 insertions(+)
diff --git a/linux/32/ioctls_inc_align16.h b/linux/32/ioctls_inc_alig
Please avoid using mail clients which break formatting. This patch does
not apply.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Sorry, sent wrong commit.
>From 6618b4fdc99e07e09fd8d8049a347f0153c85ab5 Mon Sep 17 00:00:00 2001
From: Nikolay Marchuk
Date: Thu, 16 Mar 2017 17:49:25 +0700
Subject: [PATCH 1/2] Add ioctl namespace entries from Linux 4.11
---
linux/32/ioctls_inc_align16.h | 2 ++
linux/32/ioctls_inc_align32.h |
On Sat, Mar 18, 2017 at 3:53 PM, Eugene Syromyatnikov wrote:
> So, after some thinking, I have the following scheme in mind:
>
> {old,}stat{,64} TRACE_STAT TST
%stat
> {old,}lstat{,64}TRACE_LSTAT TLST
%lstat
> {old,new,}fstat{,at}64 TRACE_FSTAT
This patch does not apply with the following diagnostics:
fatal: corrupt patch at line 15
error: could not build fake ancestor
Patch failed at 0001 Add ioctl namespace entries from Linux 4.11
then,
error: patch failed: Makefile.am:172
error: Makefile.am: patch does not apply
error: patch failed:
On Sat, Mar 18, 2017 at 01:10:33PM +0300, Victor Krapivensky wrote:
> On Sat, Mar 18, 2017 at 04:00:50AM +0300, Dmitry V. Levin wrote:
> > I suggest placing AT_STATX_SYNC_TYPE before AT_STATX_FORCE_SYNC
> > so we could use printflags.
>
> I don't see any sense in that:
> AT_STATX_{SYNC_AS_STAT,FOR
On Sat, Mar 18, 2017 at 02:49:48PM +0530, Abhishek Tiwari wrote:
> Going with the above description for narrow statfs->
>
> Is naming %statfs = statfs+statfs64 as TRACE_NSTATFS and shorthand as TNS
> fine ?
So, after some thinking, I have the following scheme in mind:
{old,}stat{,64} TR
On Sat, Mar 18, 2017 at 04:00:50AM +0300, Dmitry V. Levin wrote:
> I suggest placing AT_STATX_SYNC_TYPE before AT_STATX_FORCE_SYNC
> so we could use printflags.
I don't see any sense in that:
AT_STATX_{SYNC_AS_STAT,FORCE_SYNC,DONT_SYNC} are mutually exclusive, and
statx called with flags=AT_STATX_
On Fri, Mar 17, 2017 at 08:08:29PM +0300, Victor Krapivensky wrote:
<...>
> --- /dev/null
> +++ b/statx.c
> @@ -0,0 +1,111 @@
> +/*
> + * Copyright (c) 2017 The strace developers.
> + * All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modific
On Sat, Mar 18, 2017 at 2:09 PM, Eugene Syromyatnikov wrote:
> On Thu, Mar 16, 2017 at 12:24 AM, Dmitry V. Levin wrote:
>> On Wed, Mar 15, 2017 at 11:14:29PM +0530, Abhishek Tiwari wrote:
>> [...]
>>> Is it fine to group statfs+ statfs64+ fstatfs + fstatfs64 + ustat as
>>> %statfs or it should b
>From 33d0341f2705e067b7617a6ec30e442d707714d0 Mon Sep 17 00:00:00 2001
From: Nikolay Marchuk
Date: Thu, 16 Mar 2017 17:49:25 +0700
Subject: [PATCH 1/2] Add ioctl namespace entries from Linux 4.11
---
linux/32/ioctls_inc_align16.h | 2 ++
linux/32/ioctls_inc_align32.h | 2 ++
linux/32/ioctls_inc
On Thu, Mar 16, 2017 at 12:24 AM, Dmitry V. Levin wrote:
> On Wed, Mar 15, 2017 at 11:14:29PM +0530, Abhishek Tiwari wrote:
> [...]
>> Is it fine to group statfs+ statfs64+ fstatfs + fstatfs64 + ustat as
>> %statfs or it should be (statfs+statfs64 + ustat) and
>> (fstatfs+ftsatfs64) i.e. two diff
31 matches
Mail list logo
