Re: [PATCH] Print io_submit() offsets in decimal

2013-03-30 Thread Dmitry V. Levin
On Sat, Mar 30, 2013 at 07:19:50PM -0500, Zev Weiss wrote: > On Mar 30, 2013, at 6:17 PM, Dmitry V. Levin wrote: > > On Fri, Mar 29, 2013 at 03:37:00PM -0500, Zev Weiss wrote: > >> Hello, > >> > >> Current strace prints the offset members of iocb structs passed to > >> io_submit() in hex, which I

Re: [PATCH] Print io_submit() offsets in decimal.

2013-03-30 Thread Zev Weiss
gt; Yes, let's change it to match the pread/pwrite output format. > Would you like to write a commit message? > Sure, hopefully the version below is formatted appropriately... Also, I noticed that the rest of the strace codebase uses %d for decimal integers, so I changed the patch to m

Re: [PATCH] Print io_submit() offsets in decimal.

2013-03-30 Thread Dmitry V. Levin
Hi, On Fri, Mar 29, 2013 at 03:37:00PM -0500, Zev Weiss wrote: > Hello, > > Current strace prints the offset members of iocb structs passed to > io_submit() in hex, which I can't see any particular reason for (it > mismatches the normal pread/pwrite format, for one thing), and the additional >

[PATCH] Print io_submit() offsets in decimal.

2013-03-29 Thread Zev Weiss
Hello, Current strace prints the offset members of iocb structs passed to io_submit() in hex, which I can't see any particular reason for (it mismatches the normal pread/pwrite format, for one thing), and the additional lack of a leading "0x" prefix makes it unnecessarily difficult to parse. C