Re: [PATCH v2 1/3] Add decoding for binder ioctls

2016-06-22 Thread Dmitry V. Levin
On Wed, Jun 22, 2016 at 03:41:19PM +0200, Gabriel Laskar wrote: [...] > Since android does not use the configure, but a separate Makefile with > all the values hardcoded, Does it? OMG. > does it makes sense to bother with it? Absolutely not. -- ldv pgp85B1IwC4Wc.pgp Description: PGP signat

Re: [PATCH v2 1/3] Add decoding for binder ioctls

2016-06-22 Thread Gabriel Laskar
On Wed, 22 Jun 2016 13:37:19 +0300 "Dmitry V. Levin" wrote: > On Wed, Jun 22, 2016 at 11:30:29AM +0200, Antoine Damhet wrote: > [...] > > > > + if (_IOC_SIZE(type) > 0) { > > > > + tprints("["); > > > > + printxval(x, type, str); > > > > +

Re: [PATCH v2 1/3] Add decoding for binder ioctls

2016-06-22 Thread Dmitry V. Levin
On Wed, Jun 22, 2016 at 11:30:29AM +0200, Antoine Damhet wrote: [...] > > > + if (_IOC_SIZE(type) > 0) { > > > + tprints("["); > > > + printxval(x, type, str); > > > + tprints(", "); > > > + if (pos + sizeof(type) + _IOC_SIZE(t

Re: [PATCH v2 1/3] Add decoding for binder ioctls

2016-06-22 Thread Antoine Damhet
Le Mon, 20 Jun 2016 15:07:52 +0300, "Dmitry V. Levin" a écrit : > On Sat, Jun 18, 2016 at 07:13:54PM +0200, Antoine Damhet wrote: > [...] > > +static int > > +decode_binder_commands_buffer(struct tcb *tcp, uintptr_t buffer, > > size_t pos, > > + size_t size, const struct xlat *x, const

Re: [PATCH v2 1/3] Add decoding for binder ioctls

2016-06-20 Thread Dmitry V. Levin
On Mon, Jun 20, 2016 at 03:07:52PM +0300, Dmitry V. Levin wrote: > On Sat, Jun 18, 2016 at 07:13:54PM +0200, Antoine Damhet wrote: [...] > > + if (_IOC_SIZE(type) > 0) { > > + tprints("["); > > + printxval(x, type, str); > > + tprints(

Re: [PATCH v2 1/3] Add decoding for binder ioctls

2016-06-20 Thread Dmitry V. Levin
On Sat, Jun 18, 2016 at 07:13:54PM +0200, Antoine Damhet wrote: [...] > +static int > +decode_binder_commands_buffer(struct tcb *tcp, uintptr_t buffer, size_t pos, > + size_t size, const struct xlat *x, const char *str) > +{ > + if (size < sizeof(uint32_t)) { > + tprints

[PATCH v2 1/3] Add decoding for binder ioctls

2016-06-18 Thread Antoine Damhet
This patch introduce decoding for binder ioctls including the command and return protocol from BINDER_WRITE_READ. * binder.c: New file. * xlat/binder_driver_commands.in: New file. * xlat/binder_driver_returns.in: New file. * Makefile.am (strace_SOURCES): Add binder.c. * ioctl.c (ioctl_decode): Cal