Re: GSoC 2017 Introduction: Netlink socket parsers

2017-04-18 Thread JingPiao Chen
On Mon, Apr 17, 2017 at 9:40 PM, Dmitry V. Levin wrote: >On Wed, Mar 29, 2017 at 05:39:59PM +0800, JingPiao Chen wrote: >> I updated the patch[1] and the proposal draft[2]. >> Please provide some feedback. >> [1]https://github.com/ppiao/strace/tree/nl-socket > >As I said, every logically separate c

Re: GSoC 2017 Introduction: Netlink socket parsers

2017-04-17 Thread Dmitry V. Levin
On Wed, Mar 29, 2017 at 05:39:59PM +0800, JingPiao Chen wrote: > I updated the patch[1] and the proposal draft[2]. > Please provide some feedback. > [1]https://github.com/ppiao/strace/tree/nl-socket As I said, every logically separate change must go to an individual commit, the way Fabien did in h

Re: GSoC 2017 Introduction: Netlink socket parsers

2017-03-29 Thread JingPiao Chen
I updated the patch[1] and the proposal draft[2]. Please provide some feedback. Thank you. [1]https://github.com/ppiao/strace/tree/nl-socket [2] https://docs.google.com/document/d/15cVdpdBP6jzEGP74tSG18ymi278_P2uv8MhRus-CuPI/edit?usp=sharing >On Tue, Mar 28, 2017 at 10:37 AM, Dmitry V. Levin wrot

Re: GSoC 2017 Introduction: Netlink socket parsers

2017-03-27 Thread JingPiao Chen
On Tue, Mar 28, 2017 at 10:37 AM, Dmitry V. Levin wrote: >On Mon, Mar 27, 2017 at 10:40:05PM +0800, JingPiao Chen wrote: >> 2017-03-27 6:16 GMT+08:00 Dmitry V. Levin wrote: >> >On Sun, Mar 19, 2017 at 12:25:11PM +0800, JingPiao Chen wrote: >> >> Hello strace-developers: >> >> My name is JingPiao C

Re: GSoC 2017 Introduction: Netlink socket parsers

2017-03-27 Thread Dmitry V. Levin
On Mon, Mar 27, 2017 at 10:40:05PM +0800, JingPiao Chen wrote: > 2017-03-27 6:16 GMT+08:00 Dmitry V. Levin wrote: > >On Sun, Mar 19, 2017 at 12:25:11PM +0800, JingPiao Chen wrote: > >> Hello strace-developers: > >> My name is JingPiao Chen. I'am a Computer Science sophomore from > >> Guangdong Pha

Re: GSoC 2017 Introduction: Netlink socket parsers

2017-03-27 Thread JingPiao Chen
>Hi, 2017-03-27 6:16 GMT+08:00 Dmitry V. Levin wrote: >On Sun, Mar 19, 2017 at 12:25:11PM +0800, JingPiao Chen wrote: >> Hello strace-developers: >> My name is JingPiao Chen. I'am a Computer Science sophomore from >> Guangdong Pharmaceutical University. I am interested in Netlink socket >> parsers

Re: GSoC 2017 Introduction: Netlink socket parsers

2017-03-26 Thread Dmitry V. Levin
Hi, On Sun, Mar 19, 2017 at 12:25:11PM +0800, JingPiao Chen wrote: > Hello strace-developers: > My name is JingPiao Chen. I'am a Computer Science sophomore from > Guangdong Pharmaceutical University. I am interested in Netlink socket > parsers suggested by Gabriel Laskar and Dmitry V. Levin. I am

Re: GSoC 2017 Introduction: Netlink socket parsers

2017-03-25 Thread JingPiao Chen
>Hello strace-developers: > My name is JingPiao Chen. I'am a Computer Science sophomore from >Guangdong Pharmaceutical University. I am interested in Netlink socket >parsers suggested by Gabriel Laskar and Dmitry V. Levin. I am familiar >with C, git, shell script, and gdb. > >My current work base o

GSoC 2017 Introduction: Netlink socket parsers

2017-03-18 Thread JingPiao Chen
Hello strace-developers: My name is JingPiao Chen. I'am a Computer Science sophomore from Guangdong Pharmaceutical University. I am interested in Netlink socket parsers suggested by Gabriel Laskar and Dmitry V. Levin. I am familiar with C, git, shell script, and gdb. My current work base on the co

Re: GSoC 2017 introduction

2017-03-12 Thread Eugene Syromyatnikov
On Sat, Mar 11, 2017 at 02:51:35PM +0300, Victor Krapivensky wrote: > Removed a trailing semicolon in a macro definition in tests/xstatx.c > and changed copyright holders of new files to "The strace developers". > > Please review this one. > > I've also found a possile buffer overflow bug in unwi

Re: GSoC 2017 introduction

2017-03-11 Thread Victor Krapivensky
Removed a trailing semicolon in a macro definition in tests/xstatx.c and changed copyright holders of new files to "The strace developers". Please review this one. I've also found a possile buffer overflow bug in unwind.c. Attaching a separate patch. On 03/10/2017 09:59 PM, Victor Krapivensky

Re: GSoC 2017 introduction

2017-03-10 Thread Victor Krapivensky
On 03/10/2017 04:36 AM, Dmitry V. Levin wrote: This cannot be correct. OK, removed it for now, and fixed all the issues you mentioned. I've also added a test, so please review. I've also stumbled upon a wrong comment in util.c. Attaching a separate patch for it. This is wrong, the type of n

Re: GSoC 2017 introduction

2017-03-09 Thread Dmitry V. Levin
On Fri, Mar 10, 2017 at 01:55:13AM +0300, Victor Krapivensky wrote: > From e8754de2791ddb6c79fd51a49c83582c9d9a01d7 Mon Sep 17 00:00:00 2001 > From: Victor Krapivensky > Date: Thu, 9 Mar 2017 20:26:14 +0300 > Subject: [PATCH v2] Add support for statx syscall I've given a very cursory look at this

Re: GSoC 2017 introduction

2017-03-09 Thread Victor Krapivensky
On 03/09/2017 10:24 PM, Eugene Syromyatnikov wrote: PS. Btw, by a quick look at the patch (haven't reviewed it yet), I can say that you at least forgot to wire up i386 arch [2], improperly indented SEN(statx) and most probably would have problems with struct statx name clash once glibc decided to

Re: GSoC 2017 introduction

2017-03-09 Thread Eugene Syromyatnikov
On Thu, Mar 9, 2017 at 5:44 PM, Victor Krapivensky wrote: > I would like to implement the parser for statx. Here is my current > attempt (no tests yet). > I've spotted the tests/statx.sh script. Unfortunately, due to that > tests/init.sh expects the caller name to end with ".test", it just > endle

Re: GSoC 2017 introduction

2017-03-09 Thread Victor Krapivensky
I would like to implement the parser for statx. Here is my current attempt (no tests yet). I've spotted the tests/statx.sh script. Unfortunately, due to that tests/init.sh expects the caller name to end with ".test", it just endlessly runs itself. What is it supposed to do? Also, how do I get sysc

Re: GSoC 2017 introduction

2017-03-06 Thread Dmitry V. Levin
Hi Victor, On Sun, Mar 05, 2017 at 06:31:31PM +0300, Victor Krapivensky wrote: > Hi everybody! My name is Victor Krapivensky and I am a first-year > student at MIPT. > > I want to implement Lua-scriptable advanced syscall tampering for > strace. > > I am quite fluent in C, have an interest in sy

GSoC 2017 introduction

2017-03-05 Thread Victor Krapivensky
Hi everybody! My name is Victor Krapivensky and I am a first-year student at MIPT. I want to implement Lua-scriptable advanced syscall tampering for strace. I am quite fluent in C, have an interest in system programming and debugging, and have good understanding of how Lua C API works. I have pr