Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-05-24 Thread haris iqbal
On Tue, May 24, 2016 at 4:14 PM, Dmitry V. Levin wrote: > On Fri, May 13, 2016 at 03:59:02PM +0530, haris iqbal wrote: >> On Fri, May 13, 2016 at 3:54 PM, Dmitry V. Levin wrote: >> > On Fri, May 13, 2016 at 03:48:27PM +0530, haris iqbal wrote: >> >> On Fri, May 13, 2016 at 3:39 PM, Dmitry V. Levin

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-05-24 Thread Dmitry V. Levin
On Fri, May 13, 2016 at 03:59:02PM +0530, haris iqbal wrote: > On Fri, May 13, 2016 at 3:54 PM, Dmitry V. Levin wrote: > > On Fri, May 13, 2016 at 03:48:27PM +0530, haris iqbal wrote: > >> On Fri, May 13, 2016 at 3:39 PM, Dmitry V. Levin wrote: > > [...] > >> > As this is a wiki markup, it seems na

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-05-13 Thread haris iqbal
On Fri, May 13, 2016 at 3:54 PM, Dmitry V. Levin wrote: > On Fri, May 13, 2016 at 03:48:27PM +0530, haris iqbal wrote: >> On Fri, May 13, 2016 at 3:39 PM, Dmitry V. Levin wrote: > [...] >> > As this is a wiki markup, it seems natural to create a page at >> > https://sourceforge.net/p/strace/wiki/.

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-05-13 Thread Dmitry V. Levin
On Fri, May 13, 2016 at 03:48:27PM +0530, haris iqbal wrote: > On Fri, May 13, 2016 at 3:39 PM, Dmitry V. Levin wrote: [...] > > As this is a wiki markup, it seems natural to create a page at > > https://sourceforge.net/p/strace/wiki/. Could you do it? > > Done. Thanks. Any ideas how to make ne

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-05-13 Thread haris iqbal
On Fri, May 13, 2016 at 3:39 PM, Dmitry V. Levin wrote: > On Thu, May 12, 2016 at 07:46:01PM +0530, haris iqbal wrote: >> On Sat, May 7, 2016 at 1:07 AM, haris iqbal wrote: >> > On Fri, May 6, 2016 at 8:35 PM, Fabien Siron wrote: >> >> Quoting haris iqbal (2016-05-05 06:24:03) >> >>> On Sun, May

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-05-13 Thread Dmitry V. Levin
On Thu, May 12, 2016 at 07:46:01PM +0530, haris iqbal wrote: > On Sat, May 7, 2016 at 1:07 AM, haris iqbal wrote: > > On Fri, May 6, 2016 at 8:35 PM, Fabien Siron wrote: > >> Quoting haris iqbal (2016-05-05 06:24:03) > >>> On Sun, May 1, 2016 at 1:43 AM, Fabien Siron > >>> wrote: > >>> > Hi, >

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-05-12 Thread haris iqbal
On Sat, May 7, 2016 at 1:07 AM, haris iqbal wrote: > On Fri, May 6, 2016 at 8:35 PM, Fabien Siron wrote: >> Quoting haris iqbal (2016-05-05 06:24:03) >>> On Sun, May 1, 2016 at 1:43 AM, Fabien Siron wrote: >>> > Hi, >>> > >>> > Quoting haris iqbal (2016-04-30 19:01:23) >>> >> Hi, >>> >> >>> >> S

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-05-06 Thread haris iqbal
On Fri, May 6, 2016 at 8:35 PM, Fabien Siron wrote: > Quoting haris iqbal (2016-05-05 06:24:03) >> On Sun, May 1, 2016 at 1:43 AM, Fabien Siron wrote: >> > Hi, >> > >> > Quoting haris iqbal (2016-04-30 19:01:23) >> >> Hi, >> >> >> >> So, this is my attempt at writing the wiki. Comments and sugges

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-05-06 Thread Fabien Siron
Quoting haris iqbal (2016-05-05 06:24:03) > On Sun, May 1, 2016 at 1:43 AM, Fabien Siron wrote: > > Hi, > > > > Quoting haris iqbal (2016-04-30 19:01:23) > >> Hi, > >> > >> So, this is my attempt at writing the wiki. Comments and suggestions are > >> welcome. > > > > It should be maybe interesting

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-05-04 Thread haris iqbal
On Sun, May 1, 2016 at 1:43 AM, Fabien Siron wrote: > Hi, > > Quoting haris iqbal (2016-04-30 19:01:23) >> Hi, >> >> So, this is my attempt at writing the wiki. Comments and suggestions are >> welcome. > > It should be maybe interesting to add the --reroll-count=X to format-patch > as it is very c

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-04-30 Thread Fabien Siron
Hi, Quoting haris iqbal (2016-04-30 19:01:23) > Hi, > > So, this is my attempt at writing the wiki. Comments and suggestions are > welcome. It should be maybe interesting to add the --reroll-count=X to format-patch as it is very convenient to do patch versions. Regards, -- Fabien Siron --

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-04-30 Thread haris iqbal
Hi, So, this is my attempt at writing the wiki. Comments and suggestions are welcome. On Fri, Apr 29, 2016 at 8:34 PM, Gabriel Laskar wrote: > Hi Haris, > > On Fri, 29 Apr 2016 18:59:14 +0530 > haris iqbal wrote: > > > I am in the process of writing the wiki page for "Guide for new > > contrib

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-04-29 Thread Gabriel Laskar
Hi Haris, On Fri, 29 Apr 2016 18:59:14 +0530 haris iqbal wrote: > I am in the process of writing the wiki page for "Guide for new > contributors" (sorry for the delay, I was busy with my academic > project). I just want to know where should I submit the wiki page? Good idea, thanks! I guess, o

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-04-29 Thread haris iqbal
Hi, I am in the process of writing the wiki page for "Guide for new contributors" (sorry for the delay, I was busy with my academic project). I just want to know where should I submit the wiki page? On Tue, Mar 15, 2016 at 6:50 PM, haris iqbal wrote: > On Tue, Mar 15, 2016 at 1:33 PM, Philippe

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-03-15 Thread haris iqbal
On Tue, Mar 15, 2016 at 1:33 PM, Philippe Ombredanne wrote: > On Tue, Mar 15, 2016 at 4:19 AM, haris iqbal wrote: >> On Tue, Mar 15, 2016 at 3:15 AM, Dmitry V. Levin wrote: > [...] >>> Don't you see that the patch you are sending out is corrupted? >> >> Are you talking about the date in the firs

We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-03-15 Thread Philippe Ombredanne
On Tue, Mar 15, 2016 at 4:19 AM, haris iqbal wrote: > On Tue, Mar 15, 2016 at 3:15 AM, Dmitry V. Levin wrote: [...] >> Don't you see that the patch you are sending out is corrupted? > > Are you talking about the date in the first line? Or is it something else? > >> Is it really so difficult to su

Re: Working on -e trace

2016-03-14 Thread haris iqbal
On Tue, Mar 15, 2016 at 8:49 AM, haris iqbal wrote: > On Tue, Mar 15, 2016 at 3:15 AM, Dmitry V. Levin wrote: >> On Mon, Mar 14, 2016 at 11:36:24AM +0530, haris iqbal wrote: >>> >From 97da320a96fed7731a5dd2de457696377a899fae Mon Sep 17 00:00:00 2001 >>> From: Md Haris Iqbal >>> Date: Mon, 14 Mar

Re: Working on -e trace

2016-03-14 Thread haris iqbal
On Tue, Mar 15, 2016 at 3:15 AM, Dmitry V. Levin wrote: > On Mon, Mar 14, 2016 at 11:36:24AM +0530, haris iqbal wrote: >> >From 97da320a96fed7731a5dd2de457696377a899fae Mon Sep 17 00:00:00 2001 >> From: Md Haris Iqbal >> Date: Mon, 14 Mar 2016 11:32:34 +0530 >> Subject: [PATCH] Added -e trace=sch

Re: Working on -e trace

2016-03-14 Thread Dmitry V. Levin
On Mon, Mar 14, 2016 at 11:36:24AM +0530, haris iqbal wrote: > >From 97da320a96fed7731a5dd2de457696377a899fae Mon Sep 17 00:00:00 2001 > From: Md Haris Iqbal > Date: Mon, 14 Mar 2016 11:32:34 +0530 > Subject: [PATCH] Added -e trace=scheduler option for tracing scheduler related > syscalls. > > -

Re: Working on -e trace

2016-03-13 Thread haris iqbal
>From 97da320a96fed7731a5dd2de457696377a899fae Mon Sep 17 00:00:00 2001 From: Md Haris Iqbal Date: Mon, 14 Mar 2016 11:32:34 +0530 Subject: [PATCH] Added -e trace=scheduler option for tracing scheduler related syscalls. --- NEWS | 1 + defs.h|

Re: Working on -e trace

2016-03-11 Thread Dmitry V. Levin
On Fri, Mar 11, 2016 at 11:52:39PM +0530, haris iqbal wrote: > On Fri, Mar 11, 2016 at 11:35 PM, Dmitry V. Levin wrote: > > On Fri, Mar 11, 2016 at 03:01:58PM +0530, haris iqbal wrote: > >> commit fd2267ac2607215da110663b2beb9bae97c98bed > >> Author: student > >> Date: Fri Mar 11 15:00:23 2016

Re: Working on -e trace

2016-03-11 Thread haris iqbal
On Fri, Mar 11, 2016 at 11:35 PM, Dmitry V. Levin wrote: > On Fri, Mar 11, 2016 at 03:01:58PM +0530, haris iqbal wrote: >> commit fd2267ac2607215da110663b2beb9bae97c98bed >> Author: student >> Date: Fri Mar 11 15:00:23 2016 +0530 >> >> Added -e trace=scheduler option for tracing scheduler r

Re: Working on -e trace

2016-03-11 Thread Dmitry V. Levin
On Fri, Mar 11, 2016 at 03:01:58PM +0530, haris iqbal wrote: > commit fd2267ac2607215da110663b2beb9bae97c98bed > Author: student > Date: Fri Mar 11 15:00:23 2016 +0530 > > Added -e trace=scheduler option for tracing scheduler related syscalls. Sorry but "git am" cannot apply this. Please r

Re: Working on -e trace

2016-03-11 Thread haris iqbal
commit fd2267ac2607215da110663b2beb9bae97c98bed Author: student Date: Fri Mar 11 15:00:23 2016 +0530 Added -e trace=scheduler option for tracing scheduler related syscalls. diff --git a/NEWS b/NEWS index 7779f65..2f59faa 100644 --- a/NEWS +++ b/NEWS @@ -12,6 +12,7 @@ Noteworthy changes in

Re: Working on -e trace

2016-03-10 Thread haris iqbal
On Fri, Mar 11, 2016 at 1:26 AM, Dmitry V. Levin wrote: > On Thu, Mar 10, 2016 at 11:42:24PM +0530, haris iqbal wrote: >> On Thu, Mar 10, 2016 at 5:24 AM, Dmitry V. Levin wrote: >> > On Wed, Mar 09, 2016 at 11:02:52AM +0530, haris iqbal wrote: >> > [...] >> >> Sorry for the multiple commits. My vi

Re: Working on -e trace

2016-03-10 Thread Dmitry V. Levin
On Thu, Mar 10, 2016 at 11:42:24PM +0530, haris iqbal wrote: > On Thu, Mar 10, 2016 at 5:24 AM, Dmitry V. Levin wrote: > > On Wed, Mar 09, 2016 at 11:02:52AM +0530, haris iqbal wrote: > > [...] > >> Sorry for the multiple commits. My vim is giving trouble. > > > > Please don't send incremental comm

Re: Working on -e trace

2016-03-10 Thread haris iqbal
On Thu, Mar 10, 2016 at 5:24 AM, Dmitry V. Levin wrote: > On Wed, Mar 09, 2016 at 11:02:52AM +0530, haris iqbal wrote: > [...] >> Sorry for the multiple commits. My vim is giving trouble. > > Please don't send incremental commits, just amend and send the one you > already have. I did not quite un

Re: Working on -e trace

2016-03-09 Thread Dmitry V. Levin
On Wed, Mar 09, 2016 at 11:02:52AM +0530, haris iqbal wrote: [...] > Sorry for the multiple commits. My vim is giving trouble. Please don't send incremental commits, just amend and send the one you already have. > >> @@ -264,8 +264,8 @@ > >> [271] = { 6,0,SEN(process_vm_writev), > >>

Re: Working on -e trace

2016-03-08 Thread haris iqbal
commit 6a059d82bc833cb5a221e4d4cf7d5bb09a94fe60 Author: student Date: Wed Mar 9 10:47:03 2016 +0530 Corrected indentation and change the sequence of new value inserted diff --git a/defs.h b/defs.h index 564075e..531fc9d 100644 --- a/defs.h +++ b/defs.h @@ -396,7 +396,7 @@ extern const stru

Re: Working on -e trace

2016-03-08 Thread Dmitry V. Levin
On Tue, Mar 08, 2016 at 10:05:15PM +0530, haris iqbal wrote: > On Tue, Mar 8, 2016 at 4:02 AM, Dmitry V. Levin wrote: > > On Mon, Mar 07, 2016 at 02:35:50PM +0530, haris iqbal wrote: > >> 2016-03-07 Md Haris Iqbal > >> > >> * defs.h > >> * + define TRACE_SCHED 04000 / Trace scheduler-related sysc

Re: Working on -e trace

2016-03-08 Thread haris iqbal
On Tue, Mar 8, 2016 at 4:02 AM, Dmitry V. Levin wrote: > On Mon, Mar 07, 2016 at 02:35:50PM +0530, haris iqbal wrote: >> 2016-03-07 Md Haris Iqbal >> >> * defs.h >> * + define TRACE_SCHED 04000 / Trace scheduler-related syscalls / >> >> * syscall.c (lookup_class) >> * +if (strcmp(s, "schedule

Re: Working on -e trace

2016-03-08 Thread Dmitry V. Levin
On Mon, Mar 07, 2016 at 02:35:50PM +0530, haris iqbal wrote: > 2016-03-07 Md Haris Iqbal > > * defs.h > * + define TRACE_SCHED 04000 / Trace scheduler-related syscalls / > > * syscall.c (lookup_class) > * +if (strcmp(s, "scheduler") == 0) > * +return TRACE_SCHED; > * + define TSC TRA

Re: Working on -e trace

2016-03-07 Thread haris iqbal
2016-03-07 Md Haris Iqbal * defs.h * + define TRACE_SCHED 04000 / Trace scheduler-related syscalls / * syscall.c (lookup_class) * +if (strcmp(s, "scheduler") == 0) * +return TRACE_SCHED; * + define TSC TRACE_SCHED * All syscallent.h files * added TSC flag Tested with -e trace=sched

Re: Working on -e trace

2016-03-02 Thread Dmitry V. Levin
On Wed, Mar 02, 2016 at 10:45:53AM +0530, haris iqbal wrote: [...] > A little help is needed here. I could understand that for the -e > option, one uses the combination of sysent_vec[][].sys_flags and the > macros TRACE_FILE and others, which sets the proper flag in qual_vec. > Now that qual_vec is

Re: Working on -e trace

2016-03-01 Thread haris iqbal
On Thu, Feb 18, 2016 at 2:51 PM, haris iqbal wrote: > On Thu, Feb 18, 2016 at 8:07 AM, Dmitry V. Levin wrote: >> On Wed, Feb 17, 2016 at 04:56:39PM +0530, haris iqbal wrote: >>> On Sun, Feb 14, 2016 at 5:54 AM, Dmitry V. Levin wrote: >>> > On Thu, Feb 11, 2016 at 09:04:56PM +0530, haris iqbal wro

Re: Working on -e trace

2016-02-18 Thread haris iqbal
On Thu, Feb 18, 2016 at 8:07 AM, Dmitry V. Levin wrote: > On Wed, Feb 17, 2016 at 04:56:39PM +0530, haris iqbal wrote: >> On Sun, Feb 14, 2016 at 5:54 AM, Dmitry V. Levin wrote: >> > On Thu, Feb 11, 2016 at 09:04:56PM +0530, haris iqbal wrote: > [...] >> >> Another thing. If I did not miss any ste

Re: Working on -e trace

2016-02-17 Thread Dmitry V. Levin
On Wed, Feb 17, 2016 at 04:56:39PM +0530, haris iqbal wrote: > On Sun, Feb 14, 2016 at 5:54 AM, Dmitry V. Levin wrote: > > On Thu, Feb 11, 2016 at 09:04:56PM +0530, haris iqbal wrote: [...] > >> Another thing. If I did not miss any step above then I can start thinking > >> about the new category to

Re: Working on -e trace

2016-02-17 Thread haris iqbal
On Sun, Feb 14, 2016 at 5:54 AM, Dmitry V. Levin wrote: > On Thu, Feb 11, 2016 at 09:04:56PM +0530, haris iqbal wrote: > [...] >> And the part of adding to syscallent.h file, I understood. But man >> there are too many files. ;) > > Right, but you can edit them all with a single sed script. ;) Tr

Re: Working on -e trace

2016-02-13 Thread Dmitry V. Levin
On Thu, Feb 11, 2016 at 09:04:56PM +0530, haris iqbal wrote: [...] > And the part of adding to syscallent.h file, I understood. But man > there are too many files. ;) Right, but you can edit them all with a single sed script. ;) > Another thing. If I did not miss any step above then I can start t

Re: Working on -e trace

2016-02-11 Thread haris iqbal
On Thu, Feb 11, 2016 at 4:11 PM, Gabriel Laskar wrote: > On Thu, 11 Feb 2016 10:47:22 +0530 > haris iqbal wrote: > >> Hello, >> >> I have understood a fair amount of working, how -e trace=option works. >> >> Through the init() --> qualify() >> >> for (p = strtok(copy, ","); p; p = strtok(NULL

Re: Working on -e trace

2016-02-11 Thread Gabriel Laskar
On Thu, 11 Feb 2016 10:47:22 +0530 haris iqbal wrote: > Hello, > > I have understood a fair amount of working, how -e trace=option works. > > Through the init() --> qualify() > > for (p = strtok(copy, ","); p; p = strtok(NULL, ",")) { > int n; > if (opt->bitflag == QUAL_TRA

Working on -e trace

2016-02-10 Thread haris iqbal
Hello, I have understood a fair amount of working, how -e trace=option works. Through the init() --> qualify() for (p = strtok(copy, ","); p; p = strtok(NULL, ",")) { int n; if (opt->bitflag == QUAL_TRACE && (n = lookup_class(p)) > 0) { unsigned pers;