Re: [PATCH v3] Add possibility for the user to print system calls available in the platform.

2016-08-09 Thread Dmitry V. Levin
On Wed, Aug 03, 2016 at 06:19:30PM +0200, Amin Khorsandi wrote: > --- > defs.h| 1 + > strace.1 | 7 +++ > syscall.c | 57 ++--- > 3 files changed, 62 insertions(+), 3 deletions(-) > > diff --git a/defs.h b/defs.h > index 4b7e8ed..a8e

Re: Getting my self introduced

2016-08-09 Thread Dmitry V. Levin
Hi, On Fri, Aug 05, 2016 at 04:23:29PM +0200, Ahmed Soliman wrote: > Hi there, > I am student from Egypt, I would like to contribute to Strace code base, I > just wanted to get familiar to the code base and the conventions here > first, I am good with C, and some assembly (basically x86 but all of

Re: [PATCH] Unify usage of include guards.

2016-08-09 Thread Dmitry V. Levin
On Sun, Aug 07, 2016 at 06:44:19AM +0300, Eugene Syromyatnikov wrote: > This commit is an attempt to unify usage of include guards (in top-level > headers, at least). I've applied it, as you might have noticed already. ;) -- ldv pgpE3rRCq9edl.pgp Description: PGP signature ---

Re: [PATCH 1/4] tests/mlock2.c: fix test failure on mips64

2016-08-10 Thread Dmitry V. Levin
On Wed, Aug 10, 2016 at 11:38:42AM +0100, James Cowgill wrote: > In tests/mlock2.c, the address argument for the mlock2 syscall is passed > through a vararg using the "syscall" function. On 64-bit systems, while the > input argument is treated as an unsigned int, the argument is read as a > void* (

Re: [PATCH 2/4] tests/xstatx.c: fix stat syscall tests on mips64

2016-08-10 Thread Dmitry V. Levin
On Wed, Aug 10, 2016 at 11:38:43AM +0100, James Cowgill wrote: > For historical reasons the kernel struct stat represents times as unsigned > 32-bit integers on mips64. Therefore, while it's possible to give a file a > timestamp before 1970 with futimens, reading the same timestamp through > struct

Re: [PATCH 3/4] tests/nsyscalls.test: only trace the "syscall" syscall on mips o32

2016-08-10 Thread Dmitry V. Levin
On Wed, Aug 10, 2016 at 11:38:44AM +0100, James Cowgill wrote: > The "syscall" syscall only exists on o32 and causes strace to error out on > 64-bit mips ABIs. Pass st_cv_mips_abi from the configure script through to > nsyscalls.test so the MIPS ABI can be checked. > > * configure.ac (st_cv_mips_a

Re: [PATCH 4/4] tests/fcntl.c: fix fcntl test on mips64

2016-08-10 Thread Dmitry V. Levin
On Wed, Aug 10, 2016 at 11:38:45AM +0100, James Cowgill wrote: > On mips64 the F_GETLK and F_SETLKW64 constants have identical values which > causes the "wrong" constant to be printed by strace. > > tests/fcntl.c (test_flock64): do not test F_SETLKW64 on mips64. > --- > tests/fcntl.c | 3 +++ > 1

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-08-10 Thread Dmitry V. Levin
On Wed, Aug 10, 2016 at 10:31:48PM +0200, Nahim El Atmani wrote: [...] > > > * Concerning the struct qual_options, the name 'fault' and short name 'f' > > > are > > > not fixed, feel free to comment if something better comes to your mind. > > > * Regarding the error number checks in qual_fault()

Re: [PATCH 4/4] tests/fcntl.c: fix fcntl test on mips64

2016-08-11 Thread Dmitry V. Levin
On Thu, Aug 11, 2016 at 10:41:13AM +0100, James Cowgill wrote: > On 11/08/16 03:33, Dmitry V. Levin wrote: > > On Wed, Aug 10, 2016 at 11:38:45AM +0100, James Cowgill wrote: > >> On mips64 the F_GETLK and F_SETLKW64 constants have identical values which > >> causes

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-08-11 Thread Dmitry V. Levin
On Thu, Aug 11, 2016 at 04:17:41PM +0200, Nahim El Atmani wrote: > On Thu, 11 Aug 2016 05:42:52 +0300, Dmitry V. Levin wrote: [...] > > > > > --- a/syscall.c > > > > > +++ b/syscall.c > > > > > @@ -266,6 +266,14 @@ enum { > > > > &

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-08-11 Thread Dmitry V. Levin
On Thu, Aug 11, 2016 at 04:40:31PM +0200, Nahim El Atmani wrote: [...] > > > The thing is this time I need a copy of the global sparse array by tcb. I > > > was > > > I don't see why one may need a sparse array by tcb. > > > There has to be a global sparse array that fully describes fault inject

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-08-11 Thread Dmitry V. Levin
On Thu, Aug 11, 2016 at 05:51:07PM +0200, Nahim El Atmani wrote: [...] > Ok, let's take a small example to see why neither letting the accounting > information in a global scope nor letting the flag as it in the tcp does work. > If we have two tracees, and we want to cancel the second write *each*

Re: [PATCH v2 0/3] Testsuite fixes for mips64

2016-08-11 Thread Dmitry V. Levin
On Thu, Aug 11, 2016 at 04:33:00PM +, James Cowgill wrote: > These patches fix most of the testsuite failures which happen on 64-bit mips > (n32 and n64). None of the failures were bugs in strace, but rather bugs in > the testsuite. > > An example of the failures can be seen here: > https://bu

Re: [PATCH v2 0/3] Testsuite fixes for mips64

2016-08-12 Thread Dmitry V. Levin
On Fri, Aug 12, 2016 at 11:02:14AM +0100, James Cowgill wrote: [...] > >> The only test which still seems to fail on my machine is the "pwritev" > >> test, > >> but I believe that's caused by a kernel bug (which I haven't tracked down > >> yet). > > > > Does this patch changes something with the

Re: Testings on multiple architectures

2016-08-16 Thread Dmitry V. Levin
On Fri, Aug 12, 2016 at 11:51:31PM +0800, Yun-Chih Chen wrote: > Here is a list of architectures, either listed in "debian/control" or > "linux/*", against which I've tested strace: > > * alpha: Tested on Debian Lenny, kernel:2.6, with old gcc+glibc, > failed to boot custom-compiled linux-kernel+b

Re: [PATCH] Build strace for RISC-V

2016-08-19 Thread Dmitry V. Levin
On Fri, Aug 19, 2016 at 10:19:13AM +0100, Richard W.M. Jones wrote: > The original port of strace was done by Palmer Dabbelt > (eecs.berkeley.edu), based on strace 4.9. > > I only modified it to work with upstream strace, and fixed a few > things. [...] > diff --git a/linux/riscv/ioctls_arch0.h b/

Re: [PATCH v2] Build strace for RISC-V

2016-08-19 Thread Dmitry V. Levin
On Fri, Aug 19, 2016 at 11:56:05AM +0100, Richard W.M. Jones wrote: > The original port of strace was done by Palmer Dabbelt > (eecs.berkeley.edu), based on strace 4.9. [...] > diff --git a/file.c b/file.c > index 2ff0ac7..24b10b1 100644 > --- a/file.c > +++ b/file.c > @@ -148,7 +148,7 @@ SYS_FUNC(

Re: [PATCH v3] Build strace for RISC-V

2016-08-19 Thread Dmitry V. Levin
On Fri, Aug 19, 2016 at 02:16:40PM +0100, Richard W.M. Jones wrote: > v2 -> v3: > > - Remove stat32 stuff. > > - Retest (only on 64 bit). Looks OK. Does it pass the test suite? -- ldv pgpAazpNF99yM.pgp Description: PGP signature ---

Re: [PATCH v3] Build strace for RISC-V

2016-08-22 Thread Dmitry V. Levin
On Fri, Aug 19, 2016 at 09:35:23PM +0100, Richard W.M. Jones wrote: > (Adding Palmer who wrote the original patch to CC) > > On Fri, Aug 19, 2016 at 05:05:32PM +0300, Dmitry V. Levin wrote: > > On Fri, Aug 19, 2016 at 02:16:40PM +0100, Richard W.M. Jones wrote:

Re: [PATCH] Move SH-specific argument number calculation to getllval

2016-08-22 Thread Dmitry V. Levin
On Sat, Aug 20, 2016 at 05:02:55PM +0300, Eugene Syromyatnikov wrote: > This change prevents scattering of ll-related hacks and simplifies > pread/pwrite > syscalls parsers' logic a bit. Thanks, merged to master. -- ldv pgpelXu1mWSGj.pgp Description: PGP signature ---

Re: [PATCH 0/2] Minor bug in timerfd_settime parser

2016-08-22 Thread Dmitry V. Levin
Hi, On Mon, Aug 22, 2016 at 11:47:02AM +0300, Eugene Syromyatnikov wrote: > Hello. > > I've stumbled upon a subtle bug in timerfd_settime parser - it retrieves > old_value argument on entering and not on exiting. Turns out it hasn't > been noticed by timerfd_xettime test since it fills old_value

Re: strace config test failures

2016-08-29 Thread Dmitry V. Levin
Hi, On Fri, Aug 26, 2016 at 01:31:55PM -0700, Vineet Gupta wrote: > Hi, > > I was trying to cross build strace tip for ARC which was failing in weird > ways - > running bootstrap cured it. > > However in the process - when starring at config.log I see a lot config test > failures (even when con

Re: [PATCH 1/8] Fix FUTEX_WAKE_OP compare function mask

2016-08-29 Thread Dmitry V. Levin
On Mon, Aug 29, 2016 at 06:10:44PM +0300, Eugene Syromyatnikov wrote: > * futex.c (SYS_FUNC(futex)) : compare function does not > have FUTEX_OP_OPARG_SHIFT flag and occupies 4 bits from bit 24 to bit > 27, as per both initial and current (v4.7) kernel implementations, so > bring futex parser

Re: [PATCH 2/8] futex: Add handling of FUTEX_FD command

2016-08-29 Thread Dmitry V. Levin
On Mon, Aug 29, 2016 at 06:11:31PM +0300, Eugene Syromyatnikov wrote: > Since FUTEX_FD is known (and most likely reserved for the future use), albeit > obsolete, it has some expected argument format, so it's probably wise to > employ it. > > * futex.c (SYS_FUNC(futex)): add handling of FUTEX_FD co

Re: [PATCH 3/8] futex: Some refinement to unknown command argument formatting

2016-08-29 Thread Dmitry V. Levin
On Mon, Aug 29, 2016 at 06:12:15PM +0300, Eugene Syromyatnikov wrote: > Several changes have been performed: > * alternate form is used for timeout value since it is pointer half >of the time. And half of the time it is not, which can be confusing >without number base prefix. > * uaddr is

Re: [PATCH 4/8] Add xlat values for FUTEX_WAIT commands with FUTEX_CLOCK_REALTIME bit set

2016-08-29 Thread Dmitry V. Levin
On Mon, Aug 29, 2016 at 06:12:55PM +0300, Eugene Syromyatnikov wrote: > The support for these has been added in commit g337f130, before Linux 4.5. commit g337f130? Is it a septendecimal number? > * xlat/futexops.in: add FUTEX_WAIT|FUTEX_CLOCK_REALTIME and > FUTEX_WAIT_PRIVATE|FUTEX_CLOCK_REALTI

Re: [PATCH 1/8] Fix FUTEX_WAKE_OP compare function mask

2016-08-29 Thread Dmitry V. Levin
On Mon, Aug 29, 2016 at 05:39:00PM +, Eugene Syromyatnikov wrote: > On Mon, Aug 29, 2016 at 5:21 PM, Dmitry V. Levin wrote: > > futex_atomic_op_inuser > Can you please refer to the specific file where it is used for cmp > operation? I've checked include/asm-generic/fu

Re: [PATCH 5/8] futex: Use alternate form for val3 presented in hex

2016-08-29 Thread Dmitry V. Levin
On Mon, Aug 29, 2016 at 06:13:36PM +0300, Eugene Syromyatnikov wrote: > In order to distinguish it from the cases where it is printed in > decimal. > > * futex.c (SYS_FUNC(futex)) : use > alternate form for the val3 argument. Sounds reasonable. -- ldv pgpLgjhMoyaBc.pgp Description: PGP sig

Re: [PATCH 7/8] futex: Avoid printing val when it is not used by the command

2016-08-29 Thread Dmitry V. Levin
On Mon, Aug 29, 2016 at 06:14:43PM +0300, Eugene Syromyatnikov wrote: > Analogous to timeout argument omitting in FUTEX_WAKE_BITSET command. > > * futex.c (SYS_FUNC(futex)): Remove common val argument print call, add > it into specific command cases (all except FUTEX_LOCK_PI, > FUTEX_UNLOCK_PI

Re: [PATCH 1/2] Use PTRACE_SUNDETACH everywhere on SPARC and SPARC64

2016-08-30 Thread Dmitry V. Levin
On Tue, Aug 30, 2016 at 12:50:33AM +0100, James Clarke wrote: > SPARC has a different PTRACE_DETACH value correctly defined in sys/ptrace.h, > but linux/ptrace.h clobbers it with the standard one. PTRACE_SUNDETACH is > also defined to the correct value by sys/ptrace.h, so use that instead. > > * p

Re: [PATCH] futex: Remove inclusion which is not used

2016-08-30 Thread Dmitry V. Levin
On Tue, Aug 30, 2016 at 04:24:37PM +0300, Eugene Syromyatnikov wrote: > configure script doesn't perform check for linux/futex.h presence, so > HAVE_LINUX_FUTEX_H is always undefined and inclusion of system header is > never performed. Moreover, this header had an incorrect definition of > FUTEX_WA

Re: [PATCH 2/2] Use the correct m32/mx32 st_mtime_nsec check in tests/xstatx.c

2016-08-30 Thread Dmitry V. Levin
On Tue, Aug 30, 2016 at 12:50:34AM +0100, James Clarke wrote: > * tests/Makefile.am: Define MPERS_IS_m(x)32 for mpers builds. > * tests/xstatx.c: Use the correct m32/mx32 and stat/stat64 macros when > checking if st_mtime_nsec exists. > --- > > Hi, > This fixes tests-m32 failures for the *stat.c (

Re: [PATCH v3] tests: Add test for the futex syscall

2016-08-31 Thread Dmitry V. Levin
On Wed, Aug 31, 2016 at 12:32:58AM +0300, Eugene Syromyatnikov wrote: > * tests/futex.c: New file. > * tests/futex.test: Likewise. > * tests/Makefile.am (check_PROGRAMS): Add futex. > (DECODER_TESTS): Add futex.test. > --- > Changes since v2: > * Commands not available on the old kernels (2.6.18

Re: [PATCH] Refactor common sa_handler printing code

2016-08-31 Thread Dmitry V. Levin
On Wed, Aug 31, 2016 at 07:04:21PM +0300, Eugene Syromyatnikov wrote: > * xlat/sa_handler_values.in: New file. > * signal.c: Include "xlat/sa_handler_values.h". > (get_sa_handler_str, print_sa_handler): New functions. > (SYS_FUNC(sigsetmask), SYS_FUNC(signal), decode_new_sigaction): Use them. > ---

Re: [PATCH] Makefile.am: use readlink as a fallback for realpath

2016-09-01 Thread Dmitry V. Levin
On Thu, Sep 01, 2016 at 02:47:34AM +0300, Eugene Syromyatnikov wrote: > Since realpath utility is fairly new in GNU coreutils, there could be > possibility that it is not present in the system. Instead of checking > its presence in configure script it probably makes sense to resort to > calling rea

Re: [PATCH 1/2] readahead: Fix print format for the "count" argument

2016-09-01 Thread Dmitry V. Levin
On Thu, Sep 01, 2016 at 02:42:48AM +0300, Eugene Syromyatnikov wrote: > It is size_t (according to documentation and syscalls.h), so "%lu" should > be used instead of "%ld". > > * readahead.c (SYS_FUNC(readahead)): fix conversion specifier for the > "count" argument. > --- > readahead.c |2

Re: [PATCH 2/2] tests: check decoding of readahead syscall

2016-09-01 Thread Dmitry V. Levin
On Thu, Sep 01, 2016 at 02:43:30AM +0300, Eugene Syromyatnikov wrote: > * tests/readahead.c: New file. > * tests/readahead.test: New test. > * tests/.gitignore: Add readahead. > * tests/Makefile.am (check_PROGRAMS): Likewise. > (DECODER_TESTS): Add readahead.test. > --- > Simple test for simple d

Re: [PATCH v2 0/5] tests: Refactor of retstr from futex.c into a library function and updated readahead test

2016-09-05 Thread Dmitry V. Levin
On Fri, Sep 02, 2016 at 06:24:55PM +0300, Eugene Syromyatnikov wrote: > Hello. > > Changes from v1: > * sprintrc now takes long as rc argument since syscalls return long. > * Changes in various rc values support as suggested by Dmitry. > > Eugene Syromyatnikov (5): > tests/futex: Rename retst

Re: [PATCH 1/9] tests: check decoding of perf_event_open syscall

2016-09-05 Thread Dmitry V. Levin
On Mon, Sep 05, 2016 at 04:31:03AM +0300, Eugene Syromyatnikov wrote: > * tests/perf_event_open.c: New file. > * tests/perf_event_open.test: New test. > * tests/.gitignore: Add perf_event_open. > * tests/Makefile.am (check_PROGRAMS): Likewise. > (DECODER_TESTS): Add perf_event_open.test. On rhel

Re: [PATCH 0/9] Minor decoder fixes and various tests amendments

2016-09-05 Thread Dmitry V. Levin
On Mon, Sep 05, 2016 at 04:30:45AM +0300, Eugene Syromyatnikov wrote: > Hello. > > This is quite inconsistent collection of patches for various decoder > test in attempt to make them more thorough. > > Eugene Syromyatnikov (9): > aio: Use printfd for fd printing > tests: Use sprintrc for retu

Re: [PATCH 4/7] tests: Additional shmget decoder checks

2016-09-08 Thread Dmitry V. Levin
On Tue, Sep 06, 2016 at 05:08:36AM +0300, Eugene Syromyatnikov wrote: > * tests/ipc_shm.c: Additional checks for shmget syscall decoding. > --- > tests/ipc_shm.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/tests/ipc_shm.c b/tests/ipc_shm.c > index 54723e2..80a

Re: [PATCH 1/2] tests: Additional IPC checks

2016-09-08 Thread Dmitry V. Levin
On Wed, Sep 07, 2016 at 03:41:01PM +0300, Eugene Syromyatnikov wrote: [...] > diff --git a/tests/ipc_shm.c b/tests/ipc_shm.c > index 80a8f0f..c2c1b26 100644 > --- a/tests/ipc_shm.c > +++ b/tests/ipc_shm.c > @@ -49,8 +49,11 @@ cleanup(void) > int > main(void) > { > - static const key_t bogus_

Re: [PATCH 1/2] tests: Additional IPC checks

2016-09-08 Thread Dmitry V. Levin
On Wed, Sep 07, 2016 at 03:41:01PM +0300, Eugene Syromyatnikov wrote: [...] > + assert(semctl(0xfdb97531, 0xeca86420, 0xdeadbeef, > + (unsigned long) 0xbadc0dedfacef00dULL) == -1); > + printf("semctl\\(%d, %d, (IPC_64\\|)?%#x /\\* SEM_\\?\\?\\? \\*/, " > + "\\[?%#lx\

Re: [PATCH v2 0/9] Minor tests tweaks pt. 2 + Additional checks for IPC tests

2016-09-12 Thread Dmitry V. Levin
On Thu, Sep 08, 2016 at 05:05:04PM +0300, Eugene Syromyatnikov wrote: > Changes since v1: > * Commits "tests: Additional IPC checks" and "tests: Additional shmget > decoder >checks" have been merged. > * Added fix for key_t printing. > * Commits in tests now after commits in sources. > * S

Re: [PATCH] maint: update for linux 4.8

2016-09-12 Thread Dmitry V. Levin
On Mon, Sep 12, 2016 at 04:29:38PM +0300, Gleb Fotengauer-Malinovskiy wrote: > * maint/ioctls_sym.sh: Add workarounds for linux/atm_zatm.h and > xen/evtchn.h files. On Mon, Sep 12, 2016 at 04:30:18PM +0300, Gleb Fotengauer-Malinovskiy wrote: > * linux/x32/ioctls_inc0.h: Update from linux v4.8 using

Re: [PATCH] Re: your dm patch for strace

2016-09-12 Thread Dmitry V. Levin
On Thu, Aug 25, 2016 at 08:27:21AM -0400, Mikulas Patocka wrote: > On Wed, 24 Aug 2016, Masatake YAMATO wrote: > > > >> Are you talking about > > >> https://sourceforge.net/p/strace/mailman/message/34370586/ ? > > > > > > Yes. > > > > > >> The thread has apparently died without any follow-up fr

Re: [PATCH v3 2/2] tests: Workaroud for buggy glibc in ipc_msg test on ppc64

2016-09-13 Thread Dmitry V. Levin
On Tue, Sep 13, 2016 at 02:56:44AM +0300, Eugene Syromyatnikov wrote: > glibc before 2.23 (glibc-2.22-122-gbe48165? to be more precise) tried to > access > data pointed by third argument of msgctl call on 64-bit PowerPC which led to > segmentataion fault (instead of EFAULT from kernel). [...] > +/

Re: [PATCH 05/12] quota: Add missing prefixes to struct field names

2016-09-27 Thread Dmitry V. Levin
On Wed, Sep 21, 2016 at 06:11:28AM +0300, Eugene Syromyatnikov wrote: > * quota.c (decode_cmd_data): Print field names in accordance with their > definition. > --- > quota.c | 191 > --- > 1 file changed, 98 insertions(+), 93 deletion

Re: [PATCH 11/12] tests: Add support for providing program arguments

2016-09-27 Thread Dmitry V. Levin
On Wed, Sep 21, 2016 at 06:12:28AM +0300, Eugene Syromyatnikov wrote: > * tests/init.sh (run_strace_match_diff): Add support for providing > arguments to program via the PROG_ARGS environment variable. > --- > tests/init.sh |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff

Re: [PATCH 12/12] tests: Add tests for the quotactl syscall

2016-09-27 Thread Dmitry V. Levin
On Wed, Sep 21, 2016 at 06:12:37AM +0300, Eugene Syromyatnikov wrote: [...] > diff --git a/tests/quotactl-xfs.c b/tests/quotactl-xfs.c > new file mode 100644 > index 000..bfbc83b > --- /dev/null > +++ b/tests/quotactl-xfs.c [...] > +static struct xlat xfs_types[] = { > + XLAT_PAIR(1 << 0, "

Re: [PATCH 00/12] quotactl decoder tests and minor fixes

2016-09-27 Thread Dmitry V. Levin
On Wed, Sep 21, 2016 at 06:10:24AM +0300, Eugene Syromyatnikov wrote: > This patch set introduces test for the quotactl syscall along with > various changed deemed suitable during the course of implementation of > this test. It worth noting that unfortunately it is not possible to test > all the de

Re: [PATCH 06/11] fadvise: Change printing of len argument to unsigned in fadvise64 syscall

2016-09-27 Thread Dmitry V. Levin
On Thu, Sep 22, 2016 at 12:21:20AM +0300, Eugene Syromyatnikov wrote: > long sys_fadvise64(int fd, loff_t offset, size_t len, int advice); At the same time, the implementation does SYSCALL_DEFINE4(fadvise64, int, fd, loff_t, offset, size_t, len, int, advice) { return sys_fadvise64_64(fd, o

strace 4.14 released

2016-10-04 Thread Dmitry V. Levin
.14 2> /dev/null | sed '0,/:$/d' Dmitry V. Levin Elvira Khabirova Eugene Syromyatnikov Gleb Fotengauer-Malinovskiy James Clarke James Cowgill Richard W.M. Jones -- ldv pgpZ9G1qS6E4u.pgp Description: PGP signature --

Re: Interested in Open Source and contributing to Strace

2016-10-04 Thread Dmitry V. Levin
Hi Perside Rosalie, On Mon, Oct 03, 2016 at 08:57:23AM +0100, Rosalie Perside wrote: > Hello Everybody! > > My name is Perside Rosalie i am a junior computer engineer in University of > Buea-Cameroon, I am new to open source contribution and i will like to > contribute to Strace. I have cloned th

Re: strace cant parse struct msghdr RHEL

2016-10-04 Thread Dmitry V. Levin
On Tue, Oct 04, 2016 at 09:00:17AM -0400, Al Gambardella wrote: > I downloaded strace version 4.13 and was able to build the source code > and produce the strace executable. I need to see the all of the > payload in the recvmsg and sendmsg calls. including the iov style > arrays > > My system is R

Re: strace 4.14 released

2016-10-05 Thread Dmitry V. Levin
On Wed, Oct 05, 2016 at 11:08:24AM +0200, Andreas Schwab wrote: > I'm seeing this testsuite failure: > > https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:Factory/strace/s/s390x > > FAIL: count > === > > Pattern of expected output: *[^ ]+ +(1\.[01]|0\.99)[^n]*nanosle

Re: strace 4.14 released

2016-10-05 Thread Dmitry V. Levin
On Wed, Oct 05, 2016 at 11:08:24AM +0200, Andreas Schwab wrote: > I'm seeing this testsuite failure: > > https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:Factory/strace/s/s390x > > FAIL: count > === > > Pattern of expected output: *[^ ]+ +(1\.[01]|0\.99)[^n]*nanosle

Re: strace cant parse struct msghdr RHEL

2016-10-05 Thread Dmitry V. Levin
On Wed, Oct 05, 2016 at 08:08:06AM -0400, Al Gambardella wrote: > How do you build a 32-bit strace executable on a 64 bit Linux platform? e.g. $ CC='gcc -m32' ./configure --build=i686-pc-linux-gnu --target=i686-pc-linux-gnu && make && make check -- ldv pgpCGCJ9jXGRS.pgp Description: PGP sign

Re: [PATCH v2] Update ioctl entries from linux 4.9

2016-11-13 Thread Dmitry V. Levin
On Fri, Nov 11, 2016 at 08:51:45PM +0300, Gleb Fotengauer-Malinovskiy wrote: > * linux/32/ioctls_inc_align32.h: Update from linux v4.9 using ioctls_gen.sh. > * linux/32/ioctls_inc_align64.h: Likewise. > * linux/64/ioctls_inc.h: Likewise. > * linux/x32/ioctls_inc0.h: Likewise. > * NEWS: Mention this

Re: [PATCH] Don't run old_mmap test on m68k

2016-11-13 Thread Dmitry V. Levin
On Sat, Nov 12, 2016 at 10:48:55AM +0100, Andreas Schwab wrote: > * tests/old_mmap.c: Skip test on m68k. Applied, thanks. -- ldv pgpya0kbcBjvF.pgp Description: PGP signature -- Developer Access Program for Intel Xeon

Re: [PATCH] m68k: switch to PTRACE_GETREGS

2016-11-13 Thread Dmitry V. Levin
On Sat, Nov 12, 2016 at 08:02:23PM +0100, Andreas Schwab wrote: > * Makefile.am (EXTRA_DIST): Add linux/m68k/arch_regs.h, remove > linux/m68k/get_syscall_result.c. > * linux/m68k/arch_regs.c (m68k_d0, ARCH_PC_PEEK_ADDR): Don't > define. > (m68k_regs, m68k_usp_ptr, ARCH_PC_REG, ARCH_REGS_FOR_GETREGS

Re: [PATCH] Add ioctl definitions for 16-bit alignment

2016-11-13 Thread Dmitry V. Levin
On Sat, Nov 12, 2016 at 03:58:26PM +0100, Andreas Schwab wrote: > * Makefile.am (EXTRA_DIST): Add linux/32/ioctls_inc_align16.h. > * linux/32/ioctls_inc_align16.h: New file. > * linux/32/ioctls_inc.h [M68K]: Include it. > * maint/ioctls_sym.sh: Handle missing . Thanks. [...] > --- a/maint/ioctls_

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-11-15 Thread Dmitry V. Levin
Hi, On Sat, Aug 20, 2016 at 02:44:55AM +0200, Nahim El Atmani wrote: > On Fri, 29 Jul 2016 17:57:33 +0300, Dmitry V. Levin wrote: > > On Fri, Jul 29, 2016 at 03:06:50PM +0200, Gabriel Laskar wrote: > > > On Fri, 29 Jul 2016 04:04:02 +0300, Dmitry V. Levin wrote: > > > &

Re: New contributor

2016-11-16 Thread Dmitry V. Levin
Hi, On Wed, Oct 26, 2016 at 10:42:15PM +0530, Saurav Sachidanand wrote: > Hello strace team, > > I'm Saurav Sachidanand, a CS sophomore from India. I'm interested in > systems programming (with C, Rust), and I have a couple of projects on > Github (github.com/saurvs). I'd like to begin contributi

Re: Newbies first add a test.

2016-11-16 Thread Dmitry V. Levin
On Thu, Oct 27, 2016 at 01:03:00PM +0800, ChenJingPiao wrote: > Hi, I am a newbies, this is my first test add in strace, > if something wrong, please tell me. And is it necessary > to implement user manage related syscalls on strace -e? > such as: getuid, setuid, getgid, setgid, getegid, setegid, >

Re: tests: check decoding of gettid syscall.

2016-11-16 Thread Dmitry V. Levin
On Thu, Oct 27, 2016 at 01:03:36PM +0800, ChenJingPiao wrote: > From d8b52c3ac997dff046e1536d692f55cd470f72d8 Mon Sep 17 00:00:00 2001 > From: ChenJingPiao > Date: Thu, 27 Oct 2016 12:25:33 +0800 > Subject: [PATCH] tests: check decoding of gettid syscall. As one of many zero argument syscalls, ge

Re: [PATCH] Makefile.am: don't confuse CFLAGS and CFLAGS_FOR_BUILD

2016-11-16 Thread Dmitry V. Levin
Hi, On Tue, Oct 18, 2016 at 01:42:44PM +0200, Thomas De Schampheleire wrote: > From: Thomas De Schampheleire > > Commit dc427d50d96b15c9a64d7e78d97ce4d194622a63 enabled a number of extra > warning flags through configure.ac. The configure script will determine > dynamically if CC supports these

Re: [PATCH] Add ioctl definitions for 16-bit alignment

2016-11-21 Thread Dmitry V. Levin
On Mon, Nov 14, 2016 at 02:00:53AM +0300, Dmitry V. Levin wrote: > On Sat, Nov 12, 2016 at 03:58:26PM +0100, Andreas Schwab wrote: > > * Makefile.am (EXTRA_DIST): Add linux/32/ioctls_inc_align16.h. > > * linux/32/ioctls_inc_align16.h: New file. > > * linux/32/ioctls_inc

Re: [PATCH] Makefile.am: don't confuse CFLAGS and CFLAGS_FOR_BUILD

2016-12-07 Thread Dmitry V. Levin
Hi Thomas, On Tue, Dec 06, 2016 at 09:06:08PM +0100, Thomas De Schampheleire wrote: > On Wed, Nov 16, 2016 at 8:27 PM, Dmitry V. Levin wrote: [...] > > The correct fix is going to be more complex, e.g. > > - move all gl_WARN_ADD/WARN_CFLAGS related code from configure.ac to a &g

Re: readv.test is fail on Ubuntu 16.04 x86_64

2016-12-07 Thread Dmitry V. Levin
Hi, On Sun, Dec 04, 2016 at 07:59:48PM +0800, JingPiao Chen wrote: > Environment: Ubuntu 16.04 x86_64 > Version: dcc9b9cdb2cd6de7c5b300b8d1f5dfb3f0b31ab2 > > readv.test is fail on Ubuntu 16.04 x86_64 > > test-suite.log/readv.log: > > 251 FAIL: readv > 252 === > 253 > 254 ../strace: inv

Re: [PATCH] Makefile.am: don't confuse CFLAGS and CFLAGS_FOR_BUILD

2016-12-07 Thread Dmitry V. Levin
On Wed, Dec 07, 2016 at 02:58:35PM +0300, Dmitry V. Levin wrote: > On Tue, Dec 06, 2016 at 09:06:08PM +0100, Thomas De Schampheleire wrote: > > On Wed, Nov 16, 2016 at 8:27 PM, Dmitry V. Levin wrote: > [...] > > > The correct fix is going to be more complex, e.g. > &g

Re: [PATCH] Makefile.am: don't confuse CFLAGS and CFLAGS_FOR_BUILD

2016-12-07 Thread Dmitry V. Levin
Hi Thomas, On Wed, Dec 07, 2016 at 09:32:20PM +0100, Thomas De Schampheleire wrote: > On Wed, Dec 7, 2016 at 4:18 PM, Dmitry V. Levin wrote: > > On Wed, Dec 07, 2016 at 02:58:35PM +0300, Dmitry V. Levin wrote: > >> On Tue, Dec 06, 2016 at 09:06:08PM +0100, Thomas De Schampheleir

Re: Patch: Fix libunwind segfault when -p is passed before -k

2016-12-12 Thread Dmitry V. Levin
Hi, On Thu, Dec 08, 2016 at 10:00:59AM -1000, Sean Stangl wrote: > There is a segfault if strace is called as `strace -p 2260 -k`. > > The -k flag sets a global bool stack_trace_enabled. But -p already consults > stack_trace_enabled during tcb initialization. So if -p is passed first, > the libun

Re: puzzle of ioctl decode in file_ioctl.c and userfaultfd.c

2016-12-12 Thread Dmitry V. Levin
On Mon, Dec 12, 2016 at 10:39:43AM +, Dr. David Alan Gilbert wrote: > * jingpiao chen (chenjingp...@gmail.com) wrote: > > Version:4.14-ab28d7f1e5ab9b51f5708741bd13f92e768123d4 > > > > 2.userfaultfd.c:126 > > > > 126 case UFFDIO_UNREGISTER: > > 127 case UFFDIO_WAKE: { > > 128

Re: Patch: Fix libunwind segfault when -p is passed before -k

2016-12-13 Thread Dmitry V. Levin
On Mon, Dec 12, 2016 at 01:53:29PM +0300, Dmitry V. Levin wrote: > On Thu, Dec 08, 2016 at 10:00:59AM -1000, Sean Stangl wrote: > > There is a segfault if strace is called as `strace -p 2260 -k`. > > > > The -k flag sets a global bool stack_trace_enabled. Bu

strace 4.15 released

2016-12-14 Thread Dmitry V. Levin
ed to this release. $ git tag -v v4.15 2> /dev/null | sed '0,/:$/d' Andreas Schwab Dmitry V. Levin Elvira Khabirova Eugene Syromyatnikov Gleb Fotengauer-Malinovskiy JingPiao Chen Mikulas Patocka Nahim El Atmani Sean Stangl Thomas De Schampheleire -- ldv pgpTVj24b17H5.pgp Descript

Re: strace 4.15 released

2016-12-19 Thread Dmitry V. Levin
it builds are both showing issues with fault injection. I > > can't follow what the code is meant to be doing here, so no > > ideas on what's wrong. :-( > > As Dmitry said earlier: > > On Tue, 15 Nov 2016 15:43:59 +0300, Dmitry V. Levin wrote: > > Well, the m

Re: [PATCH] tests: check decoding of LOOP_* ioctls

2016-12-22 Thread Dmitry V. Levin
On Fri, Dec 16, 2016 at 12:05:02AM +0800, JingPiao Chen wrote: > >From c40ccc35dc8e40fc6dc331af3d1884a54bc72784 Mon Sep 17 00:00:00 2001 > From: JingPiao Chen > Date: Fri, 16 Dec 2016 00:02:55 +0800 > Subject: [PATCH] tests: check decoding of LOOP_* ioctls Thanks for the test, but it has reached

Re: [PATCH 2/2] tests: check decoding of SIOC* ioctls

2016-12-22 Thread Dmitry V. Levin
On Mon, Dec 19, 2016 at 11:34:13PM +0800, JingPiao Chen wrote: > >From 8b0c44c17d17ea3a9710ae7586579c288289a46e Mon Sep 17 00:00:00 2001 > From: JingPiao Chen > Date: Mon, 19 Dec 2016 23:29:54 +0800 > Subject: [PATCH 2/2] tests: check decoding of SIOC* ioctls Could you resend this using a differe

Re: [PATCH 1/2] sock: fix bitwise OR operation short circuit

2016-12-22 Thread Dmitry V. Levin
On Mon, Dec 19, 2016 at 11:33:46PM +0800, JingPiao Chen wrote: > sock.c: 150 > > 150 if (syserror(tcp) || umove(tcp, addr, &ifc) < 0) { > 151 if (ifc.ifc_buf) > 152 tprints("}"); > 153 else > 154 printaddr(addr

Re: [PATCH v2 1/2] xattr: use printstr_ex instead of print_quoted_string

2016-12-22 Thread Dmitry V. Levin
Hi, On Thu, Dec 22, 2016 at 04:10:51PM +0100, Gabriel Laskar wrote: > This fixes the display when using `-s` to limit the string size of the > values displayed by {get,set}xattr. > > * xattr.c (print_xattr_val): use printstr_ex instead of > print_quoted_string > > Reported-by: Марк Коренберг >

Re: [PATCH] tests: check decoding of LOOP_* ioctls

2016-12-22 Thread Dmitry V. Levin
On Fri, Dec 23, 2016 at 07:51:47AM +0800, JingPiao Chen wrote: > >Thanks for the test, but it has reached the mailing list badly damaged > >so I can neither read it nor apply it in a regular way. > > > >Could you resend it using a different method that doesn't lead to damaged > >patches, please? >

Re: Sending signals on syscalls

2016-12-24 Thread Dmitry V. Levin
Hi, On Sat, Dec 24, 2016 at 01:29:24PM +0100, Seraphime Kirkovski wrote: > Hello straces devs ! > > Recently, I had to do some reverse engineering on a malware for > a somewhat exotic platform. As the malware had its .text encrypted my > only possibility was strace. As always, it helped me to >

Re: [PATCH] strace: add :signal option to efault

2016-12-26 Thread Dmitry V. Levin
On Mon, Dec 26, 2016 at 10:01:58AM +0100, Seraphime Kirkovski wrote: > This extends the -e fault capability with a :signal option which > delivers a signal on entry of the specified syscall. > :error and :signal are mutually exclusive; it does not make sense to > interrupt a syscall with a signal a

Re: [PATCHv1] strace: add :signal option to efault

2016-12-26 Thread Dmitry V. Levin
On Mon, Dec 26, 2016 at 06:24:46PM +0100, Seraphime Kirkovski wrote: > This extends the -e fault capability with a :signal option which > delivers a signal on entry of the specified syscall. > > :signal and :error are complementary, if they are both specified the > syscall will be injected as per

Re: [PATCH] tests: check decoding of LOOP_* ioctls

2016-12-26 Thread Dmitry V. Levin
On Fri, Dec 23, 2016 at 08:16:16AM +0800, JingPiao Chen wrote: > >No, the formatting is broken all the same. > Sorry, my mistake. > >From e6bfa146fdd5c5eef9d317dffec93023889bd697 Mon Sep 17 00:00:00 2001 > From: JingPiao Chen > Date: Fri, 23 Dec 2016 08:10:43 +0800 > Subject: [PATCH] tests: check

Re: [PATCH 1/4] tests/.gitignore: add missing files that should be ignored

2016-12-27 Thread Dmitry V. Levin
On Tue, Dec 27, 2016 at 11:43:28AM +0800, JingPiao Chen wrote: > * tests/.gitignore: Add add_key, attach-f-p-cmd and scno.h. > --- > tests/.gitignore | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/.gitignore b/tests/.gitignore > index 3b04590..bab02a0 100644 > --- a/tests/.giti

Re: [PATCHv2 1/2] strace: add :signal option to efault

2016-12-27 Thread Dmitry V. Levin
On Tue, Dec 27, 2016 at 12:14:06PM +0100, Seraphime Kirkovski wrote: > This extends the -e fault capability with a :signal option which > delivers a signal on entry of the specified syscall. > > :signal and :error are complementary, if they are both specified the > syscall will be injected as per

Re: [PATCH 2/2] man: document the :signal option to -e fault

2016-12-27 Thread Dmitry V. Levin
On Tue, Dec 27, 2016 at 12:14:36PM +0100, Seraphime Kirkovski wrote: > This adds :signal to strace.1 > > Signed-off-by: Seraphime Kirkovski > --- > strace.1 | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/strace.1 b/strace.1 > index 24dd7d3..2be7d83 100644

Re: GSoC 2017

2016-12-28 Thread Dmitry V. Levin
Hi Stefan, On Tue, Dec 27, 2016 at 09:04:21PM +0200, Stefan Toncu wrote: > Hello! > > My name is Stefan Toncu and I am in my 3rd year at a Computer Science > University. I want to participate in Google Summer of Code 2017 and while I > was browsing through the last year’s projects, your organizat

Re: [PATCHv3 1/2] strace: implement signal injection

2016-12-28 Thread Dmitry V. Levin
On Wed, Dec 28, 2016 at 05:22:36PM +0100, Seraphime Kirkovski wrote: > This extends the fault injection capability with :signal=SIG option > which injects a signal on entering each syscall from the specified set. > > :signal and :error options are complementary, if they are both specified > the sy

Re: generate_scno issue using cross compiler (ARM)

2016-12-30 Thread Dmitry V. Levin
Hi, On Thu, Dec 29, 2016 at 11:44:23PM +0100, Joakim Bech wrote: > Hi, > > I'm not sure if I've found an issue or it's me using this the wrong way. > >From commit: > 605a705a63d533dceb3c2d489468fcd3aed3963c: tests: generate scno.h from > syscallent.h for use by other tests > > It fails for me w

Re: strace 4.15 released

2017-01-05 Thread Dmitry V. Levin
Hi, On Tue, Jan 03, 2017 at 06:02:44PM +, James Cowgill wrote: > On 20/12/16 00:36, Steve McIntyre wrote: > > On Tue, Dec 20, 2016 at 03:16:17AM +0300, Dmitry V. Levin wrote: > >> On Tue, Dec 20, 2016 at 12:50:29AM +0100, Nahim El Atmani wrote: > >>> On Mon, 19

Re: [PATCH 4/4] Implement decoding of ustat syscall

2017-01-06 Thread Dmitry V. Levin
On Fri, Jan 06, 2017 at 03:16:30PM +0800, JingPiao Chen wrote: [...] > +#include "defs.h" > +#include > + > +SYS_FUNC(ustat) > +{ > + if (entering(tcp)) > + print_dev_t(tcp->u_arg[0]); > + else { > + struct ustat ust; This structure is personality specific and ther

Re: [PATCH 2/4] qualify: fix signal=SIG_0 and signal=0 do not print error message

2017-01-06 Thread Dmitry V. Levin
On Fri, Jan 06, 2017 at 03:16:28PM +0800, JingPiao Chen wrote: > SIG_0 is not valid signal name, do not have signal number is 0. Despite SIG_0 not being a valid signal name and signal number 0 not being a valid signal, -e signal=0 should not be disallowed. There are some weird circumstances when

Re: [PATCH v2] Implement decoding of ustat syscall

2017-01-06 Thread Dmitry V. Levin
On Fri, Jan 06, 2017 at 10:27:05PM +0800, JingPiao Chen wrote: [...] > +#include "defs.h" > +#include DEF_MPERS_TYPE(struct_ustat) > +#include > +typedef struct ustat struct_ustat; > +#include MPERS_DEFS This is correct. > + > +SYS_FUNC(ustat) > +{ > + struct_ustat ust; > + > + if (enter

Re: [PATCH v3] Implement decoding of ustat syscall

2017-01-07 Thread Dmitry V. Levin
On Sat, Jan 07, 2017 at 06:22:44PM +0800, JingPiao Chen wrote: [...] > diff --git a/tests/Makefile.am b/tests/Makefile.am > index 57dd8b9..ceeccd8 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -414,6 +414,7 @@ check_PROGRAMS = \ > utime \ > utimensat \ > utimes \

Re: strace 4.15 released

2017-01-09 Thread Dmitry V. Levin
Hi, On Mon, Jan 09, 2017 at 05:31:37PM +, James Cowgill wrote: > On 06/01/17 00:51, Dmitry V. Levin wrote: > > On Tue, Jan 03, 2017 at 06:02:44PM +, James Cowgill wrote: > >> On 20/12/16 00:36, Steve McIntyre wrote: > >>> On Tue, Dec 20, 2016 at 03:16:17A

Re: [PATCH v4] Implement decoding of ustat syscall

2017-01-10 Thread Dmitry V. Levin
On Mon, Jan 09, 2017 at 09:40:19PM +0800, JingPiao Chen wrote: [...] > +#include "tests.h" > +#include > + > +#ifdef __NR_ustat > + > +# include > +# include > +# include > +# include > +# include > + > +int > +main(void) > +{ > + kernel_ulong_t magic = (kernel_ulong_t) 0xfacefeed

Re: [PATCH v5] Implement decoding of ustat syscall

2017-01-11 Thread Dmitry V. Levin
On Wed, Jan 11, 2017 at 11:52:21PM +0800, JingPiao Chen wrote: [...] > +#include "tests.h" > +#include > + > +#ifdef __NR_ustat > + > +# include > +# include > +# include > +# include > +# include > + > +int > +main(void) > +{ > + kernel_ulong_t magic = (kernel_ulong_t) 0xfacefeed

  1   2   3   4   5   6   7   8   9   10   >