Possible bug or missing feature in ForwardAction

2002-10-01 Thread phpsurf
Hi the ForwardAction seems not to be compliant with sub-applications ... The path of the jsp passed as parameter to ForwardAction (in struts-config.xml) has to be context-relative, instead of module relative ... is that a bug or a desired feature ? :)

Possible bug or missing feature in ForwardAction

2002-10-01 Thread phpsurf
Hi the ForwardAction seems not to be compliant with sub-applications ... The path of the jsp passed as parameter to ForwardAction (in=20 struts-config.xml) has to be context-relative, instead of module=20 relative ... is that a bug or a desired feature ? :)

RE: Possible bug or missing feature in ForwardAction

2002-10-01 Thread phpsurf
here is a patch that could solve this problem. execute() method of org.apache.struts.actions.ForwardAction if you have any comment about it ... --- public ActionForward execute(ActionMapping mapping,

DO NOT REPLY [Bug 13177] New: - pingquery behaviour changed after switching to commons-dbcp

2002-10-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13177. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: struts-config_1_1.dtd error?

2002-10-01 Thread Eddie Bush
Why does Opera ever see the DTD? ... odd ... I just open my DTDs up in Netbeans personally. I can't imagine the DTD being seen during app execution - I'm guessing you are opening it for reference. One observation I would make: Shouldn't we be using an encoding of UTF-8? I thought that

Re: struts-config_1_1.dtd error?

2002-10-01 Thread David Graham
Of course the app never shows the dtd :-). I went to the dtd url referenced by struts-config.xml and got xml parsing errors because of that first processing instruction. Not that I care if Opera chokes on it, but it did alert me to the fact that it probably shouldn't be in there. Dave

Re: struts-config_1_1.dtd error?

2002-10-01 Thread Eddie Bush
I'm about as stupid as it gets wrt XML/DTDs. I can use digester to instantiate/configure stuff (piece of cake!) but I haven't cured my definite lack of knowledge on XML yet ... :-/ I really should too - I see a lot of utility in it. Sorry for asking a stupid question - I just couldn't see

RE: struts-config_1_1.dtd error?

2002-10-01 Thread James Childers
David Graham wrote: The struts-config_1_1.dtd file starts with this line: ?xml version=1.0 encoding=ISO-8859-1? which I think is incorrect. DTDs aren't xml documents so they shouldn't start with that processing instruction. I'm not an XML expert but Sun's DTDs don't have this line

Re: Struts-EL: Finished with copyright header and javadoc

2002-10-01 Thread Eddie Bush
Must I explicitly ask for that section to be added to my CVS checkout? When I run cvs update I don't get it added to my checkout - am I wrong to expect that to add it? I'm a bit of a CVS novice myself :-) I know for a fact there are people wanting at this though - and it's easier to point

RE: Struts-EL: Finished with copyright header and javadoc

2002-10-01 Thread James Mitchell
Did you use -d? James Mitchell Software Engineer\Struts Evangelist Struts-Atlanta, the Open Minded Developer Network http://www.open-tools.org/struts-atlanta -Original Message- From: Eddie Bush [mailto:[EMAIL PROTECTED]] Sent: Tuesday, October 01, 2002 1:30 PM To: Struts

RE: struts-config_1_1.dtd error?

2002-10-01 Thread David Graham
Thanks for the link. I've never used xml schema and most xml I've seen is validated against a dtd but it's nice that it's there. Should I post this to bugzilla or does one of the committers want to quickly remove that line from the dtd? Dave From: James Childers [EMAIL PROTECTED] Reply-To:

Re: Struts-EL: Finished with copyright header and javadoc

2002-10-01 Thread Craig R. McClanahan
Use the following command to pick up everything new that's checked in (as well as pruning empty directories): cvs update -dP Craig On Tue, 1 Oct 2002, Eddie Bush wrote: Date: Tue, 01 Oct 2002 12:29:54 -0500 From: Eddie Bush [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL

RE: Struts-EL: Finished with copyright header and javadoc

2002-10-01 Thread Karr, David
-Original Message- From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] Sent: Tuesday, October 01, 2002 10:36 AM To: Struts Developers List Subject: Re: Struts-EL: Finished with copyright header and javadoc Use the following command to pick up everything new that's checked in

Re: Struts-EL: Finished with copyright header and javadoc

2002-10-01 Thread Eddie Bush
Thanks for the tips :-) Karr, David wrote: -Original Message- From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] Use the following command to pick up everything new that's checked in (as well as pruning empty directories): cvs update -dP Or even better, create a file

Re: Struts-EL: Finished with copyright header and javadoc

2002-10-01 Thread Eddie Bush
Karr, David wrote: Or even better, create a file $HOME/.cvsrc that sets your always options, that might look like this (make sure you understand all of these options before you store this): -- cvs -r update -dP checkout -P diff -c -- Shouldn't that be diff -u? --

org.apache.struts.util.AppException implementing an Interface

2002-10-01 Thread phpsurf
Well, that was a very smart suggestion ! So, what about creating this interface ? - this interface could be called org.apache.struts.util.IAppException - this interface would declare 2 methods: getError() and getProperty(). - this interface would be used by the default exception handler to

Re: org.apache.struts.util.AppException implementing an Interface

2002-10-01 Thread David Graham
I don't think adding interfaces using hungarian notation (I prefix) is a very good idea. It decreases readability and makes the name nonsensical. It's especially not a good idea when none of the other interfaces used in struts have that notation. Dave From: phpsurf [EMAIL PROTECTED]

RE: struts-config_1_1.dtd error?

2002-10-01 Thread tim_smithers
You will need to get used to schemas tho'. If you have a look at the draft 2.4 servlet spec, they now use a schema instead of a dtd for web.xml. It's a pity that digester doesn't yet work with registering schema's (only DTD's) - although you can set a schema. James Childers wrote: David

RE: Struts-EL: Finished with copyright header and javadoc

2002-10-01 Thread Martin Cooper
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] Sent: Monday, September 30, 2002 10:56 PM To: [EMAIL PROTECTED] Subject: Struts-EL: Finished with copyright header and javadoc I've finished adding the copyright header to all the java source files, and

RE: Struts-EL: Finished with copyright header and javadoc

2002-10-01 Thread Martin Cooper
-Original Message- From: Eddie Bush [mailto:[EMAIL PROTECTED]] Sent: Tuesday, October 01, 2002 10:58 AM To: Struts Developers List Subject: Re: Struts-EL: Finished with copyright header and javadoc Karr, David wrote: Or even better, create a file $HOME/.cvsrc that sets your

DO NOT REPLY [Bug 13187] New: - struts-config.dtd has incorrect processing instruction

2002-10-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13187. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

MessagesTag Enhancements

2002-10-01 Thread David Graham
I think some enhancements to the MessagesTag are appropriate but before I started coding a patch I thought I would get some developer opinions. I think it should support message resources keys in the same way that the ErrorsTag does. Instead of errors.* it would support messages.header

Re: cvs commit: jakarta-struts/contrib/struts-el build.xml

2002-10-01 Thread David M. Karr
craigmcc == craigmcc [EMAIL PROTECTED] writes: craigmcc craigmcc2002/10/01 18:50:13 craigmcc Modified:.build.xml craigmcccontrib/struts-el build.xml craigmcc Log: craigmcc Update the main build.xml file to include struts-el in the new

cvs commit: jakarta-struts/conf/share struts-config_1_1.dtd

2002-10-01 Thread craigmcc
craigmcc2002/10/01 20:51:56 Modified:conf/share struts-config_1_1.dtd Log: Remove the ?xml? prolog from the DTD for the Struts configuration file. DTDs are not supposed to have one, and some XML processors will complain if it is present. PR: 13187 Submitted by: [EMAIL

DO NOT REPLY [Bug 13187] - struts-config.dtd has incorrect processing instruction

2002-10-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13187. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: cvs commit: jakarta-struts/contrib/struts-el build.xml

2002-10-01 Thread David M. Karr
craigmcc == craigmcc [EMAIL PROTECTED] writes: craigmcc craigmcc2002/10/01 18:50:13 craigmcc Modified:.build.xml craigmcccontrib/struts-el build.xml craigmcc Log: craigmcc Update the main build.xml file to include struts-el in the new

DO NOT REPLY [Bug 13189] New: - html:checkbox tag should render checked if property equals value

2002-10-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13189. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: cvs commit: jakarta-struts/contrib/struts-el build.xml

2002-10-01 Thread Craig R. McClanahan
On 1 Oct 2002, David M. Karr wrote: Date: 01 Oct 2002 21:14:26 -0700 From: David M. Karr [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: cvs commit: jakarta-struts/contrib/struts-el build.xml craigmcc == craigmcc [EMAIL PROTECTED]

Re: cvs commit: jakarta-struts/contrib/struts-el build.xml

2002-10-01 Thread David M. Karr
Craig == Craig R McClanahan [EMAIL PROTECTED] writes: Craig On 1 Oct 2002, David M. Karr wrote: Date: 01 Oct 2002 21:14:26 -0700 From: David M. Karr [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: cvs commit:

Re: cvs commit: jakarta-struts/contrib/struts-el build.xml

2002-10-01 Thread David M. Karr
Craig == Craig R McClanahan [EMAIL PROTECTED] writes: Craig On 1 Oct 2002, David M. Karr wrote: Date: 01 Oct 2002 21:14:26 -0700 From: David M. Karr [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: cvs commit: