DO NOT REPLY [Bug 16603] - controller forwardPattern should support different module roots.

2003-02-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16603. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 16603] - controller forwardPattern should support different module roots.

2003-02-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16603. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: RequestProcessor methods scope

2003-02-08 Thread Cedric Dumoulin
These methods are used by the Tiles subclasses, which are part of Struts ;-) The doc says that methods are not part of the API to prevent regular users to use them. Normally, users only need to overload doInclude() or doForward(). Cedric David Graham wrote: The

cvs commit: jakarta-struts build-all-clean.bat.sample

2003-02-08 Thread rleland
rleland 2003/02/08 11:31:52 Modified:.build-all-clean.bat.sample Log: Update to build current version of struts Revision ChangesPath 1.6 +5 -2 jakarta-struts/build-all-clean.bat.sample Index: build-all-clean.bat.sample

cvs commit: jakarta-struts/src/share/org/apache/struts/tiles/xmlDefinition XmlParser.java

2003-02-08 Thread cedric
cedric 2003/02/08 11:34:19 Modified:src/share/org/apache/struts/tiles/xmlDefinition XmlParser.java Log: Let the bean rules use the correct declaration. Revision ChangesPath 1.8 +4 -4

Re: Tiles XmlParser - cut paste error?

2003-02-08 Thread Cedric Dumoulin
You are right, this is probably a cutpaste error. I have corrected it. Cedric Martin Cooper wrote: Running PMD over the latest code, I think I've found a bug in the Tiles XmlParser class. Lines 255 - 256 of this class look like this: String menuItemDefaultClass =

Re: tiles:put and put tag

2003-02-08 Thread Cedric Dumoulin
Hi, But where do you declare objects in the config file ? If we enable someting like beanName=someBean in the config file, where does the bean should come from ? Cedric Frank Kim wrote: I have a quick question regarding the difference in terms of functionality between put tag and

cvs commit: jakarta-struts/src/share/org/apache/struts/tiles/xmlDefinition XmlParser.java

2003-02-08 Thread rleland
rleland 2003/02/08 12:01:46 Modified:src/share/org/apache/struts/tiles/xmlDefinition XmlParser.java Log: deprecated setDetail level. Use the commons-logging to set digester debug level. I am assuming that since this source code is in the Struts 1.1

cvs commit: jakarta-struts build.properties.sample

2003-02-08 Thread rleland
rleland 2003/02/08 12:10:02 Modified:.build.properties.sample Log: Tiles requres JUnit 3.81 or newer for unit tests. Revision ChangesPath 1.29 +3 -3 jakarta-struts/build.properties.sample Index: build.properties.sample

cvs commit: jakarta-struts/src/test/org/apache/struts/util TestRequestUtils.java

2003-02-08 Thread craigmcc
craigmcc2003/02/08 13:01:52 Modified:src/test/org/apache/struts/mock TestMockBase.java src/test/org/apache/struts/util TestRequestUtils.java Log: As part of the investigation of Bugzilla ticket #16603, create unit tests that validate the current behavior of

DO NOT REPLY [Bug 16514] - Nested tiles fail in this release

2003-02-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16514. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

cvs commit: jakarta-struts/src/share/org/apache/struts/util RequestUtils.java

2003-02-08 Thread craigmcc
craigmcc2003/02/08 13:20:20 Modified:src/share/org/apache/struts/util RequestUtils.java Log: Formally document the behavior of forwardURL() so that people will know what to expect (and what we test for). No functionality changes. Revision ChangesPath 1.83 +38 -8

cvs commit: jakarta-struts/src/test/org/apache/struts/util TestRequestUtils.java

2003-02-08 Thread craigmcc
craigmcc2003/02/08 14:12:09 Modified:src/share/org/apache/struts/util RequestUtils.java src/test/org/apache/struts/util TestRequestUtils.java Log: Unit tests for the current behavior of RequestUtils.pageURL(). We deliberately do *not* do slash prepending here --

[Bugzilla #16603] Discussion Please

2003-02-08 Thread Craig R. McClanahan
OK, I've assigned myself the following bugzilla ticket: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16603 and am trying to decide how to deal with it. I think I understand what the reporter (cc'd above) is proposing. What's not clear is whether we should make any change now, or perhaps

cvs commit: jakarta-struts/src/share/org/apache/struts/util RequestUtils.java

2003-02-08 Thread craigmcc
craigmcc2003/02/08 15:31:30 Modified:conf/share struts-config_1_1.dtd src/share/org/apache/struts/action ExceptionHandler.java src/share/org/apache/struts/config ExceptionConfig.java src/share/org/apache/struts/util RequestUtils.java Log:

cvs commit: jakarta-struts/src/share/org/apache/struts/util RequestUtils.java

2003-02-08 Thread craigmcc
craigmcc2003/02/08 15:34:38 Modified:src/share/org/apache/struts/util RequestUtils.java Log: Forgot a closing /p. Revision ChangesPath 1.86 +5 -5 jakarta-struts/src/share/org/apache/struts/util/RequestUtils.java Index: RequestUtils.java

cvs commit: jakarta-struts/conf/share struts-config_1_1.dtd

2003-02-08 Thread craigmcc
craigmcc2003/02/08 15:41:59 Modified:conf/share struts-config_1_1.dtd Log: Oops ... make the description of how the forward and include attributes match what the current behavior actually is, rather than what they might get changed to. Revision ChangesPath 1.38

DO NOT REPLY [Bug 16882] - problem in redirect with multi module capacities

2003-02-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16882. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 16899] - tomcat-5 can not compile tiles

2003-02-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16899. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: [Bugzilla #16603] Discussion Please

2003-02-08 Thread Craig R. McClanahan
On Sat, 8 Feb 2003, Craig R. McClanahan wrote: Date: Sat, 8 Feb 2003 15:23:23 -0800 (PST) From: Craig R. McClanahan [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: [Bugzilla #16603] Discussion Please OK, I've

DO NOT REPLY [Bug 16899] - tomcat-5 can not compile tiles

2003-02-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16899. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 16899] - tomcat-5 can not compile tiles

2003-02-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16899. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: DO NOT REPLY [Bug 16749] New: - Struts EL tag handlers cannot be reused by containers

2003-02-08 Thread David M. Karr
I wanted to give a little status on this and query the committers on how they would like me to proceed. I've finished the changes for this, but I haven't checked anything in, as the consensus was that we wanted to delay a fix for this until after 1.1. The change simply required making sure every

Re: [Bugzilla #16603] Discussion Please

2003-02-08 Thread David Graham
My understanding of modules is that they're independent pieces that can plug into any Struts app. They can point to external resources if they want but don't need to. Based on that, I believe all resources for a module should live in the same module root directory. You shouldn't have some

DO NOT REPLY [Bug 16899] - tomcat-5 can not compile tiles

2003-02-08 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16899. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Re: [Bugzilla #16603] Discussion Please

2003-02-08 Thread Rob Leland
Craig R. McClanahan wrote: However, at this point in time, I'm going to suggest that we resolve this one as LATER and put it into the 1.2 Family camp. +1, We have a good product and have uncovered some inconsistent behaviour. The 1.2 relase time seems appropiate. -Rob