Re: [Sts-sponsors] [Merge] ~bjornt/maas:perftest-no-implicit-path into maas:master

2022-11-23 Thread Alberto Donato
Review: Approve +1 -- https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433441 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe : https://launchpad.net/~sts-spon

[Sts-sponsors] [Merge] ~bjornt/maas:perftest-websocket-machine-list-all into maas:master

2022-11-23 Thread MAAS Lander
The proposal to merge ~bjornt/maas:perftest-websocket-machine-list-all into maas:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433442 -- Your team MAAS Committers is subscribed to branch maas:master. --

[Sts-sponsors] [Merge] ~bjornt/maas:perftest-no-implicit-path into maas:master

2022-11-23 Thread Björn Tillenius
The proposal to merge ~bjornt/maas:perftest-no-implicit-path into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433441 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mai

Re: [Sts-sponsors] [Merge] -b perftest-no-implicit-path lp:~bjornt/maas/+git/maas into -b master lp:~maas-committers/maas - LANDING FAILED

2022-11-23 Thread MAAS Lander
LANDING -b perftest-no-implicit-path lp:~bjornt/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: FAILED BUILD LOG: http://maas-ci.internal:8080/job/maas-tester/1462/consoleText -- https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433441 Your team MAAS Committers is subscribe

[Sts-sponsors] [Merge] ~bjornt/maas:perftest-no-implicit-path into maas:master

2022-11-23 Thread MAAS Lander
The proposal to merge ~bjornt/maas:perftest-no-implicit-path into maas:master has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433441 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mai

Re: [Sts-sponsors] [UNITTESTS] -b tests-use-make-dir lp:~ack/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS FAILED

2022-11-23 Thread MAAS Lander
Review: Needs Fixing UNIT TESTS -b tests-use-make-dir lp:~ack/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: FAILED LOG: http://maas-ci.internal:8080/job/maas-tester/1463/consoleText COMMIT: 121ec0d7d123c1c455e7685ba168e75eae6eee82 -- https://code.launchpad.net/~ack/maas/+git/ma

[Sts-sponsors] [Merge] ~bjornt/maas:perftest-no-implicit-path into maas:master

2022-11-23 Thread Björn Tillenius
The proposal to merge ~bjornt/maas:perftest-no-implicit-path into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433441 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mai

Re: [Sts-sponsors] [Merge] -b perftest-no-implicit-path lp:~bjornt/maas/+git/maas into -b master lp:~maas-committers/maas - LANDING FAILED

2022-11-23 Thread MAAS Lander
LANDING -b perftest-no-implicit-path lp:~bjornt/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: FAILED BUILD LOG: http://maas-ci.internal:8080/job/maas-tester/1464/consoleText -- https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433441 Your team MAAS Committers is subscribe

[Sts-sponsors] [Merge] ~bjornt/maas:perftest-no-implicit-path into maas:master

2022-11-23 Thread MAAS Lander
The proposal to merge ~bjornt/maas:perftest-no-implicit-path into maas:master has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433441 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mai

[Sts-sponsors] [Merge] ~bjornt/maas:perftest-no-implicit-path into maas:master

2022-11-23 Thread Björn Tillenius
The proposal to merge ~bjornt/maas:perftest-no-implicit-path into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433441 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mai

Re: [Sts-sponsors] [Merge] ~troyanov/maas:vmhost-power-params into maas:master

2022-11-23 Thread Alberto Donato
jenkins: !test -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/433439 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe : https://launchpad.net/~sts-sponsor

Re: [Sts-sponsors] [Merge] ~troyanov/maas:vmhost-power-params into maas:master

2022-11-23 Thread Alberto Donato
Review: Approve lgtm, +1 -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/433439 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe : https://launchpad.net/~

[Sts-sponsors] [Merge] ~bjornt/maas:perftest-no-implicit-path into maas:master

2022-11-23 Thread MAAS Lander
The proposal to merge ~bjornt/maas:perftest-no-implicit-path into maas:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433441 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mailing l

[Sts-sponsors] [Merge] ~bjornt/maas:perf-test-dont-measure-setup into maas:master

2022-11-23 Thread Björn Tillenius
Björn Tillenius has proposed merging ~bjornt/maas:perf-test-dont-measure-setup into maas:master. Commit message: Make it move explicit what the measure in the performance tests Before, we measured how long the whole test took to run. That includes any local setup you do in the test, but also the

Re: [Sts-sponsors] [UNITTESTS] -b vmhost-power-params lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS FAILED

2022-11-23 Thread MAAS Lander
Review: Needs Fixing UNIT TESTS -b vmhost-power-params lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: FAILED LOG: http://maas-ci.internal:8080/job/maas-tester/1466/consoleText COMMIT: dc058f8c66b5298a2334ee36d0039061acbc6b93 -- https://code.launchpad.net/~troyanov/m

Re: [Sts-sponsors] [UNITTESTS] -b perf-test-dont-measure-setup lp:~bjornt/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS PASS

2022-11-23 Thread MAAS Lander
Review: Approve UNIT TESTS -b perf-test-dont-measure-setup lp:~bjornt/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: SUCCESS COMMIT: 96600367f4dfa6793f91b5628cb9a4aeb5e46dc2 -- https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433506 Your team MAAS Committers is subscribe

Re: [Sts-sponsors] [Merge] ~alexsander-souza/maas:lp1995624_suppress_script_results into maas:master

2022-11-23 Thread Björn Tillenius
Review: Approve +1 -- https://code.launchpad.net/~alexsander-souza/maas/+git/maas/+merge/433484 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe : https://launchpad.net

[Sts-sponsors] [Merge] ~bjornt/maas:perf-test-no-custom-runner into maas:master

2022-11-23 Thread Björn Tillenius
The proposal to merge ~bjornt/maas:perf-test-no-custom-runner into maas:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433518 -- Your team MAAS Committers is subscribed to branch maas:master.

[Sts-sponsors] [Merge] ~bjornt/maas:perf-test-no-custom-runner into maas:master

2022-11-23 Thread Björn Tillenius
The proposal to merge ~bjornt/maas:perf-test-no-custom-runner into maas:master has been updated. Status: Work in progress => Superseded For more details, see: https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433518 -- Your team MAAS Committers is subscribed to branch maas:master.

[Sts-sponsors] [Merge] ~bjornt/maas:perf-test-no-custom-runner into maas:master

2022-11-23 Thread Björn Tillenius
Björn Tillenius has proposed merging ~bjornt/maas:perf-test-no-custom-runner into maas:master. Commit message: Remove the custom bin/test.perf runner. There's no reason to have a custom test runner. It's better to use pytest directly, so that it's clear how to use it. I also improved the way we

[Sts-sponsors] [Merge] ~bjornt/maas:perf-test-no-custom-runner into maas:master

2022-11-23 Thread Björn Tillenius
Björn Tillenius has proposed merging ~bjornt/maas:perf-test-no-custom-runner into maas:master with ~bjornt/maas:perf-test-dont-measure-setup as a prerequisite. Commit message: Remove the custom bin/test.perf runner. There's no reason to have a custom test runner. It's better to use pytest direc

[Sts-sponsors] [Merge] ~bjornt/maas:perf-test-no-custom-decorator into maas:master

2022-11-23 Thread Björn Tillenius
Björn Tillenius has proposed merging ~bjornt/maas:perf-test-no-custom-decorator into maas:master with ~bjornt/maas:perf-test-dont-measure-setup as a prerequisite. Commit message: Requested reviews: MAAS Maintainers (maas-maintainers) For more details, see: https://code.launchpad.net/~bjorn

[Sts-sponsors] [Merge] ~bjornt/maas:perf-test-no-custom-decorator into maas:master

2022-11-23 Thread Björn Tillenius
The proposal to merge ~bjornt/maas:perf-test-no-custom-decorator into maas:master has been updated. Description changed to: Remove the @perf_test decorator. It's not needed, and it was somewhat broken. It reverted back to a savepoint, unless commit_transaction was true. In that case it simply r

[Sts-sponsors] [Merge] ~bjornt/maas:perf-test-no-custom-decorator into maas:master

2022-11-23 Thread Björn Tillenius
The proposal to merge ~bjornt/maas:perf-test-no-custom-decorator into maas:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433520 -- Your team MAAS Committers is subscribed to branch maas:master. -

[Sts-sponsors] [Merge] ~bjornt/maas:perf-test-dont-measure-setup into maas:master

2022-11-23 Thread Björn Tillenius
The proposal to merge ~bjornt/maas:perf-test-dont-measure-setup into maas:master has been updated. Commit message changed to: Make it more explicit what to measure in the performance tests Before, we measured how long the whole test took to run. That includes any local setup you do in the test,

[Sts-sponsors] [Merge] ~bjornt/maas:perf-test-no-custom-decorator into maas:master

2022-11-23 Thread Björn Tillenius
Björn Tillenius has proposed merging ~bjornt/maas:perf-test-no-custom-decorator into maas:master with ~bjornt/maas:perf-test-dont-measure-setup as a prerequisite. Commit message: Remove the @perf_test decorator. It's not needed, and it was somewhat broken. It reverted back to a savepoint, unles

Re: [Sts-sponsors] [UNITTESTS] -b perf-test-no-custom-runner lp:~bjornt/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS FAILED

2022-11-23 Thread MAAS Lander
Review: Needs Fixing UNIT TESTS -b perf-test-no-custom-runner lp:~bjornt/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: FAILED LOG: http://maas-ci.internal:8080/job/maas-tester/1468/consoleText COMMIT: 98bfd82808af8217788d3c928d8abca27ea833e3 -- https://code.launchpad.net/~bjorn

Re: [Sts-sponsors] [UNITTESTS] -b perf-test-no-custom-decorator lp:~bjornt/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS PASS

2022-11-23 Thread MAAS Lander
Review: Approve UNIT TESTS -b perf-test-no-custom-decorator lp:~bjornt/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: SUCCESS COMMIT: 3334e5ea13472b9b4cf35750598efddac43d123a -- https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433521 Your team MAAS Committers is subscrib

[Sts-sponsors] [Merge] ~alexsander-souza/maas:lp1995624_suppress_script_results into maas:master

2022-11-23 Thread Alexsander de Souza
The proposal to merge ~alexsander-souza/maas:lp1995624_suppress_script_results into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~alexsander-souza/maas/+git/maas/+merge/433484 -- Your team MAAS Committers is subscribed to b

[Sts-sponsors] [Merge] ~alexsander-souza/maas:lp1995624_suppress_script_results into maas:master

2022-11-23 Thread MAAS Lander
The proposal to merge ~alexsander-souza/maas:lp1995624_suppress_script_results into maas:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~alexsander-souza/maas/+git/maas/+merge/433484 -- Your team MAAS Committers is subscribed to branch

[Sts-sponsors] [Merge] ~ack/maas:region-refresh-no-retry into maas:master

2022-11-23 Thread Alberto Donato
Alberto Donato has proposed merging ~ack/maas:region-refresh-no-retry into maas:master. Commit message: disable request retries for controller script results reporting to region The logic used for the refresh is the same used by scrips reporting for machines, but there's no need to retry for con

Re: [Sts-sponsors] [Merge] ~ack/maas:region-refresh-no-retry into maas:master

2022-11-23 Thread Alexsander de Souza
Review: Approve +1 -- https://code.launchpad.net/~ack/maas/+git/maas/+merge/433526 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe : https://launchpad.net/~sts-sponsor

Re: [Sts-sponsors] [UNITTESTS] -b region-refresh-no-retry lp:~ack/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS FAILED

2022-11-23 Thread MAAS Lander
Review: Needs Fixing UNIT TESTS -b region-refresh-no-retry lp:~ack/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: FAILED LOG: http://maas-ci.internal:8080/job/maas-tester/1471/consoleText COMMIT: c52c6b192d2d9305d2874389383b1970afcae784 -- https://code.launchpad.net/~ack/maas/+g

[Sts-sponsors] [Merge] ~ack/maas:region-refresh-no-retry into maas:master

2022-11-23 Thread Alberto Donato
The proposal to merge ~ack/maas:region-refresh-no-retry into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ack/maas/+git/maas/+merge/433526 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mailing lis

Re: [Sts-sponsors] [UNITTESTS] -b perf-test-no-custom-runner lp:~bjornt/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS PASS

2022-11-23 Thread MAAS Lander
Review: Approve UNIT TESTS -b perf-test-no-custom-runner lp:~bjornt/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: SUCCESS COMMIT: ef1801262983fbe58792cee0b6ca7b2998ecd632 -- https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433519 Your team MAAS Committers is subscribed

[Sts-sponsors] [Merge] ~bjornt/maas:perf-test-no-custom-runner into maas:master

2022-11-23 Thread Björn Tillenius
The proposal to merge ~bjornt/maas:perf-test-no-custom-runner into maas:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433519 -- Your team MAAS Committers is subscribed to branch maas:master.

[Sts-sponsors] [Merge] ~ack/maas:region-refresh-no-retry into maas:master

2022-11-23 Thread MAAS Lander
The proposal to merge ~ack/maas:region-refresh-no-retry into maas:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~ack/maas/+git/maas/+merge/433526 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: htt

Re: [Sts-sponsors] [Merge] ~bjornt/maas:perf-test-no-custom-decorator into maas:master

2022-11-23 Thread Alberto Donato
Review: Approve +1 -- https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433521 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe : https://launchpad.net/~sts-spon

[Sts-sponsors] [Merge] ~bjornt/maas:perf-test-no-custom-runner into maas:master

2022-11-23 Thread Björn Tillenius
Björn Tillenius has proposed merging ~bjornt/maas:perf-test-no-custom-runner into maas:master with ~bjornt/maas:perf-test-dont-measure-setup as a prerequisite. Commit message: Remove the custom bin/test.perf runner. There's no reason to have a custom test runner. It's better to use pytest direc

Re: [Sts-sponsors] [Merge] ~bjornt/maas:perf-test-no-custom-runner into maas:master

2022-11-23 Thread Alberto Donato
Review: Approve +1 with a couple nits Diff comments: > diff --git a/Makefile b/Makefile > index 6ddf017..6f826b7 100644 > --- a/Makefile > +++ b/Makefile > @@ -62,7 +61,8 @@ build: \ >.run \ >$(VENV) \ >$(BIN_SCRIPTS) \ > - bin/py > + bin/py \ > + bin/test.perf I would drop this

Re: [Sts-sponsors] [Merge] ~troyanov/maas:vmhost-power-params into maas:master

2022-11-23 Thread Anton Troyanov
jenkins: !test -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/433439 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe : https://launchpad.net/~sts-sponsor

Re: [Sts-sponsors] [UNITTESTS] -b vmhost-power-params lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS PASS

2022-11-23 Thread MAAS Lander
Review: Approve UNIT TESTS -b vmhost-power-params lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: SUCCESS COMMIT: dc058f8c66b5298a2334ee36d0039061acbc6b93 -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/433439 Your team MAAS Committers is subscribed to

[Sts-sponsors] [Merge] ~troyanov/maas:vmhost-power-params into maas:master

2022-11-23 Thread Anton Troyanov
The proposal to merge ~troyanov/maas:vmhost-power-params into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/433439 -- Your team MAAS Committers is subscribed to branch maas:master. -- Maili

[Sts-sponsors] [Merge] ~troyanov/maas:vmhost-power-params into maas:master

2022-11-23 Thread MAAS Lander
The proposal to merge ~troyanov/maas:vmhost-power-params into maas:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/433439 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mailing lis

[Sts-sponsors] [Merge] ~dmascialino/maas-ci/+git/system-tests:write_version_under_test into ~maas-committers/maas-ci/+git/system-tests:master

2022-11-23 Thread Diego Mascialino
Diego Mascialino has proposed merging ~dmascialino/maas-ci/+git/system-tests:write_version_under_test into ~maas-committers/maas-ci/+git/system-tests:master. Commit message: Write version_under_test file Requested reviews: MAAS Committers (maas-committers) For more details, see: https://code

Re: [Sts-sponsors] [Merge] ~dmascialino/maas-ci/+git/system-tests:write_version_under_test into ~maas-committers/maas-ci/+git/system-tests:master

2022-11-23 Thread Alexsander de Souza
Review: Approve LGTM -- https://code.launchpad.net/~dmascialino/maas-ci/+git/system-tests/+merge/433550 Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/system-tests:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.la

Re: [Sts-sponsors] [UNITTESTS] -b write_version_under_test lp:~dmascialino/maas-ci/+git/system-tests into -b master lp:~maas-committers/maas-ci/+git/system-tests - TESTS PASS

2022-11-23 Thread MAAS Lander
Review: Approve UNIT TESTS -b write_version_under_test lp:~dmascialino/maas-ci/+git/system-tests into -b master lp:~maas-committers/maas-ci/+git/system-tests STATUS: SUCCESS COMMIT: f919a573a8a443203762cc325ae993b6eb6c864e -- https://code.launchpad.net/~dmascialino/maas-ci/+git/system-tests/+me

[Sts-sponsors] [Merge] ~dmascialino/maas-ci/+git/system-tests:write_version_under_test into ~maas-committers/maas-ci/+git/system-tests:master

2022-11-23 Thread Diego Mascialino
The proposal to merge ~dmascialino/maas-ci/+git/system-tests:write_version_under_test into ~maas-committers/maas-ci/+git/system-tests:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~dmascialino/maas-ci/+git/system-tests/+merge/433

[Sts-sponsors] [Merge] ~dmascialino/maas-ci/+git/system-tests:write_version_under_test into ~maas-committers/maas-ci/+git/system-tests:master

2022-11-23 Thread MAAS Lander
The proposal to merge ~dmascialino/maas-ci/+git/system-tests:write_version_under_test into ~maas-committers/maas-ci/+git/system-tests:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~dmascialino/maas-ci/+git/system-tests/+merge/433550 --