[Sts-sponsors] [Branch ~maas-committers/maas-ci/+git/dmascialino-maas-ci-config]

2023-01-11 Thread Paul Collins
Name: maas-ci-config => dmascialino-maas-ci-config Git identity: lp:~dmascialino/maas-ci/+git/maas-ci-config => lp:~dmascialino/maas-ci/+git/dmascialino-maas-ci-config -- lp:~maas-committers/maas-ci/+git/dmascialino-maas-ci-config https://code.launchpad.net/~maas-committers/maas-ci/+git/d

[Sts-sponsors] [Branch ~maas-committers/maas-ci/+git/dmascialino-maas-ci-config]

2023-01-11 Thread Paul Collins
Git identity: lp:~dmascialino/maas-ci/+git/dmascialino-maas-ci-config => lp:~maas-committers/maas-ci/+git/dmascialino-maas-ci-config -- lp:~maas-committers/maas-ci/+git/dmascialino-maas-ci-config https://code.launchpad.net/~maas-committers/maas-ci/+git/dmascialino-maas-ci-config You are gett

Re: [Sts-sponsors] [UNITTESTS] -b fix_writing_zonefile_with_correct_permissions lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS PASS

2023-01-11 Thread MAAS Lander
Review: Approve UNIT TESTS -b fix_writing_zonefile_with_correct_permissions lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: SUCCESS COMMIT: 34993c2e1ac1b014f406e9a3015a861f0dbe4ac9 -- https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/435611 Your team MAA

[Sts-sponsors] [Merge] ~cgrabowski/maas:fix_writing_zonefile_with_correct_permissions into maas:master

2023-01-11 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:fix_writing_zonefile_with_correct_permissions into maas:master. Commit message: allow MAAS to overwrite zonefile ownership from BIND Requested reviews: MAAS Maintainers (maas-maintainers) For more details, see: https://code.launchpad

Re: [Sts-sponsors] [UNITTESTS] -b timeout-configuration lp:~emdw/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS PASS

2023-01-11 Thread MAAS Lander
Review: Approve UNIT TESTS -b timeout-configuration lp:~emdw/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: SUCCESS COMMIT: 33a0d89a1dab8e4df194e623a3ce2bd3b3675fad -- https://code.launchpad.net/~emdw/maas/+git/maas/+merge/435525 Your team MAAS Maintainers is requested to review

[Sts-sponsors] [Merge] ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master

2023-01-11 Thread MAAS Lander
The proposal to merge ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/435598 -- Your t

[Sts-sponsors] [Merge] ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master

2023-01-11 Thread Adam Collard
The proposal to merge ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/435598 --

Re: [Sts-sponsors] [Merge] ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master

2023-01-11 Thread Diego Mascialino
Review: Approve nice! there will be easier to follow logs -- https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/435598 Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/system-tests:master. -- Mailing list: https://launchpad.net/~sts-sponso

[Sts-sponsors] [Merge] ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master

2023-01-11 Thread Adam Collard
The proposal to merge ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/435598 --

[Sts-sponsors] [Merge] ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master

2023-01-11 Thread Adam Collard
The proposal to merge ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/435598 --

Re: [Sts-sponsors] [UNITTESTS] -b lxd-logger-name lp:~adam-collard/maas-ci/+git/system-tests into -b master lp:~maas-committers/maas-ci/+git/system-tests - TESTS PASS

2023-01-11 Thread MAAS Lander
Review: Approve UNIT TESTS -b lxd-logger-name lp:~adam-collard/maas-ci/+git/system-tests into -b master lp:~maas-committers/maas-ci/+git/system-tests STATUS: SUCCESS COMMIT: 8944493b14b4bb23670154a5943aaa37f4ee7b3a -- https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/435

[Sts-sponsors] [Merge] ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master

2023-01-11 Thread Adam Collard
Adam Collard has proposed merging ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master. Commit message: Unify name of instance_name lxd: configure named logger for all instance-related LXD ops Requested reviews: MAAS Committers (ma

[Sts-sponsors] [Merge] ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master

2023-01-11 Thread Adam Collard
Adam Collard has proposed merging ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master. Commit message: Unify name of instance_name lxd: configure named logger for all instance-related LXD ops Requested reviews: MAAS Committers (ma

[Sts-sponsors] [Merge] ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master

2023-01-11 Thread Adam Collard
The proposal to merge ~adam-collard/maas-ci/+git/system-tests:lxd-logger-name into ~maas-committers/maas-ci/+git/system-tests:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/435

[Sts-sponsors] [Merge] ~adam-collard/maas:3.3-vault-proxy into maas:3.3

2023-01-11 Thread MAAS Lander
The proposal to merge ~adam-collard/maas:3.3-vault-proxy into maas:3.3 has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/435596 -- Your team MAAS Committers is subscribed to branch maas:3.3. -- Mailing list:

[Sts-sponsors] [Merge] ~mpontillo/maas:pod-vms-as-parents--experimental into maas:master

2023-01-11 Thread Adam Collard
The proposal to merge ~mpontillo/maas:pod-vms-as-parents--experimental into maas:master has been updated. Status: Work in progress => Rejected For more details, see: https://code.launchpad.net/~mpontillo/maas/+git/maas/+merge/358576 -- Your team MAAS Maintainers is requested to review the p

[Sts-sponsors] [Merge] ~adam-collard/maas:3.3-vault-proxy into maas:3.3

2023-01-11 Thread Adam Collard
Adam Collard has proposed merging ~adam-collard/maas:3.3-vault-proxy into maas:3.3. Commit message: LP:2002111 explicitly set proxies for hvac.Client Cherry-pick 79bc358e2 Requested reviews: Adam Collard (adam-collard) Related bugs: Bug #2002111 in MAAS: "Connection to local Vault fails if

[Sts-sponsors] [Merge] ~adam-collard/maas:3.3-vault-proxy into maas:3.3

2023-01-11 Thread Adam Collard
The proposal to merge ~adam-collard/maas:3.3-vault-proxy into maas:3.3 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/435596 -- Your team MAAS Committers is subscribed to branch maas:3.3. -- Mailing

Re: [Sts-sponsors] [Merge] ~adam-collard/maas:3.3-vault-proxy into maas:3.3

2023-01-11 Thread Adam Collard
Review: Approve self-approve backport -- https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/435596 Your team MAAS Committers is subscribed to branch maas:3.3. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe : https://l

Re: [Sts-sponsors] [UNITTESTS] -b undefined-controller-type lp:~lloydwaltersj/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS PASS

2023-01-11 Thread MAAS Lander
Review: Approve UNIT TESTS -b undefined-controller-type lp:~lloydwaltersj/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: SUCCESS COMMIT: 1c7dd7a741dc79cfc1ff30c543592abb3245088a -- https://code.launchpad.net/~lloydwaltersj/maas/+git/maas/+merge/435593 Your team MAAS Maintainers

[Sts-sponsors] [Merge] ~adam-collard/maas:vault-proxy into maas:master

2023-01-11 Thread MAAS Lander
The proposal to merge ~adam-collard/maas:vault-proxy into maas:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/435584 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mailing lis

[Sts-sponsors] [Merge] ~lloydwaltersj/maas:undefined-controller-type into maas:master

2023-01-11 Thread Jack Lloyd-Walters
Jack Lloyd-Walters has proposed merging ~lloydwaltersj/maas:undefined-controller-type into maas:master. Commit message: Fixes 2002550 and introduce test to ensure UI component is found Requested reviews: MAAS Maintainers (maas-maintainers) For more details, see: https://code.launchpad.net/~ll

[Sts-sponsors] [Merge] ~adam-collard/maas:vault-proxy into maas:master

2023-01-11 Thread Adam Collard
The proposal to merge ~adam-collard/maas:vault-proxy into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/435584 -- Your team MAAS Committers is subscribed to branch maas:master. -- Maili

[Sts-sponsors] [Merge] ~adam-collard/maas:vault-proxy into maas:master

2023-01-11 Thread MAAS Lander
The proposal to merge ~adam-collard/maas:vault-proxy into maas:master has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/435584 -- Your team MAAS Committers is subscribed to branch maas:master. -- Maili

Re: [Sts-sponsors] [Merge] -b vault-proxy lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas - LANDING FAILED

2023-01-11 Thread MAAS Lander
LANDING -b vault-proxy lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: FAILED BUILD LOG: http://maas-ci.internal:8080/job/maas-tester/1750/consoleText -- https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/435584 Your team MAAS Committers is subscribed

Re: [Sts-sponsors] [Merge] ~adam-collard/maas:vault-proxy into maas:master

2023-01-11 Thread Adam Collard
jenkins: !test -- https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/435584 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe : https://launchpad.net/~sts-spo

Re: [Sts-sponsors] [UNITTESTS] -b vault-proxy lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS FAILED

2023-01-11 Thread MAAS Lander
Review: Needs Fixing UNIT TESTS -b vault-proxy lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: FAILED LOG: http://maas-ci.internal:8080/job/maas-tester/1749/consoleText COMMIT: 78d46c90dd7c3e2621fc7ba5ab7661057607cafd -- https://code.launchpad.net/~adam-collard/m

[Sts-sponsors] [Merge] ~adam-collard/maas:vault-proxy into maas:master

2023-01-11 Thread Adam Collard
The proposal to merge ~adam-collard/maas:vault-proxy into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/435584 -- Your team MAAS Committers is subscribed to branch maas:master. -- Maili

Re: [Sts-sponsors] [Merge] ~adam-collard/maas:vault-proxy into maas:master

2023-01-11 Thread Adam Collard
Diff comments: > diff --git a/src/maasserver/pytest_tests/test_vault.py > b/src/maasserver/pytest_tests/test_vault.py > index 7277dbb..d0c28e8 100644 > --- a/src/maasserver/pytest_tests/test_vault.py > +++ b/src/maasserver/pytest_tests/test_vault.py > @@ -144,24 +145,54 @@ class TestVaultClien

Re: [Sts-sponsors] [Merge] ~adam-collard/maas:vault-proxy into maas:master

2023-01-11 Thread Alberto Donato
Review: Approve nice, +1 a couple minor nits inline Diff comments: > diff --git a/src/maasserver/pytest_tests/test_vault.py > b/src/maasserver/pytest_tests/test_vault.py > index 7277dbb..d0c28e8 100644 > --- a/src/maasserver/pytest_tests/test_vault.py > +++ b/src/maasserver/pytest_tests/test_v

Re: [Sts-sponsors] [UNITTESTS] -b vault-proxy lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS PASS

2023-01-11 Thread MAAS Lander
Review: Approve UNIT TESTS -b vault-proxy lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: SUCCESS COMMIT: 519a0438bef8f24dd82e7e08d8f5166975d6ddbb -- https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/435584 Your team MAAS Maintainers is requested to

[Sts-sponsors] [Merge] ~adam-collard/maas:vault-proxy into maas:master

2023-01-11 Thread Adam Collard
Adam Collard has proposed merging ~adam-collard/maas:vault-proxy into maas:master. Commit message: LP:2002111 explicitly set proxies for hvac.Client Requested reviews: MAAS Maintainers (maas-maintainers) For more details, see: https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/4

[Sts-sponsors] [Merge] ~bjornt/maas-ci/+git/maas-ci-internal:is-maas-fast-yet-no-trigger into ~maas-committers/maas-ci/+git/maas-ci-internal:main

2023-01-11 Thread MAAS Lander
The proposal to merge ~bjornt/maas-ci/+git/maas-ci-internal:is-maas-fast-yet-no-trigger into ~maas-committers/maas-ci/+git/maas-ci-internal:main has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~bjornt/maas-ci/+git/maas-ci-internal/+merge/435579

Re: [Sts-sponsors] [UNITTESTS] -b is-maas-fast-yet-no-trigger lp:~bjornt/maas-ci/+git/maas-ci-internal into -b main lp:~maas-committers/maas-ci/+git/maas-ci-internal - TESTS PASS

2023-01-11 Thread MAAS Lander
Review: Approve UNIT TESTS -b is-maas-fast-yet-no-trigger lp:~bjornt/maas-ci/+git/maas-ci-internal into -b main lp:~maas-committers/maas-ci/+git/maas-ci-internal STATUS: SUCCESS COMMIT: b39c2ca9298fc33423a0cfa3e54130d95acf66a4 -- https://code.launchpad.net/~bjornt/maas-ci/+git/maas-ci-internal/

[Sts-sponsors] [Merge] ~bjornt/maas-ci/+git/maas-ci-internal:is-maas-fast-yet-no-trigger into ~maas-committers/maas-ci/+git/maas-ci-internal:main

2023-01-11 Thread Björn Tillenius
The proposal to merge ~bjornt/maas-ci/+git/maas-ci-internal:is-maas-fast-yet-no-trigger into ~maas-committers/maas-ci/+git/maas-ci-internal:main has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~bjornt/maas-ci/+git/maas-ci-internal/+merge/

Re: [Sts-sponsors] [Merge] ~bjornt/maas-ci/+git/maas-ci-internal:is-maas-fast-yet-no-trigger into ~maas-committers/maas-ci/+git/maas-ci-internal:main

2023-01-11 Thread Adam Collard
Review: Approve -- https://code.launchpad.net/~bjornt/maas-ci/+git/maas-ci-internal/+merge/435579 Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/maas-ci-internal:main. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launc

[Sts-sponsors] [Merge] ~bjornt/maas-ci/+git/maas-ci-internal:is-maas-fast-yet-no-trigger into ~maas-committers/maas-ci/+git/maas-ci-internal:main

2023-01-11 Thread Björn Tillenius
Björn Tillenius has proposed merging ~bjornt/maas-ci/+git/maas-ci-internal:is-maas-fast-yet-no-trigger into ~maas-committers/maas-ci/+git/maas-ci-internal:main. Commit message: Remove extra trigger for is-maas-fast-yet jobs. There were triggered both by a timer to run daily, but also whenever t

[Sts-sponsors] [Merge] ~adam-collard/maas-ci/+git/system-tests:lxd-status-specific into ~maas-committers/maas-ci/+git/system-tests:master

2023-01-11 Thread MAAS Lander
The proposal to merge ~adam-collard/maas-ci/+git/system-tests:lxd-status-specific into ~maas-committers/maas-ci/+git/system-tests:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/435527 -- Y

[Sts-sponsors] [Merge] ~adam-collard/maas-ci/+git/system-tests:lxd-status-specific into ~maas-committers/maas-ci/+git/system-tests:master

2023-01-11 Thread Adam Collard
The proposal to merge ~adam-collard/maas-ci/+git/system-tests:lxd-status-specific into ~maas-committers/maas-ci/+git/system-tests:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/435527

Re: [Sts-sponsors] [Merge] ~adam-collard/maas-ci/+git/system-tests:lxd-status-specific into ~maas-committers/maas-ci/+git/system-tests:master

2023-01-11 Thread Björn Tillenius
Review: Approve +1 -- https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/435527 Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/system-tests:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.lau

Re: [Sts-sponsors] [Merge] ~seyeongkim/maas:multiple_lan_conf_channel into maas:master

2023-01-11 Thread Jack Lloyd-Walters
Review: Needs Fixing Inline nit, looks good elsewise Diff comments: > diff --git > a/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py > b/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py > index 4964f08..cb721cb 100755 > --- a/src/metadataserver/buil