Alberto Donato has proposed merging ~ack/maas:big-auto-field-default into
maas:master.
Commit message:
switch IDs defaults from AutoField to BigAutoField
This also adds a manual migration to ignore FKs for unmanaged Discovery model,
which otherwise breaks migrations
Requested reviews:
MAA
BigAutoField is the default for projects created with Django 3.2
--
https://code.launchpad.net/~ack/maas/+git/maas/+merge/442177
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Uns
Review: Approve
LGTMWC
Diff comments:
> diff --git a/src/maasserver/models/domain.py b/src/maasserver/models/domain.py
> index a793e01..5dccc9f 100644
> --- a/src/maasserver/models/domain.py
> +++ b/src/maasserver/models/domain.py
> @@ -172,12 +178,11 @@ class Domain(CleanSave, TimestampedModel)
Review: Approve
+1
--
https://code.launchpad.net/~ack/maas/+git/maas/+merge/442177
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~sts-sponsor
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:update-frontend-deps into
maas-site-manager:main.
Commit message:
chore(deps): update all front-end deps
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net/~petermakowski/
Review: Approve code, qa
LGTM
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442178
Your team MAAS Committers is subscribed to branch
~petermakowski/maas-site-manager:update-frontend-deps.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to
Review: Needs Fixing
UNIT TESTS
-b big-auto-field-default lp:~ack/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2462/console
COMMIT: 1f09d039a05bd1078f735d8aa2e437a56feaed44
--
https://code.launchpad.net/~ack/maas/+git/ma
The proposal to merge ~petermakowski/maas-site-manager:update-frontend-deps
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442178
--
Your team MAAS Com
Review: Approve
UNIT TESTS
-b update-frontend-deps lp:~petermakowski/maas-site-manager/+git/site-manager
into -b main lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: 0dfbac66289408e663c33f4931f9388267d6dc94
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-m
Diff comments:
> diff --git a/src/maasserver/models/domain.py b/src/maasserver/models/domain.py
> index a793e01..5dccc9f 100644
> --- a/src/maasserver/models/domain.py
> +++ b/src/maasserver/models/domain.py
> @@ -172,12 +178,11 @@ class Domain(CleanSave, TimestampedModel):
> :ivar objects
The proposal to merge ~petermakowski/maas-site-manager:update-frontend-deps
into maas-site-manager:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442178
--
Your team MAAS Committer
Review: Approve
UNIT TESTS
-b big-auto-field-default lp:~ack/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: 2d258d2bb8386e591dc5c9523edcff4e7350ef32
--
https://code.launchpad.net/~ack/maas/+git/maas/+merge/442177
Your team MAAS Committers is subscribed to branch
The proposal to merge ~ack/maas:big-auto-field-default into maas:master has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ack/maas/+git/maas/+merge/442177
--
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list
The proposal to merge ~ack/maas:big-auto-field-default into maas:master has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~ack/maas/+git/maas/+merge/442177
--
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: http
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: arm64
* Pocket: UPDATES
* State: Failed to build
* Duration: 6 minutes
* Build Log:
https://launchpad.net/~maas-committers/maas/+snap/maas-master/+build/2096760/+files/buildlog_s
* Snap Package: maas-3.4
* Archive: ~maas/ubuntu/3.4-next
* Distroseries: None
* Architecture: ppc64el
* Pocket: UPDATES
* State: Failed to build
* Duration: 6 minutes
* Build Log:
https://launchpad.net/~maas-committers/+snap/maas-3.4/+build/2096757/+files/buildlog_snap_ubuntu_jammy_ppc64e
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: s390x
* Pocket: UPDATES
* State: Failed to build
* Duration: 6 minutes
* Build Log:
https://launchpad.net/~maas-committers/maas/+snap/maas-master/+build/2096762/+files/buildlog_s
Nick De Villiers has proposed merging
~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main.
Commit message:
fix(tokens): Make table header sticky and remove accordion
Requested reviews:
MAAS Committers (maas-committers): code, qa
For more details, see:
https://code.la
Review: Approve
UNIT TESTS
-b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into
-b main lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: 953a6d02e94cd706aea193fe1c229286b1dd74d7
--
https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+m
Review: Needs Fixing
Q.A looks good, I just mentioned some few comments that need attention,
otherwise we're good to go.
Diff comments:
> diff --git a/frontend/src/components/TokensList/TokensList.tsx
> b/frontend/src/components/TokensList/TokensList.tsx
> index 8b93285..f0e4fc6 100644
> --- a
Alexsander de Souza has proposed merging
~alexsander-souza/maas/+git/maas-release-tools:fix_gitrev_match into
~maas-committers/maas/+git/maas-release-tools:main.
Commit message:
match multi-line strings correctly
Requested reviews:
MAAS Lander (maas-lander): unittests
MAAS Committers (maas-
Review: Approve
UNIT TESTS
-b fix_gitrev_match lp:~alexsander-souza/maas/+git/maas-release-tools into -b
main lp:~maas-committers/maas/+git/maas-release-tools
STATUS: SUCCESS
COMMIT: 196c4e55499c20be5f5dd3b2e5cb2c7277d0008a
--
https://code.launchpad.net/~alexsander-souza/maas/+git/maas-release-
Review: Approve
UNIT TESTS
-b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into
-b main lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: c13a6dd72deed1d4f838bcb51ab23cb195c95b97
--
https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+m
Review: Approve
UNIT TESTS
-b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into
-b main lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: 7a0929c0931607c5326ac001fa4956a8e17200fc
--
https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+m
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:remove-region-dialog-MAASENG-1559 into
maas-site-manager:main.
Commit message:
add useSiteQueryData hook
- rename hooks/api to hooks/react-query
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
h
Review: Approve
+`1
--
https://code.launchpad.net/~troyanov/maas-ci/+git/maas-ci-internal/+merge/442171
Your team MAAS Committers is subscribed to branch
~maas-committers/maas-ci/+git/maas-ci-internal:main.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.
Review: Approve
+1
--
https://code.launchpad.net/~alexsander-souza/maas/+git/maas-release-tools/+merge/442199
Your team MAAS Committers is subscribed to branch
~maas-committers/maas/+git/maas-release-tools:main.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@l
This works great, but would be good to get rid of arbitrary height values. Have
you tried using grid with grid-auto-rows on the container?
https://developer.mozilla.org/en-US/docs/Web/CSS/grid-auto-rows
Diff comments:
> diff --git a/frontend/src/components/TokensList/TokensList.tsx
> b/fronten
Review: Approve
UNIT TESTS
-b remove-region-dialog-MAASENG-1559
lp:~petermakowski/maas-site-manager/+git/site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: e4a2b0cfec1ae54e142d4c58e9e618e815022ca3
--
https://code.launchpad.net/~petermakowski/maas-site-manag
The proposal to merge ~troyanov/maas-ci/+git/maas-ci-internal:add-timeouts into
~maas-committers/maas-ci/+git/maas-ci-internal:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~troyanov/maas-ci/+git/maas-ci-internal/+merge/442171
--
Y
The proposal to merge ~troyanov/maas-ci/+git/maas-ci-internal:add-timeouts into
~maas-committers/maas-ci/+git/maas-ci-internal:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~troyanov/maas-ci/+git/maas-ci-internal/+merge/442171
--
Your te
Jones Ogolo has proposed merging
~jonesogolo/maas-site-manager:1561-update-mobile-menu into
maas-site-manager:main.
Commit message:
Added a close menu button on smaller screens
Close nav menu on navlink click
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https:/
The proposal to merge
~alexsander-souza/maas/+git/maas-release-tools:fix_gitrev_match into
~maas-committers/maas/+git/maas-release-tools:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~alexsander-souza/maas/+git/maas-release-tools/+
Alberto Donato has proposed merging
~ack/maas-site-manager:importlib-instead-of-pkg-resources into
maas-site-manager:main.
Commit message:
use importlib.metadata instead of deprecated pkg_resources
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.lau
one first idea inline
Diff comments:
> diff --git a/frontend/src/components/Navigation/Navigation.tsx
> b/frontend/src/components/Navigation/Navigation.tsx
> index 701e93c..1b39a24 100644
> --- a/frontend/src/components/Navigation/Navigation.tsx
> +++ b/frontend/src/components/Navigation/Navigat
Diff comments:
> diff --git
> a/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss
> b/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss
> index f3ee36a..a6b850d 100644
> ---
> a/frontend/src/components/TokensList/components/TokensTable/_Tok
Diff comments:
> diff --git a/frontend/src/components/Navigation/Navigation.tsx
> b/frontend/src/components/Navigation/Navigation.tsx
> index 701e93c..1b39a24 100644
> --- a/frontend/src/components/Navigation/Navigation.tsx
> +++ b/frontend/src/components/Navigation/Navigation.tsx
> @@ -37,6 +
The proposal to merge
~petermakowski/maas-site-manager:remove-region-dialog-MAASENG-1559 into
maas-site-manager:main has been updated.
Commit message changed to:
add useSiteQueryData hook
- rename hooks/api to hooks/react-query
- MAASENG-1500
- MAASENG-1559
For more details, see:
https://code.
The proposal to merge
~petermakowski/maas-site-manager:remove-region-dialog-MAASENG-1559 into
maas-site-manager:main has been updated.
Commit message changed to:
add useSiteQueryData hook
- rename hooks/api to hooks/react-query
For more details, see:
https://code.launchpad.net/~petermakowski/m
The proposal to merge
~petermakowski/maas-site-manager:remove-region-dialog-MAASENG-1559 into
maas-site-manager:main has been updated.
Description changed to:
https://warthogs.atlassian.net/browse/MAASENG-1559
https://warthogs.atlassian.net/browse/MAASENG-1500
QA Steps
go to /sites
select a si
Review: Approve code, qa
LGTM
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442206
Your team MAAS Committers is subscribed to branch
~petermakowski/maas-site-manager:remove-region-dialog-MAASENG-1559.
--
Mailing list: https://launchpad.net/~sts-sponso
Alberto Donato has proposed merging
~ack/maas-ci/+git/maas-ci-internal:fix-readme into
~maas-committers/maas-ci/+git/maas-ci-internal:main.
Commit message:
fix readme
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net/~ack/maas-ci/+git/ma
Review: Approve
--
https://code.launchpad.net/~ack/maas-ci/+git/maas-ci-internal/+merge/442219
Your team MAAS Committers is subscribed to branch
~maas-committers/maas-ci/+git/maas-ci-internal:main.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpa
The proposal to merge ~ack/maas-ci/+git/maas-ci-internal:fix-readme into
~maas-committers/maas-ci/+git/maas-ci-internal:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ack/maas-ci/+git/maas-ci-internal/+merge/442219
--
Your team MAA
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main.
Commit message:
enable stylelint
- fix existing stylelint errors
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net/~petermak
LANDING
-b fix_gitrev_match lp:~alexsander-souza/maas/+git/maas-release-tools into -b
main lp:~maas-committers/maas/+git/maas-release-tools
STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas-release-tools-tester/36/console
--
https://code.launchpad.net/~alexsander-souza/maas/+git/ma
The proposal to merge
~alexsander-souza/maas/+git/maas-release-tools:fix_gitrev_match into
~maas-committers/maas/+git/maas-release-tools:main has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~alexsander-souza/maas/+git/maas-release-tools/+
Diff comments:
> diff --git a/frontend/src/components/Navigation/Navigation.tsx
> b/frontend/src/components/Navigation/Navigation.tsx
> index 701e93c..1b39a24 100644
> --- a/frontend/src/components/Navigation/Navigation.tsx
> +++ b/frontend/src/components/Navigation/Navigation.tsx
> @@ -37,6 +
The proposal to merge ~ack/maas-ci/+git/maas-ci-internal:fix-readme into
~maas-committers/maas-ci/+git/maas-ci-internal:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~ack/maas-ci/+git/maas-ci-internal/+merge/442219
--
Your team MAAS Comm
The proposal to merge
~petermakowski/maas-site-manager:remove-region-dialog-MAASENG-1559 into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442206
--
Your
Review: Approve
UNIT TESTS
-b remove-region-dialog-MAASENG-1559
lp:~petermakowski/maas-site-manager/+git/site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: e8167fbf21fb0b64b96c5148944e13d0a4f71410
--
https://code.launchpad.net/~petermakowski/maas-site-manag
The proposal to merge
~petermakowski/maas-site-manager:remove-region-dialog-MAASENG-1559 into
maas-site-manager:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442206
--
Your team
Review: Approve
UNIT TESTS
-b enable-stylelint lp:~petermakowski/maas-site-manager/+git/site-manager into
-b main lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: a45fcc5d4f5518e2a068498d020cbb33882241e7
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manag
Review: Approve
UNIT TESTS
-b 1561-update-mobile-menu
lp:~jonesogolo/maas-site-manager/+git/maas-site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: 08e2e369f1576523b08cee010cec5bca28218227
--
https://code.launchpad.net/~jonesogolo/maas-site-manager/+git/maa
Review: Approve
UNIT TESTS
-b importlib-instead-of-pkg-resources
lp:~ack/maas-site-manager/+git/site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: abdf3458fb5e00bcb10ea736575ef0001edbad00
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manage
The proposal to merge
~alexsander-souza/maas/+git/maas-release-tools:fix_gitrev_match into
~maas-committers/maas/+git/maas-release-tools:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~alexsander-souza/maas/+git/maas-release-tools/+
The proposal to merge
~alexsander-souza/maas/+git/maas-release-tools:fix_gitrev_match into
~maas-committers/maas/+git/maas-release-tools:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~alexsander-souza/maas/+git/maas-release-tools/+merge/
Alberto Donato has proposed merging ~ack/maas:1914762-install-ovs-testing into
maas:master.
Commit message:
LP:1914762 install openvswitch package for network testing
Requested reviews:
MAAS Lander (maas-lander)
Björn Tillenius (bjornt)
Related bugs:
Bug #1914762 in MAAS: "test network c
Review: Approve
+1
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442213
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:importlib-instead-of-pkg-resources.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@
The proposal to merge ~ack/maas-site-manager:importlib-instead-of-pkg-resources
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442213
--
Your team MAAS Committer
Review: Approve
UNIT TESTS
-b 1914762-install-ovs-testing lp:~ack/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: a0f7206b6fbe98dee8c1cedf8f2190742d963417
--
https://code.launchpad.net/~ack/maas/+git/maas/+merge/442028
Your team MAAS Committers is subscribed to br
61 matches
Mail list logo
