[Sts-sponsors] [Merge] ~ack/maas-site-manager:importlib-instead-of-pkg-resources into maas-site-manager:main

2023-05-03 Thread MAAS Lander
The proposal to merge ~ack/maas-site-manager:importlib-instead-of-pkg-resources into maas-site-manager:main has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442213 -- Your team MAAS Committers is s

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread Thomas Parrott
I've left some comments. Diff comments: > diff --git a/src/maasagent/cmd/netmon/main.go > b/src/maasagent/cmd/netmon/main.go > index e83655f..7b60e83 100644 > --- a/src/maasagent/cmd/netmon/main.go > +++ b/src/maasagent/cmd/netmon/main.go > @@ -1,9 +1,83 @@ > package main > > +/* > + Copy

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main

2023-05-03 Thread Peter Makowski
Diff comments: > diff --git a/frontend/src/_settings.scss b/frontend/src/_settings.scss > index 0588138..bdcb88c 100644 > --- a/frontend/src/_settings.scss > +++ b/frontend/src/_settings.scss > @@ -2,11 +2,9 @@ > > // Vanilla settings: > $grid-max-width: math.div(1920, 16) * 1rem; > - > $b

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main

2023-05-03 Thread Peter Makowski
The proposal to merge ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main has been updated. Commit message changed to: enable stylelint - fix existing stylelint errors via stylelint --fix For more details, see: https://code.launchpad.net/~petermakowski/maas-site-manage

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main

2023-05-03 Thread Nick De Villiers
Diff comments: > diff --git a/frontend/src/_settings.scss b/frontend/src/_settings.scss > index 0588138..bdcb88c 100644 > --- a/frontend/src/_settings.scss > +++ b/frontend/src/_settings.scss > @@ -2,11 +2,9 @@ > > // Vanilla settings: > $grid-max-width: math.div(1920, 16) * 1rem; > - > $b

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main

2023-05-03 Thread Peter Makowski
Diff comments: > diff --git a/frontend/src/_settings.scss b/frontend/src/_settings.scss > index 0588138..bdcb88c 100644 > --- a/frontend/src/_settings.scss > +++ b/frontend/src/_settings.scss > @@ -2,11 +2,9 @@ > > // Vanilla settings: > $grid-max-width: math.div(1920, 16) * 1rem; > - > $b

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main

2023-05-03 Thread Peter Makowski
Diff comments: > diff --git a/frontend/src/_settings.scss b/frontend/src/_settings.scss > index 0588138..bdcb88c 100644 > --- a/frontend/src/_settings.scss > +++ b/frontend/src/_settings.scss > @@ -2,11 +2,9 @@ > > // Vanilla settings: > $grid-max-width: math.div(1920, 16) * 1rem; > - > $b

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main

2023-05-03 Thread Nick De Villiers
Review: Needs Fixing Just a couple of small things I noticed, but lgtm otherwise Diff comments: > diff --git > a/frontend/src/components/base/TablePagination/_TablePagination.scss > b/frontend/src/components/base/TablePagination/_TablePagination.scss > index c663d8f..3c96af4 100644 > --- a/fr

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread Christian Grabowski
> I've left some comments. Thanks Tom. I've pushed an update based on your feedback. -- https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/441702 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-spons

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread Christian Grabowski
Diff comments: > diff --git a/src/maasagent/cmd/netmon/main.go > b/src/maasagent/cmd/netmon/main.go > index e83655f..7b60e83 100644 > --- a/src/maasagent/cmd/netmon/main.go > +++ b/src/maasagent/cmd/netmon/main.go > @@ -1,9 +1,83 @@ > package main > > +/* > + Copyright 2023 Canonical Lt

Re: [Sts-sponsors] [UNITTESTS] -b go_network_discovery lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS FAILED

2023-05-03 Thread MAAS Lander
Review: Needs Fixing UNIT TESTS -b go_network_discovery lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: FAILED LOG: http://maas-ci.internal:8080/job/maas-tester/2467/console COMMIT: a02b7c7391121862bdb0debdb72d2771a181299a -- https://code.launchpad.net/~cgrabowski/

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread Mark Laing
Looks good overall. I've added some suggestions for code style/linters and there is a potential issue where a timestamp will remain unset/zero valued in the caller. Diff comments: > diff --git a/src/maasagent/cmd/netmon/main.go > b/src/maasagent/cmd/netmon/main.go > index e83655f..7b60e83 1006

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main

2023-05-03 Thread Peter Makowski
Diff comments: > diff --git > a/frontend/src/components/base/TablePagination/_TablePagination.scss > b/frontend/src/components/base/TablePagination/_TablePagination.scss > index c663d8f..3c96af4 100644 > --- a/frontend/src/components/base/TablePagination/_TablePagination.scss > +++ b/frontend

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread Mark Laing
Diff comments: > diff --git a/src/maasagent/internal/netmon/service.go > b/src/maasagent/internal/netmon/service.go > index 14ebdc6..11be56a 100644 > --- a/src/maasagent/internal/netmon/service.go > +++ b/src/maasagent/internal/netmon/service.go > @@ -1,3 +1,255 @@ > package netmon > > -fun

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread Christian Grabowski
Diff comments: > diff --git a/src/maasagent/internal/netmon/service.go > b/src/maasagent/internal/netmon/service.go > index 14ebdc6..11be56a 100644 > --- a/src/maasagent/internal/netmon/service.go > +++ b/src/maasagent/internal/netmon/service.go > @@ -1,3 +1,255 @@ > package netmon > > -fun

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main

2023-05-03 Thread Peter Makowski
The proposal to merge ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main has been updated. Description changed to: QA Steps Go to /settings/requests Inspect the pagination input component Verify that the expected browser prefix is present (-moz-appearance) For more d

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main

2023-05-03 Thread Nick De Villiers
Review: Approve code, qa LGTM! -- https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442220 Your team MAAS Committers is subscribed to branch ~petermakowski/maas-site-manager:enable-stylelint. -- Mailing list: https://launchpad.net/~sts-sponsors Post to :

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main

2023-05-03 Thread Peter Makowski
The proposal to merge ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442220 -- Your team MAAS Committ

Re: [Sts-sponsors] [UNITTESTS] -b 1561-update-mobile-menu lp:~jonesogolo/maas-site-manager/+git/maas-site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS PASS

2023-05-03 Thread MAAS Lander
Review: Approve UNIT TESTS -b 1561-update-mobile-menu lp:~jonesogolo/maas-site-manager/+git/maas-site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: SUCCESS COMMIT: abab0de3d13615724c12f68b1e7ef0666bf6ac45 -- https://code.launchpad.net/~jonesogolo/maas-site-manager/+git/maa

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread Christian Grabowski
Diff comments: > diff --git a/src/maasagent/cmd/netmon/main.go > b/src/maasagent/cmd/netmon/main.go > index e83655f..7b60e83 100644 > --- a/src/maasagent/cmd/netmon/main.go > +++ b/src/maasagent/cmd/netmon/main.go > @@ -1,9 +1,83 @@ > package main > > +/* > + Copyright 2023 Canonical Lt

Re: [Sts-sponsors] [UNITTESTS] -b enable-stylelint lp:~petermakowski/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS PASS

2023-05-03 Thread MAAS Lander
Review: Approve UNIT TESTS -b enable-stylelint lp:~petermakowski/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: SUCCESS COMMIT: 9d15b48b27f1e53589b6ba0e2c18543427abd975 -- https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manag

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread Anton Troyanov
Diff comments: > diff --git a/src/maasagent/internal/netmon/service.go > b/src/maasagent/internal/netmon/service.go > index 14ebdc6..11be56a 100644 > --- a/src/maasagent/internal/netmon/service.go > +++ b/src/maasagent/internal/netmon/service.go > @@ -1,3 +1,255 @@ > package netmon > > -fun

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main

2023-05-03 Thread MAAS Lander
The proposal to merge ~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442220 -- Your team MAAS Committers is

Re: [Sts-sponsors] [UNITTESTS] -b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS FAILED

2023-05-03 Thread MAAS Lander
Review: Needs Fixing UNIT TESTS -b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: FAILED LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/570/console COMMIT: c4e0f413093f3fbc893e14ae47e6f42994cff76e

Re: [Sts-sponsors] [UNITTESTS] -b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS FAILED

2023-05-03 Thread MAAS Lander
Review: Needs Fixing UNIT TESTS -b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: FAILED LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/571/console COMMIT: 03bc2ea5db5ada6c0d1b0dfa587eb92d4cd73ad1

[Sts-sponsors] [~ubuntu-esm/ubuntu/esm-apps-updates-staging/xenial] gce-compute-image-packages 20230328.00-0ubuntu1~16.04.0 (Accepted)

2023-05-03 Thread Launchpad PPA
Accepted: OK: gce-compute-image-packages_20230328.00.orig.tar.xz OK: gce-compute-image-packages_20230328.00-0ubuntu1~16.04.0.debian.tar.xz OK: gce-compute-image-packages_20230328.00-0ubuntu1~16.04.0.dsc -> Component: main Section: admin gce-compute-image-packages (20230328.00-0ubuntu1~16.0

Re: [Sts-sponsors] [UNITTESTS] -b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS FAILED

2023-05-03 Thread MAAS Lander
Review: Needs Fixing UNIT TESTS -b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: FAILED LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/572/console COMMIT: 10e159b369c0bf68fa4ce5bd5ac48b213fb9824d

Re: [Sts-sponsors] [UNITTESTS] -b go_network_discovery lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS FAILED

2023-05-03 Thread MAAS Lander
Review: Needs Fixing UNIT TESTS -b go_network_discovery lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: FAILED LOG: http://maas-ci.internal:8080/job/maas-tester/2471/console COMMIT: 1669f216b974e8469cf167a2f4ce1947a1be06dd -- https://code.launchpad.net/~cgrabowski/

Re: [Sts-sponsors] [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

2023-05-03 Thread Peter Makowski
Diff comments: > diff --git a/frontend/src/components/TokensList/_TokensList.scss > b/frontend/src/components/TokensList/_TokensList.scss > index 3171cbd..cf0fca6 100644 > --- a/frontend/src/components/TokensList/_TokensList.scss > +++ b/frontend/src/components/TokensList/_TokensList.scss > @@

Re: [Sts-sponsors] [UNITTESTS] -b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS PASS

2023-05-03 Thread MAAS Lander
Review: Approve UNIT TESTS -b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: SUCCESS COMMIT: 19d0ed29107202eadd38f02394d39fc027d14a5a -- https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+m

[Sts-sponsors] [Merge] ~ack/maas/+git/maas-release-tools:release-status-checks-before into ~maas-committers/maas/+git/maas-release-tools:main

2023-05-03 Thread Alberto Donato
Alberto Donato has proposed merging ~ack/maas/+git/maas-release-tools:release-status-checks-before into ~maas-committers/maas/+git/maas-release-tools:main. Commit message: print out check status before the text (so they're aligned) Requested reviews: MAAS Lander (maas-lander): unittests M

Re: [Sts-sponsors] [Merge] ~ack/maas/+git/maas-release-tools:release-status-checks-before into ~maas-committers/maas/+git/maas-release-tools:main

2023-05-03 Thread Anton Troyanov
Review: Approve -- https://code.launchpad.net/~ack/maas/+git/maas-release-tools/+merge/442256 Your team MAAS Committers is subscribed to branch ~maas-committers/maas/+git/maas-release-tools:main. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.

[Sts-sponsors] [Merge] ~ack/maas/+git/maas-release-tools:release-status-checks-before into ~maas-committers/maas/+git/maas-release-tools:main

2023-05-03 Thread Alberto Donato
The proposal to merge ~ack/maas/+git/maas-release-tools:release-status-checks-before into ~maas-committers/maas/+git/maas-release-tools:main has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ack/maas/+git/maas-release-tools/+merge/442256 -

Re: [Sts-sponsors] [UNITTESTS] -b release-status-checks-before lp:~ack/maas/+git/maas-release-tools into -b main lp:~maas-committers/maas/+git/maas-release-tools - TESTS PASS

2023-05-03 Thread MAAS Lander
Review: Approve UNIT TESTS -b release-status-checks-before lp:~ack/maas/+git/maas-release-tools into -b main lp:~maas-committers/maas/+git/maas-release-tools STATUS: SUCCESS COMMIT: b13d37e63ba780ae770ab79da51f0065bdb96d8c -- https://code.launchpad.net/~ack/maas/+git/maas-release-tools/+merge/4

[Sts-sponsors] [Merge] ~ack/maas/+git/maas-release-tools:release-status-checks-before into ~maas-committers/maas/+git/maas-release-tools:main

2023-05-03 Thread MAAS Lander
The proposal to merge ~ack/maas/+git/maas-release-tools:release-status-checks-before into ~maas-committers/maas/+git/maas-release-tools:main has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~ack/maas/+git/maas-release-tools/+merge/442256 -- You

Re: [Sts-sponsors] [UNITTESTS] -b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS PASS

2023-05-03 Thread MAAS Lander
Review: Approve UNIT TESTS -b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: SUCCESS COMMIT: 44d3bd7ff398be249d2fcc775789f099c5d96dc2 -- https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+m

Re: [Sts-sponsors] [UNITTESTS] -b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS PASS

2023-05-03 Thread MAAS Lander
Review: Approve UNIT TESTS -b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: SUCCESS COMMIT: 5bfdec113d470c480bc06ab31fbe44eec3e0565c -- https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+m

[Sts-sponsors] [Merge] ~jonesogolo/maas-site-manager:1595-pagination-single-direction-media-queries into maas-site-manager:main

2023-05-03 Thread Jones Ogolo
Jones Ogolo has proposed merging ~jonesogolo/maas-site-manager:1595-pagination-single-direction-media-queries into maas-site-manager:main. Commit message: Used single direction media queries for pagination bar styling (mobile-first) Requested reviews: MAAS Committers (maas-committers) For mo

Re: [Sts-sponsors] [UNITTESTS] -b 1595-pagination-single-direction-media-queries lp:~jonesogolo/maas-site-manager/+git/maas-site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS FAIL

2023-05-03 Thread MAAS Lander
Review: Needs Fixing UNIT TESTS -b 1595-pagination-single-direction-media-queries lp:~jonesogolo/maas-site-manager/+git/maas-site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: FAILED LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/577/console COMMIT: 3f60d626

Re: [Sts-sponsors] [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

2023-05-03 Thread Peter Makowski
Diff comments: > diff --git > a/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss > b/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss > index 2dd28ec..1793d8e 100644 > --- > a/frontend/src/components/TokensList/components/TokensTable/_Tok

Re: [Sts-sponsors] [Merge] ~jonesogolo/maas-site-manager:1595-pagination-single-direction-media-queries into maas-site-manager:main

2023-05-03 Thread Nick De Villiers
Small linting error in CI, fix that and you should be good to merge (yarn lint --fix) -- https://code.launchpad.net/~jonesogolo/maas-site-manager/+git/maas-site-manager/+merge/442261 Your team MAAS Committers is requested to review the proposed merge of ~jonesogolo/maas-site-manager:1595-paginat

[Sts-sponsors] [Merge] ~lloydwaltersj/maas-ci/+git/maas-ci-config:fix-external-gh-testers into ~maas-committers/maas-ci/+git/maas-ci-config:master

2023-05-03 Thread Jack Lloyd-Walters
Jack Lloyd-Walters has proposed merging ~lloydwaltersj/maas-ci/+git/maas-ci-config:fix-external-gh-testers into ~maas-committers/maas-ci/+git/maas-ci-config:master. Commit message: add job name to maas-ansible-collection-job-creator Requested reviews: MAAS Committers (maas-committers) For mo

Re: [Sts-sponsors] [Merge] ~lloydwaltersj/maas-ci/+git/maas-ci-config:fix-external-gh-testers into ~maas-committers/maas-ci/+git/maas-ci-config:master

2023-05-03 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~lloydwaltersj/maas-ci/+git/maas-ci-config/+merge/442268 Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/maas-ci-config:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@list

[Sts-sponsors] [Merge] ~lloydwaltersj/maas-ci/+git/maas-ci-config:fix-external-gh-testers into ~maas-committers/maas-ci/+git/maas-ci-config:master

2023-05-03 Thread Jack Lloyd-Walters
The proposal to merge ~lloydwaltersj/maas-ci/+git/maas-ci-config:fix-external-gh-testers into ~maas-committers/maas-ci/+git/maas-ci-config:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~lloydwaltersj/maas-ci/+git/maas-ci-config/+

Re: [Sts-sponsors] [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

2023-05-03 Thread Peter Makowski
Review: Approve -- https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+merge/442192 Your team MAAS Committers is requested to review the proposed merge of ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main. -- Mailing list: https://launchpad.n

[Sts-sponsors] [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

2023-05-03 Thread Nick De Villiers
The proposal to merge ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+merge/442192 -- Your team MAAS Committers i

Re: [Sts-sponsors] [UNITTESTS] -b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS PASS

2023-05-03 Thread MAAS Lander
Review: Approve UNIT TESTS -b adjust-sticky-styling lp:~nickdv99/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: SUCCESS COMMIT: 8c0691cb18f435c31dc8579c682994d11689c3fa -- https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+m

[Sts-sponsors] [Merge] ~lloydwaltersj/maas-ci/+git/maas-ci-config:fix-external-gh-testers into ~maas-committers/maas-ci/+git/maas-ci-config:master

2023-05-03 Thread mp+442268
The proposal to merge ~lloydwaltersj/maas-ci/+git/maas-ci-config:fix-external-gh-testers into ~maas-committers/maas-ci/+git/maas-ci-config:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~lloydwaltersj/maas-ci/+git/maas-ci-config/+merge/

[Sts-sponsors] [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

2023-05-03 Thread MAAS Lander
The proposal to merge ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+merge/442192 -- Your team MAAS Committers is requ

[Sts-sponsors] [Merge] ~troyanov/maas:lint-go-fix into maas:master

2023-05-03 Thread Anton Troyanov
Anton Troyanov has proposed merging ~troyanov/maas:lint-go-fix into maas:master. Commit message: chore: add lint-go-fix target --fix Fix found issues (if it's supported by the linter) List of linters that support Autofix can be found here [0] [0] https://golangci-lint.run/usage/linters/ Requ

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:add-VITE_USE_MOCK_DATA-env-var into maas-site-manager:main

2023-05-03 Thread Peter Makowski
Peter Makowski has proposed merging ~petermakowski/maas-site-manager:add-VITE_USE_MOCK_DATA-env-var into maas-site-manager:main. Commit message: add VITE_USE_MOCK_DATA env var Requested reviews: MAAS Committers (maas-committers) For more details, see: https://code.launchpad.net/~petermakowsk

[Sts-sponsors] [Bug 1915678] Change abandoned on os-brick (stable/stein)

2023-05-03 Thread OpenStack Infra
Change abandoned by "Brian Rosmaita " on branch: stable/stein Review: https://review.opendev.org/c/openstack/os-brick/+/814840 Reason: Stein transitioned to End of Life by change Icf9a539a7b8b and is accepting no more changes. -- You received this bug notification because you are a member of SE

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:add-VITE_USE_MOCK_DATA-env-var into maas-site-manager:main

2023-05-03 Thread Nick De Villiers
Review: Approve LGTM! -- https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442286 Your team MAAS Committers is subscribed to branch ~petermakowski/maas-site-manager:add-VITE_USE_MOCK_DATA-env-var. -- Mailing list: https://launchpad.net/~sts-sponsors Post to

Re: [Sts-sponsors] [UNITTESTS] -b lint-go-fix lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS FAILED

2023-05-03 Thread MAAS Lander
Review: Needs Fixing UNIT TESTS -b lint-go-fix lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: FAILED LOG: http://maas-ci.internal:8080/job/maas-tester/2472/console COMMIT: 700c4cf9d76308c85db6363ba62f36de4710528c -- https://code.launchpad.net/~troyanov/maas/+git/maa

[Sts-sponsors] [Merge] ~ack/maas-site-manager:accepted-sites into maas-site-manager:main

2023-05-03 Thread Alberto Donato
Alberto Donato has proposed merging ~ack/maas-site-manager:accepted-sites into maas-site-manager:main. Commit message: add accepted and created fields to Site, only return accepted ones in /sites Requested reviews: MAAS Committers (maas-committers) For more details, see: https://code.launch

Re: [Sts-sponsors] [Merge] ~troyanov/maas:lint-go-fix into maas:master

2023-05-03 Thread Anton Troyanov
jenkins: !test -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442284 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe : https://launchpad.net/~sts-sponsor

Re: [Sts-sponsors] [UNITTESTS] -b add-VITE_USE_MOCK_DATA-env-var lp:~petermakowski/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS PASS

2023-05-03 Thread MAAS Lander
Review: Approve UNIT TESTS -b add-VITE_USE_MOCK_DATA-env-var lp:~petermakowski/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: SUCCESS COMMIT: 8146ba689135e1b057403ac501f06be37f1ed661 -- https://code.launchpad.net/~petermakowski/maas-site-manager/

Re: [Sts-sponsors] [Merge] ~ack/maas-site-manager:accepted-sites into maas-site-manager:main

2023-05-03 Thread Jack Lloyd-Walters
Review: Approve +1 -- https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442289 Your team MAAS Committers is subscribed to branch ~ack/maas-site-manager:accepted-sites. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:add-VITE_USE_MOCK_DATA-env-var into maas-site-manager:main

2023-05-03 Thread Peter Makowski
The proposal to merge ~petermakowski/maas-site-manager:add-VITE_USE_MOCK_DATA-env-var into maas-site-manager:main has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442286 -- Your te

Re: [Sts-sponsors] [UNITTESTS] -b lint-go-fix lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS PASS

2023-05-03 Thread MAAS Lander
Review: Approve UNIT TESTS -b lint-go-fix lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: SUCCESS COMMIT: 700c4cf9d76308c85db6363ba62f36de4710528c -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442284 Your team MAAS Committers is subscribed to branch m

Re: [Sts-sponsors] [UNITTESTS] -b accepted-sites lp:~ack/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS PASS

2023-05-03 Thread MAAS Lander
Review: Approve UNIT TESTS -b accepted-sites lp:~ack/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: SUCCESS COMMIT: 35db7235676a260ed1bf3e9fb7754485614ca1f4 -- https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442289 Your

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:add-VITE_USE_MOCK_DATA-env-var into maas-site-manager:main

2023-05-03 Thread MAAS Lander
The proposal to merge ~petermakowski/maas-site-manager:add-VITE_USE_MOCK_DATA-env-var into maas-site-manager:main has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442286 -- Your team MAA

[Sts-sponsors] [Bug 1983100] Re: dotnet build intermittently crashes with segfault on Ubuntu 18.04

2023-05-03 Thread Tom Moyer
This updated debdiff (openssl-atexit-v2.debdiff) includes the DEP-3 headers, cleans up the patch names by prepending lp1983100- to each patch, and is rebased on the latest release in bionic-security. ** Description changed: [Impact] Bionic's OpenSSL 1.1.1 package (https://launchpad.net/u

[Sts-sponsors] [Merge] ~ack/maas-site-manager:accepted-sites into maas-site-manager:main

2023-05-03 Thread Alberto Donato
The proposal to merge ~ack/maas-site-manager:accepted-sites into maas-site-manager:main has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442289 -- Your team MAAS Committers is subscribed to b

[Sts-sponsors] [Merge] ~ack/maas-site-manager:accepted-sites into maas-site-manager:main

2023-05-03 Thread MAAS Lander
The proposal to merge ~ack/maas-site-manager:accepted-sites into maas-site-manager:main has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/442289 -- Your team MAAS Committers is subscribed to branch

Re: [Sts-sponsors] [Merge] ~troyanov/maas:lint-go-fix into maas:master

2023-05-03 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442284 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe : https://launchpad.net/~sts-sp

[Sts-sponsors] [Merge] ~troyanov/maas:lint-go-fix into maas:master

2023-05-03 Thread Anton Troyanov
The proposal to merge ~troyanov/maas:lint-go-fix into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442284 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list:

[Sts-sponsors] [Merge] ~troyanov/maas:lint-go-fix into maas:master

2023-05-03 Thread MAAS Lander
The proposal to merge ~troyanov/maas:lint-go-fix into maas:master has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442284 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list:

Re: [Sts-sponsors] [Merge] -b lint-go-fix lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas - LANDING FAILED

2023-05-03 Thread MAAS Lander
LANDING -b lint-go-fix lp:~troyanov/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: FAILED BUILD LOG: http://maas-ci.internal:8080/job/maas-tester/2475/console -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442284 Your team MAAS Committers is subscribed to branch ma

[Sts-sponsors] [Merge] ~troyanov/maas:lint-go-fix into maas:master

2023-05-03 Thread Anton Troyanov
The proposal to merge ~troyanov/maas:lint-go-fix into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442284 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list:

[Sts-sponsors] [Merge] ~troyanov/maas:lint-go-fix into maas:master

2023-05-03 Thread MAAS Lander
The proposal to merge ~troyanov/maas:lint-go-fix into maas:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442284 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https

Re: [Sts-sponsors] [UNITTESTS] -b go_network_discovery lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas - TESTS PASS

2023-05-03 Thread MAAS Lander
Review: Approve UNIT TESTS -b go_network_discovery lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas STATUS: SUCCESS COMMIT: fbffe5122a93c0e7237e62c2faefd3c88372 -- https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/441702 Your team MAAS Committers is subscribe

[Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:go_network_discovery into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/441702 -- Your team MAAS Committers is subscribed to branch maas:master. --

[Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread MAAS Lander
The proposal to merge ~cgrabowski/maas:go_network_discovery into maas:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/441702 -- Your team MAAS Committers is subscribed to branch maas:master. -- Mailin

[Sts-sponsors] [Snap build #2098295] amd64 build of maas-master snap package (maas) in ubuntu jammy-updates

2023-05-03 Thread noreply
* Snap Package: maas-master * Archive: ~maas-committers/ubuntu/latest-deps * Distroseries: None * Architecture: amd64 * Pocket: UPDATES * State: Failed to build * Duration: 6 minutes * Build Log: https://launchpad.net/~maas-committers/maas/+snap/maas-master/+build/2098295/+files/buildlog_s

[Sts-sponsors] [Snap build #2098292] amd64 build of maas-3.4 snap package (maas) in ubuntu jammy-updates

2023-05-03 Thread noreply
* Snap Package: maas-3.4 * Archive: ~maas/ubuntu/3.4-next * Distroseries: None * Architecture: amd64 * Pocket: UPDATES * State: Failed to build * Duration: 6 minutes * Build Log: https://launchpad.net/~maas-committers/+snap/maas-3.4/+build/2098292/+files/buildlog_snap_ubuntu_jammy_amd64_ma

[Sts-sponsors] [Snap build #2098294] ppc64el build of maas-3.4 snap package (maas) in ubuntu jammy-updates

2023-05-03 Thread noreply
* Snap Package: maas-3.4 * Archive: ~maas/ubuntu/3.4-next * Distroseries: None * Architecture: ppc64el * Pocket: UPDATES * State: Failed to build * Duration: 11 minutes * Build Log: https://launchpad.net/~maas-committers/+snap/maas-3.4/+build/2098294/+files/buildlog_snap_ubuntu_jammy_ppc64

[Sts-sponsors] [Snap build #2098298] ppc64el build of maas-master snap package (maas) in ubuntu jammy-updates

2023-05-03 Thread noreply
* Snap Package: maas-master * Archive: ~maas-committers/ubuntu/latest-deps * Distroseries: None * Architecture: ppc64el * Pocket: UPDATES * State: Failed to build * Duration: 11 minutes * Build Log: https://launchpad.net/~maas-committers/maas/+snap/maas-master/+build/2098298/+files/buildlo

[Sts-sponsors] [Snap build #2098299] s390x build of maas-master snap package (maas) in ubuntu jammy-updates

2023-05-03 Thread noreply
* Snap Package: maas-master * Archive: ~maas-committers/ubuntu/latest-deps * Distroseries: None * Architecture: s390x * Pocket: UPDATES * State: Failed to build * Duration: 18 minutes * Build Log: https://launchpad.net/~maas-committers/maas/+snap/maas-master/+build/2098299/+files/buildlog_

[Sts-sponsors] [Snap build #2098296] s390x build of maas-3.4 snap package (maas) in ubuntu jammy-updates

2023-05-03 Thread noreply
* Snap Package: maas-3.4 * Archive: ~maas/ubuntu/3.4-next * Distroseries: None * Architecture: s390x * Pocket: UPDATES * State: Failed to build * Duration: 19 minutes * Build Log: https://launchpad.net/~maas-committers/+snap/maas-3.4/+build/2098296/+files/buildlog_snap_ubuntu_jammy_s390x_m

[Sts-sponsors] [Snap build #2098297] arm64 build of maas-master snap package (maas) in ubuntu jammy-updates

2023-05-03 Thread noreply
* Snap Package: maas-master * Archive: ~maas-committers/ubuntu/latest-deps * Distroseries: None * Architecture: arm64 * Pocket: UPDATES * State: Failed to build * Duration: 22 minutes * Build Log: https://launchpad.net/~maas-committers/maas/+snap/maas-master/+build/2098297/+files/buildlog_

[Sts-sponsors] [Snap build #2098293] arm64 build of maas-3.4 snap package (maas) in ubuntu jammy-updates

2023-05-03 Thread noreply
* Snap Package: maas-3.4 * Archive: ~maas/ubuntu/3.4-next * Distroseries: None * Architecture: arm64 * Pocket: UPDATES * State: Failed to build * Duration: 25 minutes * Build Log: https://launchpad.net/~maas-committers/+snap/maas-3.4/+build/2098293/+files/buildlog_snap_ubuntu_jammy_arm64_m

[Sts-sponsors] [Bug 1983100] Re: dotnet build intermittently crashes with segfault on Ubuntu 18.04

2023-05-03 Thread Heitor Alves de Siqueira
** Changed in: openssl (Ubuntu Bionic) Status: Incomplete => In Progress -- You received this bug notification because you are a member of SE ("STS") Sponsors, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1983100 Title: dotnet build intermittently crashes with