Re: [Sts-sponsors] [Merge] ~seyeongkim/maas:lp1979403_to_3_2 into maas:3.2

Review: Approve +1 -- https://code.launchpad.net/~seyeongkim/maas/+git/maas/+merge/442700 Your team MAAS Committers is subscribed to branch maas:3.2. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

Re: [Sts-sponsors] [Merge] ~ian-may/nvidia-dgx-2:spec-1.5 into nvidia-dgx-2:master

Review: Approve -- https://code.launchpad.net/~ian-may/nvidia-dgx-2/+git/nvidia-dgx-2/+merge/442766 Your team nvidia-dgx-2 is subscribed to branch nvidia-dgx-2:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~ian-may/nvidia-dgx-2:spec-1.5 into nvidia-dgx-2:master

Ian May has proposed merging ~ian-may/nvidia-dgx-2:spec-1.5 into nvidia-dgx-2:master. Requested reviews: nvidia-dgx-2 (nvidia-dgx-2) For more details, see: https://code.launchpad.net/~ian-may/nvidia-dgx-2/+git/nvidia-dgx-2/+merge/442766 -- Your team nvidia-dgx-2 is requested to review the

[Sts-sponsors] [CI build #34361] amd64 CI build of ~maas-committers/maas-ci/+git/system-tests:4af0cc5a738f286204c730af82378c0f5acd3c9b

* Git Repository: ~maas-committers/maas-ci/+git/system-tests * Commit: 4af0cc5a738f286204c730af82378c0f5acd3c9b * Distroseries: ubuntu jammy * Architecture: amd64 * State: Failed to build * Duration: 4 minutes * Build Log:

[Sts-sponsors] [Merge] ~cgrabowski/maas-ci/+git/maas-ci-config:fix_ansible_collections_permissions_issue into ~maas-committers/maas-ci/+git/maas-ci-config:master

The proposal to merge ~cgrabowski/maas-ci/+git/maas-ci-config:fix_ansible_collections_permissions_issue into ~maas-committers/maas-ci/+git/maas-ci-config:master has been updated. Status: Approved => Merged For more details, see:

[Sts-sponsors] [Merge] ~cgrabowski/maas-ci/+git/maas-ci-config:fix_ansible_collections_permissions_issue into ~maas-committers/maas-ci/+git/maas-ci-config:master

The proposal to merge ~cgrabowski/maas-ci/+git/maas-ci-config:fix_ansible_collections_permissions_issue into ~maas-committers/maas-ci/+git/maas-ci-config:master has been updated. Status: Needs review => Approved For more details, see:

Re: [Sts-sponsors] [Merge] ~jonesogolo/maas-site-manager:1548-enrolment-tokens-export-action into maas-site-manager:main

A quick note on `useTokensExportQuery` - I'm not sure react query will be the right solution for handling file downloads. In case you're having issues with it, might make sense to use axios directly. --

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:add-total_machines-key into maas-site-manager:main

Review: Approve +1 -- https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442742 Your team MAAS Committers is subscribed to branch ~petermakowski/maas-site-manager:add-total_machines-key. -- Mailing list: https://launchpad.net/~sts-sponsors Post to :

Re: [Sts-sponsors] [Merge] ~jonesogolo/maas-site-manager:1548-enrolment-tokens-export-action into maas-site-manager:main

I'd suggest adding a static csv file to src/mocks instead of trying to generate it manually. In the mock service worker you'll most likely want to use binary response type https://mswjs.io/docs/recipes/binary-response-type You'd also need to add header for the response to be handled correctly

Re: [Sts-sponsors] [UNITTESTS] -b add-total_machines-key lp:~petermakowski/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS FAILED

Review: Needs Fixing UNIT TESTS -b add-total_machines-key lp:~petermakowski/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: FAILED LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/629/console COMMIT:

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:add-total_machines-key into maas-site-manager:main

Peter Makowski has proposed merging ~petermakowski/maas-site-manager:add-total_machines-key into maas-site-manager:main. Commit message: add total_machines key Requested reviews: MAAS Committers (maas-committers) For more details, see:

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas-ci/+git/maas-ci-config:fix_ansible_collections_permissions_issue into ~maas-committers/maas-ci/+git/maas-ci-config:master

Review: Approve -- https://code.launchpad.net/~cgrabowski/maas-ci/+git/maas-ci-config/+merge/442699 Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/maas-ci-config:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to :

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:polling-frequency-value-MAASENG-1545 into maas-site-manager:main

The proposal to merge ~petermakowski/maas-site-manager:polling-frequency-value-MAASENG-1545 into maas-site-manager:main has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442647 -- Your

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:display-request-errors-MAASENG-1629 into maas-site-manager:main

The proposal to merge ~petermakowski/maas-site-manager:display-request-errors-MAASENG-1629 into maas-site-manager:main has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442646 -- Your

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:fix-validation-message-cutoff-MAASENG-1611 into maas-site-manager:main

> A little bit og the message is still cut off on the tokens page and the bottom > border also goes hidden when the error message is displayed, screenshot below > https://imgur.com/a/MADpezy This is due to the use of fixed height on this page, which will be addressed in

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:MAASENG-1676-requests-endpoint-POST-method into maas-site-manager:main

The proposal to merge ~petermakowski/maas-site-manager:MAASENG-1676-requests-endpoint-POST-method into maas-site-manager:main has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442721 --

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main

Peter Makowski has proposed merging ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main. Commit message: separate context for different views MAASENG-1549 - extract RowSelectionContextProviders - move app context consumer

[Sts-sponsors] [CI build #34184] amd64 CI build of ~maas-committers/maas-ci/+git/system-tests:e96a6ccceae379dd544fdfcbbfd3e36ac0c168ff

* Git Repository: ~maas-committers/maas-ci/+git/system-tests * Commit: e96a6ccceae379dd544fdfcbbfd3e36ac0c168ff * Distroseries: ubuntu jammy * Architecture: amd64 * State: Failed to build * Duration: 4 minutes * Build Log:

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:polling-frequency-value-MAASENG-1545 into maas-site-manager:main

The proposal to merge ~petermakowski/maas-site-manager:polling-frequency-value-MAASENG-1545 into maas-site-manager:main has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442647 --

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:MAASENG-1676-requests-endpoint-POST-method into maas-site-manager:main

The proposal to merge ~petermakowski/maas-site-manager:MAASENG-1676-requests-endpoint-POST-method into maas-site-manager:main has been updated. Status: Needs review => Approved For more details, see:

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main

The proposal to merge ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main has been updated. Status: Needs review => Work in progress For more details, see:

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:display-request-errors-MAASENG-1629 into maas-site-manager:main

The proposal to merge ~petermakowski/maas-site-manager:display-request-errors-MAASENG-1629 into maas-site-manager:main has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442646 --

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:MAASENG-1676-requests-endpoint-POST-method into maas-site-manager:main

Review: Approve code, qa LGTM -- https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442721 Your team MAAS Committers is subscribed to branch ~petermakowski/maas-site-manager:MAASENG-1676-requests-endpoint-POST-method. -- Mailing list:

Re: [Sts-sponsors] [UNITTESTS] -b separate-context-providers-for-different-views-MAASENG-1549 lp:~petermakowski/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager -

Review: Needs Fixing UNIT TESTS -b separate-context-providers-for-different-views-MAASENG-1549 lp:~petermakowski/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: FAILED LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/623/console

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main

Peter Makowski has proposed merging ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main. Commit message: separate context for different views MAASENG-1549 - extract RowSelectionContextProviders - move app context consumer

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:polling-frequency-value-MAASENG-1545 into maas-site-manager:main

Review: Approve code, qa LGTM -- https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442647 Your team MAAS Committers is subscribed to branch ~petermakowski/maas-site-manager:display-request-errors-MAASENG-1629. -- Mailing list:

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:display-request-errors-MAASENG-1629 into maas-site-manager:main

Review: Approve code, qa LGTM -- https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442646 Your team MAAS Committers is subscribed to branch ~petermakowski/maas-site-manager:display-request-errors-MAASENG-1629. -- Mailing list:

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:fix-validation-message-cutoff-MAASENG-1611 into maas-site-manager:main

Review: Needs Fixing qa A little bit og the message is still cut off on the tokens page and the bottom border also goes hidden when the error message is displayed, screenshot below https://imgur.com/a/MADpezy Diff comments: > diff --git

Re: [Sts-sponsors] [UNITTESTS] -b MAASENG-1676-requests-endpoint-POST-method lp:~petermakowski/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS PASS

Review: Approve UNIT TESTS -b MAASENG-1676-requests-endpoint-POST-method lp:~petermakowski/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager STATUS: SUCCESS COMMIT: 5d8dfd6c597ec95874ec805777e050c71a4b771f --

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:MAASENG-1676-requests-endpoint-POST-method into maas-site-manager:main

The proposal to merge ~petermakowski/maas-site-manager:MAASENG-1676-requests-endpoint-POST-method into maas-site-manager:main has been updated. Description changed to: QA Steps Go to /settings/requests Select a few requests Press Accept or Deny Verify the correct API call has been made using

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:MAASENG-1676-requests-endpoint-POST-method into maas-site-manager:main

Peter Makowski has proposed merging ~petermakowski/maas-site-manager:MAASENG-1676-requests-endpoint-POST-method into maas-site-manager:main. Commit message: use POST method for requests MAASENG-1676 Requested reviews: MAAS Committers (maas-committers) For more details, see: