[Sts-sponsors] [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

2023-05-03 Thread MAAS Lander
The proposal to merge ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+merge/442192 -- Your team MAAS Committers is

[Sts-sponsors] [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

2023-05-03 Thread Nick De Villiers
The proposal to merge ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+merge/442192 -- Your team MAAS Committers

Re: [Sts-sponsors] [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

2023-05-03 Thread Peter Makowski
Review: Approve -- https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+merge/442192 Your team MAAS Committers is requested to review the proposed merge of ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main. -- Mailing list:

Re: [Sts-sponsors] [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

2023-05-03 Thread Peter Makowski
Diff comments: > diff --git > a/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss > b/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss > index 2dd28ec..1793d8e 100644 > --- >

Re: [Sts-sponsors] [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

2023-05-03 Thread Peter Makowski
Diff comments: > diff --git a/frontend/src/components/TokensList/_TokensList.scss > b/frontend/src/components/TokensList/_TokensList.scss > index 3171cbd..cf0fca6 100644 > --- a/frontend/src/components/TokensList/_TokensList.scss > +++ b/frontend/src/components/TokensList/_TokensList.scss >

Re: [Sts-sponsors] [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

2023-05-02 Thread Nick De Villiers
Diff comments: > diff --git > a/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss > b/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss > index f3ee36a..a6b850d 100644 > --- >

Re: [Sts-sponsors] [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

2023-05-02 Thread Peter Makowski
This works great, but would be good to get rid of arbitrary height values. Have you tried using grid with grid-auto-rows on the container? https://developer.mozilla.org/en-US/docs/Web/CSS/grid-auto-rows Diff comments: > diff --git a/frontend/src/components/TokensList/TokensList.tsx >

Re: [Sts-sponsors] [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

2023-05-02 Thread Jones Ogolo
Review: Needs Fixing Q.A looks good, I just mentioned some few comments that need attention, otherwise we're good to go. Diff comments: > diff --git a/frontend/src/components/TokensList/TokensList.tsx > b/frontend/src/components/TokensList/TokensList.tsx > index 8b93285..f0e4fc6 100644 > ---

[Sts-sponsors] [Merge] ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main

2023-05-02 Thread Nick De Villiers
Nick De Villiers has proposed merging ~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main. Commit message: fix(tokens): Make table header sticky and remove accordion Requested reviews: MAAS Committers (maas-committers): code, qa For more details, see: