The proposal to merge
~petermakowski/maas-site-manager:fix-validation-message-cutoff-MAASENG-1611
into maas-site-manager:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442634
--
The proposal to merge
~petermakowski/maas-site-manager:fix-validation-message-cutoff-MAASENG-1611
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve code, qa
Sure, if we're not updating the select label in this MP, than the changes are
good to go
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442634
Your team MAAS Committers is subscribed to branch
> A little bit og the message is still cut off on the tokens page and the bottom
> border also goes hidden when the error message is displayed, screenshot below
> https://imgur.com/a/MADpezy
This is due to the use of fixed height on this page, which will be addressed in
Review: Needs Fixing qa
A little bit og the message is still cut off on the tokens page and the bottom
border also goes hidden when the error message is displayed, screenshot below
https://imgur.com/a/MADpezy
Diff comments:
> diff --git
The proposal to merge
~petermakowski/maas-site-manager:fix-validation-message-cutoff-MAASENG-1611
into maas-site-manager:main has been updated.
Description changed to:
QA Steps
Enter an invalid value into current page input field
Verify that the error message is displayed correctly
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:fix-validation-message-cutoff-MAASENG-1611
into maas-site-manager:main.
Commit message:
fix: validation message cutoff MAASENG-1611
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
7 matches
Mail list logo
