The proposal to merge
~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549
into maas-site-manager:main has been updated.
Status: Approved => Merged
For more details, see:
The proposal to merge
~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
Diff comments:
> diff --git a/frontend/src/components/MainLayout/MainLayout.tsx
> b/frontend/src/components/MainLayout/MainLayout.tsx
> index 9be3fca..3fe61c0 100644
> --- a/frontend/src/components/MainLayout/MainLayout.tsx
> +++ b/frontend/src/components/MainLayout/MainLayout.tsx
> @@ -19,21
Review: Approve code, qa
Looks good, just one question down in the diff
Diff comments:
> diff --git a/frontend/src/components/MainLayout/MainLayout.tsx
> b/frontend/src/components/MainLayout/MainLayout.tsx
> index 9be3fca..3fe61c0 100644
> ---
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549
into maas-site-manager:main.
Commit message:
separate context for different views MAASENG-1549
- extract RowSelectionContextProviders
- move app context consumer
The proposal to merge
~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549
into maas-site-manager:main has been updated.
Status: Needs review => Work in progress
For more details, see:
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549
into maas-site-manager:main.
Commit message:
separate context for different views MAASENG-1549
- extract RowSelectionContextProviders
- move app context consumer
7 matches
Mail list logo