[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main

2023-05-16 Thread MAAS Lander
The proposal to merge ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main has been updated. Status: Approved => Merged For more details, see:

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main

2023-05-16 Thread Peter Makowski
The proposal to merge ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main has been updated. Status: Needs review => Approved For more details, see:

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main

2023-05-16 Thread Peter Makowski
Diff comments: > diff --git a/frontend/src/components/MainLayout/MainLayout.tsx > b/frontend/src/components/MainLayout/MainLayout.tsx > index 9be3fca..3fe61c0 100644 > --- a/frontend/src/components/MainLayout/MainLayout.tsx > +++ b/frontend/src/components/MainLayout/MainLayout.tsx > @@ -19,21

Re: [Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main

2023-05-16 Thread Nick De Villiers
Review: Approve code, qa Looks good, just one question down in the diff Diff comments: > diff --git a/frontend/src/components/MainLayout/MainLayout.tsx > b/frontend/src/components/MainLayout/MainLayout.tsx > index 9be3fca..3fe61c0 100644 > ---

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main

2023-05-12 Thread Peter Makowski
Peter Makowski has proposed merging ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main. Commit message: separate context for different views MAASENG-1549 - extract RowSelectionContextProviders - move app context consumer

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main

2023-05-12 Thread Peter Makowski
The proposal to merge ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main has been updated. Status: Needs review => Work in progress For more details, see:

[Sts-sponsors] [Merge] ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main

2023-05-12 Thread Peter Makowski
Peter Makowski has proposed merging ~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549 into maas-site-manager:main. Commit message: separate context for different views MAASENG-1549 - extract RowSelectionContextProviders - move app context consumer