Re: Install instructions

2013-12-17 Thread Dazed_75
Yep, removing that trailing backslash fixed it for me too. Thanks! On Tue, Dec 17, 2013 at 12:22 PM, Sergey Starosek wrote: > On Tue, Dec 17, 2013 at 8:05 PM, Dirk Hohndel wrote: > >> Please edit the subsurface-install.pri file on your system, find the >> section above and remove the '\' at

Re: Install instructions

2013-12-17 Thread Dirk Hohndel
On Tue, 2013-12-17 at 18:13 +, Tim Wootton wrote: > On 17/12/13 17:31, Dirk Hohndel wrote > > > > And I can already see why... and this makes me wonder why this works on > > my systems... > > > > Please edit the subsurface-install.pri file on your system, find the > > section above and remove t

Re: Install instructions

2013-12-17 Thread Sergey Starosek
On Tue, Dec 17, 2013 at 8:05 PM, Dirk Hohndel wrote: > Please edit the subsurface-install.pri file on your system, find the > section above and remove the '\' at the very end of > > MANDIR = $(DATADIR)/man/man1$${nl}\ > > run qmake again and see what happens :-) > > Bisecting led me to commit ca

Re: Install instructions

2013-12-17 Thread Tim Wootton
On 17/12/13 17:31, Dirk Hohndel wrote > > And I can already see why... and this makes me wonder why this works on > my systems... > > Please edit the subsurface-install.pri file on your system, find the > section above and remove the '\' at the very end of > > MANDIR = $(DATADIR)/man/man1$${nl}\ >

Re: Install instructions

2013-12-17 Thread Tim Wootton
On 17/12/13 17:31, Dirk Hohndel wrote > subsurface-install.pri is read by qmake. > > It looks to me as if the qmake version of your OS is hosed. > Are you running Debian sid by any chance? > > /D > > > > ___ > subsurface mailing list > subsurface@hohndel.

Re: Install instructions

2013-12-17 Thread Dirk Hohndel
On Tue, 2013-12-17 at 17:58 +, Tim Wootton wrote: > On 17/12/13 17:31, Dirk Hohndel wrote > > subsurface-install.pri is read by qmake. > > > > It looks to me as if the qmake version of your OS is hosed. > > Are you running Debian sid by any chance? > I have 2 subversion build directories on my

Re: Install instructions

2013-12-17 Thread Tim Wootton
On 17/12/13 17:49, Dirk Hohndel wrote: > > OK - so this is broken. > > Frustrating that no one has noticed this in the 2.5 months we have used > qmake until AFTER a release. Not so surprising as it's more recent that. The problem wasn't there in 3.9.2-157-gd06eaf4efd39. Not sure I'll be able to p

Re: Install instructions

2013-12-17 Thread Dazed_75
On Tue, Dec 17, 2013 at 10:49 AM, Dirk Hohndel wrote: > On Tue, 2013-12-17 at 17:21 +, Tim Wootton wrote: > > On 17/12/13 14:33, Dirk Hohndel wrote: > > > > > > This means that not only 'prefix' is missing - something is completely > > > hosed: > > > > > > BINDIR = $(prefix)/bin > > > DATAD

Re: Install instructions

2013-12-17 Thread Dirk Hohndel
On Tue, 2013-12-17 at 17:21 +, Tim Wootton wrote: > On 17/12/13 14:33, Dirk Hohndel wrote: > > > > This means that not only 'prefix' is missing - something is completely > > hosed: > > > > BINDIR = $(prefix)/bin > > DATADIR = $(prefix)/share > > DESKTOPDIR = $(DATADIR)/applications > > > >

Re: Install instructions

2013-12-17 Thread Tim Wootton
On 17/12/13 14:33, Dirk Hohndel wrote: > > This means that not only 'prefix' is missing - something is completely > hosed: > > BINDIR = $(prefix)/bin > DATADIR = $(prefix)/share > DESKTOPDIR = $(DATADIR)/applications > > Those two install instructions above install into BINDIR and DESKTOPDIR >

Re: Install instructions

2013-12-17 Thread Dazed_75
On Tue, Dec 17, 2013 at 10:31 AM, Dirk Hohndel wrote: > On Tue, 2013-12-17 at 10:26 -0700, Dazed_75 wrote: > > > > > > > This means that not only 'prefix' is missing - something is > > completely > > hosed: > > > > BINDIR = $(prefix)/bin > > DATADIR = $(p

Re: Install instructions

2013-12-17 Thread Dirk Hohndel
On Tue, 2013-12-17 at 10:26 -0700, Dazed_75 wrote: > > > This means that not only 'prefix' is missing - something is > completely > hosed: > > BINDIR = $(prefix)/bin > DATADIR = $(prefix)/share > DESKTOPDIR = $(DATADIR)/

Re: Install instructions

2013-12-17 Thread Dazed_75
On Tue, Dec 17, 2013 at 7:33 AM, Dirk Hohndel wrote: > On Tue, 2013-12-17 at 15:14 +0100, Robert Helling wrote: > > On 17.12.2013, at 05:16, Dazed_75 wrote: > > > > > That makes no sense. Which options did you call qmake with? > > > Which platform is this on? > > > > > > No options at all as sho

Re: [PATCH] Files: fix a path encoding issue on Windows

2013-12-17 Thread Lubomir I. Ivanov
On 17 December 2013 19:26, Lubomir I. Ivanov wrote: > if someone has better ideas, or corrections please share them. typo. > i probably start making these changes tomorrow morning GMT. > i *can probably.. lubomir -- ___ subsurface mailing list subsur

Re: [PATCH] Files: fix a path encoding issue on Windows

2013-12-17 Thread Lubomir I. Ivanov
On 17 December 2013 18:40, Thiago Macieira wrote: > On terça-feira, 17 de dezembro de 2013 06:48:51, Dirk Hohndel wrote: >> Thiago, can I get an ACK from you for this patch, please? > > ACK, but incomplete. > > There are other places where we encode filenames to 8-bit. We should: > > - ensure tha

Re: [PATCH] Files: fix a path encoding issue on Windows

2013-12-17 Thread Thiago Macieira
On terça-feira, 17 de dezembro de 2013 06:48:51, Dirk Hohndel wrote: > Thiago, can I get an ACK from you for this patch, please? ACK, but incomplete. There are other places where we encode filenames to 8-bit. We should: - ensure that all file names are encoded with QFile::encodeName and decoded

Re: [PATCH] Files: fix a path encoding issue on Windows

2013-12-17 Thread Dirk Hohndel
Thiago, can I get an ACK from you for this patch, please? /D On Tue, 2013-12-17 at 16:10 +0200, Lubomir I. Ivanov wrote: > From: "Lubomir I. Ivanov" > > The Qt frontend currently uses a C backend e.g. file.c, > but Windows does things it's own way and we cannot quite > relly on methods such as

Re: Install instructions

2013-12-17 Thread Dirk Hohndel
On Tue, 2013-12-17 at 15:14 +0100, Robert Helling wrote: > On 17.12.2013, at 05:16, Dazed_75 wrote: > > > That makes no sense. Which options did you call qmake with? > > Which platform is this on? > > > > No options at all as shown on the "Building" page. I used qmake rather > > than qmake-qt4

Re: Install instructions

2013-12-17 Thread Robert Helling
On 17.12.2013, at 05:16, Dazed_75 wrote: > That makes no sense. Which options did you call qmake with? > Which platform is this on? > > No options at all as shown on the "Building" page. I used qmake rather than > qmake-qt4 although both executables are present. Same here (on my old debian b

[PATCH] Files: fix a path encoding issue on Windows

2013-12-17 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" The Qt frontend currently uses a C backend e.g. file.c, but Windows does things it's own way and we cannot quite relly on methods such as open() to work for paths with special characters. A solution for that is to always pass UTF-8 encoded filenames (that may eventually

Fwd: [PATCH] Files: fix a path encoding issue on Windows

2013-12-17 Thread Lubomir I. Ivanov
resent to the mailing list... -- Forwarded message -- From: Lubomir I. Ivanov Date: 17 December 2013 15:11 Subject: Re: [PATCH] Files: fix a path encoding issue on Windows To: "Lubomir I. Ivanov" Cc: Thiago Macieira On 17 December 2013 15:05, Lubomir I. Ivanov wrote: > From:

Re: Install instructions

2013-12-17 Thread Tim Wootton
On 17/12/13 08:10, Jef Driesen wrote: > On 2013-12-17 01:07, Dirk Hohndel wrote: >> >> Jef, what else is required? >> >> Debian: libtool autoconf >> Fedora: libtool autoconf > > Automake is required too, although it may already be installed > automatically as a dependency of the other packages. Not

Re: Install instructions

2013-12-17 Thread Jef Driesen
On 2013-12-17 01:07, Dirk Hohndel wrote: On Tue, 2013-12-17 at 00:28 +0100, Jef Driesen wrote: On 17-12-13 00:03, Dazed_75 wrote: > Just a reminder that no one has ever provided a fix for the problem > originally reported. That being that if one wishes to build > libdivecomputer in Linux, the d