Re: Everyone please read.... Re: GSOC 2014 is almost here - Volunteer mentors needed

2014-02-08 Thread Miika Turkia
On Sun, Feb 9, 2014 at 2:48 AM, Dirk Hohndel wrote: > And of course, MORE IDEAS ARE STILL WELCOME. > I do have an idea that would bring HTML into the mix. It would also need C++ skills. Is this seen as useful addition? Exporting HTML logbook Brief Explanation: Export the log book into HTML a

Re: Some code clean-ups.

2014-02-08 Thread Boris Barbulovski
Sorry for that. For some unknown reason for me the sign line was not there. Now I run with "--signoff" parameter('git format-patch master..devel --signoff') and I can see the sign in the file. I hope I did it right this time. :) br, Boris.. On Sun, Feb 9, 2014 at 5:06 AM, Dirk Hohndel wrote

Re: Some code clean-ups.

2014-02-08 Thread Dirk Hohndel
I liked all of the patches, but they are all missing your Signed-Off-By: line... /D On Sun, 2014-02-09 at 00:17 +0100, Boris Barbulovski wrote: > More code clean-ups mainly regarding static instance() member. > > > br, Boris.. > > ___ > subsurface m

Everyone please read.... Re: GSOC 2014 is almost here - Volunteer mentors needed

2014-02-08 Thread Dirk Hohndel
On Sat, 2014-02-08 at 14:48 -0800, Dirk Hohndel wrote: > On Sat, 2014-02-08 at 16:46 -0600, Kunda Loves Scribus wrote: > > > Awesome! > > I've added a Mentor: field to the wiki. Check out Screenshot > > (http://imgur.com/tdnFwnZ) > > Now we just need to divvy up the names between the proposed proj

Some code clean-ups.

2014-02-08 Thread Boris Barbulovski
More code clean-ups mainly regarding static instance() member. br, Boris.. From 4535eeb65e2aad9e7ae7dda86fc7b52eb2b1c322 Mon Sep 17 00:00:00 2001 From: Boris Barbulovski Date: Sat, 8 Feb 2014 20:12:13 +0100 Subject: [PATCH 1/4] PrintDialog class cleanup. * Remove static PrintDialog::instance() m

Re: GSOC 2014 is almost here - Volunteer mentors needed

2014-02-08 Thread Dirk Hohndel
On Sat, 2014-02-08 at 16:46 -0600, Kunda Loves Scribus wrote: > Awesome! > I've added a Mentor: field to the wiki. Check out Screenshot > (http://imgur.com/tdnFwnZ) > Now we just need to divvy up the names between the proposed projects. I'll do a first stab on this one - I didn't realize we neede

Re: GSOC 2014 is almost here - Volunteer mentors needed

2014-02-08 Thread Kunda Loves Scribus
On Sat, Feb 8, 2014 at 4:39 PM, Dirk Hohndel wrote: > On Sat, 2014-02-08 at 16:33 -0600, Kunda Loves Scribus wrote: > > Most of the GSOC requirements have been met. I don't see anything > > missing except for a major lack of mentors. > > http://trac.hohndel.org/wiki/Gsoc_2014 > > I think we are c

Re: GSOC 2014 is almost here - Volunteer mentors needed

2014-02-08 Thread Dirk Hohndel
On Sat, 2014-02-08 at 16:33 -0600, Kunda Loves Scribus wrote: > Most of the GSOC requirements have been met. I don't see anything > missing except for a major lack of mentors. > http://trac.hohndel.org/wiki/Gsoc_2014 I think we are close. The following people have been pressed into service, errr,

Re: GSOC 2014 is almost here - Volunteer mentors needed

2014-02-08 Thread Kunda Loves Scribus
Most of the GSOC requirements have been met. I don't see anything missing except for a major lack of mentors. http://trac.hohndel.org/wiki/Gsoc_2014 The end date is Feb 14th. If you are thinking about mentoring let yourself be heard now. Also another requirement is that the mentoring organization

Re: SubsurfaceAbout class cleanup.

2014-02-08 Thread Boris Barbulovski
I will do better job in commit messages in the future. On Sat, Feb 8, 2014 at 5:06 PM, Dirk Hohndel wrote: > On Sat, 2014-02-08 at 08:50 +0100, Boris Barbulovski wrote: > > > > > > An SubsurfaceAbout class cleanup. > > > > > > Main change is that now SubsurfaceAbout doesn't have instance object

[PATCH] Load preferences before they are saved.

2014-02-08 Thread Michael Andreen
Load all the settings in the PreferenceDialog constructor. Previously all the settings were overwritten with default values the first time PreferencesDialog::syncSettings() was called. Signed-off-by: Michael Andreen --- qt-ui/preferences.cpp | 10 +- qt-ui/preferences.h | 1 + 2 files

Re: GSOC 2014 is almost here - Volunteer mentors needed

2014-02-08 Thread Dirk Hohndel
On Feb 8, 2014, at 8:56 AM, Robert C. Helling wrote: > Dirk, > >> Am 08.02.2014 um 17:51 schrieb Dirk Hohndel : >> >> I take this to mean that no one is actually interested in doing this. > > Did you see my comments/questions regarding this a couple of days ago on irc? > > In particular whe

Re: GSOC 2014 is almost here - Volunteer mentors needed

2014-02-08 Thread Dirk Hohndel
No one edited the wiki, no one except for the people that I personally pushed volunteered. I take this to mean that no one is actually interested in doing this. Kinda disappointing - this could have brought us new contributors and long wanted contributions. /D On Sun, 2014-01-26 at 09:32 -0800

well deserved and long overdue commit

2014-02-08 Thread Dirk Hohndel
Just pushed that commit... enough said. /D commit 2a3a1c1b412ea3da896c21840e07662002197dd0 Author: Dirk Hohndel Date: Sat Feb 8 08:19:37 2014 -0800 Long over-due change to the About text Giving Tomaz the credit he deserves. Signed-off-by: Dirk Hohndel diff --git a/qt

Re: SubsurfaceAbout class cleanup.

2014-02-08 Thread Dirk Hohndel
On Sat, 2014-02-08 at 08:50 +0100, Boris Barbulovski wrote: > > > An SubsurfaceAbout class cleanup. > > > Main change is that now SubsurfaceAbout doesn't have instance object, > but it constructs and destructs dynamically. Based on Tomaz' ACK I have taken the patch... > If small patch it's ac

Re: SubsurfaceAbout class cleanup.

2014-02-08 Thread Tomaz Canabrava
On Sat, Feb 8, 2014 at 1:07 PM, Dirk Hohndel wrote: > > It was my understanding that we wanted to have the instance classes to > avoid having multiple class objects by mistake and to avoid creating and > destroying these objects at the wrong moment. > that was one of the reasons I created them t

Re: SubsurfaceAbout class cleanup.

2014-02-08 Thread Dirk Hohndel
It was my understanding that we wanted to have the instance classes to avoid having multiple class objects by mistake and to avoid creating and destroying these objects at the wrong moment. So I'm confused why we would now remove them? /D On Sat, 2014-02-08 at 09:03 -0200, Tomaz Canabrava wrote

Re: [PATCH 1/2] Add support for Shearwater Desktop XML logs

2014-02-08 Thread Miika Turkia
Fixes #432 On Sat, Feb 8, 2014 at 2:00 PM, Miika Turkia wrote: > Signed-off-by: Miika Turkia > --- > subsurface.qrc | 1 + > xslt/commonTemplates.xsl | 40 + > xslt/shearwater.xslt | 110 > +++ > 3 files changed, 151

[PATCH 1/2] Add support for Shearwater Desktop XML logs

2014-02-08 Thread Miika Turkia
Signed-off-by: Miika Turkia --- subsurface.qrc | 1 + xslt/commonTemplates.xsl | 40 + xslt/shearwater.xslt | 110 +++ 3 files changed, 151 insertions(+) create mode 100644 xslt/shearwater.xslt diff --git a/subsurface.

[PATCH 2/2] Check XML attribute to detect correct XSLT

2014-02-08 Thread Miika Turkia
Very few dive log files can be identified by the name of the root element in the XML log. As same element names are used between different software, we need to use attributes as well to identify correct XSLT to convert the log to Subsurface format. I would not be surprised if at some point we'll ju

Re: SubsurfaceAbout class cleanup.

2014-02-08 Thread Tomaz Canabrava
I don't mind removing the instance() classes, I created them that way so it was easyer to create them in the correct order ( meaning, no order at all :P ) On Sat, Feb 8, 2014 at 5:50 AM, Boris Barbulovski wrote: > > An SubsurfaceAbout class cleanup. > > Main change is that now SubsurfaceAbout do