Re: segmentation fault with last git version

2014-02-09 Thread Miika Turkia
I was able to reproduce with debug and normal builds. I start subsurface and close default log file immediately. The graph stays on screen, even though log is closed (with debug build, I first need to switch to the new profile tab, standard is in that tab by default). Now I just hit ctrl-i for impo

Re: More code cleanup

2014-02-09 Thread Dirk Hohndel
On Mon, 2014-02-10 at 00:30 +0100, Boris Barbulovski wrote: > > (1) > > I will read thru the CodingStyle. Thanks > (2) > QLineEdit * -> QLineEdit change is for performance reasons(not that > will have any performance boost, I believe it's a good practice). > > pros: > > * There is one

Re: patches for the new profile

2014-02-09 Thread Dazed_75
Words are just woeds. Thy are meant to convey a meaning intendeded by the speaker, writer, conveyor. But, in fact, they only convey the meaning seen by the hearer or listener. Bad words and desriptionsare only effective to people who CHOOSE to hear them that way. I do feel sorry for those people

Re: More code cleanup

2014-02-09 Thread Boris Barbulovski
(1) I will read thru the CodingStyle. (2) QLineEdit * -> QLineEdit change is for performance reasons(not that will have any performance boost, I believe it's a good practice). pros: * There is one less dynamic allocation/deallocation if you use object variable member instead of pointer(to

Re: More code cleanup

2014-02-09 Thread Dirk Hohndel
Thanks for all the patches! a few quick comments... (1) look at our CodingStyle document - in a C++ constructor initialization list, the colon is on the same line and continuation lines are aligned as the rule above: ClassName::ClassName() : x(1), y(2),

Re: Everyone please read.... Re: GSOC 2014 is almost here - Volunteer mentors needed

2014-02-09 Thread Dirk Hohndel
On Sun, 2014-02-09 at 23:19 +0200, Lubomir I. Ivanov wrote: > On 9 February 2014 02:48, Dirk Hohndel wrote: > > On Sat, 2014-02-08 at 14:48 -0800, Dirk Hohndel wrote: > >> On Sat, 2014-02-08 at 16:46 -0600, Kunda Loves Scribus wrote: > >> > >> > Awesome! > >> > I've added a Mentor: field to the wi

Re: Everyone please read.... Re: GSOC 2014 is almost here - Volunteer mentors needed

2014-02-09 Thread Lubomir I. Ivanov
On 9 February 2014 02:48, Dirk Hohndel wrote: > On Sat, 2014-02-08 at 14:48 -0800, Dirk Hohndel wrote: >> On Sat, 2014-02-08 at 16:46 -0600, Kunda Loves Scribus wrote: >> >> > Awesome! >> > I've added a Mentor: field to the wiki. Check out Screenshot >> > (http://imgur.com/tdnFwnZ) >> > Now we jus

Re: segmentation fault with last git version

2014-02-09 Thread Pedro Neves
Hi: I cannot make the steps any more specific. They are exactly the ones I've written. What I find odd is if I choose to import a log file into my default log file, there's no seg fault - only if I try to import into a blank logbook. I haven't tried to use git bisect yet. I'll have to check

[PATCH] parse-xml.c: Fix a warning about missing braces

2014-02-09 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" warning: suggest explicit braces to avoid ambiguous 'else' Signed-off-by: Lubomir I. Ivanov --- parse-xml.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/parse-xml.c b/parse-xml.c index 111075b..1d88ab6 100644 --- a/parse-xml.c +++ b/parse-xml.

Re: segmentation fault with last git version

2014-02-09 Thread Lubomir I. Ivanov
On 9 February 2014 22:26, Pedro Neves wrote: > Hi all: > > I get a segmentation fault with the latest git version of Subsurface. > Here are the steps to reproduce it: > > 1 - Open Subsurface > > 2 - Create a new logbook > > 3 - Select Import Log Files (Ctrl + I) > > Subsurface crashes with a seg f

Re: segmentation fault with last git version

2014-02-09 Thread Dirk Hohndel
Have you tried bisecting this? One of my favorite features of git. And with something so easily reproduced this should be trivial... /D --- From my phone Pedro Neves wrote: >___ >subsurface mailing list >subsurface@hohndel.org >http://lists.hohndel.or

segmentation fault with last git version

2014-02-09 Thread Pedro Neves
Hi all: I get a segmentation fault with the latest git version of Subsurface. Here are the steps to reproduce it: 1 - Open Subsurface 2 - Create a new logbook 3 - Select Import Log Files (Ctrl + I) Subsurface crashes with a seg fault. However, If I select "Import Log Files" with a logbook wi

More code cleanup

2014-02-09 Thread Boris Barbulovski
* mainly class constructor initialize list updates * some initialize list reorder * some class static instance() function member removal * some lazy stucture initializations From 17e2ce418ffc0f4b72ae6ebfc42dbbc1446583bf Mon Sep 17 00:00:00 2001 From: Boris Barbulovski Date: Sun, 9 Feb 2014 17:51:1

Any IOS app developers on this list?

2014-02-09 Thread Dirk Hohndel
Similar request as in the previous email. We are proposing an IOS companion app as one of the GSoC ideas. Currently I am listed as the mentor, but I have never written an Objective C application. It would be MUCH better if the mentor actually had done some IOS app development. This really doesn'

Any CCR divers on this list?

2014-02-09 Thread Dirk Hohndel
We have had several requests for enhanced capabilities for CCR diving. I have added this as one of the proposals for the Google Summer of Code application, but we really need at least some internal support from a CCR diver to make sure this all makes sense. Ideally the CCR diver would be willing

[PATCH 3/3] Use 'struct membuffer' for profile info string generation

2014-02-09 Thread Linus Torvalds
From: Linus Torvalds Date: Sat, 18 Jan 2014 16:21:13 -0800 Subject: [PATCH 3/3] Use 'struct membuffer' for profile info string generation The profile info was generated using nasty string concatenation that the membuffers are much better at anyway. And membuffers don't need those arbitrarily si

[PATCH 2/3] Clean up membuffer internal structure names, add strip function

2014-02-09 Thread Linus Torvalds
From: Linus Torvalds Date: Sun, 9 Feb 2014 09:40:49 -0800 Subject: [PATCH 2/3] Clean up membuffer internal structure names, add strip function The "size" member was confusing - it's the size of the allocation, not the size of the current string. The size of the current string is the member cal

Re: Some code clean-ups.

2014-02-09 Thread Dirk Hohndel
On Sun, 2014-02-09 at 06:31 +0100, Boris Barbulovski wrote: > Sorry for that. > > > For some unknown reason for me the sign line was not there. Now I run > with "--signoff" parameter('git format-patch master..devel --signoff') > and I can see the sign in the file. > > > I hope I did it right th

Re: Everyone please read.... Re: GSOC 2014 is almost here - Volunteer mentors needed

2014-02-09 Thread Anton Lundin
Sorry for answering in a weird place in this thread, I'm on my phone with wherry little internet for another week. I can volunteer as a mentor. I also have another idea for a gsoc project. The idea is to build a ci/cb environment to test build our code on all our platforms and have a good stabl