Re: [PATCH] ticket #412 Saving edits requires to move focus first

2014-03-18 Thread Gehad
sorry my bad . after editing values in cylinders or weights hitting save will not save the changes to save the edit one must move the focus to a different field first which is unfriendly this is fixed by losing the focus before accepting the changes Signed-off-by: Gehad elrobey

Re: [PATCH] Don't calculate with NaN when on 100% o2

2014-03-18 Thread Robert Helling
On 18.03.2014, at 04:39, Dirk Hohndel d...@hohndel.org wrote: Guys, I really don't want Anton's patch. Linus hasn't submitted a better patch. I could just take both of them and merge them. The choices, the choices... maybe it’s a good idea to take a step back. Often enough, when

Re: Cross-building Subsurface on Linux for Windows

2014-03-18 Thread Farzana Raisa
Now I am facing problem eith fedora 20. It says git2.h is not found. I installed both libgit2 and libgit2-devel. Then created a simlink in subsurface directory to git2.h and git2 dir. But compiling aborted with this error: save-git.c:852:2: too many arguments to function git_reference_set_target

Re: Cross-building Subsurface on Linux for Windows

2014-03-18 Thread Lubomir I. Ivanov
On 18 March 2014 13:36, Farzana Raisa farzanaahme...@gmail.com wrote: Now I am facing problem eith fedora 20. It says git2.h is not found. I installed both libgit2 and libgit2-devel. Then created a simlink in subsurface directory to git2.h and git2 dir. But compiling aborted with this error:

Re: Cross-building Subsurface on Linux for Windows

2014-03-18 Thread Farzana Raisa
It's already been added to mingw-make.sh On Tue, Mar 18, 2014 at 5:51 PM, Lubomir I. Ivanov neolit...@gmail.comwrote: On 18 March 2014 13:36, Farzana Raisa farzanaahme...@gmail.com wrote: Now I am facing problem eith fedora 20. It says git2.h is not found. I installed both libgit2 and

Re: Cross-building Subsurface on Linux for Windows

2014-03-18 Thread Lubomir I. Ivanov
please, don't use top-posting: http://en.wikipedia.org/wiki/Posting_style#Top-posting On 18 March 2014 14:21, Farzana Raisa farzanaahme...@gmail.com wrote: It's already been added to mingw-make.sh it's important to find what libgit2-dev version you have. CONFIG += libgit21-api would define

Re: Cross-building Subsurface on Linux for Windows

2014-03-18 Thread Farzana Raisa
Sorry for using top posting On Tue, Mar 18, 2014 at 6:50 PM, Lubomir I. Ivanov neolit...@gmail.comwrote: please, don't use top-posting: http://en.wikipedia.org/wiki/Posting_style#Top-posting On 18 March 2014 14:21, Farzana Raisa farzanaahme...@gmail.com wrote: It's already been added to

Cross building subsurface on linux for windows

2014-03-18 Thread Farzana Raisa
It is now compiling but showing error in linking. linking release/subsurface.exe /usr/lib64/gcc/i686-w64-mingw32/4.8.2/../../../../i686-w64-mingw32/bin/ld: cannot find -lusb-1.0 /usr/lib64/gcc/i686-w64-mingw32/4.8.2/../../../../i686-w64-mingw32/bin/ld: cannot find -lgit2

Re: Quick question on Subsurface

2014-03-18 Thread Dirk Hohndel
On Mon, 2014-03-17 at 22:22 -0700, Michal Suchanek wrote: Sorry, didn’t find any pointers as to where to ask this: Are you at all planning to support Liquivision dive computers? The Subsurface software seems really nice, and I’d love to use it with my Liquivision Xeo Trimix computer.

Re: BuildingSubsurfaceOnWindows.zip

2014-03-18 Thread Lubomir I. Ivanov
On 27 February 2014 17:33, Lubomir I. Ivanov neolit...@gmail.com wrote: hello, here is a ZIP package (~40mb) that can get one started when building subsurface on windows. it contains DLLs, -dev packages, CMD wrappers and scripts.

Re: Quick question on Subsurface

2014-03-18 Thread Jef Driesen
On 2014-03-18 14:55, Dirk Hohndel wrote: On Mon, 2014-03-17 at 22:22 -0700, Michal Suchanek wrote: Sorry, didn’t find any pointers as to where to ask this: Are you at all planning to support Liquivision dive computers? The Subsurface software seems really nice, and I’d love to use it with my

Re: New profile, line thickness of pp-graphs and ruler in Qt5

2014-03-18 Thread Lubomir I. Ivanov
On 18 March 2014 16:14, Anton Lundin gla...@acc.umu.se wrote: I just played around with Qt5 a bit and noticed that the pp-graph lines are way to thick and the ruler line too. see attached patch. is that a fix for the ruler line? lubomir -- diff --git a/qt-ui/profile/ruleritem.cpp

Re: [PATCH] ticket #412 Saving edits requires to move focus first

2014-03-18 Thread Dirk Hohndel
Hmm... this still doesn't look like a tab to me... sorry to be a pain - but the goal is for you to show that you figured out how to do this right /D On Tue, 2014-03-18 at 10:52 +0200, Gehad wrote: sorry my bad . after editing values in cylinders or weights hitting save will not save the

Re: Cross building subsurface on linux for windows

2014-03-18 Thread Dirk Hohndel
On Tue, 2014-03-18 at 19:30 +0600, Farzana Raisa wrote: It is now compiling but showing error in linking. linking release/subsurface.exe /usr/lib64/gcc/i686-w64-mingw32/4.8.2/../../../../i686-w64-mingw32/bin/ld: cannot find -lusb-1.0

Re: New profile, line thickness of pp-graphs and ruler in Qt5

2014-03-18 Thread Anton Lundin
On 18 March, 2014 - Lubomir I. Ivanov wrote: On 18 March 2014 16:40, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 March 2014 16:14, Anton Lundin gla...@acc.umu.se wrote: I just played around with Qt5 a bit and noticed that the pp-graph lines are way to thick and the ruler line too.

Re: New profile, line thickness of pp-graphs and ruler in Qt5

2014-03-18 Thread Dirk Hohndel
On Tue, 2014-03-18 at 17:05 +0200, Lubomir I. Ivanov wrote: On 18 March 2014 16:40, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 March 2014 16:14, Anton Lundin gla...@acc.umu.se wrote: I just played around with Qt5 a bit and noticed that the pp-graph lines are way to thick and the

Re: New profile, line thickness of pp-graphs and ruler in Qt5

2014-03-18 Thread Anton Lundin
On 18 March, 2014 - Dirk Hohndel wrote: On Tue, 2014-03-18 at 17:05 +0200, Lubomir I. Ivanov wrote: On 18 March 2014 16:40, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 March 2014 16:14, Anton Lundin gla...@acc.umu.se wrote: I just played around with Qt5 a bit and noticed that the

Re: New profile, line thickness of pp-graphs and ruler in Qt5

2014-03-18 Thread Lubomir I. Ivanov
On 18 March 2014 17:17, Dirk Hohndel d...@hohndel.org wrote: On Tue, 2014-03-18 at 17:05 +0200, Lubomir I. Ivanov wrote: On 18 March 2014 16:40, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 March 2014 16:14, Anton Lundin gla...@acc.umu.se wrote: I just played around with Qt5 a bit and

Re: New profile, line thickness of pp-graphs and ruler in Qt5

2014-03-18 Thread Dirk Hohndel
On Tue, 2014-03-18 at 16:23 +0100, Anton Lundin wrote: So does this change the visual result on Qt4? I.e., does this need to be conditional to running Qt5, or is this something we want unconditional as provided? I see no problem when building a Qt4 version with that patch. A simple

Re: New profile, line thickness of pp-graphs and ruler in Qt5

2014-03-18 Thread Tomaz Canabrava
People, stawp. :) QPen p; p.setCosmetic( true ); THIS. it will make the pen not scale on zoom. On Tue, Mar 18, 2014 at 12:27 PM, Lubomir I. Ivanov neolit...@gmail.comwrote: On 18 March 2014 17:17, Dirk Hohndel d...@hohndel.org wrote: On Tue, 2014-03-18 at 17:05 +0200, Lubomir I. Ivanov

Re: [Patch] Open File Dialog File Location Text Misaligned

2014-03-18 Thread Dirk Hohndel
On Tue, 2014-03-18 at 23:33 +0800, Long Wu wrote: Hi Lubomir, I have an alternative way of fixing this problem, it is set the option with QFileDialog::DontUseNativeDialog, Umm. I don't think that's what I like to see. One of the reasons we switched to Qt was the mess with the dialogs

Re: New profile, line thickness of pp-graphs and ruler in Qt5

2014-03-18 Thread Lubomir I. Ivanov
On 18 March 2014 17:37, Tomaz Canabrava tcanabr...@kde.org wrote: On Tue, Mar 18, 2014 at 12:32 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 March 2014 17:29, Tomaz Canabrava tcanabr...@kde.org wrote: People, stawp. :) QPen p; p.setCosmetic( true ); THIS. it will make

Re: [Patch] Open File Dialog File Location Text Misaligned

2014-03-18 Thread Robert Helling
On 18.03.2014, at 16:33, Long Wu wul...@comp.nus.edu.sg wrote: Hi, I have an alternative way of fixing this problem, it is set the option with QFileDialog::DontUseNativeDialog, The dialog looks closer to the original dialog. And without modify much code. I would strongly vote for

[PATCH] Link to marbledata when building out of tree

2014-03-18 Thread Anton Lundin
When building and running subsurface out of tree, marbledata was inaccessible to subsurface. Signed-off-by: Anton Lundin gla...@acc.umu.se --- subsurface.pro | 4 1 file changed, 4 insertions(+) diff --git a/subsurface.pro b/subsurface.pro index 988161f..4cca263 100644 --- a/subsurface.pro

Re: [Patch] Clear pn2GasItem po2GasItem pheGasItem after log closed

2014-03-18 Thread Long Wu
Hi, Lubomir, I have modified the tab indent problem. Please check the attached patch file:) Best regards, Wu Long On Tue, Mar 18, 2014 at 1:04 AM, Lubomir I. Ivanov neolit...@gmail.comwrote: On 17 March 2014 19:02, Wu Long sfcn...@gmail.com wrote: Hi, Lubomir, So for this patch, do I

Re: New profile, line thickness of pp-graphs and ruler in Qt5

2014-03-18 Thread Anton Lundin
On 18 March, 2014 - Lubomir I. Ivanov wrote: On 18 March 2014 17:27, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 March 2014 17:17, Dirk Hohndel d...@hohndel.org wrote: On Tue, 2014-03-18 at 17:05 +0200, Lubomir I. Ivanov wrote: On 18 March 2014 16:40, Lubomir I. Ivanov

Re: New profile, line thickness of pp-graphs and ruler in Qt5

2014-03-18 Thread Lubomir I. Ivanov
On 18 March 2014 18:02, Anton Lundin gla...@acc.umu.se wrote: On 18 March, 2014 - Lubomir I. Ivanov wrote: On 18 March 2014 17:27, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 March 2014 17:17, Dirk Hohndel d...@hohndel.org wrote: On Tue, 2014-03-18 at 17:05 +0200, Lubomir I. Ivanov

Re: [Patch] Clear pn2GasItem po2GasItem pheGasItem after log closed

2014-03-18 Thread Long Wu
Ok, that is wired. As I use FakeVim in QtCreator, I have already disabled smart mapping for tab completion in .vimrc.. Let me check this... Best regards, Wu Long On Wed, Mar 19, 2014 at 12:06 AM, Lubomir I. Ivanov neolit...@gmail.comwrote: On 18 March 2014 18:01, Long Wu

Re: Marbledata for out of tree builds

2014-03-18 Thread Anton Lundin
On 18 March, 2014 - Lubomir I. Ivanov wrote: On 18 March 2014 18:17, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 March 2014 17:51, Anton Lundin gla...@acc.umu.se wrote: Nowadays when i testbuild things for Qt4 and Qt5 ive started to build out of tree to make it easy to compare

Re: [Patch] Open File Dialog File Location Text Misaligned

2014-03-18 Thread Dirk Hohndel
On Tue, 2014-03-18 at 23:50 +0800, Long Wu wrote: I agree so, but this text misalignment only happens in Qt4.8? Anybody tried in Qt5.0? That picture looks totally bogus. That's what needs to be addressed. Using QFileDialog static methods will cause this, but creating a QFileDialog object

Re: [Patch] Clear pn2GasItem po2GasItem pheGasItem after log closed

2014-03-18 Thread Long Wu
Ok, hope this time fixed after set noexpandtab.. Sorry about making these mistakes. As this is my first time commit to open source project for gsoc:) Thanks for your help! Best regards, Wu Long On Wed, Mar 19, 2014 at 12:19 AM, Long Wu wul...@comp.nus.edu.sg wrote: Ok, that is wired. As I

Re: [Patch] Clear pn2GasItem po2GasItem pheGasItem after log closed

2014-03-18 Thread Lubomir I. Ivanov
On 18 March 2014 18:55, Long Wu wul...@comp.nus.edu.sg wrote: Ok, hope this time fixed after set noexpandtab.. Sorry about making these mistakes. As this is my first time commit to open source project for gsoc:) the patch will not apply as it is, because what you did was make the change

Re: Marbledata for out of tree builds

2014-03-18 Thread Dirk Hohndel
On Tue, 2014-03-18 at 16:51 +0100, Anton Lundin wrote: Nowadays when i testbuild things for Qt4 and Qt5 ive started to build out of tree to make it easy to compare results. I'm not sure if creating a symlink is the best option, but it works for our main build environments so I'm sending this

Re: [Patch] Clear pn2GasItem po2GasItem pheGasItem after log closed

2014-03-18 Thread Lubomir I. Ivanov
On 18 March 2014 18:55, Long Wu wul...@comp.nus.edu.sg wrote: Ok, hope this time fixed after set noexpandtab.. Sorry about making these mistakes. As this is my first time commit to open source project for gsoc:) a useful git command to look into: git rebase -i HEAD~n where n is the number

Re: Marbledata for out of tree builds

2014-03-18 Thread Anton Lundin
On 18 March, 2014 - Lubomir I. Ivanov wrote: On 18 March 2014 18:29, Anton Lundin gla...@acc.umu.se wrote: On 18 March, 2014 - Lubomir I. Ivanov wrote: On 18 March 2014 18:17, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 March 2014 17:51, Anton Lundin gla...@acc.umu.se wrote:

[PATCH v2] Link to marbledata when building out of tree

2014-03-18 Thread Anton Lundin
When building and running subsurface out of tree, marbledata was inaccessible to subsurface. Signed-off-by: Anton Lundin gla...@acc.umu.se --- subsurface.pro | 4 1 file changed, 4 insertions(+) diff --git a/subsurface.pro b/subsurface.pro index 988161f..98f23b7 100644 --- a/subsurface.pro

Re: [Patch] Clear pn2GasItem po2GasItem pheGasItem after log closed

2014-03-18 Thread Lubomir I. Ivanov
On 18 March 2014 20:12, Long Wu wul...@comp.nus.edu.sg wrote: Hi, Lubomir, Thanks very much for your advise, will this patch work? yes, it does. forwarding your patch to the mailing list with an Acked-by line from me... lubomir -- 0001-Clear-PN2-PO2-PHE-GasItem.patch Description: Binary

Re: [PATCH v2] Link to marbledata when building out of tree

2014-03-18 Thread Lubomir I. Ivanov
On 18 March 2014 19:59, Anton Lundin gla...@acc.umu.se wrote: When building and running subsurface out of tree, marbledata was inaccessible to subsurface. Signed-off-by: Anton Lundin gla...@acc.umu.se --- subsurface.pro | 4 1 file changed, 4 insertions(+) diff --git

GSOC Proposal and Subsurface Questionnaire

2014-03-18 Thread Venkatesh Shukla IIT BHU
Hello guys I am Venkatesh Shukla, an undergraduate from IIT BHU, Varanasi. I am applying to Google Summer of Code 2014 and would like to work with Subsurface. This is the link to my proposal : http://goo.gl/FA8BS5 I would be grateful to receive your comments and feedback for improvement. Also,

Re: [PATCH] ticket #412 Saving edits requires to move focus first

2014-03-18 Thread Gehad
to fix the patch problem I used emacs to remove all white spaces , also I used git apply check and there is no white spaces errors , I used tabs not spaces with 8 spaces width. I think this will fix the problem. Regards and Thanks Gehadelrobey From 0ed4b7b6d1cd3bdce41334d78e3b4e54b1858997 Mon