Re: please resend your patches...CCR

2014-08-13 Thread Willem Ferguson
Hallo Robert, I would agree that the cylinder pressure logging functions could do well within a separate source file. But such a separate file would be dependent on definitions in /profile.c/, the most important of which is the /plot_info/ structure. The actual work is being done at a high

Re: please resend your patches...CCR

2014-08-13 Thread Willem Ferguson
Of course below I meant /profile.h/ not /profile.c/ On 13/08/2014 12:41, Willem Ferguson wrote: Hallo Robert, I would agree that the cylinder pressure logging functions could do well within a separate source file. But such a separate file would be dependent on definitions in /profile.c/, the

[PATCH 1/3] Rename list column from O2% to Gas

2014-08-13 Thread Anton Lundin
In the dive list, calling the column O2% is kinda wrong, because in at least my dive list there are both air and trimix showing up, so this renames that column to Gas. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/models.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/3] Rename the model column from NITROX to GAS

2014-08-13 Thread Anton Lundin
The column isn't just about NITROX, there might be air and trimix in there too. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/divelistview.cpp | 2 +- qt-ui/models.cpp | 6 +++--- qt-ui/models.h | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 3/3] Rename dive gas function and defines for clarity

2014-08-13 Thread Anton Lundin
This renames the dive gas functions to not talk about just nitrox, and to instead talk about gas. Signed-off-by: Anton Lundin gla...@acc.umu.se --- divelist.c | 12 ++-- divelist.h | 2 +- qt-ui/models.cpp | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git

Re: Partial push of Josh's configure-dive-computer GSoC project

2014-08-13 Thread Dirk Hohndel
On Wed, Aug 13, 2014 at 10:59:13AM -0700, Thiago Macieira wrote: On Saturday 09 August 2014 21:47:03 Joshua Joseph wrote: On 9 Aug 2014 18:34, Thiago Macieira thi...@macieira.org wrote: Hi everyone This is just to let you know that I've pushed a portion of Josh's work and signed

Re: please resend your patches...

2014-08-13 Thread Dirk Hohndel
Sorry, with the heat in Mexico, missing A/C the first day and some internet problem I'm a bit behind on email... On Mon, Aug 11, 2014 at 11:45:44PM +0200, Robert C. Helling wrote: Quite a few patches were sent over the past few weeks that for various reasons didn't make it into 4.2. I am

Re: Partial push of Josh's configure-dive-computer GSoC project

2014-08-13 Thread Thiago Macieira
On Wednesday 13 August 2014 21:10:31 Dirk Hohndel wrote: Note that this needs libdivecomputer with at least commit 56e2dec7266e71e725604a4a8bff5e61f3d62259 (I've cherry-picked that to release-0.4 and it built successfully). Does it need that to BUILD or to WORK? Build. Without it,

Re: My progress in HTML export.

2014-08-13 Thread Gehad Elrobey
Hi miika, I attached patches for the mentioned bug and other random fixes. Now I think the exports are quite stable. There is one remaining known bug in the keyboard arrows navigation between dives I will fix it and submit a patch later. I ll also work on some style enhancement. thanks. On