On Tue, Jun 03, 2014 at 07:35:07PM +0200, Willem Ferguson wrote:
> 1) All the variables in the sample structures are strongly typed
> 2) Two additional types were declared in units.h:
> o2pressure_t
> bearing_t
> 3) The following variables were added:
> diluentpressure
> o2setpo
On Tue, Jun 03, 2014 at 06:31:42PM +0200, Joakim Bygdell wrote:
> Git latest master, (1f1dcecc02a5c33c81d41a8a7c6aa2b9cc6b6da5)
> Platform Mac.
>
> In Add Dive escape key has no function.
> Maybe it isn’t implemented as in the Planner that pressing the ESC key
> cancels the operation.
This shoul
On Wed, Jun 04, 2014 at 01:38:56AM +0200, roberto forini wrote:
> I tried with a more simple dive 10 minutes at 40 meters and a slow ascent
> to surface.
>
> If i change directly setting a number in the gfhight It hangs. It doesnt if
> i use the up/down buttons
>
> If i change gflow it works fine
On Wed, Jun 04, 2014 at 01:26:19AM +0200, roberto forini wrote:
> I will try to do the bugtrack.
Thanks
> > > 4) printing the dives could be useful have a space between divelogs just
> > to
> > > make space on the border for punching. (different layout depending on
> > > number of dives in the sa
On Tue, Jun 03, 2014 at 04:01:48PM -0700, Linus Torvalds wrote:
>
> We parsed it rigth for dive computers, but not for the manually filled
> per-dive case. The git save seems to have gotten it right.
>
> I think this has been broken since the whole "move as much as possible to
> the dive comput
On Wed, Jun 04, 2014 at 12:37:48AM +0200, roberto forini wrote:
> Good Job. No problem on planning a dive. i can add some issues/ideas (don't
> know who made what):
> 1) i'm not able to set the dive location using the double click of the
> mouse above the world map if the dive is in modify/edit mod
On Tue, Jun 03, 2014 at 07:59:17AM -0700, Dirk Hohndel wrote:
>
> Will make new Windows binaries as well.
http://subsurface.hohndel.org/downloads/outbox/subsurface-4.1-247-g1f1dcecc02a5.exe
/D
___
subsurface mailing list
subsurface@hohndel.or
On Tue, Jun 03, 2014 at 09:15:44AM -0300, Tomaz Canabrava wrote:
> robeto,
>
> before you try - subsurface is crashing if you open it without a dive
> file directly ( that's because I forgot to check if a dive existed
> before accessing it )
> the patch is already send, just need to make sure dir
On Tue, Jun 03, 2014 at 11:17:06PM +1200, Rick Walsh wrote:
> With the latest changes, subsurface is now crashing when aborting a dive plan.
Yes, Tomaz was a bit to aggressive dereferencing dive pointers.
Fix was pushed a minute ago
/D
___
subsurface ma
I didn't want to leave all the fun of breaking the code to Tomaz, so I
decided to get in on it as well. While he is off breaking the picture
handling, I decided to break^H^H^H^H^Hrewrite the dive editing code.
I think the new code is much more straight forwardward and much easier to
get right, but
On Mon, Jun 02, 2014 at 09:14:16PM -0700, Richard DePas wrote:
> On Mon, Jun 2, 2014 at 9:12 PM, Miika Turkia wrote:
>
> > On Tue, Jun 3, 2014 at 5:09 AM, Richard DePas
> > wrote:
> >
> >> I'm running the latest Windows binary. Was cleaning up some location
> >> names in my logs. Found that if I
On Mon, Jun 02, 2014 at 10:31:35PM +0200, roberto forini wrote:
> is this the actual code you guys are working on? i would like to install to
> follow your job...
This is eight commits ago (the name contains the git SHA). But yes, it's
quite recent.
I can make these available more frequently if t
On Mon, Jun 02, 2014 at 06:41:23AM -0700, Dirk Hohndel wrote:
> > While the subsequent gas changes look like they're doing the right
> > thing, it doesn't seem to care about the ppO2 of the first gas. See
> > the attached screenshot, there is nothing telling me that tak
On Mon, Jun 02, 2014 at 11:02:13AM -0400, William Perry wrote:
> On Jun 2, 2014, at 10:34 AM, Robert Helling wrote:
>
> > On 01.06.2014, at 20:19, Dirk Hohndel wrote:
> >
> >> On Sun, Jun 01, 2014 at 08:11:26PM +0200, Robert C. Helling wrote:
> >>>
>
Ok, here we go... I'm on a plane, nothing else useful to do.
[edited later: I'm finishing this on the bus which is really making me
sick... but I didn't want you to have to wait for two more hours)
/D
]
On Mon, Jun 02, 2014 at 11:11:16AM +0200, Willem Ferguson wrote:
> ---
> developernotes|
Willem,
In working on a full patch review of the original patch. I'll get it out to
you in a couple of hours, I think. That might help you focus the rework...
/D
On June 2, 2014 9:48:21 AM Willem Ferguson
wrote:
I hope this is good as a first patch!
Changes to sample data structure:
Th
On Mon, Jun 02, 2014 at 05:06:31PM +0200, Willem Ferguson wrote:
> On 02/06/2014 16:41, Tomaz Canabrava wrote:
> >Willem, almost 5k lines in one single commit is very hard to track down if
> >it's right and wrong, do you have the history of the branch or you didn't
> >make smaller commits? in any c
On Mon, Jun 02, 2014 at 11:11:16AM +0200, Willem Ferguson wrote:
> This branch is based on main branch commit 4.1.117-gcfe865dd0c78
>
> This commit is the first for the rebreather branch. It implements
> 18 files changed, 4829 insertions(+), 99 deletions(-)
> create mode 100644 developernotes
>
On Mon, Jun 02, 2014 at 09:07:02PM +1200, Rick Walsh wrote:
> I tried to take up Dirk's challenge of breaking the latest master. I
> didn't manage that,
That's really good to hear :-)
> but I found a couple of issues with the planner.
>
> While the subsequent gas changes look like they're doing
As requested... a recent Windows installer:
http://subsurface.hohndel.org/downloads/outbox/subsurface-4.1-224-gc6f816a64477.exe
/D
___
subsurface mailing list
subsurface@hohndel.org
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
On Sun, Jun 01, 2014 at 06:25:44PM -0700, Linus Torvalds wrote:
>
> Every single user of the get_gas_name() function wanted to just use the
> result to create a message or printout, and that made the interface a bit
> cumbersome.
Thanks for doing that. It was on my todo list. I think I'm making
On Fri, May 30, 2014 at 11:46:55PM +0100, Tim Wootton wrote:
> Adds new methods to the MinMaxAvgWidget class to allow override
> of the default tooltips of its min and max icons, and then uses
> these methods to make the tooltips for the Stats tab Depth
> instance more descriptive.
Thanks. Pushed.
These patch series are incredibly boring and yet have a high risk of
breaking things - so please test Subsurface in general, not just adding
plans (admittedly, that's where most of the changes are visible).
I have made decent progress towards making us actually use our gasmix data
structures in mo
On Sun, Jun 01, 2014 at 10:34:36PM +0200, Robert C. Helling wrote:
>
> On 01 Jun 2014, at 21:12, Dirk Hohndel wrote:
>
> > OK, I should have just pushed this instead of sending the email first.
> > This is step 0 of this painful cleanup; next step is to keep things as
On Sun, Jun 01, 2014 at 12:05:44PM -0700, Dirk Hohndel wrote:
> > Sadly, type cleanups tend to be *really* painful, because the type
> > percolates all the way, and we have some helper functions that
> > explciitly don't take the typed structures because they end up bein
On Sun, Jun 01, 2014 at 11:40:01AM -0700, Linus Torvalds wrote:
> On Sun, Jun 1, 2014 at 10:37 AM, Dirk Hohndel wrote:
> >>
> >> those are actually sane and simple rules.
> >
> > That does seem sane. Given it's late in the Linux cycle, do you have the
>
On Sun, Jun 01, 2014 at 08:01:10PM +0200, Joakim Bygdell wrote:
> Dirk, when opening the planner we read the gas list from the selected
> dive in the dive list and if it contains unused gas mixes we get the
> issue we are seeing now. Would it not be more accurate to only populate
> the gas list wi
On Sun, Jun 01, 2014 at 08:11:26PM +0200, Robert C. Helling wrote:
>
> On 01 Jun 2014, at 18:47, Martin Gysel wrote:
>
> > what about a template based output? where everyone can easily change the
> > template like
> > "\D \T \G \R" for "Depth Time Gas Runtime"
>
> I am sure that is too complex
On Sun, Jun 01, 2014 at 10:27:09AM -0700, Linus Torvalds wrote:
>
> Side note: that whole cylinder mess is actually pretty similar to what
> you are proposing, and for exactly the same reasons: wanting to have
> an explicit value where an explicit value wasn't really a good idea.
>
> The fact is,
On Sun, Jun 01, 2014 at 09:55:04AM -0700, Linus Torvalds wrote:
> On Jun 1, 2014 9:34 AM, "Henrik Brautaset Aronsen" <
> subsurf...@henrik.synth.no> wrote:
> >
> > The only places we need to treat air specially is:
>
> No. You kind of proceed my point, by missing one of the cases I explicitly
> li
Our gas tracking in the planner was broken on several levels.
I have just pushed out a couple of commits that make it somewhat better
I still haven't addressed the odd initial gas change / gas name shown
issue when you start with a different gas than gas 0. So that remains on
my todo list. But at
On Sun, Jun 01, 2014 at 05:48:20PM +0200, Henrik Brautaset Aronsen wrote:
> Dirk Hohndel wrote:
> >On Sun, Jun 01, 2014 at 01:28:58PM +0200, subsurf...@henrik.synth.no wrote:
> >>From: Henrik Brautaset Aronsen
> >>
> >>The notion that air is special is a weird
On Sun, Jun 01, 2014 at 04:54:53PM +0200, Joakim Bygdell wrote:
> >>
> >> Except that in the planner view only one gasmix is listed under Available
> >> Gases. And that one is air by default.
> >
> > Now I'm confused.
> > You clearly have tanks with these gases. I bet this goes back to "show
> >
On Sun, Jun 01, 2014 at 04:25:22PM +0200, Giuseppe `ferdy` Miceli wrote:
> On 01 Jun 2014, at 16:11, Joakim Bygdell wrote:
>
> > A minimalistic table would look something loke this.
> > Showing only depth and time/action.
> > There really is no point in showing ascent speeds/transition times.
> >
On Sun, Jun 01, 2014 at 01:28:58PM +0200, subsurf...@henrik.synth.no wrote:
> From: Henrik Brautaset Aronsen
>
> The notion that air is special is a weird one. It clutters our code
> base with special handling whenever o2 == 0 means AIR. (All my rec
> dives are with EAN32. Why can't that be sp
On Sun, Jun 01, 2014 at 03:56:56PM +0200, Joakim Bygdell wrote:
> >> Gas consumption:
> >> 2581l of EAN27
> >> 0l of EAN32
> >> 0l of (24/24)
> >> 0l of EAN30
> >
> > There are two observations here:
> > a) it is by design that Subsurface looks at all cylinders that are
> > available and tries to
On Sun, Jun 01, 2014 at 01:28:58PM +0200, subsurf...@henrik.synth.no wrote:
> From: Henrik Brautaset Aronsen
>
> The notion that air is special is a weird one. It clutters our code
> base with special handling whenever o2 == 0 means AIR. (All my rec
> dives are with EAN32. Why can't that be sp
On Sun, Jun 01, 2014 at 03:23:03PM +0200, Robert C. Helling wrote:
>
>
> > Am 01.06.2014 um 14:54 schrieb Henrik Brautaset Aronsen
> > :
> >
> > Agreed, it really makes sense to force these values to be in whole minutes.
> > At least that's what GUE Deco Planner and Multideco/VPlanner does.
>
On Sun, Jun 01, 2014 at 02:54:47PM +0200, Henrik Brautaset Aronsen wrote:
> Martin Gysel wrote:
> >>Only used gas in the plan is the EAN27.
> >>
> >>Subsurface dive plan
> >>based on GFlow = 30 and GFhigh = 85
> >>
> >>Transition to 40 m in 2:00 min - runtime 2:00 on EAN27
> >>Stay at 40 m for 25:0
On Sun, Jun 01, 2014 at 10:08:41AM +0200, Joakim Bygdell wrote:
> I really like the way the planner starts to look now,
> but we still have a problem with unused tanks that exists in the dive log
> also appear in the plan.
>
> Only used gas in the plan is the EAN27.
>
> Subsurface dive plan
> b
On Sat, May 31, 2014 at 03:49:58PM -0700, Dirk Hohndel wrote:
>
> But I'd still argue to not do a separate window (because we are reusing
> the profile and having two windows makes this awkward). Instead let's
> replace the dive list and the globe with more space for the
On Sun, Jun 01, 2014 at 12:54:27AM +0200, Henrik Brautaset Aronsen wrote:
> >>
> >> We "fixed" this by removing the info overlay (actually I think it would
> >be
> >> correct even if we didn't remove the info overlay - prior to my changes
> >> today the profile was rendered with the wrong gases).
>
On Sun, Jun 01, 2014 at 12:37:34AM +0200, Henrik Brautaset Aronsen wrote:
> Henrik Brautaset Aronsen wrote:
> >Dirk Hohndel wrote:
> >>>Henrik, would that be equally cool?
> >>>The divelist space will likely allow us to list stop time and transition
> >>
On Sun, Jun 01, 2014 at 12:33:44AM +0200, Henrik Brautaset Aronsen wrote:
> Dirk Hohndel wrote:
> >>Just one little issue: the fields in the deco stop rows acts like they are
> >>editable (at least here on my Mac), which they shouldn't be. It doesn't do
> >
On Sun, Jun 01, 2014 at 12:27:22AM +0200, Henrik Brautaset Aronsen wrote:
> Dirk Hohndel wrote:
> >>But that's not what caused the crash, because I'm unable to recreate it.
> >>Anyway, here it is:
> >>
> >>Exception Type: EXC_CRASH
On Sun, Jun 01, 2014 at 12:22:23AM +0200, Henrik Brautaset Aronsen wrote:
> Robert C. Helling wrote:
> >this is a copy and paste form planner code before the new profile. After
> >calculating deco it adds the deco stops to the model so that they are
> >displayed in the table.
>
> I *really* like
On Sun, Jun 01, 2014 at 12:14:43AM +0200, Henrik Brautaset Aronsen wrote:
> Dirk Hohndel wrote:
> >Hehe, not asleep after all, even though it's midnight Sat/Sun...
> >You sure know how to have fun on a weekend night, Henrik! :-)
>
> Yup, a helluva party going on h
Hehe, not asleep after all, even though it's midnight Sat/Sun...
You sure know how to have fun on a weekend night, Henrik! :-)
On Sun, Jun 01, 2014 at 12:01:34AM +0200, Henrik Brautaset Aronsen wrote:
^^
> Dirk Hohndel wrote:
> >Frustrating
On Sat, May 31, 2014 at 02:20:09PM -0700, Dirk Hohndel wrote:
> On Sat, May 31, 2014 at 09:55:34AM -0300, Tomaz Canabrava wrote:
> > It's on the ruler, we can disable the ruler on plan / add mode.
>
> Frustratingly, even on my Mac I cannot reproduce this.
> I tried var
On Sat, May 31, 2014 at 09:55:34AM -0300, Tomaz Canabrava wrote:
> It's on the ruler, we can disable the ruler on plan / add mode.
Frustratingly, even on my Mac I cannot reproduce this.
I tried various things, having the ruler on, off, random stuff. Cannot get
the crash.
Henrik and Joakim, do you
On Sat, May 31, 2014 at 11:11:19PM +0200, Henrik Brautaset Aronsen wrote:
> Dirk Hohndel wrote:
> >Have you looked at what it would take to disable the ruler so maybe we can
> >fix the other issue that Henrik and Joakim were seeing?
>
> I get the same crash if I choose "
On Sat, May 31, 2014 at 01:22:44PM -0700, Dirk Hohndel wrote:
> > >> My bet is that it is unused cylinders.
> > >> Turn showing them on in the preferences.
> > >> Dive 222 has seven or right cylinders, most unused
> > >
> > > they are unused.
On Sat, May 31, 2014 at 03:16:41PM -0300, Tomaz Canabrava wrote:
> On Sat, May 31, 2014 at 1:13 PM, Tomaz Canabrava wrote:
> > On Sat, May 31, 2014 at 1:11 PM, Dirk Hohndel wrote:
> >> My bet is that it is unused cylinders.
> >> Turn showing them on in the preferences.
My bet is that it is unused cylinders.
Turn showing them on in the preferences.
Dive 222 has seven or right cylinders, most unused
/D
--
From my phone
On May 31, 2014 8:55:08 AM "Robert C. Helling"
wrote:
> Am 31.05.2014 um 17:42 schrieb Tomaz Canabrava :
> maybe the cylinders are bei
On Sat, May 31, 2014 at 06:34:00AM -0700, Dirk Hohndel wrote:
> On Sat, May 31, 2014 at 03:20:06PM +0200, Joakim Bygdell wrote:
> > >
> > > So something goes horribly wrong copying the cylinders. Again, very odd if
> > > I look at the code.
> > >
> >
On Sat, May 31, 2014 at 03:20:06PM +0200, Joakim Bygdell wrote:
> >
> > So something goes horribly wrong copying the cylinders. Again, very odd if
> > I look at the code.
> >
> > I can start the planner here just fine with a dive file with 300+ dives
> > and a myriad of gas mixes.
> >
> > I wond
On Sat, May 31, 2014 at 02:33:03PM +0200, Joakim Bygdell wrote:
>
> On 31 May 2014, at 14:25, Tomaz Canabrava wrote:
>
> > So anyone can help tracking this down with me:
> >
> > Open a dive log, choose any dive, go to planner mode:
> >
> > planner doesn't show the dive.
> >
> > I also got a l
On Sat, May 31, 2014 at 01:15:49PM +0200, Joakim Bygdell wrote:
> > On Sat, May 31, 2014 at 4:15 AM, Joakim Bygdell wrote:
> >> Ehh, no.
> >> Latest master crashes for me when I open the Add Dive or the Planner.
> >>
> >> I can trace it to your commit Dirk,
> >> 4dfe12e508d1abd9a65ce1cb1b32421da
On Fri, May 30, 2014 at 02:18:30PM +0200, Joakim Bygdell wrote:
> This was done on the latest master (9f12e7086d9d71bed7863ba0e3e63ed36831197a).
> One thing that I noted was that if you just save the planner as it it
> presented without doning any changes, it doesn’t crash when you open it a
> se
On Fri, May 30, 2014 at 01:32:47PM -0700, Dirk Hohndel wrote:
> On Fri, May 30, 2014 at 10:14:49PM +0200, Robert C. Helling wrote:
> >
> > On 30 May 2014, at 19:05, Henrik Brautaset Aronsen
> > wrote:
> >
> > > When I start Subsurface and selec
On Fri, May 30, 2014 at 10:14:49PM +0200, Robert C. Helling wrote:
>
> On 30 May 2014, at 19:05, Henrik Brautaset Aronsen
> wrote:
>
> > When I start Subsurface and select Log » Plan Dive, I get this little
> > sweetie:
> >
> > Crashed Thread: 0 Dispatch queue: com.apple.main-thread
>
> Fo
On Fri, May 30, 2014 at 07:05:15PM +0200, Henrik Brautaset Aronsen wrote:
> Dirk Hohndel wrote:
> >Oh, nice. I was too careful (or should have checked this before writing my
> >last email)... it turns out that most of Henrik's issues appear to be
> >addressed with my ch
On Fri, May 30, 2014 at 04:27:48PM +0200, Joakim Bygdell wrote:
> >> I agree the two representations differ, but my aim was actually to
> >> change the saved plan rather than the table. I actively suppressed the
> >> information about transition times (and also waypoints where only the
> >> ascend
On Fri, May 30, 2014 at 08:54:13AM -0300, Tomaz Canabrava wrote:
> On Fri, May 30, 2014 at 12:57 AM, Dirk Hohndel wrote:
> > On Fri, May 30, 2014 at 02:24:50AM +0300, Gehad wrote:
> >> Patch attached to fix the order of quoting to prevents the corruption of
> >> fo
On Fri, May 30, 2014 at 02:38:02PM +0200, Robert Helling wrote:
>
> I will look at the problem with the last stop depth later when I have
> more time.
More time. What a concept. I guess I could completely give up on sleep...
> Just a quick comment:
>
> > NOTE. These values are from the planner
On Fri, May 30, 2014 at 11:04:15AM +0200, Robert Helling wrote:
> > On Thu, May 29, 2014 at 04:35:18PM -0700, Dirk Hohndel wrote:
> >> I haven't spent any time looking into this, but I noticed that I cannot
> >> change the duration of any segment of a dive plan in
On Fri, May 30, 2014 at 09:45:18AM +0200, Lutz Vieweg wrote:
> On 05/30/2014 09:24 AM, Rick Walsh wrote:
> >Average should be the actual average depth.
>
> Hmm... that is not a conclusive definition, though.
Yes it is. The average depth of all the dives that are included in the set
you are lookin
On Fri, May 30, 2014 at 07:24:13PM +1200, Rick Walsh wrote:
> -- Forwarded message --
> > https://trac.hohndel.org/ticket/521
> > Dive Stats: "Average" depth lower than "Minimum" depth
>
> I'm pretty sure 'minimum' is actually the minimum of all the maximum
> depths. I.e. the deepe
On Fri, May 30, 2014 at 02:24:50AM +0300, Gehad wrote:
> Patch attached to fix the order of quoting to prevents the corruption of
> format.
I'll take the patch as it's rather straight forward, but I have my
misgivings about the whole way quote() has been implemented.
Take a look at the quote func
On Thu, May 29, 2014 at 04:35:18PM -0700, Dirk Hohndel wrote:
> I haven't spent any time looking into this, but I noticed that I cannot
> change the duration of any segment of a dive plan in the data table. You
> can change the depth, but not the duration.
>
> To reproduce
On Thu, May 29, 2014 at 11:56:51PM -0300, Tomaz Canabrava wrote:
> lots of fixes. :)
Great patch series. Thanks, Tomaz.
/D
___
subsurface mailing list
subsurface@hohndel.org
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
I haven't spent any time looking into this, but I noticed that I cannot
change the duration of any segment of a dive plan in the data table. You
can change the depth, but not the duration.
To reproduce:
Start Subsurface
Close your data file (Ctrl-W)
Start planning a dive (Ctrl-L)
In the table widg
On Thu, May 29, 2014 at 08:11:26PM -0300, Tomaz Canabrava wrote:
> 2014-05-29 18:59 GMT-03:00 Robert C. Helling :
> >
> > this is a copy and paste form planner code before the new profile. After
> > calculating deco it adds the deco stops to the model so that they are
> > displayed in the table.
Oh, nice. I was too careful (or should have checked this before writing my
last email)... it turns out that most of Henrik's issues appear to be
addressed with my changes...
On Thu, May 29, 2014 at 03:23:26PM +0200, Henrik Brautaset Aronsen wrote:
>
> Nice work everyone! I stumbled upon a couple
On Thu, May 29, 2014 at 08:49:25PM +0200, Robert C. Helling wrote:
>
> On 29 May 2014, at 17:26, Dirk Hohndel wrote:
>
> > I've been thinking about this... the planner could do a much better job
> > tracking tanks and gases. Right now this is a mess, left over fro
Willem,
Why would this email go only to me? Please send Subsurface questions to
the mailing list.
On Thu, May 29, 2014 at 09:03:40PM +0200, Willem Ferguson wrote:
>
> I have made quite a bit of progress (I think) with respect to rebreather
> dive logs. I read in the rebreather dive log and trans
On Thu, May 29, 2014 at 04:21:28PM -0300, Tomaz Canabrava wrote:
> >
> > indeed the problem is that the information is kept (at least in part)
> > in several data structures (model (i.e. UI), struct dive, dive plan
> > and in the deco part as well in a list of depth at which something
> > happens).
On Thu, May 29, 2014 at 08:44:10PM +0200, Robert C. Helling wrote:
>
> sorry, even if it’s father’s day here, I am covered with work (real work, day
> job). So just a quick answer:
Sorry for you!
> > Something is completely wonky with the gas calculations:
> >
> > > o2='50.0%' start='200.0 b
I've been thinking about this... the planner could do a much better job
tracking tanks and gases. Right now this is a mess, left over from the old
planner code written for Subsurface 3.
Instead of having create_dive_from_plan re-create the cylinders as it
parses the plan, it should use the cylinde
Here is a gentle reminder:
Each GSOC student should send patches and status updates to their mentor
(Cc'ing the mailing list unless this is REALLY a personal email) at least
once a week, preferably more often.
I've seen code from Andrey (we need to be better about Cc'ing the mailing
list) and fro
On Thu, May 29, 2014 at 11:17:56AM +0300, Miika Turkia wrote:
> Here are some patches from Gehad for the HTML export. I fixed typos while
> reading them through. There is also one patch from me to include some more
> characters to be encoded with proper HTML encoding.
Thanks for doing that, Miika.
Hi Henrik,
I'm so happy to see email from you on the mailing list.
Welcome back!
On Thu, May 29, 2014 at 03:23:26PM +0200, Henrik Brautaset Aronsen wrote:
> Dirk Hohndel wrote:
> >I ran Subsurface under Valgrind and that quickly pointed out a few more
> >issues. With the lat
I ran Subsurface under Valgrind and that quickly pointed out a few more
issues. With the latest changes I pushed I believe add dive and the
planner are now functional and random combinations of them no longer crash
Subsurface or confuse the dive list.
I would really appreciate if people could try
On Wed, May 28, 2014 at 01:15:19PM -0700, Dirk Hohndel wrote:
> On Wed, May 28, 2014 at 03:47:52PM -0300, Tomaz Canabrava wrote:
> > but crashes if you have a divelist. be warned.
>
> I have pushed a fix for the crash.
> I'm still not clear WHY it crashes. I worry if ther
On Wed, May 28, 2014 at 03:47:52PM -0300, Tomaz Canabrava wrote:
> but crashes if you have a divelist. be warned.
I have pushed a fix for the crash.
I'm still not clear WHY it crashes. I worry if there is some inconsistency
hidden somewhere in our data structures that we need to fix to avoid
troub
On Tue, May 27, 2014 at 12:03:15AM +0200, José Carlos Andreu Galán wrote:
> - regExp = QString("(\\d+)[" UTF8_DEGREE
> "\\s](\\d+)[\'\\s](\\d+)([,\\.](\\d+))?[\"\\s]([NS%1%2])"
> - "\\s*(\\d+)[" UTF8_DEGREE
> "\\s](\\d+)[\'\\s](\\d+)([,\\.](\\d+))?[\"\\s](
On Mon, May 26, 2014 at 05:03:00PM -0300, Tomaz Canabrava wrote:
>
> Thanks for all the info. I have something *worckable* here, but right
> now I'm in the middle of cleaning things up to send.
Can you be on IRC? That would help me.
/D
___
subsurface m
On Mon, May 26, 2014 at 09:54:20PM +0200, Robert C. Helling wrote:
> Hi,
>
> I played around some more with Tomaz’ recent patches that move the
> planner to the new profile. Here are some comments:
>
> 1) I think it is pretty save to get rid of the assert in planner.c: I
> put it there to make su
On Mon, May 26, 2014 at 06:15:09PM +0200, Robert C. Helling wrote:
>
> On 26 May 2014, at 15:55, Dirk Hohndel wrote:
>
> Dirk,
>
> > On Sun, May 25, 2014 at 10:41:08PM +0200, Robert C. Helling wrote:
> >>
> >> this patch removes all unnecessa
On Sun, May 25, 2014 at 10:41:08PM +0200, Robert C. Helling wrote:
>
> this patch removes all unnecessary occurrences of gasmix.o2.permille in
> favour of get_o2(). This gets around the problem that air is (o2=he=0) in
> relation with comparing gases.
Patch looks very good, but doesn't apply to
Did you really want to just simply remove the connect? Maybe there's some
implicit magic that I'm missing, but to me this looks wrong.
/D
On Mon, May 26, 2014 at 12:06:56AM +0200, Anton Lundin wrote:
> diff --git a/qt-ui/downloadfromdivecomputer.cpp
> b/qt-ui/downloadfromdivecomputer.cpp
> index
On Mon, May 26, 2014 at 12:02:33AM +0200, José Carlos Andreu Galán wrote:
> I found myself trying to copy/paste coordinates for my dives from diving
> websites / forums and Subsurface did not accept them because it was
> applying strictly the suggestions from ISO6709 Annex D.
> Now it parses them c
On Sun, May 25, 2014 at 11:06:22AM -0300, Tomaz Canabrava wrote:
> Being away from 4 timezones and waking up at the same time: irony.
You must be confused. I woke up 3 hours ago and have been working on
Subsurface since 5:30...
> gonna do breakfast and will be subsurfing again. :)
By then my gue
On Sun, May 25, 2014 at 12:57:04AM -0300, Tomaz Canabrava wrote:
> three - the last one I commented three lines so the code compiles, but
> I most probably broke something with that. there's a huge TODO on it
> so I remember to unbreak things tomorrow when I wake.
All this (including the TODOs) as
On Sun, May 25, 2014 at 12:08:29PM +0200, ch4123allsch...@gmail.com wrote:
> Hallo Hohndel
>
> Ich wollte fragen ob die Aktuelle Version auf für Deb / Ubuntu geben wird?
Die Frage sollte man doch eher dem Debian oder Ubuntu Maintainer stellen,
oder?
> Leider schaff ich es nicht selber zu Kompili
e selection
consistent. What I need to stop doing is the
Q_EMIT currentDiveChanged(selected_dive);
at the end of selectionChanged() and instead do it at the end of
selectDives(). That way we avoid all the unneccessary redraws.
/D
> On Sat, May 24, 2014 at 9:59 PM, Dirk Hohndel wrote:
>
On May 24, 2014 5:48:47 PM Tomaz Canabrava wrote:
Each selectDive call will trigger a replot of the dive in the profile,
so if you click on a point that has like 10 dives, it will plot those
10 dives. that's why I disconnected the selectionModel and reconnected
afterwards, to make it only show
I'm trying to figure out why the entirely broken code is SelectDives is
there. Here's how I would implement this - with the added advantage that
my code actually appears to work and to do what it appears the function is
intended to do...
The existing dive messes up our selection correlation, it a
bite us some other time...
Tomaz, Thiago, can you look at this and tell me why clearSelection()
doesn't appear to trigger the selectionChange() slot?
/D
commit 10e567515161f23510874236efd2f105c033ecec
Author: Dirk Hohndel
Date: Sat May 24 13:55:18 2014 -0700
Dive list: work around o
On Sat, May 24, 2014 at 05:16:23PM -0300, Tomaz Canabrava wrote:
> >> How do I do that on the ProfileWidget2 file?
> >
> > I didn’t. I just deselected the icon.
>
> ah o.o
> I tougth it was something I needed to do on the code. maybe we should
> force-disable it while on add or plan?
Yes, definit
601 - 700 of 1330 matches
Mail list logo
