Re: 4.1 Beta on PlanetKDE

2014-04-28 Thread Dirk Hohndel
On Mon, 2014-04-28 at 13:14 -0300, Tomaz Canabrava wrote: On Mon, Apr 28, 2014 at 12:51 PM, Dirk Hohndel d...@hohndel.org wrote: In order to rub it in? I'm not that kind of people. :) There's Mono posts on planet gnome, C# posts, C++ / Qt posts there. And subsurface

Re: 4.1 Beta on Gnome

2014-04-28 Thread Dirk Hohndel
On Mon, 2014-04-28 at 18:57 +0200, Willem Ferguson wrote: On 28/04/2014 18:40, Dirk Hohndel wrote: Which reminds me - now that I switched to KDE I need to occasionally make sure that this still looks OK on Gnome3. Linus, are you still testing on Gnome? Anyone else? Are there visual

Re: icons for gas changes

2014-04-27 Thread Dirk Hohndel
On Sun, 2014-04-27 at 12:01 -0300, Tomaz Canabrava wrote: On Sun, Apr 27, 2014 at 11:45 AM, roberto forini forin...@gmail.com wrote: Hi, why not add an icon on the gas change? i made some and i hope it could be possibile to put the relative icon on the event of

[Fwd: [Subsurface-trac] [Subsurface] #500: Data download on Tusa Zen Air computer fails]

2014-04-27 Thread Dirk Hohndel
Can we switch the subsurface-git AUR on Arch to use libdivecomputer master? I don't think this will fix this issue (nothing in the git log seems related), but since I'm building the Mac and Windows binaries based on master I would think it makes sense to build all the early binaries based on

Re: Profile toolbox button positions

2014-04-27 Thread Dirk Hohndel
On Sun, 2014-04-27 at 21:57 -0300, Luisa Pires wrote: I also prefer the gray out idea for consistency. I didn't work on them any further because the idea wasn't approved. It was approved - and Tomaz said that you didn't need to do a second set of icons, he could do that in software. I like

Re: [PATCH] make git save commit messages more informative

2014-04-27 Thread Dirk Hohndel
On Sun, 2014-04-27 at 18:29 -0700, Linus Torvalds wrote: Instead of just having Created by subsurface version, put the number of dives and the location of the last dive in the message. That makes things like gitk show a much more useful view of what actually got saved. That's not the number

Re: [PATCH 4/5] Move export functions to own menu

2014-04-26 Thread Dirk Hohndel
I'm willing to accept the rest of the changes, even though this once again changes strings after the first beta. Seriously, I appreciate all contributions, but I really wonder what it is when I talk for weeks about working towards a release and RELIABLY after I cut the first beta come in changes

Re: 4.1 beta 1

2014-04-25 Thread Dirk Hohndel
On Thu, 2014-04-24 at 14:48 -0700, Dirk Hohndel wrote: Windows installer is in the downloads section Mac binaries will follow tonight (I hope) Sources were tagged Grmbl As some people on IRC noticed, I messed up the pushing. And I messed up the local tag that I used to build the first Windows

Re: 4.1 beta 1

2014-04-25 Thread Dirk Hohndel
On Fri, 2014-04-25 at 07:50 -0700, Dirk Hohndel wrote: On Thu, 2014-04-24 at 14:48 -0700, Dirk Hohndel wrote: Windows installer is in the downloads section Mac binaries will follow tonight (I hope) Sources were tagged Grmbl As some people on IRC noticed, I messed up the pushing. And I

Re: Fwd: [Announce] Qt 4.8.6 released

2014-04-24 Thread Dirk Hohndel
I will work on getting that compiled so that Mac and Windows binaries use 4.8.6 /D On Thu, 2014-04-24 at 08:01 -0700, Thiago Macieira wrote: -- Mensagem encaminhada -- Assunto: [Announce] Qt 4.8.6 released Data: qui 24 abr 2014, 13:40:19 De: List for announcements

4.1 beta 1

2014-04-24 Thread Dirk Hohndel
Windows installer is in the downloads section Mac binaries will follow tonight (I hope) Sources were tagged Please test. /D ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: xml dive logs: minimum attribute count.

2014-04-23 Thread Dirk Hohndel
On Wed, 2014-04-23 at 09:01 +0300, Miika Turkia wrote: On Wed, Apr 23, 2014 at 8:50 AM, Willem Ferguson willemfergu...@zoology.up.ac.za wrote: take the liberty of posting this message again in an attempt to elicit a response. Hope it's ok? The attached xml

Re: [PATCH][User-Manual][Companion-app]-Minor-changes-on-app-and-manual.patch

2014-04-23 Thread Dirk Hohndel
Salvador, I have some questions about the changes to the manual... On Tue, 2014-04-22 at 20:14 +0200, Salvador Cuñat wrote: Subsurface companion is, basically, the same from last Subsurface release, it's only been added with the map feature which is depicted here. Distance between

Re: Changes to dive sample structure

2014-04-22 Thread Dirk Hohndel
Hi Willem A few questions... On Tue, 2014-04-22 at 12:05 +0200, Willem Ferguson wrote: Here are suggested additions to the existing sample structure in order to accommodate dive logs from rebreather systems. struct sample { duration_t time; depth_t depth;

Re: Dealing with Poseidon MkVI dive logs.

2014-04-22 Thread Dirk Hohndel
On Tue, 2014-04-22 at 19:23 +0300, Miika Turkia wrote: Hi Willem, I'll include the mailing list, as this should really be discussed there, especially since we are talking about functionality me and Tomaz are not familiar with. Yes, unless there is something that's truly personal I really

Re: Changes to dive sample structure

2014-04-22 Thread Dirk Hohndel
... Everyone else - I'm including all of Willem's email to me so context is maintained On Tue, 2014-04-22 at 22:28 +0200, Willem Ferguson wrote: On 22/04/2014 16:23, Dirk Hohndel wrote: Hi Willem A few questions... On Tue, 2014-04-22 at 12:05 +0200, Willem Ferguson wrote: Here

GSoC projects

2014-04-22 Thread Dirk Hohndel
Hi everyone Miika just pointed out to me that I completely forgot to announce the accepted GSoC projects on the mailing list. Four projects were accepted (completely insane for a first year project): Andrey Zhdanov iOS Subsurface Companion Application (mentor: Dirk) Gehad Elrobey Exporting

Re: patch: remove interdependencies from the code.

2014-04-20 Thread Dirk Hohndel
On Wed, 2014-04-16 at 22:57 -0300, Tomaz Canabrava wrote: Dirk, Read this patch carefully, if I got anything wrong here I can crash the app, or worse, make your cat pregnant. He's a neutered boy cat. So I'm not overly worried. This is an important patch regarding to the 'unittest'

Re: towards 4.1

2014-04-19 Thread Dirk Hohndel
On Fri, 2014-04-18 at 22:57 -0700, Dirk Hohndel wrote: I have put a Windows binary up for download. I have not been able to do any testing on it whatsoever, so I don't even know if it will work. But figuring out what fails might also help. might be useful if I told you where to find it. Brain

Re: towards 4.1

2014-04-19 Thread Dirk Hohndel
On Sat, 2014-04-19 at 12:43 +0200, Rainer Mohr wrote: Hi Dirk, Let me know once there's a Mac package, I'll be happy to test... I figured it out. Somehow the libgit2 shared library didn't have a correct rpath embedded. So now I have a dmg for people to try:

Re: towards 4.1

2014-04-19 Thread Dirk Hohndel
On Sat, 2014-04-19 at 09:33 -0700, Richard DePas wrote: As we are currently at my parents', I could give the windows version a quick try. The only flaw I could find are the subscripts of n2 and o2 in the infobox have a font/encoding problem. At least with German localization. Yes, I

Re: towards 4.1

2014-04-19 Thread Dirk Hohndel
On Sat, 2014-04-19 at 19:26 +0200, Robert C. Helling wrote: Am 19.04.2014 um 19:11 schrieb Richard DePas richard.de...@gmail.com: Calibri is installed on the machine. 'MS Shell Dlg 2' comes up by default. Selecting Calibri in the Preferences does correct the subscript issue.

Re: towards 4.1

2014-04-19 Thread Dirk Hohndel
On Sat, 2014-04-19 at 20:21 +0200, Gehad wrote: On 04/19/2014 07:43 PM, Dirk Hohndel wrote: On Sat, 2014-04-19 at 19:26 +0200, Robert C. Helling wrote: Am 19.04.2014 um 19:11 schrieb Richard DePas richard.de...@gmail.com: Calibri is installed on the machine. 'MS Shell Dlg 2' comes up

Re: towards 4.1

2014-04-19 Thread Dirk Hohndel
On Apr 19, 2014, at 12:42 PM, Jef Driesen j...@libdivecomputer.org wrote: On 19-04-14 21:11, Dirk Hohndel wrote: On Sat, 2014-04-19 at 11:52 -0700, Dirk Hohndel wrote: Both of them are linked against libdivecomputer 0.4.2 Jef - is that the version we should be using? Does it have all

Re: towards 4.1

2014-04-19 Thread Dirk Hohndel
On Apr 19, 2014, at 12:49 PM, Jef Driesen j...@libdivecomputer.org wrote: When I did a quick look it seemed to me that 0.4.2 had fixes that were not in master, that’s why I picked 0.4.2. Did I manage to confuse myself? I merged the release-0.4 branch into master immediately after the v0.4.2

Re: towards 4.1

2014-04-19 Thread Dirk Hohndel
On Apr 19, 2014, at 3:43 PM, Richard DePas richard.de...@gmail.com wrote: Thanks for testing. I would really love to see people try to play with all the different options, dialogs, context menus, etc. We have quite a few new developers on this list (not just GSoC candidates but several

Re: Some progress on the planner

2014-04-18 Thread Dirk Hohndel
On Fri, 2014-04-18 at 16:08 +0200, Robert C. Helling wrote: On 17 Apr 2014, at 16:33, Dirk Hohndel d...@hohndel.org wrote: - the ratio of comments to code in Subsurface has always been rather low, to the point of making it often brutally hard to understand the existing code. Especially

Re: Some more suggestions

2014-04-18 Thread Dirk Hohndel
On Fri, 2014-04-18 at 11:41 +0100, Marcin Małecki wrote: Since my previous suggestion were well received I thought some more about other features I might recommend. 1) Default cylinder - at the moment you can select a default cylinder. This is useful to a point. Once you start diving with

Re: Some progress on the planner

2014-04-17 Thread Dirk Hohndel
Hi Robert, thanks for picking up this 10 ton bolder and rolling it up the hill... On Thu, 2014-04-17 at 10:54 +0200, Robert Helling wrote: the last days, I have spend some time with the planner. All this has happened on my “oneplannertable” branch on github but here I send the currents state

Re: Some progress on the planner

2014-04-17 Thread Dirk Hohndel
On Thu, 2014-04-17 at 10:54 +0200, Robert Helling wrote: The update of the profile only works partially upon changes in the list of available gases. This may have something to do with these errors at start: $ ./subsurface Object::connect: No such signal

Re: Some progress on the planner

2014-04-17 Thread Dirk Hohndel
On Thu, 2014-04-17 at 21:48 -0500, Lakshman wrote: On Thu, Apr 17, 2014 at 10:19 AM, Dirk Hohndel d...@hohndel.org wrote: On Thu, 2014-04-17 at 10:54 +0200, Robert Helling wrote: The update of the profile only works partially upon changes in the list of available gases. This may have

Re: [PATCH] Small patch with Luisa's toolbox icons WITH ATTACHMENT

2014-04-16 Thread Dirk Hohndel
On Wed, 2014-04-16 at 17:47 +0200, Willem Ferguson wrote: Install Luisa's Heart Rate icon and DC-reported ceiling icon 1) Replace the current text-based heart rate icon with Luisa's design 2) Move the heart rate graph icon up in the toolbox with the cluster of buttons

Re: [PATCH] Unexpected Behaviour in preference window.

2014-04-15 Thread Dirk Hohndel
On Tue, 2014-04-15 at 09:27 +0200, Robert C. Helling wrote: On Mon, 14 Apr 2014, Dirk Hohndel wrote: Hi, But the TecDetails, Units, all the settings that we need to look at in several places should be in prefs. as I said on IRC, I am currently trying to get the planner to a workable

Re: [PATCH] Removing unneeded refrences to QSettings

2014-04-15 Thread Dirk Hohndel
On Fri, 2014-04-11 at 23:54 +0200, Gehad wrote: The patch attached changes some QSettings refrences to prefs struct. Some are not changed yet like the rulergraph setting , because I didn't implement the setter function yet. Sorry I missed this one. Some comments: a) please explain the

Re: Ceiling Icons

2014-04-14 Thread Dirk Hohndel
On Sun, 2014-04-13 at 20:59 +0200, Willem Ferguson wrote: On 11/04/2014 20:49, Luisa Pires wrote: Willem, I agree, if the graph is red, the graph in the button should be red as well. I'm attaching the new version. Regarding the last three..if they work kind of as options

Re: [PATCH] Mark Air/Water temp field red for wrong input.

2014-04-14 Thread Dirk Hohndel
This works well - but when playing with it I noticed that currently edits are broken - they don't modify the data in the dive. This is not something that your patch broke, though. I'll need to figure out when that happened. /D ___ subsurface mailing

Re: [PATCH] Mark Air/Water temp field red for wrong input.

2014-04-14 Thread Dirk Hohndel
On Mon, 2014-04-14 at 09:23 -0500, Lakshman wrote: On Mon, Apr 14, 2014 at 7:30 AM, Dirk Hohndel d...@hohndel.org wrote: This works well - but when playing with it I noticed that currently edits are broken - they don't modify the data in the dive. This is not something that your patch

Re: [PATCH] Unexpected Behaviour in preference window.

2014-04-14 Thread Dirk Hohndel
On Sat, 2014-04-12 at 14:02 +0200, Gehad wrote: On 04/11/2014 04:19 PM, Dirk Hohndel wrote: I think I had something slightly different in mind: The prefs variable should contain a member for each setting. And we need That was too simplistic :-) to redo those members so

Re: [PATCH] git-save: improve commit authorship data

2014-04-14 Thread Dirk Hohndel
On Mon, 2014-04-14 at 14:41 -0700, Linus Torvalds wrote: diff --git a/linux.c b/linux.c index ea0170dc89f8..03d0bfbf9670 100644 --- a/linux.c +++ b/linux.c + if (username *username) { + const char hostname[64]; + struct membuffer mb = { 0 }; +

Re: [PATCH] Unexpected Behaviour in preference window.

2014-04-11 Thread Dirk Hohndel
On Fri, 2014-04-11 at 12:31 +0300, Lubomir I. Ivanov wrote: On 11 April 2014 11:44, Gehad Elrobey gehadelro...@gmail.com wrote: On Thu, Apr 10, 2014 at 7:19 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue, 2014-04-08 at 14:11 +0200, Gehad wrote: On 04/07/2014 10:22 PM, Dirk Hohndel

Re: [RFC] Operating system name/version detection

2014-04-10 Thread Dirk Hohndel
Thiago, I believe this is largely borrowed from your code - can you work with Joshua on good / correct attribution of the code origin. Also, would you do a quick review of the code? I asked Joshua to send it here so I could test it and everyone could provide input. Robert (or any of the other

Re: [PATCH] Ticket #473: Add option of saving User ID in xml

2014-04-10 Thread Dirk Hohndel
Hi Venkatesh, sorry this took longer than usual - things have been crazy busy for me. Sadly none of the other developers provided review, either (cough, cough)... Added feature of saving subsurface userid in local files (xml as well as the git repo) as per ticket #473 For git repo,

Re: [PATCH] Changing some references of QSettings to the pref struct.

2014-04-10 Thread Dirk Hohndel
On Tue, 2014-04-08 at 14:11 +0200, Gehad wrote: This patch changes some references of QSettings to the preference struct. Thanks. BTW, you don't need the explicit path in this: @@ -1,7 +1,8 @@ #include animationfunctions.h +#include ../../dive.h +#include ../../pref.h #include

Re: unable to complete cross-building on fedora 20

2014-04-10 Thread Dirk Hohndel
On Thu, 2014-04-10 at 14:05 -0500, Lakshman wrote: I've never had a no job control error, where were you trying to build marble and libgit2? I think the INSTALL suggests creating a build directory, which I would suggest. You might hit a couple more bumps trying to cross- compile, I

Re: [PATCH] Ticket #473: Add option of saving User ID in xml

2014-04-10 Thread Dirk Hohndel
On Fri, 2014-04-11 at 08:34 +0530, Venkatesh Shukla wrote: +static void parse_settings_userid(char *line, struct membuffer *str, void *_unused) +{ + char *uid = line; + if (uid) + { +

Re: [PATCH] Unexpected Behaviour in preference window.

2014-04-07 Thread Dirk Hohndel
On Mon, 2014-04-07 at 19:12 +0200, Gehad wrote: Some fields in the preference window are not restored correctly, This patch fixes them. I am not sure if the commit message is clear enough or not. I slightly rephrased it and accepted the patch. Of course there is still a somewhat bigger

[Fwd: [Subsurface-trac] #486: Manually entered profile not transferred correctly to divelogs.de]

2014-04-06 Thread Dirk Hohndel
Interesting bug. So the default dive created when simply doing Add Dive and then saving the dive looks like this in Subsurface: divelog program='subsurface' version='2' settings /settings dives dive number='1' date='2014-04-06' time='14:33:25' duration='46:06 min' cylinder / divecomputer

Re: [PATCH] Fixes divelogs.de upload error #483

2014-04-05 Thread Dirk Hohndel
On Sat, 2014-04-05 at 14:15 +0530, Venkatesh Shukla wrote: Arguments 2 and 3 in fread() seemed to be exchanged because of which only one character was read into the temp xml file. Fixed it by exchange and replacing 1 by sizeof(char) to be sure. Signed-off-by: Venkatesh Shukla

Re: [PATCH] Fixes divelogs.de upload error #483

2014-04-05 Thread Dirk Hohndel
On Sat, 2014-04-05 at 21:29 +0530, Venkatesh Shukla wrote: I have attached the updated patch which includes correct explanation of error. Please note the change I made to the commit message :-) It really helps me if people get in the habit of correctly referencing trac bugs. /D

Re: [PATCH] Different system locale settings cause the export to crash

2014-04-05 Thread Dirk Hohndel
On Sat, 2014-04-05 at 15:48 -0700, Linus Torvalds wrote: On Sat, Apr 5, 2014 at 1:40 PM, Dirk Hohndel d...@hohndel.org wrote: May I make up a commit message (I'll add some curse words to make it sound more authentic) and add you SOB? I was thinking you'd just credit it as a small change

Re: [PATCH] Edit bookmark name.

2014-04-03 Thread Dirk Hohndel
On Thu, 2014-04-03 at 19:12 +0200, Yosef Hamza wrote: last version of the batch. It works just as simple bookmarks with all it's functions. the second attachment to check saving/loading and a preview. Thanks, Yosef, a few comments a) the patch looks indented correctly, but all the tabs are

Re: [PATCH] Fixing dive notes escape characters in World map exporter

2014-04-03 Thread Dirk Hohndel
Thanks, Gehad. Usually it's nice to have at least a quick here is XYZ in the email itself (in many email programs, including the one that I use, attachments aren't shown by default). I added three more minor style cleanups to your old code into this commit and pushed it out. /D On Thu,

Re: [PATCH] Fixing dive notes escape characters in World map exporter

2014-04-03 Thread Dirk Hohndel
Playing around with this some more... I get a strange error when opening the .html file produced for all of my dives. The JS console shows: Uncaught TypeError: Cannot read property '__e3_' of undefined main.js:15 Googling for that it seems to imply that there is an ordering issue in your

Re: Update Checking

2014-04-02 Thread Dirk Hohndel
On Wed, 2014-04-02 at 09:56 +0300, Joshua Joseph wrote: On Thu, Mar 6, 2014 at 10:03 PM, Dirk Hohndel d...@hohndel.org wrote: BTW: is there a QT function that gives us a nice OS Version? I looked at QSysInfo and that's not all that useful. I was thinking

Re: [PATCH] Edit Bookmarks name

2014-04-01 Thread Dirk Hohndel
I'll respond to the last feedback that I had given you - but this is to the patch you sent 15 minutes ago: On Tue, 2014-03-25 at 09:49 -0700, Dirk Hohndel wrote: On Tue, 2014-03-25 at 17:55 +0200, Yosef Hamza wrote: big parts of your patch have 4 space indentation. Still true can you

Re: [PATCH] Don't calculate with NaN when on 100% o2

2014-03-31 Thread Dirk Hohndel
On Mon, 2014-03-31 at 13:04 +0200, Robert Helling wrote: here are two patches. The first I kindof announced on IRC: The depth value taking into account both O2 and N2 is to rate how narced you are and only makes sense for trimix dives (as for nitrox dives it always equals the real depth). The

Re: [PATCH] Don't calculate with NaN when on 100% o2

2014-03-31 Thread Dirk Hohndel
Willem, I wonder if we want to spend a sentence each in the manual on explaining what we really mean by EAD and END... /D On Mon, 2014-03-31 at 09:01 -0700, Dirk Hohndel wrote: On Mon, 2014-03-31 at 13:04 +0200, Robert Helling wrote: here are two patches. The first I kindof announced on IRC

Re: Crash after saving to a git repo

2014-03-31 Thread Dirk Hohndel
On Mon, 2014-03-31 at 19:57 +0200, Anton Lundin wrote: I trigger this after loading my xml file and then trying to save it to a new branch in a fresh git-repo. I'm kinda confused that I'm seem to be the only one hitting this one, because i can reproduce it to 100%. So which version of

Re: [PATCH] Don't calculate with NaN when on 100% o2

2014-03-31 Thread Dirk Hohndel
On Mon, 2014-03-31 at 20:46 +0200, Robert C. Helling wrote: On 31 Mar 2014, at 18:54, Dirk Hohndel d...@hohndel.org wrote: I wonder if we want to spend a sentence each in the manual on explaining what we really mean by EAD and END... Here is my attempt at doing that. Excellent, Robert

Re: Crash after saving to a git repo

2014-03-31 Thread Dirk Hohndel
On Mon, 2014-03-31 at 13:52 -0700, Linus Torvalds wrote: On Mon, Mar 31, 2014 at 1:51 PM, Anton Lundin gla...@acc.umu.se wrote: Yepp, it fixes things both for current head built threadsafe and the Ubuntu packaged one. Goodie. Dirk, mind applying it with some obvious commit message and my

Re: [PATCH] Fixing dive notes escape characters in World map exporter

2014-03-31 Thread Dirk Hohndel
Stupidly I can't include your patch in my response... oh well. Quick questions: a) I don't think we support any architecture where sizeof(char) isn't just 1 - and we don't do those calculations anywhere else. So I think you might as well drop them. I forgot to ask about that in the first patch

Re: patch built relative to commit 7902af2

2014-03-31 Thread Dirk Hohndel
On Mon, 2014-03-31 at 23:50 -0500, Lakshman wrote: Hello Dirk, Attached are the two patches, one from Robert Helling 0001-Distinguish-between-entered-and-calculated-waypoints.patch and the other by me built relative to Robert' patch. Since, I could not apply patch from Robert onto current

Re: Problems while using divecomputer-simulator for linux

2014-03-30 Thread Dirk Hohndel
On Sun, 2014-03-30 at 11:51 -0700, Linus Torvalds wrote: On Sun, Mar 30, 2014 at 11:17 AM, Venkatesh Shukla IIT BHU venkatesh.shukla.ee...@iitbhu.ac.in wrote: It used to work earlier. I don't understand what went wrong. I also tried switching to the release-0.4 branch. But the error

Re: [PATCH] Don't calculate with NaN when on 100% o2

2014-03-30 Thread Dirk Hohndel
On Tue, 2014-03-18 at 09:53 +0100, Robert Helling wrote: On 18.03.2014, at 04:39, Dirk Hohndel d...@hohndel.org wrote: Guys, I really don't want Anton's patch. Linus hasn't submitted a better patch. I could just take both of them and merge them. The choices, the choices... maybe

Re: [PATCH] Don't calculate with NaN when on 100% o2

2014-03-30 Thread Dirk Hohndel
On Sun, 2014-03-30 at 23:52 +0200, Robert C. Helling wrote: On 30 Mar 2014, at 23:07, Dirk Hohndel d...@hohndel.org wrote: Tried to talk to you on IRC, but let's repeat here: + entry-ead = (entry-depth + 1) * (1000 - fhe) / 1000.0 - 1; + entry-end

Re: [PATCH] Exporting a World-Map prototype

2014-03-30 Thread Dirk Hohndel
I took the patch but I found a bug. If your dive notes contain newlines then the resulting java script breaks with unterminated string literal because when printed out the string literal runs across multiple lines. So you need to find newlines in the strings that you print and convert them into

Re: [PATCH]Edit bookmarks name

2014-03-29 Thread Dirk Hohndel
no patch included / attached /D On Mar 28, 2014, at 2:54 PM, Yosef Hamza jo.adam...@gmail.com wrote: This patch add the ability to change bookmarks name to more meaningful names for the user -if wishes- ___ subsurface mailing list

Re: [PATCH] Exporting a World-Map prototype

2014-03-29 Thread Dirk Hohndel
On Sat, 2014-03-29 at 19:57 +0200, Gehad wrote: I added some more info to the information window that appears when hovering the dives. Also I fixed the line continuation and used the file and membuffer Api better. fixed the dives with no dive sight error. Please provide me feedback. We

Re: Feedback, features requests, suggestions

2014-03-28 Thread Dirk Hohndel
On Thu, 2014-03-27 at 13:38 -0500, Lakshman wrote: Attached patch is updated as per the suggestion. Thanks. I just pushed it. Please look at the commit message in the version that I pushed. I rephrased what you wrote - especially note the syntax for auto-integration with trac. If you use this

Re: [PATCH] Exporting a World-Map prototype

2014-03-28 Thread Dirk Hohndel
On Fri, 2014-03-28 at 11:45 +0200, Gehad Elrobey wrote: On Thu, Mar 27, 2014 at 3:53 AM, Miika Turkia miika.tur...@gmail.com wrote: And a brief test; positioning dives with no GPS location to 0,0 does not seem right. But as a PoC this seems to be working

Re: Feedback, features requests, suggestions

2014-03-27 Thread Dirk Hohndel
On Wed, 2014-03-26 at 13:34 -0500, Lakshman wrote: You meant to say it doesn't provide any information that you are interested in? Whether you care about it or not, it sure is meaningful. Feel free to file an enhancement request at trac.hohndel.org

Re: [PATCH] Center On Earth When Startup

2014-03-27 Thread Dirk Hohndel
On Wed, 2014-03-26 at 17:59 +0800, Hugle wrote: This patch remove the unused variable 'marble' at 'global.cpp'. Either move that to the end of the commit message, or split in two patches. Starting the commit message with this seems wrong. At the same time, it makes the marble widget center on

Re: Updates to section 3 of user manual

2014-03-25 Thread Dirk Hohndel
On Tue, 2014-03-25 at 10:02 -0500, Lakshman wrote: On Tue, Mar 25, 2014 at 9:55 AM, Dirk Hohndel d...@hohndel.org wrote: The patch fails to apply to master... If this is regarding 0002-Minor-edits-to-updated-section-3-documentation.patch, this patch was made on top of the patch 0002

Re: Road to 4.2

2014-03-25 Thread Dirk Hohndel
On Tue, 2014-03-25 at 11:56 -0300, Tomaz Canabrava wrote: People, We are in bugfix mode for 4.1, it will be an awesome release, we got picture support, something that was on the todo list for quite a while, a new and almost-identical profile that has smooth animations and it's the base for

Re: [PATCH] Exporting a World-Map prototype

2014-03-25 Thread Dirk Hohndel
On Tue, 2014-03-25 at 15:09 +0200, Gehad wrote: I'm waiting for your appreciated reviews and feedback. I haven't tried the patch, just looked at the code so far. There are some odd white space (space between comma and next argument, for example) and line breaking decisions in there, especially

Re: [PATCH] Exporting a World-Map prototype

2014-03-25 Thread Dirk Hohndel
On Tue, 2014-03-25 at 17:20 +0200, Gehad Elrobey wrote: On Tue, Mar 25, 2014 at 4:53 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue, 2014-03-25 at 15:09 +0200, Gehad wrote: I'm waiting for your appreciated reviews and feedback. I haven't tried

Re: [PATCH] Edit Bookmarks name

2014-03-25 Thread Dirk Hohndel
On Tue, 2014-03-25 at 17:55 +0200, Yosef Hamza wrote: big parts of your patch have 4 space indentation. can you explain in the commit message why you switched the pixmap to be a flag? you always add the option to Edit name to the context menu if there is any event - but this only makes sense

Re: [PATCH 1/2] simplewidgets: Include stdint for cross compatability

2014-03-25 Thread Dirk Hohndel
On Tue, 2014-03-25 at 12:54 -0500, Alberto Corona wrote: Not including stdint leaves 'int64_t when' without a type and undefined when compiling for Windows with mingw Good catch, thanks. I need to be more consistent in doing the Windows cross builds... :-) /D

Re: [PATCH 2/2] Windows packaging script: check mingw bin directory

2014-03-25 Thread Dirk Hohndel
On Tue, 2014-03-25 at 12:54 -0500, Alberto Corona wrote: Windows packaging script now checks whether the mingw bin directory is in either /usr/i686-w64-mingw32/bin or /usr/i686-w64-mingw32/sys-root/mingw/bin Signed-off-by: Alberto Corona albco...@gmail.com ---

Re: Finding translation string

2014-03-23 Thread Dirk Hohndel
On Sat, 2014-03-22 at 14:24 +0200, Andrey Zhdanov wrote: On 22 Mar 2014, at 12:56, Jan Birk jan.g.b...@gmail.com wrote: I have some trouble finding the string add dive data point (406) in SubSurface. In order to translate it correctly I need to see the string in its context. Can

Re: [PATCH] Improved logic in cylinder management and gas change events

2014-03-23 Thread Dirk Hohndel
On Sat, 2014-03-22 at 11:04 +0100, Jan Mulder wrote: On 21-03-14 18:44, Linus Torvalds wrote: On Fri, Mar 21, 2014 at 8:51 AM, Jan Mulder jlmul...@planet.nl wrote: First, I ran in to an obvious bug. Manually add a 2nd cylinder to a dive, and try to delete it right away. Patch looks sane

Re: Feedback, features requests, suggestions

2014-03-23 Thread Dirk Hohndel
On Sat, 2014-03-22 at 15:21 +, Marcin Małecki wrote: Hi I am a new diver and also new to Subsurface. Have been using the application for about 2 months. There are several comments and suggestion I would like to make: 1) It would be useful if User ID from the GPS android web service

Re: [PATCH] Add current time and adjusted time to gui when one asjusts dive's timestamp

2014-03-20 Thread Dirk Hohndel
On Thu, 2014-03-20 at 02:54 +0200, Gehad wrote: I added the current time and the adjusted time to the shift time widget, I added a function in dive.c to get the timestamp of the first selected dive, I am not sure if a similar function is already implemented before. Have you searched? :-)

Re: GSOC 2014

2014-03-19 Thread Dirk Hohndel
On Wed, 2014-03-19 at 08:23 -0700, Shemil Hashan wrote: Hi all, I'm new here. Saw you guys on GSoc list and went through the details. Few ideas matches my experience very well. Dirk Hohndel is the mentor for that project. Dirk Hohndel,can you help me? please look at http://trac.hohndel.org

Re: proposed solution for #436 Output should be directed to the windows console

2014-03-19 Thread Dirk Hohndel
On Wed, 2014-03-19 at 21:19 +0600, Farzana Raisa wrote: I am not being able to cross compile on linux for windows. And I have discussed about it in the list. That's why i couldn't compile it in window. But i guess the problem will be solved if i use fprintf(stderr, ) instead of printf() in the

learning to use email [was: Re: subsurface Digest, Vol 28, Issue 127]

2014-03-19 Thread Dirk Hohndel
On Wed, 2014-03-19 at 09:22 -0700, Shemil Hashan wrote: You should know how ios app building is done. Procedure is different from other development methods. I guess since android version already exists building the backend will be unneccessary. We need to build the fron end for iphones

Re: [PATCH] git object store: make it possible to work with checked-out git branches

2014-03-19 Thread Dirk Hohndel
On Wed, 2014-03-19 at 13:53 -0700, Linus Torvalds wrote: Please edit the patch to remove that fprintf(stderr...); line before applying it. Done /D ___ subsurface mailing list subsurface@hohndel.org

Re: Quick question on Subsurface

2014-03-18 Thread Dirk Hohndel
On Mon, 2014-03-17 at 22:22 -0700, Michal Suchanek wrote: Sorry, didn’t find any pointers as to where to ask this: Are you at all planning to support Liquivision dive computers? The Subsurface software seems really nice, and I’d love to use it with my Liquivision Xeo Trimix computer.

Re: [PATCH] ticket #412 Saving edits requires to move focus first

2014-03-18 Thread Dirk Hohndel
Hmm... this still doesn't look like a tab to me... sorry to be a pain - but the goal is for you to show that you figured out how to do this right /D On Tue, 2014-03-18 at 10:52 +0200, Gehad wrote: sorry my bad . after editing values in cylinders or weights hitting save will not save the

Re: Cross building subsurface on linux for windows

2014-03-18 Thread Dirk Hohndel
On Tue, 2014-03-18 at 19:30 +0600, Farzana Raisa wrote: It is now compiling but showing error in linking. linking release/subsurface.exe /usr/lib64/gcc/i686-w64-mingw32/4.8.2/../../../../i686-w64-mingw32/bin/ld: cannot find -lusb-1.0

Re: New profile, line thickness of pp-graphs and ruler in Qt5

2014-03-18 Thread Dirk Hohndel
On Tue, 2014-03-18 at 17:05 +0200, Lubomir I. Ivanov wrote: On 18 March 2014 16:40, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 March 2014 16:14, Anton Lundin gla...@acc.umu.se wrote: I just played around with Qt5 a bit and noticed that the pp-graph lines are way to thick and the

Re: New profile, line thickness of pp-graphs and ruler in Qt5

2014-03-18 Thread Dirk Hohndel
On Tue, 2014-03-18 at 16:23 +0100, Anton Lundin wrote: So does this change the visual result on Qt4? I.e., does this need to be conditional to running Qt5, or is this something we want unconditional as provided? I see no problem when building a Qt4 version with that patch. A simple

Re: [Patch] Open File Dialog File Location Text Misaligned

2014-03-18 Thread Dirk Hohndel
On Tue, 2014-03-18 at 23:33 +0800, Long Wu wrote: Hi Lubomir, I have an alternative way of fixing this problem, it is set the option with QFileDialog::DontUseNativeDialog, Umm. I don't think that's what I like to see. One of the reasons we switched to Qt was the mess with the dialogs

Re: [Patch] Open File Dialog File Location Text Misaligned

2014-03-18 Thread Dirk Hohndel
On Tue, 2014-03-18 at 23:50 +0800, Long Wu wrote: I agree so, but this text misalignment only happens in Qt4.8? Anybody tried in Qt5.0? That picture looks totally bogus. That's what needs to be addressed. Using QFileDialog static methods will cause this, but creating a QFileDialog object

Re: Marbledata for out of tree builds

2014-03-18 Thread Dirk Hohndel
On Tue, 2014-03-18 at 16:51 +0100, Anton Lundin wrote: Nowadays when i testbuild things for Qt4 and Qt5 ive started to build out of tree to make it easy to compare results. I'm not sure if creating a symlink is the best option, but it works for our main build environments so I'm sending this

Re: Some subsurface notes from a week of diving

2014-03-17 Thread Dirk Hohndel
On Sun, 2014-03-16 at 15:52 -0700, Linus Torvalds wrote: On Sun, Mar 16, 2014 at 1:57 PM, Dirk Hohndel d...@hohndel.org wrote: Oops. We used to have code that fixes that. Wonder where that got lost. I think the new profile lost it in the re-implementation. The old code didn't blindly just

Re: Some subsurface notes from a week of diving

2014-03-17 Thread Dirk Hohndel
On Mon, 2014-03-17 at 08:31 -0700, Linus Torvalds wrote: On Mon, Mar 17, 2014 at 8:13 AM, Dirk Hohndel d...@hohndel.org wrote: Look at this little gem. I think I'll reorder this a little bit: No need. +static inline int number_of_computers(struct dive *dive) +{ + int

Re: Cross-building Subsurface on Linux for Windows

2014-03-17 Thread Dirk Hohndel
On Mon, 2014-03-17 at 19:11 +0200, Lubomir I. Ivanov wrote: On 17 March 2014 18:01, Farzana Raisa farzanaahme...@gmail.com wrote: in order to solving bug i need to compile subsurface in windows and i'm trying cross building on ubuntu for windows. I've installed both mingw32 and gcc-mingw32.

Re: [PATCH] ticket #412 Saving edits requires to move focus first

2014-03-17 Thread Dirk Hohndel
On Tue, 2014-03-18 at 03:19 +0200, Gehad wrote: after editing values in cylinders or weights hitting save will not save the changes to save the edit one must move the focus to a different field first which is unfriendly this is fixed by losing the focus before accepting the changes This looks

Re: [PATCH] Don't calculate with NaN when on 100% o2

2014-03-17 Thread Dirk Hohndel
On Mon, 2014-03-17 at 13:05 -0700, Linus Torvalds wrote: On Mon, Mar 17, 2014 at 12:25 PM, Anton Lundin gla...@acc.umu.se wrote: Fixes: 465 Actually, probably only on x86. double ratio = (double)fhe / (1000.0 - fo2); + /* if we have 100% o2, ratio is nan

<    2   3   4   5   6   7   8   9   10   >