Re: Patch

2014-03-16 Thread Dirk Hohndel
On Sun, 2014-03-16 at 15:39 +0800, Rishubh Jain wrote: I have attached two screenshots..one is of the code..I guess I have covered on all the indentation problems and also about that writesetting function, i was not sure what to do exactly so I would like to discuss that with you. A

Re: Some question about Touch UI Port (Android) - GSOC 2014

2014-03-16 Thread Dirk Hohndel
On Sun, 2014-03-16 at 11:39 +, Thongchai Wirojsakseree wrote: Dear Subsurface team, My name is Thongchai Wirojsakseree. I am a student at Bristol university in the UK. I am looking to submission a project in GSOC and I am interested in Subsurface which relates with GPS. When I am

Re: Some question about Touch UI Port (Android) - GSOC 2014

2014-03-16 Thread Dirk Hohndel
On Mar 16, 2014, at 12:26 PM, Chris Lewis chrislewis...@gmail.com wrote: This is perhaps a little off topic but I also live in Bristol. Do you actually dive? If you would like to give it a try in a pool I am a member of a local club so could help you out. +1 - I think that’s totally on

Re: Some subsurface notes from a week of diving

2014-03-16 Thread Dirk Hohndel
On Mar 16, 2014, at 1:45 PM, Anton Lundin gla...@acc.umu.se wrote: I just came home from a nice week of diving in the Red Sea, and here is some sort of braindump about the issues i found in subsurface during this week. Crashes when trying to add a Gas Change event after selecting another

Re: [PATCH] Improve partial pressure graphs

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 19:00 +0100, Jan Mulder wrote: This being my first submission to this list, first a very short introduction. I'm an active technical diver, both in long range cave diving context and a little (deep) wreck diving. Obviously, this involves a lot of gear, different

Re: facing problem in code compiling

2014-03-15 Thread Dirk Hohndel
On Sun, 2014-03-16 at 02:09 +0800, Farzana Raisa wrote: I am facing problem in compiling your source code in ubuntu. Though i have compiled livedivecomputer it is saying unable to locate package libgit2-dev. What to do? First, sending email just to me is rarely a great idea, unless you have a

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 10:46 -0700, Linus Torvalds wrote: There are two bugs that shows in subsurface: - the default cylinder behavior is broken, broken, broken. You have set your default cylinder to AL80 (which is actually the default if nothing has been set manually), and at least one of

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 12:41 -0700, Linus Torvalds wrote: On Sat, Mar 15, 2014 at 12:26 PM, Dirk Hohndel d...@hohndel.org wrote: So here's what I'm proposing to fix the current implementation a) if no default cylinder is set, don't just use AL80. Disable the default cylinder logic b

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 21:07 +0100, Robert C. Helling wrote: I think what Linus points out is quite important: It is quite unfortunate that we treat “gas change” to be equivalent to “cylinder index change”. We already had complaints from people who wanted to have several cylinders containing

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 13:38 -0700, Linus Torvalds wrote: On Sat, Mar 15, 2014 at 1:23 PM, Dirk Hohndel d...@hohndel.org wrote: OK, I just pushed out two commits that make these two changes. Actually, I think the second one is buggy. You did this: if (i == 0 !get_tanksize(devdata

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 13:45 -0700, Dirk Hohndel wrote: Brain fart. You are of course correct. Thanks for catching this. Speaking of Brain Farts. Yesterday was Pie Day. Today is humble pie day - at least for me. Trying to track down the bug you described when deleting a single cylinder I

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 17:19 -0700, Linus Torvalds wrote: On Sat, Mar 15, 2014 at 1:57 PM, Dirk Hohndel d...@hohndel.org wrote: Based on our logic you SHOULD NOT be able to delete either of the cylinders as they are both IN USE. You have to FIRST delete the gas change event (making

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 17:54 -0700, Dirk Hohndel wrote: And right now I don't think we have any way to remove gas events... Details, details. I'll fix that. I just pushed a commit that fixes this. I have several doubts about the commit. a) I don't know why the selection with -items

Re: [PATCH] Ticket #423 - Import GPX file from SD card

2014-03-14 Thread Dirk Hohndel
On Fri, 2014-03-14 at 15:31 +0100, Jef Driesen wrote: On 2014-03-11 19:26, Venkatesh Shukla IIT BHU wrote: 1. As I have seen there are two projects that could be taken up in the field of android application for Subsurface in Google Summer of Code. a. First is a full feature port of

Re: Minizip integration in Subsurface

2014-03-14 Thread Dirk Hohndel
On Fri, 2014-03-14 at 14:29 -0500, Alberto Corona wrote: So I was digging around in the mailing list archives and found this discussion on the move to minizp: http://lists.hohndel.org/pipermail/subsurface/2014-January/009644.html Was a decision reached on how minizip will be used (static v

Re: [PATCH] Improved handling of git syntax names with no git repository

2014-03-14 Thread Dirk Hohndel
On Fri, 2014-03-14 at 18:00 -0700, Linus Torvalds wrote: From: Linus Torvalds torva...@linux-foundation.org Date: Fri, 14 Mar 2014 17:55:07 -0700 Subject: [PATCH] Improved handling of git syntax names with no git repository This makes is_git_repository() return non-NULL for all file names

Re: Few bugs and a feature req from testing Subsurface

2014-03-13 Thread Dirk Hohndel
On Thu, 2014-03-13 at 23:06 +0200, Miika Turkia wrote: So here is log of the two dives. Seems that Vyper, that was downloaded first, does not have any gas change events on it. On the other hand Stinger has one such event... Shouldn't a gaschange event be generated on download even if the

Re: another dependency glitch

2014-03-13 Thread Dirk Hohndel
On Mar 13, 2014, at 4:59 PM, Cristian Ionescu-Idbohrn cristian.ionescu-idbo...@axis.com wrote: Simple make on an already built master, after pulling: compiling qt-ui/about.cpp compiling save-git.c compiling subsurfacestartup.c make: *** No rule to make target

Re: Few bugs and a feature req from testing Subsurface

2014-03-13 Thread Dirk Hohndel
On Thu, 2014-03-13 at 18:26 -0600, Miika Turkia wrote: As always, it's complicated. For Suunto divecomputers we should have exactly the gas change events that the computer sends to us. On multi gas capable Suuntos you ALWAYS start with the first gas, so there's no change necessary. On

Re: Updates to manual

2014-03-12 Thread Dirk Hohndel
On Wed, 2014-03-12 at 09:49 +0200, Willem Ferguson wrote: The user interface is changing quite rapidly. Would it be acceptable that we wait for the new set of buttons on the profile panel is finalised before Pedro and myself proceed with the corresponding updates in the manual? Or would

Re: 4.1 planning

2014-03-12 Thread Dirk Hohndel
On Wed, 2014-03-12 at 17:56 +0300, Joshua Joseph wrote: What am I missing? Hi Dirk, I am working on the check for updates feature. Thanks for the reminder. I occasionally see you testing the backend service. Let me know if you need any changes there. This obviously will impact the

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-12 Thread Dirk Hohndel
On Wed, 2014-03-12 at 19:01 +0200, Lubomir I. Ivanov wrote: so perhaps the patch can be modified to exclude the preferences dialog change? I would accept a patch modified like that. I just think there are a few scenarios in which it is nice if the preferences dialog is not modal.

Re: [PATCH 3/4] MainWindow: maintain one window instance of the yearly statistics

2014-03-12 Thread Dirk Hohndel
On Wed, 2014-03-12 at 19:09 +0200, Lubomir I. Ivanov wrote: On 11 March 2014 20:38, Lubomir I. Ivanov neolit...@gmail.com wrote: On 11 March 2014 20:25, Dirk Hohndel d...@hohndel.org wrote: On Tue, 2014-03-11 at 18:31 +0200, Lubomir I. Ivanov wrote: From: Lubomir I. Ivanov neolit

Re: partial fix to coding style suggestions for vim settings

2014-03-11 Thread Dirk Hohndel
On Tue, 2014-03-11 at 07:01 -0600, Miika Turkia wrote: On 10 Mar 2014, at 13:02, Lakshman acrlaksh...@gmail.com wrote: This is my mistake, instead of using one tab character as per the mail by Thiago just now, I was using 4 spaces. I saw the commit messages in git log and wrongly

Re: [PATCH 1/4] Profile2: provide means to disable the tool buttons

2014-03-11 Thread Dirk Hohndel
On Tue, 2014-03-11 at 18:30 +0200, Lubomir I. Ivanov wrote: From: Lubomir I. Ivanov neolit...@gmail.com Once the poster is displayed when there are no dives in the list, we may also want to disable the QToolButtons (PO2, SAC, etc..), until a new dive is loaded and the profile is redrawn.

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Dirk Hohndel
On Tue, 2014-03-11 at 18:30 +0200, Lubomir I. Ivanov wrote: From: Lubomir I. Ivanov neolit...@gmail.com For some dialogs like Preferences and Renumber it would be much safer to make them Qt::WindowModal to the parent (MainWindow). Initially the Preferences was non-modal on purpose. So the

Re: [PATCH 5/6] Ruler: change how the ruler text drawing works

2014-03-11 Thread Dirk Hohndel
On Wed, 2014-03-12 at 00:09 +0200, Lubomir I. Ivanov wrote: From: Lubomir I. Ivanov neolit...@gmail.com A couple of problems with the ruler: - the rotated text doesn't look very well at all and interpolation doesn't help it much - measuring towards the right most part of the profile makes

Re: [PATCH 3/4] Profile2: use a different image when no profile is visible

2014-03-10 Thread Dirk Hohndel
On Mon, 2014-03-10 at 17:59 +0200, Lubomir I. Ivanov wrote: From: Lubomir I. Ivanov neolit...@gmail.com This patch adds a new image resource named poster.png which, is shown instead of the 3 posters. The main reason for that is due to the poster text not being visible. This new image is

Re: [PATCH 2/2] Profile2: use an implicit initializer for a struct array

2014-03-10 Thread Dirk Hohndel
On Mon, 2014-03-10 at 13:43 +0200, Lubomir I. Ivanov wrote: From: Lubomir I. Ivanov neolit...@gmail.com Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- last warning from -Wall with 4.4.0. --- qt-ui/profile/diveprofileitem.cpp | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] Ticket #423 - Import GPX file from SD card

2014-03-09 Thread Dirk Hohndel
Venkatesh, thanks for sending this patch! On Sun, 2014-03-09 at 13:34 +0530, Venkatesh Shukla IIT BHU wrote: Framework added for importing GPX file from SD card. A friend of mine and occasional dive buddy was the one who entered this suggestion. He will be thrilled to hear that someone is

Re: Need guidance for Android divecomputer downloader

2014-03-09 Thread Dirk Hohndel
On Sun, 2014-03-09 at 06:44 +0530, Harshit Gupta B.Tech., Electrical, IT-BHU, Varanasi (INDIA) wrote: I need some guidance from where I can study about how the desktop application works or atleast give me the links , so that I can understand the code and try to implement it on Android. I asked

Re: Feature: Showing units along with labels

2014-03-09 Thread Dirk Hohndel
Hi Lakshman, On Sun, 2014-03-09 at 03:13 -0500, Lakshman wrote: In an attempt to slightly enhance user experience, I tried to show units along with labels. This feature can be enabled or disabled as shown in the attached snapshots. Patch is also attached. Would be grateful for any sort of

Re: Need guidance for Android divecomputer downloader

2014-03-09 Thread Dirk Hohndel
On Sun, 2014-03-09 at 08:20 -0700, Dirk Hohndel wrote: many are divers (including Linux and myself) and as often as we can get ---^^^ This may be my most common typo, ever. I fix this at least once in every email to Linus (or about Linus) that I send... Thankfully I

Re: Improving the authentication process of subsurface.

2014-03-09 Thread Dirk Hohndel
On Sat, 2014-03-08 at 20:22 +0100, Aurélien PRALONG wrote: Harshit, I have to click on the click on existing account option and after writing my email-id, An email is received containing my generated id. Then I have to copy my generated id and then paste in the retrieve account option.

Re: [PATCH 02/12] Fix event saving in git format due to wrong argument order

2014-03-09 Thread Dirk Hohndel
On Sun, 2014-03-09 at 18:42 -0700, Linus Torvalds wrote: The argument order is a bit mixed up, which is partly why this happened. But considering that this is the worst bug I've hit so far in the saving code, I guess I shouldn't complain too much. Signed-off-by: Linus Torvalds

Re: [PATCH 03/12] git save format: add dive computer nicknames and firmware details

2014-03-09 Thread Dirk Hohndel
On Sun, 2014-03-09 at 18:42 -0700, Linus Torvalds wrote: + +#define VERSION 2 Why version 2? Wouldn't this be 3? Or are you considering this equivalent to our v2 file format? /D ___ subsurface mailing list subsurface@hohndel.org

Re: [PATCH 05/12] git repository reading: start reading the actual file contents

2014-03-09 Thread Dirk Hohndel
On Sun, 2014-03-09 at 18:43 -0700, Linus Torvalds wrote: From: Linus Torvalds torva...@linux-foundation.org Date: Sat, 8 Mar 2014 13:11:50 -0800 Subject: [PATCH 05/12] git repository reading: start reading the actual file contents If we want to scale to thousands of dives, we'll eventually

Re: [PATCH 07/12] Parse basic trip and dive data from the git blobs

2014-03-09 Thread Dirk Hohndel
On Sun, 2014-03-09 at 18:44 -0700, Linus Torvalds wrote: From: Linus Torvalds torva...@linux-foundation.org Date: Sun, 9 Mar 2014 12:19:41 -0700 Subject: [PATCH 07/12] Parse basic trip and dive data from the git blobs Some things are still missing: samples and events, and cylinder and

Re: [PATCH 12/12] parse divecomputer model nickname/firmware/serial information

2014-03-09 Thread Dirk Hohndel
On Sun, 2014-03-09 at 18:47 -0700, Linus Torvalds wrote: From: Linus Torvalds torva...@linux-foundation.org Date: Sun, 9 Mar 2014 18:31:36 -0700 Subject: [PATCH 12/12] parse divecomputer model nickname/firmware/serial information This was the final piece we didn't read. I can now read my

Re: [PATCH 12/12] parse divecomputer model nickname/firmware/serial information

2014-03-09 Thread Dirk Hohndel
On Sun, 2014-03-09 at 20:55 -0700, Linus Torvalds wrote: On Sun, Mar 9, 2014 at 8:24 PM, Dirk Hohndel d...@hohndel.org wrote: I get Unmatched action 'salinity' when reading back the data I write out... Ahh, an example of something I don't have in my dives. You could have tried mine

Re: [PATCH 06/12] Start actually parsing the git object data

2014-03-09 Thread Dirk Hohndel
On Sun, 2014-03-09 at 20:48 -0700, Linus Torvalds wrote: On Sun, Mar 9, 2014 at 8:14 PM, Dirk Hohndel d...@hohndel.org wrote: +#define MAXLINE 100 Can you remind me why this is a valid assumption? We simply ensure this max length when writing and then any tool outside of Subsurface

Re: [PATCH 03/12] git save format: add dive computer nicknames and firmware details

2014-03-09 Thread Dirk Hohndel
On Sun, 2014-03-09 at 20:42 -0700, Linus Torvalds wrote: On Sun, Mar 9, 2014 at 8:02 PM, Dirk Hohndel d...@hohndel.org wrote: Or are you considering this equivalent to our v2 file format? Yes, I consider the git format to be the same version as the XML format. They really are very similar

Re: Improving the authentication process of subsurface.

2014-03-08 Thread Dirk Hohndel
On Sat, 2014-03-08 at 17:32 +0530, Harshit Gupta B.Tech., Electrical, IT-BHU, Varanasi (INDIA) wrote: Hi all.! I am one of the GSoC'14 aspirant and have been trying to study the Android Companion App of subsurface. Initially when playing with the app, I found it cumbersome while retrieving

Re: Patch

2014-03-08 Thread Dirk Hohndel
On Sat, 2014-03-08 at 23:00 +0800, Rishubh Jain wrote: Hey Dirk Please review my patch once more ...I think its usefull and i guess even few people like thiago thinks it will be usefull, It makes the UI a little more friendly You have not read my response. You have not reacted to the

Re: Patch

2014-03-08 Thread Dirk Hohndel
On Sun, 2014-03-09 at 03:20 +0800, Rishubh Jain wrote: sorry forgot to attach...attached here On Saturday, 8 March 2014 11:48 PM, Rishubh Jain rishubhj...@ymail.com wrote: Hi Dirk I have attached a screen shot with this mail of the new message box...please check if this is to your

Re: [PATCH] Make Marble optional

2014-03-07 Thread Dirk Hohndel
/0x1A/subsurface/commit/eb215101097120f8c62339fd767b71574cdd0bbd On Mon, Mar 3, 2014 at 7:29 PM, Dirk Hohndel d...@hohndel.org wrote: On Mon, 2014-03-03 at 18:17 -0600, Alberto

Re: RFC: Initial git save format

2014-03-07 Thread Dirk Hohndel
On Fri, 2014-03-07 at 08:12 -0800, Linus Torvalds wrote: On Mar 7, 2014 5:42 AM, Tomaz Canabrava tcanabr...@kde.org wrote: can anybody recheck this for me? from what Linus wrote, this should work for libgit2 0.20, but I had to extend his macro to check the libgitversion to be = 20.

Re: RFC: Initial git save format

2014-03-07 Thread Dirk Hohndel
On Fri, 2014-03-07 at 08:30 -0800, Dirk Hohndel wrote: On Fri, 2014-03-07 at 08:12 -0800, Linus Torvalds wrote: On Mar 7, 2014 5:42 AM, Tomaz Canabrava tcanabr...@kde.org wrote: can anybody recheck this for me? from what Linus wrote, this should work for libgit2 0.20, but I had

Re: [PATCH] Add libgit2 dependency to INSTALL file (MacPorts stanza)

2014-03-07 Thread Dirk Hohndel
On Fri, 2014-03-07 at 15:25 +0100, Giuseppe 'ferdy' Miceli wrote: Update the instruction to build Subsurface on MacOSX using MacPorts after the introduction of git-save format and its libgit2 dependency. Please note that (at least on MacOSX using Macports) building Subsurface fails at make

Re: RFC: Initial git save format

2014-03-07 Thread Dirk Hohndel
On Fri, 2014-03-07 at 13:03 -0800, Linus Torvalds wrote: On Fri, Mar 7, 2014 at 12:45 PM, Robert C. Helling hell...@atdotde.de wrote: I hope you mean something like ~/.subsurface or even ~/.subsurfacerc . At least for me ~/subsurface is already a git repository and is my subsurface

Re: Patch

2014-03-07 Thread Dirk Hohndel
On Sat, 2014-03-08 at 12:24 +0800, Rishubh Jain wrote: I hope this is it...The patch is just an enhancement . its a small try to improve the UI of subsurface. While Quiting instead of asking the user to go back and either save or discard changes it asks the user to save changes or discard the

Re: Patch

2014-03-07 Thread Dirk Hohndel
March 2014 10:15 AM, Dirk Hohndel d...@hohndel.org wrote: On Sat, 2014-03-08 at 12:24 +0800, Rishubh Jain wrote: I hope this is it...The patch is just an enhancement . its a small try to improve the UI of subsurface. While Quiting instead of asking the user to go back and either save

Re: [PATCH] Fixed layout of yearly statistics model

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 18:59 +0530, Heena Mahour wrote: From aacfca96716bbb82f6bb9b14e32e590c0c11ec7c Mon Sep 17 00:00:00 2001 From: heena mahour heena...@gmail.com Date: Thu, 6 Mar 2014 18:52:36 +0530 Subject: [PATCH 4/4] Signed-off-by: heena mahour heena...@gmail.com Yearly Statistics

Re: Update Checking

2014-03-06 Thread Dirk Hohndel
On Wed, 2014-03-05 at 16:50 +0300, Joshua Joseph wrote: Hi, The attached patch implements the check for updates feature for windows and mac. A few comments... I would much rather like the app to figure out the OS it's running on at runtime. It would be useful for us to know if people run

Re: Update Checking

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 10:57 -0800, Thiago Macieira wrote: Em qua 05 mar 2014, às 16:50:20, Joshua Joseph escreveu: Hi, The attached patch implements the check for updates feature for windows and mac. Why are you translating the URL? Do you expect it to be localised? Missed that one.

Re: Import from webservice

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 20:02 +0100, Jan Birk wrote: Den 06-03-2014 19:41, Dirk Hohndel skrev: The idea is that you download the dive from your dive computer (or manually add it to the dive log). Then downloading the location data from the web service will match the location to the dive(s

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 13:28 -0800, Linus Torvalds wrote: So Dirk knows about this effort, and it's been rattling around in my head for a long while, but it took some time for me to digest how to actually do it. When I saw your G+ post I was trying to remember when we first started talking

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 14:29 -0800, Linus Torvalds wrote: On Thu, Mar 6, 2014 at 2:03 PM, Dirk Hohndel d...@hohndel.org wrote: compiling save-git.c save-git.c: In function ‘create_new_commit’: save-git.c:569:3: error: too many arguments to function ‘git_branch_create’ save-git.c:572:2

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
If you don't mind I'd add this to your previous commit - this way I have one fewer possible doesn't compile point when doing a git bisect in the future. You also forgot a commit message and SOB... /D On Thu, 2014-03-06 at 14:40 -0800, Linus Torvalds wrote: On Thu, Mar 6, 2014 at 2:29 PM,

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 15:03 -0800, Linus Torvalds wrote: On Thu, Mar 6, 2014 at 1:54 PM, Dirk Hohndel d...@hohndel.org wrote: how do you intend the actual UI to work? Ideally this would be a no user interaction UI in most cases. I don't want divers to have to wonder what we might mean

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 16:20 -0800, Linus Torvalds wrote: On Thu, Mar 6, 2014 at 3:20 PM, Dirk Hohndel d...@hohndel.org wrote: The problem with that is that it exposes terminology to Joe and Jane Diver that I'd prefer to hide from them. Actually, with the git save-file, my *preference

Re: Very minor patch, added new terms to doc

2014-03-05 Thread Dirk Hohndel
On Wed, 2014-03-05 at 22:19 +0530, Gopichand Paturi wrote: Hello All, This is a very minor patch involving adding some useful terms into terms.txt file. Firstly let me know if I made any patch mistakes. This time I don't want to repeat them. I did not put a commit message since this is

Re: Gsoc idea: Android downloader

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 15:24 +0100, Anton Lundin wrote: The serial api may not be exposed to the java world, but it is certainly usable from native code. As far as I know, you only needed a few minor tweaks to compile libdivecomputer for Android [1]. Once we have that, an Android

Re: CodingStyle

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 15:41 +0100, Cristian Ionescu-Idbohrn wrote: Emacs has the ability to learn coding styles. Cool, I had never used that before. Dirk, Could you please point out a few files that could be used as templates? At this point, the C/C++/h files have been reformatted using

Re: CodingStyle

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 16:17 +0100, Cristian Ionescu-Idbohrn wrote: On Mon, 3 Mar 2014, Dirk Hohndel wrote: On Mon, 2014-03-03 at 15:41 +0100, Cristian Ionescu-Idbohrn wrote: Emacs has the ability to learn coding styles. Cool, I had never used that before. Dirk, Could you

Re: [PATCH] Added .DS_Store file to .gitignore

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 12:25 -0800, Thiago Macieira wrote: Em seg 03 mar 2014, às 09:37:13, Dirk Hohndel escreveu: On Mon, 2014-03-03 at 17:05 +0100, Giuseppe 'ferdy' Miceli wrote: Shall we have git ignore annoying MacOSX's .DS_Store file as well? Good idea. minor style suggestion

Re: CodingStyle

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 07:37 -0800, Dirk Hohndel wrote: At this point, the C/C++/h files have been reformatted using my clang tool. Some things are not as I would love them to be (e.g. what was done to the enums), but as I said when I announced that commit - this is better than what we

Re: Subsurface on Android and desktop

2014-03-03 Thread Dirk Hohndel
Quick response from my phone. Linus and I discussed this in detail. He is working on a new storage backbend for subsurface that will allow keeping desktop and mobile (or other multiple instance configurations) consistent and in sync. He is distracted by his other little open source project, but

Re: Assigned Patch

2014-03-02 Thread Dirk Hohndel
We don't use the assigned field of trac. I see that people are assigning bugs to themselves but as far as I'm concerned that is meaningless. /D --- From my phone Muhammad Umair m.umai...@gmail.com wrote: Hi Dirk, I let you know that people are talking patch that are already assigned.  I am

Re: GSOC 2014

2014-03-02 Thread Dirk Hohndel
On Mon, 2014-03-03 at 09:59 +0530, Darshana Prasad wrote: Hi subsurface team. I am a student in Sri Lankan University. I have created a symbian app with Qt and and I am quite familiar with Qt and C++, Qt libraries. I have gone through the idea page and i am interested in and l\my skills

Re: [PATCH] Make Marble optional

2014-03-01 Thread Dirk Hohndel
On Sat, 2014-03-01 at 08:08 -0600, Alberto Corona wrote: My intentions weren't to pass someone else's code as mine, hence Implemented some changes suggested by glance, though you're right, I should have asked them first. No. some changes suggested by glance means you talked to him and then

Re: [PATCH] Make Marble optional

2014-03-01 Thread Dirk Hohndel
Hey Lubomir, thanks for the great review and feedback. Much appreciated. my other email focused on the origin of the patch - so Alberto, as you continue to work on this, please take Lubomir's comments into account as well. /D On Sat, 2014-03-01 at 12:15 +0200, Lubomir I. Ivanov wrote: On 1

Re: My First patch

2014-03-01 Thread Dirk Hohndel
Let me be a little more forceful here :-) On Sat, 2014-03-01 at 21:32 +0200, Lubomir I. Ivanov wrote: I am sending this,as an improvement to the existing code since goto is not preferred as a reliable keyword in software development process. goto is perfectly fine in a lot of cases and

Re: GSoC-2-14

2014-02-27 Thread Dirk Hohndel
On Thu, 2014-02-27 at 11:27 -0500, Sewwandi Wijayaratna wrote: hello, I am a female graduate student studying electrical and computer engineering and I would like to participate in GSoC 2014 program. Hi Sewwandi I am interested to provide a proposal for the project Better Zip file

Re: GSoC 2014 IPhone Companion APP

2014-02-27 Thread Dirk Hohndel
On Thu, 2014-02-27 at 20:05 +0100, Muhammad Umair wrote: I am very much interested in IPhone Companion APP”. I would like to know about more details about the project. Besides, I have the following questions. a) UI for IPhone and IPad will be similar or different ? Given how simple

Re: GSoC 2014 Ideas

2014-02-26 Thread Dirk Hohndel
On Wed, 2014-02-26 at 21:10 +0200, Lubomir I. Ivanov wrote: On 26 February 2014 20:51, Alberto Corona albco...@gmail.com wrote: Hey Lubomir, I've tried building subsurface natively on Windows but ran into quite a few problems when following the INSTALL instructions. What method do you got

Re: [PATCH] Typesetting in profile infobox

2014-02-26 Thread Dirk Hohndel
On Thu, 2014-02-27 at 01:36 +0200, Andrey Zhdanov wrote: There should be a space between the colon and the value in the information box in the profile. The vertical speed should have only one digit after the decimal point (at least in metric units). Fixes #443 Signed-off-by: Andrey

Re: GSoC 2014 Ideas

2014-02-26 Thread Dirk Hohndel
On Wed, 2014-02-26 at 17:54 -0600, Alberto Corona wrote: Alright so, I've gone through either building most of the dependencies natively, or using the binaries and I'd like to make a few changes to the instructions. Most notably using Cygwin instead of Msysgit as Cygwin has an installer that

Re: GSoC 2014 Ideas

2014-02-26 Thread Dirk Hohndel
On Wed, 2014-02-26 at 16:47 -0800, Thiago Macieira wrote: Em qua 26 fev 2014, às 16:38:15, Dirk Hohndel escreveu: On Wed, 2014-02-26 at 17:54 -0600, Alberto Corona wrote: Alright so, I've gone through either building most of the dependencies natively, or using the binaries and I'd like

Re: GSoC 2014 Ideas

2014-02-26 Thread Dirk Hohndel
On Wed, 2014-02-26 at 18:00 -0800, Thiago Macieira wrote: Em qua 26 fev 2014, às 17:20:19, Dirk Hohndel escreveu: As for the issue of the GCC version being old, feel free to get a newer version of MinGW. The Qt 4.8.6 pre-release packages are now built with a new MinGW too: http

Re: Mac retina support in Qt

2014-02-25 Thread Dirk Hohndel
On Tue, 2014-02-25 at 16:53 -0800, Thiago Macieira wrote: Em ter 25 fev 2014, às 16:49:09, Thiago Macieira escreveu: Em ter 25 fev 2014, às 16:18:17, Thiago Macieira escreveu: I don't know. Something to ask in the interest mailing list, though. Retina display support should be working

Re: GSOC 2014

2014-02-25 Thread Dirk Hohndel
On Wed, 2014-02-26 at 00:30 -0500, Yaoxuan Jiang wrote: Hi, My name is Yaoxuan. I’m a 4th year computer science student from National University of Singapore. I’ m quite interested in the iPhone App idea and I've around 2-year iOS programming experience. I’ve interned in two start-ups to

Re: GSOC 2014

2014-02-25 Thread Dirk Hohndel
Please ALWAYS keep the mailing list in the Cc (unless you really have private / personal stuff to discuss) On Wed, 2014-02-26 at 01:21 -0500, Yaoxuan Jiang wrote: What I want to say is It’s possible to keep the background task alive and do the tracking by time interval. However, the

[Fwd: [Subsurface] Your organization application has been accepted.]

2014-02-24 Thread Dirk Hohndel
Forwarded Message From: no-re...@google-melange.appspotmail.com To: d...@hohndel.org Subject: [Subsurface] Your organization application has been accepted. Date: Mon, 24 Feb 2014 18:40:43 + Congratulations! Your Organization Application for Subsurface to Google Summer of

Re: [Fwd: [Subsurface] Your organization application has been accepted.]

2014-02-24 Thread Dirk Hohndel
Those of you who have (been) volunteered to mentor... could you sign up at melange for a mentor account and then connect to the subsurface project there, please? /D On Mon, 2014-02-24 at 10:55 -0800, Dirk Hohndel wrote: Forwarded Message From: no-re...@google

Re: GSoC 2014 Ideas

2014-02-24 Thread Dirk Hohndel
We suggest that all students start by submitting a couple of small patches before we pick them... This will help us get to know you better... /D --- From my phone Alberto Corona albco...@gmail.com wrote: ___ subsurface mailing list

Re: Add main menu recent files

2014-02-21 Thread Dirk Hohndel
On Fri, 2014-02-21 at 07:29 -0800, Dirk Hohndel wrote: You also need to decide whether the keys are 0 based or one based: +for (int c = 1; c = 4; c++) { +QString key = QString(File_%1).arg(c); and later +for (int c = 0; c 4; c++) { +QString key = QString(File_

Re: Your email address could not been confirmed, has your session expired?

2014-02-19 Thread Dirk Hohndel
Hi Armin On Wed, 2014-02-19 at 10:57 +0100, Armin Leuprecht wrote: dear developers, no matter which browser i use, i always get this error message (see subject) when i try to confirm my account at hohndel.org Sorry about that. It's a known problem that we still haven't figured out. For

Re: Any CCR divers on this list?

2014-02-19 Thread Dirk Hohndel
On Wed, 2014-02-19 at 14:05 +, Paul Sargent wrote: We have had several requests for enhanced capabilities for CCR diving. I have added this as one of the proposals for the Google Summer of Code application, but we really need at least some internal support from

Re: latest master

2014-02-18 Thread Dirk Hohndel
On Tue, 2014-02-18 at 16:25 -0800, Thiago Macieira wrote: Em ter 18 fev 2014, às 16:16:10, Dirk Hohndel escreveu: On Feb 18, 2014, at 3:47 PM, Tomaz Canabrava tcanabr...@kde.org wrote: dirk, can you test the patch? I couldn`t really understand why it crashed if not static, since we should

fair warning - white space changes are coming

2014-02-17 Thread Dirk Hohndel
If you have any outstanding patches, those might become a little harder to apply as I will be running my coding style / whitespace tool over the sources in the next few hours. Please let me know if that's an issue for you. I'm reasonably certain that I can actually make it work if you send me

latest master

2014-02-17 Thread Dirk Hohndel
This does not include the promised whitespace overhaul. Instead I added a few outstanding patches and went down the rabbit hole of trying to track down a crash with Robert's image shift patches. Here's how I can reliably reproduce this. Open a dive log in Subsurface - one of the test dives will

Re: latest master

2014-02-17 Thread Dirk Hohndel
On Mon, 2014-02-17 at 23:34 -0300, Tomaz Canabrava wrote: On Mon, Feb 17, 2014 at 7:57 PM, Dirk Hohndel d...@hohndel.org wrote: This does not include the promised whitespace overhaul. Instead I added a few outstanding patches and went down the rabbit

Re: Hilfe Import Computerdatan

2014-02-16 Thread Dirk Hohndel
On Sun, 2014-02-16 at 17:29 +0100, Michael Schlick wrote: Hallo, Ich benötige Hilfe beim Import der Tauchdaten aus der Memomouse. Ich habe leider keine andere Supportfunktion gefunden und versuche es nun auf diesem Wege. Ich verwende noch ein älteres Exemplar, das nur einen seriellen

Re: Hilfe Import Computerdatan

2014-02-16 Thread Dirk Hohndel
On Sun, 2014-02-16 at 08:42 -0800, Dirk Hohndel wrote: On Sun, 2014-02-16 at 17:29 +0100, Michael Schlick wrote: Hallo, Ich benötige Hilfe beim Import der Tauchdaten aus der Memomouse. Ich habe leider keine andere Supportfunktion gefunden und versuche es nun auf diesem Wege. Ich

Re: [PATCH 1/2] micro-optimisation: avoid division in main strtod() loop

2014-02-16 Thread Dirk Hohndel
I think I'll have to pull the full email into the commit message... /D --- From my phone Linus Torvalds torva...@linux-foundation.org wrote: From: Linus Torvalds torva...@linux-foundation.org Date: Mon, 10 Feb 2014 13:41:00 -0800 Subject: [PATCH 1/2] micro-optimisation: avoid division in main

Re: [PATCH 2/2] Fix missed +0.5 rounding - use rint() instead

2014-02-16 Thread Dirk Hohndel
On Sun, 2014-02-16 at 11:52 -0800, Linus Torvalds wrote: I'm still thinking about better file formats and backup, but haven't come up with anything that I'm actually happy about. In the meantime I'm dicking around and sending out these silly small cleanups. I for one enjoy them. As

Re: Create backup file when writing new xml file?

2014-02-16 Thread Dirk Hohndel
On Sun, 2014-02-16 at 14:21 -0800, Dirk Hohndel wrote: I will take the patch as is and ask the Windows expert (Lubomir) and the Qt export (Thiago) to see if there is something we should do differently. Should have looked more closely... this is lacking a concise commit message and SOB... /D

Re: Create backup file when writing new xml file?

2014-02-16 Thread Dirk Hohndel
On Sun, 2014-02-16 at 13:25 -0800, Linus Torvalds wrote: On Sun, Feb 16, 2014 at 11:52 AM, Linus Torvalds torva...@linux-foundation.org wrote: I'm still thinking about better file formats and backup, but haven't come up with anything that I'm actually happy about. So I really haven't

Re: Import from Suunto Cobra TC not possible

2014-02-15 Thread Dirk Hohndel
On Sat, 2014-02-15 at 08:11 +0100, Jef Driesen wrote: On 14-02-14 17:06, Wolfgang Uhl wrote: wow, that's quick response! Answering emails is easy. Fixing the problem usually takes a bit longer :-) Allright, i only enabled logfile, but not dump and started the import again, please find

<    3   4   5   6   7   8   9   10   >