Re: [patch] Small code simplification

2013-12-26 Thread Dirk Hohndel
On Thu, 2013-12-26 at 15:02 +0100, Patrick Valsecchi wrote: Usage of QStringList::contains instead of iterating the list. Thanks, Patrick. That's much simpler and easier to read. /D ___ subsurface mailing list subsurface@hohndel.org

Re: Some recent change completely broke the DC import

2013-12-26 Thread Dirk Hohndel
On Thu, 2013-12-26 at 16:08 +0100, Lutz Vieweg wrote: Hi, I was just in the process of recording the DC import process for the v4 video tutorial when I noticed that precisely that import does not work anymore (at least with the Suunto D9, but I suspect a generic issue). The bug must have

Re: Ctrl+f in manual

2013-12-26 Thread Dirk Hohndel
On Dec 26, 2013, at 4:24 PM, Lutz Vieweg l...@5t9.de wrote: Hi, I wondered whether a find function exists in the Manual display, so I just tried: When I pressed Ctrl+f, a small white entry field appeared - but in an unexpected location - obscuring part of the dive list headline, not

Re: Ctrl+f in manual

2013-12-26 Thread Dirk Hohndel
On Dec 26, 2013, at 4:39 PM, Lutz Vieweg l...@5t9.de wrote: On 12/27/2013 01:26 AM, Dirk Hohndel wrote: Would you mind filing bugs on these things? Done. Thanks Now it's good night for me, will have to get back to the grindstone in the morning. Making progress on the v4 video

Re: Figures in manual

2013-12-24 Thread Dirk Hohndel
On Tue, 2013-12-24 at 14:30 -0200, Tomaz Canabrava wrote: But, my particular opinion as a KDE user: I prefer the gnome look'n feel. really. :-) In all talks that I do I state that if KDE had the gnome designers, that would do a killer Desktop Enviroment. Umm. Don't get Linus (or me)

Re: GPS coordinate parsing

2013-12-24 Thread Dirk Hohndel
On Mon, 2013-12-23 at 15:14 -0800, Dirk Hohndel wrote: I just pushed a commit that attempts to improve the parsing of GPS coordinates: We used to only support full degrees and decimal minutes. We now also support fully decimal and degrees, minutes and decimal seconds

Re: Uwatec Smart Z data download takes 1.5 hours for only 4 dives

2013-12-23 Thread Dirk Hohndel
On Dec 23, 2013, at 4:29 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Mon, Dec 23, 2013 at 1:25 PM, Dirk Hohndel d...@hohndel.org wrote: Linus - I don't remember why we did not use the fingerprint based implementation... can you remind me? The fingerprint was too much

Re: collected fixes for the website

2013-12-18 Thread Dirk Hohndel
On Wed, 2013-12-18 at 22:09 +0200, Willem Ferguson wrote: The html is not OS-dependent. Strictly speaking it does not need to be built in the conventional way because among all OSs it is constant and the user does not really have need for the .txt version. Is there not a case to be made

Re: Install instructions

2013-12-17 Thread Dirk Hohndel
On Tue, 2013-12-17 at 17:21 +, Tim Wootton wrote: On 17/12/13 14:33, Dirk Hohndel wrote: This means that not only 'prefix' is missing - something is completely hosed: BINDIR = $(prefix)/bin DATADIR = $(prefix)/share DESKTOPDIR = $(DATADIR)/applications Those two install

Re: Install instructions

2013-12-17 Thread Dirk Hohndel
On Tue, 2013-12-17 at 18:13 +, Tim Wootton wrote: On 17/12/13 17:31, Dirk Hohndel wrote And I can already see why... and this makes me wonder why this works on my systems... Please edit the subsurface-install.pri file on your system, find the section above and remove

Re: merge window for Subsurface 4.1 is open

2013-12-16 Thread Dirk Hohndel
On Mon, 2013-12-16 at 09:14 +0100, Robert Helling wrote: On 16.12.2013, at 00:40, Dirk Hohndel d...@hohndel.org wrote: Dirk, Something like: a 4 weeks window to merge new features after a release. Then 8 weeks of bug fixing, documenting, translating, and finally a week to do

Re: [PATCH 4/4] Move the variable initialisations closer to use and add blanks

2013-12-16 Thread Dirk Hohndel
On Mon, 2013-12-16 at 09:06 -0800, Thiago Macieira wrote: Makes the code easier to read, IMHO. Yeah, this is one of those things that are REALLY a matter of taste and a matter of what you are used to. I always have preferred this style, having the variables declared as close to first use as

Re: Move XSLT files into a Qt resource

2013-12-16 Thread Dirk Hohndel
On Mon, 2013-12-16 at 09:09 -0800, Thiago Macieira wrote: This patch series moves the .xslt files and the xslt/ subdir in the installation into a Qt resource. That means it's in a read-only section of memory instead of on disk. Benefits are that we don't need to install and manage the files,

accented characters

2013-12-16 Thread Dirk Hohndel
With the Europeans trying Subsurface 4 now, we are getting reports that it doesn't deal well with accented characters: I've dowloaded a dive, went to edit the notes to: Plongée de Noël Hit the save button and got that back in my notes: Plong�e de No�l That

Re: [PATCH] Use UTF-8 for text strings.

2013-12-16 Thread Dirk Hohndel
So why would we need those explicit conversions? /D --- From my phone Michael Andreen h...@ruin.nu wrote: Fixes #371 Signed-off-by: Michael Andreen h...@ruin.nu --- I haven't been able to test it on windows, hopefully I didn't miss any strings. qt-ui/maintab.cpp | 20 ++-- 1

Re: Install instructions

2013-12-16 Thread Dirk Hohndel
On Tue, 2013-12-17 at 00:28 +0100, Jef Driesen wrote: On 17-12-13 00:03, Dazed_75 wrote: Just a reminder that no one has ever provided a fix for the problem originally reported. That being that if one wishes to build libdivecomputer in Linux, the directions provided on

Re: merge window for Subsurface 4.1 is open

2013-12-15 Thread Dirk Hohndel
On Mon, 2013-12-16 at 01:48 +0200, Lubomir I. Ivanov wrote: On 16 December 2013 01:40, Dirk Hohndel d...@hohndel.org wrote: Hehe... that caught your attention, didn't it? I am thinking of switching to a time based release methodology. There are a couple of weird obscure open source

<    5   6   7   8   9   10