From 255a7efe33839ea2fc3eb964e0f307e0bcc599fe Mon Sep 17 00:00:00 2001
From: Gehad elrobey gehadelro...@gmail.com
Date: Wed, 17 Sep 2014 12:54:26 +0300
Subject: [PATCH 1/2] HTML: fix typo in dive counter
adds a missing space to dive counter.
Fixes #722
Signed-off-by: Gehad elrobey gehadelro
From 4b6b926dbbb8f76c0cf50eae78d7b530d3e0ed7b Mon Sep 17 00:00:00 2001
From: Gehad elrobey gehadelro...@gmail.com
Date: Wed, 17 Sep 2014 13:22:48 +0300
Subject: [PATCH 2/2] HTML: Cursor is on top of graph tooltip
-change the color of the depth graph slightly to be more readable.
-change
loaded to the html page.
anyone have ideas to change this?
Regards,
Gehad
From eab7314c959f984814bf7d943310b0037bcfbf74 Mon Sep 17 00:00:00 2001
From: Gehad elrobey gehadelro...@gmail.com
Date: Wed, 27 Aug 2014 20:19:20 +0300
Subject: [PATCH] HTML: export valid JSON.
Remove the trailing commas from
On Wed, Aug 27, 2014 at 12:14 AM, Dirk Hohndel d...@hohndel.org wrote:
On Tue, Aug 26, 2014 at 11:13:22PM +0300, Gehad Elrobey wrote:
This is very useful thanks, I ll try to migrate the JSON exporter to this
model.
Yes, I think Linus' post was extremely useful. :-)
I'd love to see a patch
On Wed, Aug 27, 2014 at 9:43 AM, Salvo Tomaselli tipos...@tiscali.it
wrote:
Hello,
so, I think we should fix that json generation thing.
Do you have time for it or you want me to work on it on my own?
I am on a family vacation this week and have limited time on the computer,
I'll start
I think this can be done easily by just checking if the item is the last
item in the array before putting the commas.
Also I think there are other 3rd party JSON parsers for python that can be
more advanced and coup with the trailing commas.
Regards,
Gehad
On Tue, Aug 26, 2014 at 9:08 PM, Dirk
This is very useful thanks, I ll try to migrate the JSON exporter to this
model.
Dirk: I think you have missed a patch that adds the divecomputer data to
the exports.
On Tue, Aug 26, 2014 at 10:02 PM, Linus Torvalds
torva...@linux-foundation.org wrote:
On Tue, Aug 26, 2014 at 11:24 AM, Gehad
On Sun, Aug 24, 2014 at 6:33 PM, Salvo Tomaselli tipos...@tiscali.it
wrote:
Hello,
I was trying to work with the exported json and I've encountered some
problems.
- It doesn't really seem to be valid json.
json should be all contained within {}, but it's not.
That initial trips= is
On Sat, Aug 23, 2014 at 2:12 AM, Dirk Hohndel d...@hohndel.org wrote:
On Sat, Aug 23, 2014 at 12:56:15AM +0200, Salvo Tomaselli wrote:
Which version of Subsurface are you using?
4.2 from the tarball on the website.
That's our latest release. We have 120 commits since then - you can either
:21 AM, Gehad Elrobey gehadelro...@gmail.com
wrote:
I attached fixes to some minor bugs that Dirk has mentioned before.
Regards,
Gehad
On Thu, Aug 14, 2014 at 8:10 AM, Gehad Elrobey gehadelro...@gmail.com
wrote:
Hi miika,
I attached patches for the mentioned bug and other random fixes
On Thu, Aug 14, 2014 at 7:10 PM, Dirk Hohndel d...@hohndel.org wrote:
I just pushed out the latest changes.
I like the progress, but there are a couple of small things that I find
odd...
- naming of export:
I think it would make much more sense to name the exports
filename_given.html
I attached fixes to some minor bugs that Dirk has mentioned before.
Regards,
Gehad
On Thu, Aug 14, 2014 at 8:10 AM, Gehad Elrobey gehadelro...@gmail.com
wrote:
Hi miika,
I attached patches for the mentioned bug and other random fixes.
Now I think the exports are quite stable.
There is one
about the missing trips seems to occur when
exporting selected dives. Even if I try to export two trips, the trips are
not shown, but all the exported dives are assigned to the trip *other*.
miika
On Sun, Aug 10, 2014 at 12:41 PM, Gehad Elrobey gehadelro...@gmail.com
wrote:
Hi miika,
Here
On Mon, Aug 11, 2014 at 5:29 PM, Dirk Hohndel d...@hohndel.org wrote:
On August 11, 2014 5:43:27 AM Paul-Erik Törrönen pol...@777-team.org
wrote:
Let's add another one:
Sorting the dive list by (Water) temperature, negative values are not
handled correctly, I get the order of -1,
miika.tur...@gmail.com wrote:
On Fri, Aug 8, 2014 at 5:32 PM, Gehad Elrobey gehadelro...@gmail.com
wrote:
I have attached some patches that improves the statistics table view and
fix the cells layout.
Thanks, I'll take a look later.
On Mon, Aug 4, 2014 at 6:40 PM, Miika Turkia miika.tur
- Total time is wrapped too much as shown on attached screenshot
I'll re-send the current patch set with my SOB later today.
miika
On Mon, Aug 4, 2014 at 5:03 PM, Gehad Elrobey gehadelro...@gmail.com
wrote:
Hi Miika,
Sorry for the delay, I had some family vacations this week.
I
On Tue, Aug 5, 2014 at 12:59 PM, Paul-Erik Törrönen pol...@777-team.org
wrote:
Subsurface v4.1.93-103-gc477f5602909, built with libdivecomputer v0.4.2
FF31.0 on Linux Fedora 20 64bit.
The graph shown in 'show more details' (should this be 'Show more
details', ie. capital S?) does not
to the
static temperature fix (I guess).
miika
On Sun, Jul 27, 2014 at 11:01 PM, Gehad Elrobey gehadelro...@gmail.com
wrote:
I Attached four patches that fix the mentioned bugs. I ll still work on
more improvements for the current javascript code.
Regards,
Gehad
On Fri, Jul 25, 2014 at 8:02 AM
I Attached four patches that fix the mentioned bugs. I ll still work on
more improvements for the current javascript code.
Regards,
Gehad
On Fri, Jul 25, 2014 at 8:02 AM, Miika Turkia miika.tur...@gmail.com
wrote:
On Thu, Jul 24, 2014 at 10:29 PM, Gehad Elrobey gehadelro...@gmail.com
wrote
:16 AM, Gehad Elrobey gehadelro...@gmail.com
wrote:
Hi miika,
On Sun, Jul 20, 2014 at 8:02 AM, Miika Turkia miika.tur...@gmail.com
wrote:
New bugs I spotted:
- The tooltip on temperature graphs shows actually the time
(concatenated with temperature unit).
what is it supposed to show
the last dive, first click on left does not change the
selection, only re-clicking on left does
I'll still do a bit of poking around once I have more time...
miika
On Sat, Jul 19, 2014 at 6:30 AM, Gehad Elrobey gehadelro...@gmail.com
wrote:
I Attached some bug fixes, Still working
found another bug.
:P
//Anton
___
subsurface mailing list
subsurface@hohndel.org
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
From c3826df07a6a839c32af092ad2e936586d616f57 Mon Sep 17 00:00:00 2001
From: Gehad elrobey gehadelro
I'll not add other features until I send patches for the current bug list,
and leave the Worldmap integration for later development.
Thanks Miika and Poltsi for the testing.
Regards,
Gehad
On Tue, Jul 15, 2014 at 5:39 PM, Miika Turkia miika.tur...@gmail.com
wrote:
A few more bugs:
- Trimix
feedback.
Regards,
Gehad
On Fri, Jul 11, 2014 at 6:28 AM, Miika Turkia miika.tur...@gmail.com
wrote:
Here are the latest patches with my SOB. This includes also the Rick's
patch that was missed.
On Fri, Jul 11, 2014 at 5:05 AM, Gehad Elrobey gehadelro...@gmail.com
wrote:
I attached two
skipped the 0001 HTML: use Right/Left arrows to switch between dives, as
it seemed to already be included in master.
miika
From b760d0dfe378c427abd0805a0c12cf535085fc96 Mon Sep 17 00:00:00 2001
From: Gehad elrobey gehadelro...@gmail.com
Date: Tue, 8 Jul 2014 17:59:56 +0200
Subject: [PATCH 2/3] HTML
see it odd that depths are in negative
values, what do others think?
miika
On Sat, Jun 28, 2014 at 6:26 PM, Gehad Elrobey gehadelro...@gmail.com
wrote:
I Fixed the last 6 patches and attached them again with two additional
patches.
I fixed the whitespaces and code style
clear. At
least when reading on cell phone...
miika
On 02 Jul 2014, at 00:24, Gehad Elrobey gehadelro...@gmail.com wrote:
I edited the HTML export section in user-manual.txt,
Please review the changes, and check that the changes is well structured.
Regards,
Gehad
On Sun, Jun 29, 2014
I re-attached the patch, It applies on current master correctly.
Regards,
Gehad
From 56f5f886750b5b3cd2b0748dc41c64f60d4a4756 Mon Sep 17 00:00:00 2001
From: Gehad elrobey gehadelro...@gmail.com
Date: Thu, 26 Jun 2014 16:47:48 +0300
Subject: [PATCH 1/2] HTML: use Right/Left arrows to switch
On Mon, Jun 30, 2014 at 6:32 PM, Paul-Erik Törrönen pol...@777-team.org
wrote:
This is not strictly on-topic, rather more generally about the HTML-export.
A couple of issues spotted:
* The tank display is messed up (see attachment). The main tank (which is
displayed correctly in graph) has
I will send a patch with some relevant documentation before Friday.
Regards,
Gehad
On Sun, Jun 29, 2014 at 12:58 AM, Miika Turkia miika.tur...@gmail.com
wrote:
Gehad, can you write a bit more about the HTML export before the next
release. I know, I do not fully understand all the
handle_event). Just check from a sample dive that I am correct.
Tablet is a poor tool to check code...
I believe the deleted means that user has deleted the event and does not
want to see it anymore.
miika
On Jun 24, 2014 10:04 PM, Gehad Elrobey gehadelro...@gmail.com wrote:
I was lately working
On Mon, Jun 23, 2014 at 9:33 AM, Miika Turkia miika.tur...@gmail.com
wrote:
On 22 Jun 2014, at 19:19, Gehad Elrobey gehadelro...@gmail.com wrote:
On Sun, Jun 22, 2014 at 1:46 PM, Miika Turkia miika.tur...@gmail.com
wrote:
Can you post sample screenshots of both versions? Compiling code
correctly? I
don't understand the semantics of these curves very well so any feedback
from you will be appreciated for sure.
Regards,
Gehad
On Tue, Jun 17, 2014 at 6:31 AM, Miika Turkia miika.tur...@gmail.com
wrote:
On Tue, Jun 17, 2014 at 1:12 AM, Gehad Elrobey gehadelro...@gmail.com
wrote
On Thu, Jun 19, 2014 at 7:52 PM, Tomaz Canabrava tcanabr...@kde.org wrote:
veyr good gehad, I'm very much in love with the outcome of your patches. :)
Thanks Tomaz, Do you have any comments regarding the dive profile?
On Thu, Jun 19, 2014 at 1:34 PM, Gehad Elrobey gehadelro...@gmail.com
So I had a look about Highcharts which Poltsi has suggested,
which looks much better and neater than the native sketched curves.
Anyway this will require us to add JQuery files plus the library files to
the exports.
I am not sure if this will meet the requirements, I think it was required
not to
Actually this should have been sent to the mailing list, My phone client
doesn't reply all by default. Sorry for that.
-- Forwarded message --
From: Gehad Elrobey gehadelro...@gmail.com
Date: 11 Jun 2014 11:14
Subject: Re: My progress in HTML export.
To: pol...@777-team.org
Cc
On Wed, Jun 11, 2014 at 11:27 PM, Dirk Hohndel d...@hohndel.org wrote:
On Tue, Jun 10, 2014 at 11:06:39AM -0300, Tomaz Canabrava wrote:
From 4352ac280a489a21df8aa3c8b718b4635afe64b6 Mon Sep 17 00:00:00 2001
From: Tomaz Canabrava tomaz.canabr...@intel.com
Date: Tue, 10 Jun 2014 07:42:13
The fourth patch will sadly cause me a lot of pain,
I was working on a fix for that bug.
On Tue, Jun 10, 2014 at 5:15 PM, Tomaz Canabrava tcanabr...@kde.org wrote:
ugh - forget about patches 0005 to 0008 , I was trying to do something
but then realized this was the wrong approach.
and 0009
Hi,
This is my update about gsoc progress, I am now working on a detailed view
for each dive, so more information can be viewed for each single dive.
The exports will contain:
Bookmarks, dive stats , dive profile and I may add photos (I need to look
how this is implemented in subsurface, I think
need someone to test the HTML export at least in Windows.
miika
On 06/04/2014 07:15 AM, Dirk Hohndel wrote:
On Tue, Jun 03, 2014 at 09:12:36PM +0300, Miika Turkia wrote:
From 684bdf422b466763045a25179b0ee022c9cb5cf3 Mon Sep 17 00:00:00 2001
From: Gehad elrobey gehadelro...@gmail.com
Date
the add cylinder/weights button is placed in a wrong position as shown in
the attached photo on my windows 7 machine.
Its need more padding.
Regards,
Gehad elrobey
___
subsurface mailing list
subsurface@hohndel.org
http://lists.hohndel.org/cgi-bin
Here is the fixed patch.
0001-Renaming-the-prefs-struct-members-to-be-consistent-w.patch
Description: Binary data
___
subsurface mailing list
subsurface@hohndel.org
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
On Thu, Apr 10, 2014 at 7:19 PM, Dirk Hohndel d...@hohndel.org wrote:
On Tue, 2014-04-08 at 14:11 +0200, Gehad wrote:
On 04/07/2014 10:22 PM, Dirk Hohndel wrote:
I'd really like to have a prefs variable that tracks the currently
active prefs and only reference that anywhere in the
be set to view it on the map.
Regards,
Gehad elrobey
I am updating the material for the user manual. Here are a few things I
struggle to understand about the UI:
1) Export HTML Word Map on File item of main menu. This generates an HTML
world map with no information superimposed
Thanks so much lubomir for your detailed clarification. I will follow this
coding style in my coming patches.
Regards,
Gehad elrobey
On Thu, Apr 3, 2014 at 5:47 PM, Lubomir I. Ivanov neolit...@gmail.comwrote:
On 3 April 2014 16:34, Gehad Elrobey gehadelro...@gmail.com wrote:
I still want
the point 0,0 , how is it supposed to work ?
Now I am working to interface it with the existing FILE functions and
adding additional dive information, What is missing rather than this ?
Regards,
Gehad elrobey
___
subsurface mailing list
subsurface
On Tue, Mar 25, 2014 at 4:53 PM, Dirk Hohndel d...@hohndel.org wrote:
On Tue, 2014-03-25 at 15:09 +0200, Gehad wrote:
I'm waiting for your appreciated reviews and feedback.
I haven't tried the patch, just looked at the code so far.
There are some odd white space (space between comma and
The return key auto completes the word while the space key is used to enter
another tag not to auto complete.
In this case it is impossible to know if you are going to insert a new tag
or you just want to move to another field.
Regards,
Gehad elrobey
On Mar 22, 2014 3:41 AM, Linus Torvalds torva
Hi,
I am Gehad elrobey a junior software engineering student and i am very
interested in the gsoc project of Exporting HTML files of the dive list.
Now i am in the final phase in writing my proposal and I have got few
questions and i like to discuss them with the community.
1- how do
49 matches
Mail list logo
