Re: [CCR PATCH] Calculate appropriate po2 values

2014-06-21 Thread Willem Ferguson
Robert, On 21/06/2014 12:43, Robert C. Helling wrote: three quick comments: 1) What about the case of readings 1050, 1140, 1160? Then only one difference is big. As is, diff_limit is the value that determines the way the rule is applied. I hope that diff_limit will ultimately be an editible

Re: [CCR PATCH] Calculate appropriate po2 values

2014-06-21 Thread Robert C. Helling
On 21 Jun 2014, at 00:54, Dirk Hohndel wrote: Hi, > Could someone else do a code review and provide feedback - maybe some of > the long time contributors (Lubomir, Miika, Henrik)? three quick comments: 1) What about the case of readings 1050, 1140, 1160? Then only one difference is big. 2)

Re: [CCR PATCH] Calculate appropriate po2 values

2014-06-20 Thread Dirk Hohndel
Willem, I haven't had enough time looking at your patches and thinking through them. Could someone else do a code review and provide feedback - maybe some of the long time contributors (Lubomir, Miika, Henrik)? Thanks /D On Fri, Jun 20, 2014 at 06:44:28PM +0200, Willem Ferguson wrote: > Ca

[CCR PATCH] Calculate appropriate po2 values

2014-06-20 Thread Willem Ferguson
Calculate appropriate O2 partial pressures for CCR dives Files affected: profile.h, profile.c This patch ensures an appropriate representation of oxygen partial pressures for CCR equipment with one or more oxygen partial pressure sensors. The calculated po2 is stored in the