Thanks so much lubomir for your detailed clarification. I will follow this
coding style in my coming patches.
Regards,
Gehad elrobey
On Thu, Apr 3, 2014 at 5:47 PM, Lubomir I. Ivanov neolit...@gmail.comwrote:
On 3 April 2014 16:34, Gehad Elrobey gehadelro...@gmail.com wrote:
I still want to
--
Regards,
Gehad Elrobey
From f36ba732684f3d4ef8713aef8d30dbfd338b2d8a Mon Sep 17 00:00:00 2001
From: Gehad elrobey gehadelro...@gmail.com
Date: Thu, 3 Apr 2014 20:52:58 +0200
Subject: [PATCH] Fixing dive notes escape characters in worldmap exporter
Replacing the newlines in the string with
Thanks, Gehad.
Usually it's nice to have at least a quick here is XYZ in the email
itself (in many email programs, including the one that I use,
attachments aren't shown by default).
I added three more minor style cleanups to your old code into this
commit and pushed it out.
/D
On Thu,
Playing around with this some more... I get a strange error when opening
the .html file produced for all of my dives. The JS console shows:
Uncaught TypeError: Cannot read property '__e3_' of undefined main.js:15
Googling for that it seems to imply that there is an ordering issue in
your
On 1 April 2014 07:50, Dirk Hohndel d...@hohndel.org wrote:
Stupidly I can't include your patch in my response... oh well.
Quick questions:
a) I don't think we support any architecture where sizeof(char) isn't
just 1 - and we don't do those calculations anywhere else. So I think
you might
On Tue, Apr 1, 2014 at 2:13 PM, Gehad gehadelro...@gmail.com wrote:
On 04/01/2014 06:50 AM, Dirk Hohndel wrote:
b) I know that different people have different preferences there, but
from an API perspective I would prefer replace_char(string, old, new)
I changed the order of the arguments,
I couldn't find an easy way to use the memBuffer but I added Miika's
optimization, and fixed the memory leak. I think this is working fine.
Regards,
Gehad elrobey
From d5df6b5c8d6274135edfc8d9ea98864c768fea27 Mon Sep 17 00:00:00 2001
From: Gehad elrobey gehadelro...@gmail.com
Date: Tue, 1 Apr
--
Regards,
Gehad Elrobey
From 7fe2e050df5170a88ada31ec6b876ee1cd0b3640 Mon Sep 17 00:00:00 2001
From: Gehad elrobey gehadelro...@gmail.com
Date: Tue, 1 Apr 2014 00:50:58 +0200
Subject: [PATCH] Fixing dive notes escape characters in worldmap exporter
Replacing the newlines in the string with
Stupidly I can't include your patch in my response... oh well.
Quick questions:
a) I don't think we support any architecture where sizeof(char) isn't
just 1 - and we don't do those calculations anywhere else. So I think
you might as well drop them. I forgot to ask about that in the first
patch
