Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-12 Thread Lubomir I. Ivanov
On 12 March 2014 19:12, Dirk Hohndel wrote: > On Wed, 2014-03-12 at 19:01 +0200, Lubomir I. Ivanov wrote: >> >> so perhaps the patch can be modified to exclude the preferences dialog >> >> change? >> > >> > I would accept a patch modified like that. I just think there are a few >> > scenarios in

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-12 Thread Dirk Hohndel
On Wed, 2014-03-12 at 19:01 +0200, Lubomir I. Ivanov wrote: > >> so perhaps the patch can be modified to exclude the preferences dialog > >> change? > > > > I would accept a patch modified like that. I just think there are a few > > scenarios in which it is nice if the preferences dialog is not mo

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-12 Thread Lubomir I. Ivanov
On 12 March 2014 18:51, Dirk Hohndel wrote: > On Tue, 2014-03-11 at 21:20 +0200, Lubomir I. Ivanov wrote: >> On 11 March 2014 20:23, Dirk Hohndel wrote: >> > On Tue, 2014-03-11 at 18:30 +0200, Lubomir I. Ivanov wrote: >> >> From: "Lubomir I. Ivanov" >> >> >> >> For some dialogs like Preferences

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-12 Thread Dirk Hohndel
On Tue, 2014-03-11 at 21:20 +0200, Lubomir I. Ivanov wrote: > On 11 March 2014 20:23, Dirk Hohndel wrote: > > On Tue, 2014-03-11 at 18:30 +0200, Lubomir I. Ivanov wrote: > >> From: "Lubomir I. Ivanov" > >> > >> For some dialogs like Preferences and Renumber it would be > >> much safer to make the

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Lubomir I. Ivanov
On 11 March 2014 20:23, Dirk Hohndel wrote: > On Tue, 2014-03-11 at 18:30 +0200, Lubomir I. Ivanov wrote: >> From: "Lubomir I. Ivanov" >> >> For some dialogs like Preferences and Renumber it would be >> much safer to make them Qt::WindowModal to the parent (MainWindow). > > Discuss some notes on

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Linus Torvalds
On Tue, Mar 11, 2014 at 11:57 AM, Tomaz Canabrava wrote: > > A 'Toggle Units' button on the toolbar can simplify this, what you think? Yes, I'd probably use that instead. Linus ___ subsurface mailing list subsurface@hohndel.org http://l

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Tomaz Canabrava
On Tue, Mar 11, 2014 at 3:52 PM, Linus Torvalds < torva...@linux-foundation.org> wrote: > On Tue, Mar 11, 2014 at 11:35 AM, Lubomir I. Ivanov > wrote: > > > > most software that i've used make any preferences dialog modal. > > one potential user interaction issue here is if the main window is > >

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Linus Torvalds
On Tue, Mar 11, 2014 at 11:35 AM, Lubomir I. Ivanov wrote: > > most software that i've used make any preferences dialog modal. > one potential user interaction issue here is if the main window is > maximized [..] I've had the opposite problem. The damn modal window isn't a real window to some of

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Lubomir I. Ivanov
On 11 March 2014 20:23, Dirk Hohndel wrote: > On Tue, 2014-03-11 at 18:30 +0200, Lubomir I. Ivanov wrote: >> From: "Lubomir I. Ivanov" >> >> For some dialogs like Preferences and Renumber it would be >> much safer to make them Qt::WindowModal to the parent (MainWindow). > > Initially the Preferen

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Dirk Hohndel
On Tue, 2014-03-11 at 18:30 +0200, Lubomir I. Ivanov wrote: > From: "Lubomir I. Ivanov" > > For some dialogs like Preferences and Renumber it would be > much safer to make them Qt::WindowModal to the parent (MainWindow). Initially the Preferences was non-modal on purpose. So the idea was that yo

[PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" For some dialogs like Preferences and Renumber it would be much safer to make them Qt::WindowModal to the parent (MainWindow). Signed-off-by: Lubomir I. Ivanov --- note that QtCreator (2.6.2 from Qt4.8.x) adds some XML noise in the lines of some margin changes which se