Re: GSoC Progress: Configuring Dive Computers via Subsurface

2014-08-05 Thread Jef Driesen
On 2014-07-29 18:17, Dirk Hohndel wrote: On Mon, Jul 28, 2014 at 01:09:46PM -0700, Thiago Macieira wrote: By the way, I also told Josh that I would count the code he developed for libdivecomputer as part of his GSoC project, though I haven't seen any yet. Yes, Jef and I had discussed that bri

Re: GSoC Progress: Configuring Dive Computers via Subsurface

2014-07-29 Thread Dirk Hohndel
On Mon, Jul 28, 2014 at 01:09:46PM -0700, Thiago Macieira wrote: > On Monday 28 July 2014 08:06:58 Dirk Hohndel wrote: > > I don’t have a firm rule for that. > > I usually ask that commits don’t break the build (because that makes > > bisecting so much more painful). I don’t like it when people sen

Re: GSoC Progress: Configuring Dive Computers via Subsurface

2014-07-28 Thread Thiago Macieira
On Monday 28 July 2014 08:06:58 Dirk Hohndel wrote: > I don’t have a firm rule for that. > I usually ask that commits don’t break the build (because that makes > bisecting so much more painful). I don’t like it when people send me > sequences like this: > > A > B > revert A > C > > (just rebase a

Re: GSoC Progress: Configuring Dive Computers via Subsurface

2014-07-28 Thread Dirk Hohndel
On Jul 28, 2014, at 7:45 AM, Thiago Macieira wrote: > On Monday 28 July 2014 07:33:19 Dirk Hohndel wrote: >> And if course I'd love to see those patches signed off by your mentor as >> well :-) > > The mentor has reviewed them and made comments on GitHub :-) > > Josh was working on cleaning up

Re: GSoC Progress: Configuring Dive Computers via Subsurface

2014-07-28 Thread Thiago Macieira
On Monday 28 July 2014 07:33:19 Dirk Hohndel wrote: > And if course I'd love to see those patches signed off by your mentor as > well :-) The mentor has reviewed them and made comments on GitHub :-) Josh was working on cleaning up some of the issues I found. So the question is whether the cleanu

Re: GSoC Progress: Configuring Dive Computers via Subsurface

2014-07-28 Thread Dirk Hohndel
And if course I'd love to see those patches signed off by your mentor as well :-) /D On July 28, 2014 7:20:56 AM Tomaz Canabrava wrote: Joseph, Can you do like the other GSockers and do weekly updates with patches from what you are working on? this would make our work and yorus so much eas

Re: GSoC Progress: Configuring Dive Computers via Subsurface

2014-07-28 Thread Dirk Hohndel
On July 28, 2014 7:18:40 AM Joseph W Joshua wrote: > On Jul 28, 2014, at 17:14, Dirk Hohndel wrote: > > How far are you from it making sense to integrate this into master? > All of the code except the firmware update can be integrated into master. After 4.2 :-) But I'll be happy to add i

Re: GSoC Progress: Configuring Dive Computers via Subsurface

2014-07-28 Thread Tomaz Canabrava
Joseph, Can you do like the other GSockers and do weekly updates with patches from what you are working on? this would make our work and yorus so much easier. On Mon, Jul 28, 2014 at 11:18 AM, Joseph W Joshua wrote: > >> On Jul 28, 2014, at 17:14, Dirk Hohndel wrote: >> >> How far are you from

Re: GSoC Progress: Configuring Dive Computers via Subsurface

2014-07-28 Thread Joseph W Joshua
> On Jul 28, 2014, at 17:14, Dirk Hohndel wrote: > > How far are you from it making sense to integrate this into master? > All of the code except the firmware update can be integrated into master. ___ subsurface mailing list subsurface@hohndel.org h

Re: GSoC Progress: Configuring Dive Computers via Subsurface

2014-07-28 Thread Dirk Hohndel
How far are you from it making sense to integrate this into master? /D On July 28, 2014 7:12:24 AM Joshua Joseph wrote: Hello all. I have been working on dive computer configuration using Subsurface. So far I am able to read settings from an OSTC 3, modify them and send them back to the dev

GSoC Progress: Configuring Dive Computers via Subsurface

2014-07-28 Thread Joshua Joseph
Hello all. I have been working on dive computer configuration using Subsurface. So far I am able to read settings from an OSTC 3, modify them and send them back to the device. I also have a feature for backing up the settings to an XML file. Currently, I am working on updating the OSTC 3 firmware