Re: help understanding a Windows crash report

2014-10-30 Thread Lubomir I. Ivanov
On 30 October 2014 00:07, Dirk Hohndel d...@hohndel.org wrote: Please test http://subsurface-divelog.org/downloads/daily/subsurface-4.2-349-g2b8043b82b99.exe if you have a chance to make sure that it's not just my system where this works again... This one also implements the long missing

Re: help understanding a Windows crash report

2014-10-30 Thread Dirk Hohndel
On Oct 30, 2014, at 3:15 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 30 October 2014 00:07, Dirk Hohndel d...@hohndel.org wrote: Please test http://subsurface-divelog.org/downloads/daily/subsurface-4.2-349-g2b8043b82b99.exe if you have a chance to make sure that it's not just my

[PATCH] Added close button to print preview window title bar.

2014-10-30 Thread John Van Ostrand
Without this I was only able to close it by choosing to print. Signed-off-by: John Van Ostrand j...@vanostrand.com --- qt-ui/printdialog.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qt-ui/printdialog.cpp b/qt-ui/printdialog.cpp index f8f06ae..a65078b 100644 ---

Re: messing with the gas / tank handling

2014-10-30 Thread Steve Butler
G Once my EON Steel arrives we'll need to drive up to Hoodsport and do some data collection... :-)? As in Hood Canal, WA? Somehow I thought you were located in Europe. Guess I need to be more curious in the future! --Steve (Enumclaw, WA -- OC mostly at Redondo) PS Looks like I'll need

divelist and units

2014-10-30 Thread Dirk Hohndel
So someone suggested this idea the other day (sorry, forgot who it was) when we were discussing the space issues and alignment issues with the header of the divelist. Don't show the units in the header at all, show them only in a tooltip. So I figured how hard can that be? and tried to implement

Re: totally off topic [was: Re: messing with the gas / tank handling]

2014-10-30 Thread John Van Ostrand
On Thu, Oct 30, 2014 at 10:57 AM, Dirk Hohndel d...@hohndel.org wrote: On Thu, Oct 30, 2014 at 07:45:47AM -0700, Steve Butler wrote: G Once my EON Steel arrives we'll need to drive up to Hoodsport and do some data collection... :-)? As in Hood Canal, WA? Somehow I thought you were

Re: divelist and units

2014-10-30 Thread Dirk Hohndel
On Thu, Oct 30, 2014 at 11:25:25AM -0400, John Van Ostrand wrote: On Thu, Oct 30, 2014 at 11:10 AM, Dirk Hohndel d...@hohndel.org wrote: So someone suggested this idea the other day (sorry, forgot who it was) It was in trac where I made the suggestion. I'm glad it worked out, since I

Re: help understanding a Windows crash report

2014-10-30 Thread Dirk Hohndel
On Wed, Oct 29, 2014 at 09:19:22PM -0700, Dirk Hohndel wrote: On Oct 29, 2014, at 6:50 PM, Thiago Macieira thi...@macieira.org wrote: I'm fairly certain it's not a Qt bug now. This is a binary incompatibility issue between QtGui and QtWidgets due either a bug in Dirk's packaging or

Re: divelist and units

2014-10-30 Thread Linus Torvalds
On Thu, Oct 30, 2014 at 8:10 AM, Dirk Hohndel d...@hohndel.org wrote: So someone suggested this idea the other day (sorry, forgot who it was) when we were discussing the space issues and alignment issues with the header of the divelist. Don't show the units in the header at all, show them only

Re: [PATCH] Divelist: make the column headers for units left aligned

2014-10-30 Thread Dirk Hohndel
Just FYI, I had this applied yesterday and then reverted it today because I think with my change to move the units to the tooltip I think this isn't needed and things actually look better without it. I know you implemented what I suggested. Thanks for that. It's just that John's suggestion was

Re: [PATCH] Correct bug: setpoint handling of Poseidon CCR dive logs

2014-10-30 Thread Dirk Hohndel
Linus, much of this is code that you wrote (the original when do we zero thing, when don't we). I clearly mis-remembered some of this. Would you chime in to get to the right resolution here, please? On Thu, Oct 30, 2014 at 08:29:18AM +0200, Willem Ferguson wrote: Ok, so here is how I understand

Re: [PATCH] Correct bug: setpoint handling of Poseidon CCR dive logs

2014-10-30 Thread Linus Torvalds
On Thu, Oct 30, 2014 at 10:32 AM, Dirk Hohndel d...@hohndel.org wrote: I think I remember now. The logic was that many tank sensors don't give a reading in every sample. And somehow, somewhere this got converted into samples with no pressure reading ending up with the previous pressure

Re: [PATCH] Changed tissue icon on profile graph.

2014-10-30 Thread Dirk Hohndel
On Thu, Oct 30, 2014 at 01:51:06PM -0400, John Van Ostrand wrote: The previous icon was of a bird that didn't seem to make sense. This icon looks like the tissue graph and should be more intuitive. Yes. BTW, I think the bird is an inside joke. The idea for the graph was inspired by the

[PATCH] Added English documentation for tissue graph.

2014-10-30 Thread John Van Ostrand
--- Documentation/images/tissues.jpg | Bin 0 - 1270 bytes Documentation/images/tissuesGraph.jpg | Bin 0 - 37994 bytes Documentation/user-manual.txt | 7 +++ 3 files changed, 7 insertions(+) create mode 100644 Documentation/images/tissues.jpg create mode 100644

Re: [RFC] Don't display deleted tags after dive edit

2014-10-30 Thread Dirk Hohndel
On Thu, Oct 30, 2014 at 10:31:16PM +0300, Joseph W. Joshua wrote: The attached patch fixes issue #732 on trac. Please check, I hope my approach is right. Nope, doesn't seem to do it for me... Of course trying to figure out WHY this didn't work made me dig in and so I fixed it instead :-/

[PATCH] Set the number of O2 sensors for Poseidon MK6

2014-10-30 Thread Miika Turkia
Signed-off-by: Miika Turkia miika.tur...@gmail.com --- file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/file.c b/file.c index 9861a03..42f8ef6 100644 --- a/file.c +++ b/file.c @@ -471,6 +471,7 @@ int parse_txt_file(const char *filename, const char *csv) dive-dc.model =

Re: [RFC] Don't display deleted tags after dive edit

2014-10-30 Thread Joseph W. Joshua
Nope, doesn't seem to do it for me... Of course trying to figure out WHY this didn't work made me dig in and so I fixed it instead :-/ Glad that its working /D ___ subsurface mailing list subsurface@subsurface-divelog.org

[PATCH] Fix inconsistent search result in HTML export

2014-10-30 Thread Gehad Elrobey
Patch is attached to fix some inconsistency in HTML exports search. From 7da7578385511e516a6010e1186f3542ed0ca1d2 Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Fri, 31 Oct 2014 02:50:17 +0200 Subject: [PATCH] Fix inconsistent search result in HTML export The advanced