[no subject]

2014-12-30 Thread Tomaz Canabrava
Deivide can say that he loves me one more time. From 6b1a4d743f81ea5c8835eb7c4e428f75912a6fcf Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Tue, 30 Dec 2014 21:57:12 -0200 Subject: [PATCH 9/9] Make the Mean Depth Instant Line Works. It's a bit jumpy, but works. Signed-off-by: Tomaz Canabr

Re: only copy used cylinders to planned dive

2014-12-30 Thread Robert Helling
> On 30 Dec 2014, at 22:03, Anton Lundin wrote: > > On 30 December, 2014 - Robert Helling wrote: > >> >> Dirk, >> >> please double check this patch, as it was you who explicitly wrote there >> „false“ in 611bae34 for reasons beyond me. >> > > This is bad to only copy the used ones. If you

Re: only copy used cylinders to planned dive

2014-12-30 Thread Anton Lundin
On 31 December, 2014 - Robert Helling wrote: > > > On 30 Dec 2014, at 22:03, Anton Lundin wrote: > > > > On 30 December, 2014 - Robert Helling wrote: > > > >> > >> Dirk, > >> > >> please double check this patch, as it was you who explicitly wrote there > >> „false“ in 611bae34 for reasons

Re: only copy used cylinders to planned dive

2014-12-30 Thread Anton Lundin
On 30 December, 2014 - Robert Helling wrote: > > Dirk, > > please double check this patch, as it was you who explicitly wrote there > „false“ in 611bae34 for reasons beyond me. > This is bad to only copy the used ones. If you read the commit message in 8b371cf8, you see that not copying all

only copy used cylinders to planned dive

2014-12-30 Thread Robert Helling
0001-Only-copy-used-cyliders-to-planned-dive.patch Description: Binary data Dirk, please double check this patch, as it was you who explicitly wrote there „false“  in 611bae34 for reasons beyond me.BestRobert signature.asc Description: Message signed with OpenPGP using GPGMail __

[PATCH] Clear DC information when closing log file

2014-12-30 Thread Miika Turkia
Fixes #799 Signed-off-by: Miika Turkia --- qt-ui/mainwindow.cpp | 4 1 file changed, 4 insertions(+) diff --git a/qt-ui/mainwindow.cpp b/qt-ui/mainwindow.cpp index 5a35b13..c578cb3 100644 --- a/qt-ui/mainwindow.cpp +++ b/qt-ui/mainwindow.cpp @@ -283,6 +283,10 @@ void MainWindow::closeCurre

[PATCH] Guess imperial cylinder sizes on CSV import

2014-12-30 Thread Miika Turkia
This patch uses pre-defined working pressures on cylinders to roughly calculate the size in liters. Imperial selection is ignored here as we can use the prefix to detect if the value seems like imperial unit (and the type of cylinder varies based on location, not divers preference in unit). Signed

Re: Fwd: Re: Compilation error on latest master and build instructions

2014-12-30 Thread Dirk Hohndel
On Tue, Dec 30, 2014 at 08:38:23PM +0200, Willem Ferguson wrote: > On 30/12/2014 17:16, Dirk Hohndel wrote: > >On Tue, Dec 30, 2014 at 04:27:13PM +0200, Willem Ferguson wrote: > >Hey, I had planned to work on Win32 this morning. Guess I'll work on the > >website first. And then find time to figure

Re: Fwd: Re: Compilation error on latest master and build instructions

2014-12-30 Thread Willem Ferguson
On 30/12/2014 17:16, Dirk Hohndel wrote: On Tue, Dec 30, 2014 at 04:27:13PM +0200, Willem Ferguson wrote: Hey, I had planned to work on Win32 this morning. Guess I'll work on the website first. And then find time to figure out OpenSUSE Tumbleweed. Then after all that, I can look at the latest f

Re: Fwd: Re: Compilation error on latest master and build instructions

2014-12-30 Thread Dirk Hohndel
On Tue, Dec 30, 2014 at 07:16:28AM -0800, Dirk Hohndel wrote: > On Tue, Dec 30, 2014 at 04:27:13PM +0200, Willem Ferguson wrote: > > Benjamin, Anton, Miika, > > > > Thank you very much for the pointers. I managed in the end in exactly the > > ways you suggested. We need to get the latest Linux bui

Re: OpenSUSE packages

2014-12-30 Thread Anton Lundin
On 30 December, 2014 - Dirk Hohndel wrote: > On Tue, Dec 30, 2014 at 04:17:12PM +0100, Guillaume Gardet wrote: > > > > Le 30/12/2014 16:05, Dirk Hohndel a écrit : > > >On Tue, Dec 30, 2014 at 03:20:54PM +0100, Guillaume Gardet wrote: > > >>Le 22/12/2014 21:09, Dirk Hohndel a écrit : > > >>>On Mon

[PATCH] Record the cylinder idx on DLF gaschange

2014-12-30 Thread Anton Lundin
Use the new and fancy cylinder idx to record which cylinder we change to on the DLF import. Signed-off-by: Anton Lundin --- parse-xml.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/parse-xml.c b/parse-xml.c index 115e2a2..33b4c3e 100644 --- a/parse-xml.c +++ b/parse-xml.c @@ -2653,6 +2

Re: OpenSUSE packages

2014-12-30 Thread Dirk Hohndel
On Tue, Dec 30, 2014 at 04:34:18PM +0100, Guillaume Gardet wrote: > >>Yes. The Tumbleweed builds have been broken for a few days and the error > >>message makes no sense to me. It looks like the rpm is packaged and > >>everything and then it fails with a non-sensical error. > > > >I will try to hav

Re: OpenSUSE packages

2014-12-30 Thread Dirk Hohndel
On Tue, Dec 30, 2014 at 04:17:12PM +0100, Guillaume Gardet wrote: > > Le 30/12/2014 16:05, Dirk Hohndel a écrit : > >On Tue, Dec 30, 2014 at 03:20:54PM +0100, Guillaume Gardet wrote: > >>Le 22/12/2014 21:09, Dirk Hohndel a écrit : > >>>On Mon, Dec 22, 2014 at 06:40:51AM -0800, Dirk Hohndel wrote:

[PATCH] Remove unused variable

2014-12-30 Thread Anton Lundin
Signed-off-by: Anton Lundin --- qt-ui/socialnetworks.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/qt-ui/socialnetworks.cpp b/qt-ui/socialnetworks.cpp index ac418f2..5b7c74b 100644 --- a/qt-ui/socialnetworks.cpp +++ b/qt-ui/socialnetworks.cpp @@ -202,7 +202,6 @@ void FacebookManager::sen

[PATCH 1/3] Remove NO_USERSURVEY

2014-12-30 Thread Anton Lundin
Back in 71dbcdc0d625 ("Added the option of opening User Survey form explicitly") a define for not adding the user-survey was created. This is quite unnecessary and this removes that option. Based-on-patch-by: Nikhil Bharadwaj Gosala Signed-off-by: Anton Lundin --- qt-ui/mainwindow.cpp | 13 ---

[PATCH 3/3] Connect the UserSurvey to its qt-parrent

2014-12-30 Thread Anton Lundin
This makes sure the UserSurvey object is removed correctly by the qt object tracking system. Signed-off-by: Anton Lundin --- qt-ui/mainwindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/mainwindow.cpp b/qt-ui/mainwindow.cpp index 8343f62..5a35b13 100644 --- a/qt

[PATCH 2/3] Correct capitalisation

2014-12-30 Thread Anton Lundin
Signed-off-by: Anton Lundin --- qt-ui/mainwindow.ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/mainwindow.ui b/qt-ui/mainwindow.ui index dc38a0d..08c8d34 100644 --- a/qt-ui/mainwindow.ui +++ b/qt-ui/mainwindow.ui @@ -864,7 +864,7 @@ p, li { white-space: pre-wrap; }

Re: OpenSUSE packages

2014-12-30 Thread Guillaume Gardet
Le 30/12/2014 16:17, Guillaume Gardet a écrit : Le 30/12/2014 16:05, Dirk Hohndel a écrit : On Tue, Dec 30, 2014 at 03:20:54PM +0100, Guillaume Gardet wrote: Le 22/12/2014 21:09, Dirk Hohndel a écrit : On Mon, Dec 22, 2014 at 06:40:51AM -0800, Dirk Hohndel wrote: On Mon, Dec 22, 2014 at 10:1

Re: [PATCH] CSV imperial import

2014-12-30 Thread Dirk Hohndel
On Tue, Dec 30, 2014 at 05:02:42PM +0200, Miika Turkia wrote: > These patches allow one to import CSV file in imperial units. It is for the > pre-configured Subsurface style CSV. I am not sure how sensible this is, > but this format allows importing more fields than what we have in the > manual CSV

Re: OpenSUSE packages

2014-12-30 Thread Guillaume Gardet
Le 30/12/2014 16:05, Dirk Hohndel a écrit : On Tue, Dec 30, 2014 at 03:20:54PM +0100, Guillaume Gardet wrote: Le 22/12/2014 21:09, Dirk Hohndel a écrit : On Mon, Dec 22, 2014 at 06:40:51AM -0800, Dirk Hohndel wrote: On Mon, Dec 22, 2014 at 10:19:11AM +0100, Guillaume Gardet wrote: Le 20/12/2

Re: Fwd: Re: Compilation error on latest master and build instructions

2014-12-30 Thread Dirk Hohndel
On Tue, Dec 30, 2014 at 04:27:13PM +0200, Willem Ferguson wrote: > Benjamin, Anton, Miika, > > Thank you very much for the pointers. I managed in the end in exactly the > ways you suggested. We need to get the latest Linux build instructions on > the Subsurface web site. The current ones (for V4.2

[PATCH v2] Cleanup OSTC settings debug code

2014-12-30 Thread Anton Lundin
The old OSTC settings debug code was a bit ugly. This cleans that up and contains all the ugly-ness behind the DEBUG_OSTC ifdef. Signed-off-by: Anton Lundin --- configuredivecomputerthreads.cpp | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/configu

Re: [PATCH] Cleanup OSTC debug code

2014-12-30 Thread Anton Lundin
On 30 December, 2014 - Dirk Hohndel wrote: > On Tue, Dec 30, 2014 at 10:48:42AM +0100, Anton Lundin wrote: > > The old OSTC debug code was a bit ugly. This cleans that up and contains > > all the ugly-ness behind the ifdef. > > I'm not sure I understand this patch. > > Previously we didn't actua

Re: OpenSUSE packages

2014-12-30 Thread Dirk Hohndel
On Tue, Dec 30, 2014 at 03:20:54PM +0100, Guillaume Gardet wrote: > > Le 22/12/2014 21:09, Dirk Hohndel a écrit : > >On Mon, Dec 22, 2014 at 06:40:51AM -0800, Dirk Hohndel wrote: > >>On Mon, Dec 22, 2014 at 10:19:11AM +0100, Guillaume Gardet wrote: > >>>Le 20/12/2014 06:40, Dirk Hohndel a écrit :

[PATCH] CSV imperial import

2014-12-30 Thread Miika Turkia
These patches allow one to import CSV file in imperial units. It is for the pre-configured Subsurface style CSV. I am not sure how sensible this is, but this format allows importing more fields than what we have in the manual CSV import (and we got a request for this). Thus I thought it might be us

Re: Android app Improvements

2014-12-30 Thread Dirk Hohndel
On Tue, Dec 30, 2014 at 09:53:30AM -0200, Tomaz Canabrava wrote: > Joseph > > In qml this is easier ( swipe) but we May need to change a few things on > the software. > > Id go for qml on mobile platforms, and if you hit any wall I can help > change the code só it works on mobile and desktop.

Re: Compilation error on latest master

2014-12-30 Thread Dirk Hohndel
On Tue, Dec 30, 2014 at 01:27:58PM +0200, Benjamin wrote: > If I use the version of libdivecomputer which the INSTALL file points to, > then I get the same error. > If I sync against the official repository for libdivecomputer, then I don't. I just pushed a clarification for the INSTALL file. If b

Re: [PATCH] Cleanup OSTC debug code

2014-12-30 Thread Dirk Hohndel
On Tue, Dec 30, 2014 at 10:48:42AM +0100, Anton Lundin wrote: > The old OSTC debug code was a bit ugly. This cleans that up and contains > all the ugly-ness behind the ifdef. I'm not sure I understand this patch. Previously we didn't actually open the device for an OSTC 2N, but only if DEBUG_OSTC

Re: Compilation error on latest master

2014-12-30 Thread Dirk Hohndel
On Tue, Dec 30, 2014 at 09:20:45AM +0100, Anton Lundin wrote: > On 30 December, 2014 - Willem Ferguson wrote: > > > compiling configuredivecomputerthreads.cpp > > configuredivecomputerthreads.cpp: In member function ‘virtual void > > FirmwareUpdateThread::run()’: > > configuredivecomputerthreads.c

Fwd: Re: Compilation error on latest master and build instructions

2014-12-30 Thread Willem Ferguson
Benjamin, Anton, Miika, Thank you very much for the pointers. I managed in the end in exactly the ways you suggested. We need to get the latest Linux build instructions on the Subsurface web site. The current ones (for V4.2) are not quite up to date and would not go a long way to help a newby.

Re: OpenSUSE packages

2014-12-30 Thread Guillaume Gardet
Le 22/12/2014 21:09, Dirk Hohndel a écrit : On Mon, Dec 22, 2014 at 06:40:51AM -0800, Dirk Hohndel wrote: On Mon, Dec 22, 2014 at 10:19:11AM +0100, Guillaume Gardet wrote: Le 20/12/2014 06:40, Dirk Hohndel a écrit : We now have official OpenSUSE packages - available at http://software.opensus

Re: Android app Improvements

2014-12-30 Thread Joseph W. Joshua
> On Dec 30, 2014, at 2:53 PM, Tomaz Canabrava wrote: > > Joseph > > In qml this is easier ( swipe) but we May need to change a few things on the > software. > > Id go for qml on mobile platforms, and if you hit any wall I can help change > the code só it works on mobile and desktop. > >

Re: Compilation error on latest master

2014-12-30 Thread Anton Lundin
On 30 December, 2014 - Benjamin wrote: > If I use the version of libdivecomputer which the INSTALL file points to, > then I get the same error. > If I sync against the official repository for libdivecomputer, then I don't. > Use the Subsurface-testing branch, and not the Subsurface-4.3 branch of

Re: Android app Improvements

2014-12-30 Thread Tomaz Canabrava
Joseph In qml this is easier ( swipe) but we May need to change a few things on the software. Id go for qml on mobile platforms, and if you hit any wall I can help change the code só it works on mobile and desktop. Em 30/12/2014 01:56, "Joseph W. Joshua" escreveu: > > Hello all, > > I’m think

Re: Compilation error on latest master

2014-12-30 Thread Benjamin
If I use the version of libdivecomputer which the INSTALL file points to, then I get the same error. If I sync against the official repository for libdivecomputer, then I don't. Benjamin On 30 December 2014 at 10:20, Anton Lundin wrote: > On 30 December, 2014 - Willem Ferguson wrote: > > > comp

[PATCH] Cleanup OSTC debug code

2014-12-30 Thread Anton Lundin
The old OSTC debug code was a bit ugly. This cleans that up and contains all the ugly-ness behind the ifdef. Signed-off-by: Anton Lundin --- configuredivecomputerthreads.cpp | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/configuredivecomputerthreads.cpp b

Re: Compilation error on latest master

2014-12-30 Thread Anton Lundin
On 30 December, 2014 - Willem Ferguson wrote: > compiling configuredivecomputerthreads.cpp > configuredivecomputerthreads.cpp: In member function ‘virtual void > FirmwareUpdateThread::run()’: > configuredivecomputerthreads.cpp:1532:76: error: ‘hw_ostc3_device_fwupdate’ > was not declared in this s

Compilation error on latest master

2014-12-30 Thread Willem Ferguson
compiling configuredivecomputerthreads.cpp configuredivecomputerthreads.cpp: In member function ‘virtual void FirmwareUpdateThread::run()’: configuredivecomputerthreads.cpp:1532:76: error: ‘hw_ostc3_device_fwupdate’ was not declared in this scope rc = hw_ostc3_device_fwupdate(m_data->device,