Broken links on user manual

2015-01-30 Thread Miika Turkia
There are a couple of broken links / references on our user manual. I looked at the first one but couldn't figure out where it should be pointing to..so I am now trying to delegate the fixing of them to Willem :D Following x-refs are used but the destination is missing: S_ExtraTab S_InfoBox

Re: Any qmake experts out there?

2015-01-30 Thread Lubomir I. Ivanov
On 30 January 2015 at 03:07, Lubomir I. Ivanov neolit...@gmail.com wrote: here is my progress in a single patch if someone is interested. i'm CCing Thiago, because maybe he can help with a qmake issue. basically i have the same setup that this patch applies in a test project: - the version_h

Problems setting tank information.

2015-01-30 Thread Benjamin
After I imported a dive today from my non-AI dive computer, I tried to set the tank size. No matter what I did, it always bounced my selection back to the default tank when I tried to either click on the tank from the drop-list or press enter to select the tank size. I'm using the latest git

Re: [PATCH] Document iPhone companion app

2015-01-30 Thread Miika Turkia
I intended to have width limitation for the image, but it seems to be missing from this patch. ---8--- diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt index 471647c..b3c98d7 100644 --- a/Documentation/user-manual.txt +++ b/Documentation/user-manual.txt @@ -1447,7

Re: Segfault after export to DiveShare

2015-01-30 Thread Dirk Hohndel
On Fri, Jan 30, 2015 at 07:15:32AM -0800, Dirk Hohndel wrote: Program received signal SIGSEGV, Segmentation fault. 0x01810b80 in ?? () (gdb) bt #0  0x01810b80 in ?? () #1  0x0056a464 in DiveShareExportDialog::~DiveShareExportDialog() () #2  0x0056a489 in

Re: iPhone companion app

2015-01-30 Thread JB2Cool
You are seeing this 'dive' from within Subsurface itself? On Fri, Jan 30, 2015 at 4:27 PM, Miika Turkia miika.tur...@gmail.com wrote: I just tested this out and got the location to be added to a dive on Subsurface. So it appears to be working. At one point I had an extra space on the ID and

Re: Compilation error with latest master

2015-01-30 Thread Cristian Ionescu-Idbohrn
On Fri, 30 Jan 2015, Dirk Hohndel wrote: On Fri, Jan 30, 2015 at 06:21:45PM +, Pedro Neves wrote: Hi all: I'm trying to compile the latest subsurface master on my system (Debian/Sid) and I'm getting the following error. I've just recently installed my OS on this PC and I'm not sure

Compilation error with latest master

2015-01-30 Thread Pedro Neves
Hi all: I'm trying to compile the latest subsurface master on my system (Debian/Sid) and I'm getting the following error. I've just recently installed my OS on this PC and I'm not sure if I'm missing any package: compiling qt-ui/completionmodels.cpp In file included from

[PATCH] Export the XSLT based exports in a new Thread.

2015-01-30 Thread Gehad Elrobey
libxml2 consumes the main thread time while formatting the xml document. So I attached a patch that calls the export function in a new thread. Now I am working on adding the progress bar functionality #785, but still can't interface with libxml2. Regards, Gehad From

Re: [PATCH] qmake: use a dedicated build script to generate ssrf-version.h

2015-01-30 Thread Cristian Ionescu-Idbohrn
On Fri, 30 Jan 2015, Lubomir I. Ivanov wrote: I'll just nitpick on this one: diff --git a/scripts/write-version b/scripts/write-version new file mode 100644 index 000..42505ae --- /dev/null +++ b/scripts/write-version @@ -0,0 +1,61 @@ +#!/bin/sh Try this same thing with adding: set

Re: iPhone companion app

2015-01-30 Thread Yosef Hamza
I used couple of weeks ago. There's some bugs I wanted to fix but totally forgot I will work on them tomorrow hopefully 1_ The apps drains battery like CRAZY! It's working invisibly and GPS consume some good battery power, O noticed it the first day I installed the app to try it and the next day

Re: [PATCH] Don't go to edit mode if the dive notes field didn't change.

2015-01-30 Thread Miika Turkia
On Fri, Jan 30, 2015 at 10:40 PM, Gehad Elrobey gehadelro...@gmail.com wrote: The main-tab view is inconsistent as mentioned in #804, this patch fixes the notes view. I get crashes when applying this patch. This occurs when I attempt to write to the notes field or focus leaves it. Program

Re: Broken links on user manual

2015-01-30 Thread Miika Turkia
On Fri, Jan 30, 2015 at 8:26 PM, Willem Ferguson willemfergu...@zoology.up.ac.za wrote: On 30/01/2015 19:02, Miika Turkia wrote: There are a couple of broken links / references on our user manual. I looked at the first one but couldn't figure out where it should be pointing to..so I am

Re: Compilation error with latest master

2015-01-30 Thread Cristian Ionescu-Idbohrn
On Fri, 30 Jan 2015, Pedro Neves wrote: I'm trying to compile the latest subsurface master on my system (Debian/Sid) and I'm getting the following error. I've just recently installed my OS on this PC and I'm not sure if I'm missing any package: compiling qt-ui/completionmodels.cpp In file

Re: Compilation error with latest master

2015-01-30 Thread Pedro Neves
Hi: Installing libicu-dev solved the problem. Cheers: Pedro On 01/30/2015 06:29 PM, Dirk Hohndel wrote: On Fri, Jan 30, 2015 at 06:21:45PM +, Pedro Neves wrote: Hi all: I'm trying to compile the latest subsurface master on my system (Debian/Sid) and I'm getting the following error.

[PATCH] User-manual - Update and expand section dealing with dive planning

2015-01-30 Thread Willem Ferguson
User-manual: Dive planner text I took Robert's contribution describing the dive planner and expanded it a bit, added two more graphics to show CCR and pSCR dive planning, and changed a third image. Moved the section dealing with configuring a dive computer to be in a

Re: Problems setting tank information.

2015-01-30 Thread Pedro Neves
Hi: I'm not sure if it's related with bug #803, but I'm also having problems selecting tanks. When I select a tank, the tank nformation disapears from the tab and the cylinders tab doesn't get populated. If I manually fill all the info (Type, size, Work press., etc.), after I apply changes,

Re: iPhone companion app

2015-01-30 Thread Dirk Hohndel
On Fri, Jan 30, 2015 at 06:57:25PM +0200, Miika Turkia wrote: Yep, I got the location to a manually added dive in Subsurface itself. If the user ID is correct on both sides, then the only thing I can think of causing trouble is the time sync. I think the biggest problem is that many people

Re: iPhone companion app

2015-01-30 Thread Jason Bramwell
On 30 Jan 2015, at 17:35, Dirk Hohndel d...@hohndel.org wrote: On Fri, Jan 30, 2015 at 06:57:25PM +0200, Miika Turkia wrote: Yep, I got the location to a manually added dive in Subsurface itself. If the user ID is correct on both sides, then the only thing I can think of causing trouble

[PATCH] Don't go to edit mode if the dive notes field didn't change.

2015-01-30 Thread Gehad Elrobey
The main-tab view is inconsistent as mentioned in #804, this patch fixes the notes view. Regards, Gehad From b86ac5633ce73ab22a600ff3986dcfc2dfe8d63c Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Fri, 30 Jan 2015 22:27:16 +0200 Subject: [PATCH] Don't go to edit mode if

Re: Broken links on user manual

2015-01-30 Thread Willem Ferguson
On 30/01/2015 19:02, Miika Turkia wrote: There are a couple of broken links / references on our user manual. I looked at the first one but couldn't figure out where it should be pointing to..so I am now trying to delegate the fixing of them to Willem :D Following x-refs are used but the

change in plans re: 4.4

2015-01-30 Thread Dirk Hohndel
Just a quick heads up. Those of you who followed this cycle will remember that my initial reason for trying to get 4.4 out fairly quickly was to add Facebook support to Subsurface. And as luck would have it, this afternoon our post access to Facebook was approved. So my tentative plan is now to

Re: [PATCH] Include iPhone companion app to user survey

2015-01-30 Thread Dirk Hohndel
I agree. This creates yet another new string. /D On Sat, Jan 31, 2015 at 08:05:50AM +0200, Miika Turkia wrote: We should mention the iPhone companion app either alongside the Android app or at its own line if more precise information is wanted. I suppose this text change should be enough as

please test Facebook integration

2015-01-30 Thread Dirk Hohndel
I have pushed a few patches that make Facebook integration work for me. This may not be the pinnacle of amazing UI design, but it's much better than what was there. As I mentioned in my earlier post, I still think we may want to protect this with a pin, but at least for a beta version this should

Re: [PATCH] Don't go to edit mode if the dive notes field didn't change.

2015-01-30 Thread Dirk Hohndel
On Fri, Jan 30, 2015 at 11:01:06PM +0200, Gehad Elrobey wrote: I forgot to check for the empty value in the two conditions, patch re-attached. Actually, we have our own beautiful same_string() function that does the sane thing when comparing NULL and (they are the same). Let's use that

[PATCH] Prevent crash on shutdown

2015-01-30 Thread Anton Lundin
We always call reply-deleteLater(), so we where actually calling delete on a stale pointer, that caused subsurface to crash on shutdown. Reported-by: Sergey Starosek sergey-staro...@yandex.ru Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/diveshareexportdialog.cpp | 1 - 1 file changed,

Re: Segfault after export to DiveShare

2015-01-30 Thread Dirk Hohndel
On Fri, Jan 30, 2015 at 04:20:30PM +0300, Sergey Starosek wrote: Steps to reproduce: - start subsurface - select one dive and export it to DiveShare Wow. I completely forgot about DiveShare. Salvo, the UI where you collect the impressively long token is hideous. :-/ But of course that

Segfault after export to DiveShare

2015-01-30 Thread Sergey Starosek
Steps to reproduce: - start subsurface - select one dive and export it to DiveShare - close Subsurface Program received signal SIGSEGV, Segmentation fault. 0x01810b80 in ?? () (gdb) bt #0  0x01810b80 in ?? () #1  0x0056a464 in

Manual update for planning rebreather dives

2015-01-30 Thread Robert Helling
From a068ae104175b3e51316456f58bc3098469bb496 Mon Sep 17 00:00:00 2001 From: Robert C. Helling hell...@atdotde.de Date: Fri, 30 Jan 2015 11:57:57 +0100 Subject: [PATCH] User manual additions for rebreather modes ...in particular for planning rebreather dives. Signed-off-by: Robert C. Helling